All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] spl: socfpga: stratix10: add hex file output for spl image
Date: Tue, 21 Aug 2018 05:52:07 +0200	[thread overview]
Message-ID: <82031e24-5001-de59-acff-956a090d2a3c@denx.de> (raw)
In-Reply-To: <6dedb6e1eeaa0f673a78156652acee8cd3bbb130.camel@linux.intel.com>

On 08/20/2018 11:04 PM, Dalon L Westergreen wrote:
> On Mon, 2018-08-20 at 20:33 +0200, Marek Vasut wrote:
>> On 08/20/2018 03:54 PM, Dalon Westergreen wrote:
>> Stratix10 requires a hex image of the spl for boot.  The hex
>> image is added to the FPGA configuration image and loaded to
>> the processor memory by the configuration engine.
>>
>> Signed-off-by: Dalon Westergreen <dwesterg at gmail.com <mailto:dwesterg@gmail.com>>
>> ---
>>  scripts/Makefile.spl | 10 ++++++++++
>>  1 file changed, 10 insertions(+)
>>
>> diff --git a/scripts/Makefile.spl b/scripts/Makefile.spl
>> index 76d08fd92b..c424f87e6e 100644
>> --- a/scripts/Makefile.spl
>> +++ b/scripts/Makefile.spl
>> @@ -190,6 +190,7 @@ endif
>>  ifdef CONFIG_ARCH_SOCFPGA
>>  ALL-$(CONFIG_TARGET_SOCFPGA_GEN5)	+= $(obj)/$(SPL_BIN).sfp
>>  ALL-$(CONFIG_TARGET_SOCFPGA_ARRIA10)	+= $(obj)/$(SPL_BIN).sfp
>> +ALL-$(CONFIG_TARGET_SOCFPGA_STRATIX10)	+= $(obj)/$(SPL_BIN).hex
>>  endif
>>  
>>  ifdef CONFIG_ARCH_SUNXI
>> @@ -299,6 +300,15 @@ OBJCOPYFLAGS_u-boot-x86-16bit-spl.bin := -O binary -j .start16 -j .resetvec
>>  $(obj)/u-boot-x86-16bit-spl.bin: $(obj)/u-boot-spl FORCE
>>  	$(call if_changed,objcopy)
>>  
>> +ifdef CONFIG_TARGET_SOCFPGA_STRATIX10
>> +OBJCOPYFLAGS_$(SPL_BIN).hex = -I binary -O ihex --change-addresses 0xffe00000
>>
>> Why is this --change-address needed ? This smells like a hack of some
>> sort ...
>>
> I believe the tool that uses this file expects this offset, that said i have not
> 
> tried using a hex file without this change address applied.  I will try without 
> 
> this, and see what happens.

You probably need to adjust the link address of the SPL or U-Boot too.

-- 
Best regards,
Marek Vasut

  reply	other threads:[~2018-08-21  3:52 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-20 13:54 [U-Boot] [PATCH 0/2] socfpga: cleanup files generated for spl Dalon Westergreen
2018-08-20 13:54 ` [U-Boot] [PATCH 1/2] spl: socfpga: only gen5 devices and arria10 require sfp image Dalon Westergreen
2018-08-20 13:54 ` [U-Boot] [PATCH 2/2] spl: socfpga: stratix10: add hex file output for spl image Dalon Westergreen
2018-08-20 18:33   ` Marek Vasut
2018-08-20 21:04     ` Dalon L Westergreen
2018-08-21  3:52       ` Marek Vasut [this message]
2018-08-27 15:30         ` Dalon L Westergreen
2018-08-27 19:03           ` Marek Vasut
2018-08-27 22:03             ` Dalon L Westergreen
2018-08-27 23:54               ` Marek Vasut
2018-08-28 15:43                 ` Dalon L Westergreen
2018-08-28 15:51                   ` Marek Vasut
2018-08-28 15:55                     ` Dalon L Westergreen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=82031e24-5001-de59-acff-956a090d2a3c@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.