* [PATCH 2/2] conf: add upcall line for nvdimm in request-key.conf
@ 2018-10-12 18:08 Dave Jiang
2018-10-12 18:14 ` Dan Williams
` (8 more replies)
0 siblings, 9 replies; 10+ messages in thread
From: Dave Jiang @ 2018-10-12 18:08 UTC (permalink / raw)
To: keyrings
Add support for nvdimm key management.
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
---
request-key.conf | 1 +
1 file changed, 1 insertion(+)
diff --git a/request-key.conf b/request-key.conf
index ff16a95..b76c414 100644
--- a/request-key.conf
+++ b/request-key.conf
@@ -39,3 +39,4 @@ create user debug:* revoked /bin/keyctl reject %k 30 %c %S
create user debug:loop:* * |/bin/cat
create user debug:* * /usr/share/keyutils/request-key-debug.sh %k %d %c %S
negate * * * /bin/keyctl negate %k 30 %S
+create logon nvdimm* * /usr/sbin/nvdimm-upcall %k
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH 2/2] conf: add upcall line for nvdimm in request-key.conf
2018-10-12 18:08 [PATCH 2/2] conf: add upcall line for nvdimm in request-key.conf Dave Jiang
@ 2018-10-12 18:14 ` Dan Williams
2018-10-12 20:37 ` David Howells
` (7 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: Dan Williams @ 2018-10-12 18:14 UTC (permalink / raw)
To: keyrings
On Fri, Oct 12, 2018 at 11:08 AM Dave Jiang <dave.jiang@intel.com> wrote:
>
> Add support for nvdimm key management.
Kind of sad that we need to edit this top-level conf file. David,
could you clarify why /etc/request.d can't be used for kernel upcalls?
Otherwise, assuming that's not an acceptable approach:
Reviewed-by: Dan Williams <dan.j.williams@intel.com>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 2/2] conf: add upcall line for nvdimm in request-key.conf
2018-10-12 18:08 [PATCH 2/2] conf: add upcall line for nvdimm in request-key.conf Dave Jiang
2018-10-12 18:14 ` Dan Williams
@ 2018-10-12 20:37 ` David Howells
2018-10-12 20:45 ` Dave Jiang
` (6 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: David Howells @ 2018-10-12 20:37 UTC (permalink / raw)
To: keyrings
You should take a look at this patch:
https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/keyutils.git/commit/?h=next&id_2f3c34b0b23e5d2ea4564ac990827c47999992
on the keyutils next branch. You should add a file into:
/etc/request-key.d/
with this line:
+create logon nvdimm* * /usr/sbin/nvdimm-upcall %k
in it. Do you actually want to say "nvdimm:*", btw?
David
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 2/2] conf: add upcall line for nvdimm in request-key.conf
2018-10-12 18:08 [PATCH 2/2] conf: add upcall line for nvdimm in request-key.conf Dave Jiang
2018-10-12 18:14 ` Dan Williams
2018-10-12 20:37 ` David Howells
@ 2018-10-12 20:45 ` Dave Jiang
2018-10-12 20:53 ` Dan Williams
` (5 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: Dave Jiang @ 2018-10-12 20:45 UTC (permalink / raw)
To: keyrings
On 10/12/2018 01:37 PM, David Howells wrote:
> You should take a look at this patch:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/keyutils.git/commit/?h=next&id_2f3c34b0b23e5d2ea4564ac990827c47999992
Ah that's great! Do you know when this will be released? Would also be
interested to know when Fedora will pick up this release.
>
> on the keyutils next branch. You should add a file into:
>
> /etc/request-key.d/
>
> with this line:
>
> +create logon nvdimm* * /usr/sbin/nvdimm-upcall %k
>
> in it. Do you actually want to say "nvdimm:*", btw?
Yes. Good catch. I'll update that and also have ndctl package to install
/etc/request-key.d/nvdimm.conf with that instead.
Thanks.
>
> David
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 2/2] conf: add upcall line for nvdimm in request-key.conf
2018-10-12 18:08 [PATCH 2/2] conf: add upcall line for nvdimm in request-key.conf Dave Jiang
` (2 preceding siblings ...)
2018-10-12 20:45 ` Dave Jiang
@ 2018-10-12 20:53 ` Dan Williams
2018-10-15 14:11 ` David Howells
` (4 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: Dan Williams @ 2018-10-12 20:53 UTC (permalink / raw)
To: keyrings
On Fri, Oct 12, 2018 at 1:37 PM David Howells <dhowells@redhat.com> wrote:
>
> You should take a look at this patch:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/keyutils.git/commit/?h=next&id_2f3c34b0b23e5d2ea4564ac990827c47999992
>
> on the keyutils next branch. You should add a file into:
>
> /etc/request-key.d/
>
> with this line:
>
> +create logon nvdimm* * /usr/sbin/nvdimm-upcall %k
>
> in it. Do you actually want to say "nvdimm:*", btw?
Thanks David. I also saw your recent pull request add TPM support.
That's something we're interested in as a follow-on for the nvdimm
keys so we can perhaps minimize a plain text key floating around in
kernel space.
So next time I'll pay closer attention to latest upstream before
shooting off snarky comments.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 2/2] conf: add upcall line for nvdimm in request-key.conf
2018-10-12 18:08 [PATCH 2/2] conf: add upcall line for nvdimm in request-key.conf Dave Jiang
` (3 preceding siblings ...)
2018-10-12 20:53 ` Dan Williams
@ 2018-10-15 14:11 ` David Howells
2018-10-15 23:38 ` Dave Jiang
` (3 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: David Howells @ 2018-10-15 14:11 UTC (permalink / raw)
To: keyrings
Dave Jiang <dave.jiang@intel.com> wrote:
> > You should take a look at this patch:
> >
> > https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/keyutils.git/commit/?h=next&id_2f3c34b0b23e5d2ea4564ac990827c47999992
>
> Ah that's great! Do you know when this will be released? Would also be
> interested to know when Fedora will pick up this release.
If you can give that a test for me, that'd be great.
David
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 2/2] conf: add upcall line for nvdimm in request-key.conf
2018-10-12 18:08 [PATCH 2/2] conf: add upcall line for nvdimm in request-key.conf Dave Jiang
` (4 preceding siblings ...)
2018-10-15 14:11 ` David Howells
@ 2018-10-15 23:38 ` Dave Jiang
2018-10-17 8:20 ` David Howells
` (2 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: Dave Jiang @ 2018-10-15 23:38 UTC (permalink / raw)
To: keyrings
On 10/15/2018 07:11 AM, David Howells wrote:
> Dave Jiang <dave.jiang@intel.com> wrote:
>
>>> You should take a look at this patch:
>>>
>>> https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/keyutils.git/commit/?h=next&id_2f3c34b0b23e5d2ea4564ac990827c47999992
>>
>> Ah that's great! Do you know when this will be released? Would also be
>> interested to know when Fedora will pick up this release.
>
> If you can give that a test for me, that'd be great.
Tested. Works. Thanks!
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 2/2] conf: add upcall line for nvdimm in request-key.conf
2018-10-12 18:08 [PATCH 2/2] conf: add upcall line for nvdimm in request-key.conf Dave Jiang
` (5 preceding siblings ...)
2018-10-15 23:38 ` Dave Jiang
@ 2018-10-17 8:20 ` David Howells
2018-10-17 14:10 ` Jiang, Dave
2018-11-02 14:10 ` David Howells
8 siblings, 0 replies; 10+ messages in thread
From: David Howells @ 2018-10-17 8:20 UTC (permalink / raw)
To: keyrings
Dave Jiang <dave.jiang@intel.com> wrote:
> Tested. Works. Thanks!
Excellent! Can I put you down as a Tested-by line?
David
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 2/2] conf: add upcall line for nvdimm in request-key.conf
2018-10-12 18:08 [PATCH 2/2] conf: add upcall line for nvdimm in request-key.conf Dave Jiang
` (6 preceding siblings ...)
2018-10-17 8:20 ` David Howells
@ 2018-10-17 14:10 ` Jiang, Dave
2018-11-02 14:10 ` David Howells
8 siblings, 0 replies; 10+ messages in thread
From: Jiang, Dave @ 2018-10-17 14:10 UTC (permalink / raw)
To: keyrings
> On Oct 17, 2018, at 1:20 AM, David Howells <dhowells@redhat.com> wrote:
>
> Dave Jiang <dave.jiang@intel.com> wrote:
>
>> Tested. Works. Thanks!
>
> Excellent! Can I put you down as a Tested-by line?
Yes. Thank you.
>
> David
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 2/2] conf: add upcall line for nvdimm in request-key.conf
2018-10-12 18:08 [PATCH 2/2] conf: add upcall line for nvdimm in request-key.conf Dave Jiang
` (7 preceding siblings ...)
2018-10-17 14:10 ` Jiang, Dave
@ 2018-11-02 14:10 ` David Howells
8 siblings, 0 replies; 10+ messages in thread
From: David Howells @ 2018-11-02 14:10 UTC (permalink / raw)
To: keyrings
Dave Jiang <dave.jiang@intel.com> wrote:
> Add support for nvdimm key management.
I'm not going to apply this as you said you could make your change to the
nvdimm package. You will need to have a dependency there on keyutils-1.5.12.
David
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2018-11-02 14:10 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-12 18:08 [PATCH 2/2] conf: add upcall line for nvdimm in request-key.conf Dave Jiang
2018-10-12 18:14 ` Dan Williams
2018-10-12 20:37 ` David Howells
2018-10-12 20:45 ` Dave Jiang
2018-10-12 20:53 ` Dan Williams
2018-10-15 14:11 ` David Howells
2018-10-15 23:38 ` Dave Jiang
2018-10-17 8:20 ` David Howells
2018-10-17 14:10 ` Jiang, Dave
2018-11-02 14:10 ` David Howells
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.