All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Christie <michaelc-hcNo3dDEHLuVc3sceRu5cw@public.gmane.org>
To: Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
Cc: Sagi Grimberg
	<sagig-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>,
	"Martin K. Petersen"
	<martin.petersen-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>,
	Sagi Grimberg <sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
	nab-IzHhD5pYlfBP7FQvKIMDCQ@public.gmane.org,
	roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	target-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v2 1/3] scsi_cmnd: Introduce scsi_transfer_length helper
Date: Wed, 25 Jun 2014 10:59:19 -0500	[thread overview]
Message-ID: <8223888D-6AF4-41B8-BFD7-63F23A293134@cs.wisc.edu> (raw)
In-Reply-To: <20140625113536.GA30312-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>


On Jun 25, 2014, at 6:35 AM, Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org> wrote:

> On Wed, Jun 25, 2014 at 01:32:39PM +0300, Sagi Grimberg wrote:
>> So I tested a bidirectional command using:
>> $ sg_raw --infile=/root/filex --send=1024 --request=1024
>> --outfile=/root/filex "/dev/bsg/7:0:0:0" 53 00 00 00 00 00 00 00 02 00
>> 
>> And I see:
>> kernel: session1: iscsi_prep_scsi_cmd_pdu iscsi prep [bidirectional cid 0 sc
>> ffff880468ca1e00 cdb 0x53 itt 0x16 len 1024 bidi_len 1024 cmdsn 223 win 64]
>> 
>> This confirms what I wrote above, so AFAICT no additional fix is required
>> for libiscsi wrt bidi commands support.
> 
> Good to know.  I'd really prefer just going with the fix from Martin
> that I have already queued up for 3.16, and then we can have the fully
> fledged out "new" scsi_transfer_length() for 3.17.
> 

I am fine with this too.

I was way off track. I was more concerned with not wanting to use multiple functions/macros to get the transfer len. That should definitely be done when there is more time.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2014-06-25 15:59 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-11  9:09 [PATCH v2 0/3] Include protection information in transport header Sagi Grimberg
2014-06-11  9:09 ` [PATCH v2 1/3] scsi_cmnd: Introduce scsi_transfer_length helper Sagi Grimberg
2014-06-11 23:39   ` Martin K. Petersen
2014-06-23 21:24   ` Mike Christie
     [not found]     ` <53A89B0F.4040300-hcNo3dDEHLuVc3sceRu5cw@public.gmane.org>
2014-06-24  1:58       ` Martin K. Petersen
2014-06-25  1:17         ` Vladislav Bolkhovitin
2014-07-27  8:45           ` Boaz Harrosh
     [not found]   ` <1402477799-24610-2-git-send-email-sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2014-06-24  6:54     ` Mike Christie
2014-06-24 12:53       ` Martin K. Petersen
     [not found]         ` <yq1mwd2h3ju.fsf-+q57XtR/GgMb6DWv4sQWN6xOck334EZe@public.gmane.org>
2014-06-24 13:08           ` Sagi Grimberg
2014-06-24 14:55             ` Christoph Hellwig
2014-06-24 15:29           ` sagi grimberg
2014-06-24 14:03         ` Christoph Hellwig
2014-06-24 16:08         ` Michael Christie
2014-06-24 16:27           ` Christoph Hellwig
2014-06-24 16:27           ` Sagi Grimberg
2014-06-24 16:30             ` Christoph Hellwig
     [not found]               ` <20140624163040.GA11499-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2014-06-24 17:00                 ` Mike Christie
2014-06-24 17:04                   ` Martin K. Petersen
2014-06-24 17:08                   ` Mike Christie
     [not found]                     ` <53A9B0A0.6000103-hcNo3dDEHLuVc3sceRu5cw@public.gmane.org>
2014-06-25  3:32                       ` Mike Christie
2014-06-25  8:48                         ` Sagi Grimberg
2014-06-25  9:17                           ` Christoph Hellwig
2014-06-25 10:32                           ` Sagi Grimberg
     [not found]                             ` <53AAA547.40300-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2014-06-25 11:35                               ` Christoph Hellwig
     [not found]                                 ` <20140625113536.GA30312-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2014-06-25 15:59                                   ` Michael Christie [this message]
2014-07-27  9:11                             ` Boaz Harrosh
     [not found]                               ` <53D4C22F.8050904-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-07-27 13:52                                 ` Christoph Hellwig
2014-08-06 12:15                               ` Sagi Grimberg
2014-06-25  9:14                         ` Christoph Hellwig
2014-06-25 11:29                           ` Martin K. Petersen
2014-06-24 16:31           ` Martin K. Petersen
     [not found]             ` <yq1fviugtgq.fsf-+q57XtR/GgMb6DWv4sQWN6xOck334EZe@public.gmane.org>
2014-06-24 17:05               ` Mike Christie
2014-06-24 13:01       ` sagi grimberg
2014-06-26 14:53   ` Bart Van Assche
     [not found]     ` <53AC3402.2080302-HInyCGIudOg@public.gmane.org>
2014-06-26 14:55       ` James Bottomley
2014-06-26 15:41         ` Atchley, Scott
2014-06-26 16:38           ` James Bottomley
     [not found]             ` <fbbc6688-5a52-4437-93b1-71e8ff84c36c-2ueSQiBKiTY7tOexoI0I+QC/G2K4zDHf@public.gmane.org>
2014-06-26 21:17               ` Atchley, Scott
2014-07-13 11:37   ` Christoph Hellwig
2014-07-13 11:40     ` Martin K. Petersen
2014-07-25 20:00     ` [PATCH] [SCSI] Make scsi_transfer_length take a scsi_data_buffer argument Martin K. Petersen
2014-07-25 21:19       ` Christoph Hellwig
2014-07-29 13:26         ` Christoph Hellwig
2014-08-06 12:12       ` Sagi Grimberg
2014-08-06 13:09         ` Sagi Grimberg
2014-08-06 15:49           ` Martin K. Petersen
2014-06-11  9:09 ` [PATCH v2 2/3] libiscsi, iser: Adjust data_length to include protection information Sagi Grimberg
2014-06-23 20:59   ` Christoph Hellwig
     [not found]     ` <20140623205948.GA15165-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2014-06-24  6:31       ` Mike Christie
     [not found]   ` <1402477799-24610-3-git-send-email-sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2014-07-27 10:08     ` Boaz Harrosh
     [not found]       ` <53D4CFAB.3040804-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-08-06 12:43         ` Sagi Grimberg
2014-08-06 13:25           ` Boaz Harrosh
2014-08-13 13:09             ` Sagi Grimberg
     [not found]               ` <53EB639C.3080307-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2014-08-14  7:17                 ` Boaz Harrosh
     [not found]           ` <53E22300.3090907-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2014-08-06 15:54             ` Martin K. Petersen
2014-06-11  9:09 ` [PATCH v2 3/3] TARGET/sbc,loopback: Adjust command data length in case pi exists on the wire Sagi Grimberg
2014-06-11 21:36 ` [PATCH v2 0/3] Include protection information in transport header Nicholas A. Bellinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8223888D-6AF4-41B8-BFD7-63F23A293134@cs.wisc.edu \
    --to=michaelc-hcno3ddehluvc3sceru5cw@public.gmane.org \
    --cc=hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=martin.petersen-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
    --cc=nab-IzHhD5pYlfBP7FQvKIMDCQ@public.gmane.org \
    --cc=roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=sagig-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org \
    --cc=sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    --cc=target-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.