From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 130C1C76196 for ; Sun, 19 Mar 2023 02:56:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229765AbjCSCz6 (ORCPT ); Sat, 18 Mar 2023 22:55:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52542 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229553AbjCSCz4 (ORCPT ); Sat, 18 Mar 2023 22:55:56 -0400 Received: from mail-pg1-x52f.google.com (mail-pg1-x52f.google.com [IPv6:2607:f8b0:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6D95218B1F; Sat, 18 Mar 2023 19:55:53 -0700 (PDT) Received: by mail-pg1-x52f.google.com with SMTP id t83so4859671pgb.11; Sat, 18 Mar 2023 19:55:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679194552; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=0PtZRbdqZnLpXZl8fukP7Y6q+KTufVstJv4cmcSFX80=; b=Ve+ZCQPiUJ843UAhYFg+/UWCgoBFWkn5LJ3ztK/mSo4qgIMXXwfU5h60N2g+yBkUaq J9hRlOdLXaB+FIIpFPiTmIOyXZARIoThEG0ue00brVwqv+aFnGQre2cqKCB6h+N7LQwo H0DtUDDnBCkbUHjV5P4ZW3ElOIDbMo6twRElIv1E1eFM9PlJwHt2/TV1KnRBrH5aiBDt 2IbiY5wDn7jc1RC27hIBbaA3dwAoE425Of8vjt9vEC+qYEJL0Z9+RyXNtcJg/x1hbVnA f1+Ifxpj0J8rUoW+ZtLBIbC8u7nJeL14zEIztLIA/RPFi5FF4610OtpkPSDlVDnbyoR3 zHvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679194552; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0PtZRbdqZnLpXZl8fukP7Y6q+KTufVstJv4cmcSFX80=; b=RQi+dlNWlC93H6Wb5N6m4fh8GWQad1HikzPfeJMO9II25UanRMrprKN292i3GzWWWf gbtkgl4un/HXJAhE2RgHOTZrw5kmFRFGHTqdZ9TtECAZ598kdJhyx9+Z5i34R2lH6mSJ +A3hj4skofrP79lJDK7SqI0KSwqQicBakrDVkzKKKox2rzqtE3DoRX8KCNjeUn1Zb09y w7LyZmJXC66573XjUcBcyY7AvyPq7fAN8989QrfpK+/YX+95kqtmHsxYdnuB5vK7Jiqa 4xrd5Fgux4ZoNjW4ZnWBEllu4/bGKVxf7jkYBiHMxWRP14e/7gUx4t4N0hmugtX1/f/o xb4Q== X-Gm-Message-State: AO0yUKXdAz3I/HXxYuu4YOVmjZV9sTn0aP0Lgf+4mKmse24uQUcAj9eV XGUPW5xTDwi1V8mFjbt+YXER47mqJy8= X-Google-Smtp-Source: AK7set88GxBcPJyP5g9MNh9Pe2mwU/odxKGYQq018AMBE0O8NH5BK9OB3gRl7K0qKZGfaXh3tAwHnQ== X-Received: by 2002:a62:7910:0:b0:625:e77b:93b2 with SMTP id u16-20020a627910000000b00625e77b93b2mr11337018pfc.5.1679194552347; Sat, 18 Mar 2023 19:55:52 -0700 (PDT) Received: from [192.168.1.101] (1-160-164-133.dynamic-ip.hinet.net. [1.160.164.133]) by smtp.gmail.com with ESMTPSA id g11-20020a62e30b000000b005ac419804d5sm3958094pfh.98.2023.03.18.19.55.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 18 Mar 2023 19:55:52 -0700 (PDT) Message-ID: <822dc1c0-f2c8-def1-c5fe-a1d03a0f9c8c@gmail.com> Date: Sun, 19 Mar 2023 10:55:48 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 From: Jacky Huang Subject: Re: [PATCH 12/15] clk: nuvoton: Add clock driver for ma35d1 clock controller To: Krzysztof Kozlowski , robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, lee@kernel.org, mturquette@baylibre.com, sboyd@kernel.org, p.zabel@pengutronix.de, gregkh@linuxfoundation.org, jirislaby@kernel.org Cc: devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, schung@nuvoton.com, Jacky Huang References: <20230315072902.9298-1-ychuang570808@gmail.com> <20230315072902.9298-13-ychuang570808@gmail.com> <764f9105-e888-4776-bd49-efec72bd409d@linaro.org> Content-Language: en-US In-Reply-To: <764f9105-e888-4776-bd49-efec72bd409d@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dear Krzysztof, On 2023/3/16 下午 03:51, Krzysztof Kozlowski wrote: > On 15/03/2023 08:28, Jacky Huang wrote: >> From: Jacky Huang >> >> The clock controller generates clocks for the whole chip, including >> system clocks and all peripheral clocks. This driver support ma35d1 >> clock gating, divider, and individual PLL configuration. >> >> There are 6 PLLs in ma35d1 SoC: >> - CA-PLL for the two Cortex-A35 CPU clock >> - SYS-PLL for system bus, which comes from the companion MCU >> and cannot be programmed by clock controller. >> - DDR-PLL for DDR >> - EPLL for GMAC and GFX, Display, and VDEC IPs. >> - VPLL for video output pixel clock >> - APLL for SDHC, I2S audio, and other IPs. >> CA-PLL has only one operation mode. >> DDR-PLL, EPLL, VPLL, and APLL are advanced PLLs which have 3 >> operation modes: integer mode, fraction mode, and spread specturm mode. >> >> Signed-off-by: Jacky Huang >> --- >> drivers/clk/Makefile | 1 + >> drivers/clk/nuvoton/Makefile | 4 + >> drivers/clk/nuvoton/clk-ma35d1-divider.c | 144 ++++ >> drivers/clk/nuvoton/clk-ma35d1-pll.c | 534 +++++++++++++ >> drivers/clk/nuvoton/clk-ma35d1.c | 970 +++++++++++++++++++++++ >> drivers/clk/nuvoton/clk-ma35d1.h | 198 +++++ >> 6 files changed, 1851 insertions(+) >> create mode 100644 drivers/clk/nuvoton/Makefile >> create mode 100644 drivers/clk/nuvoton/clk-ma35d1-divider.c >> create mode 100644 drivers/clk/nuvoton/clk-ma35d1-pll.c >> create mode 100644 drivers/clk/nuvoton/clk-ma35d1.c >> create mode 100644 drivers/clk/nuvoton/clk-ma35d1.h >> >> diff --git a/drivers/clk/Makefile b/drivers/clk/Makefile >> index e3ca0d058a25..2e7916d269e1 100644 >> --- a/drivers/clk/Makefile >> +++ b/drivers/clk/Makefile >> @@ -103,6 +103,7 @@ endif >> obj-y += mstar/ >> obj-y += mvebu/ >> obj-$(CONFIG_ARCH_MXS) += mxs/ >> +obj-$(CONFIG_ARCH_NUVOTON) += nuvoton/ > Missing compile test. > > (...) Thank you. We should have a Kconfig file in nuvoton directory. I will a Kconfig file including COMPILE_TEST. >> + >> +MODULE_AUTHOR("Chi-Fang Li"); >> +MODULE_DESCRIPTION("NUVOTON MA35D1 Clock Driver"); >> +MODULE_LICENSE("GPL v2"); >> diff --git a/drivers/clk/nuvoton/clk-ma35d1.h b/drivers/clk/nuvoton/clk-ma35d1.h >> new file mode 100644 >> index 000000000000..faae5a17e425 >> --- /dev/null >> +++ b/drivers/clk/nuvoton/clk-ma35d1.h >> @@ -0,0 +1,198 @@ >> +/* SPDX-License-Identifier: GPL-2.0-only */ >> +/* >> + * Copyright (C) 2023 Nuvoton Technology Corp. >> + * Author: Chi-Fang Li >> + */ >> + >> +#ifndef __DRV_CLK_NUVOTON_MA35D1_H >> +#define __DRV_CLK_NUVOTON_MA35D1_H >> + >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> + >> +enum ma35d1_pll_type { >> + MA35D1_CAPLL, >> + MA35D1_DDRPLL, >> + MA35D1_APLL, >> + MA35D1_EPLL, >> + MA35D1_VPLL, >> +}; >> + >> +enum ma35d1_pll_mode { >> + VSIPLL_INTEGER_MODE, >> + VSIPLL_FRACTIONAL_MODE, >> + VSIPLL_SS_MODE, >> +}; >> + >> +/* VSI-PLL CTL0~2 */ >> +#define VSIPLL_CTL0 0x0 >> +#define VSIPLL_CTL1 0x4 >> +#define VSIPLL_CTL2 0x8 >> + >> +/* VSI-PLL Specification limits */ >> +#define VSIPLL_FREF_MAX_FREQ 200000000UL >> +#define VSIPLL_FREF_MIN_FREQ 1000000UL >> +#define VSIPLL_FREFDIVM_MAX_FREQ 40000000UL >> +#define VSIPLL_FREFDIVM_MIN_FREQ0 1000000UL >> +#define VSIPLL_FREFDIVM_MIN_FREQ1 10000000UL >> +#define VSIPLL_FCLK_MAX_FREQ 2400000000UL >> +#define VSIPLL_FCLK_MIN_FREQ 600000000UL >> +#define VSIPLL_FCLKO_MAX_FREQ 2400000000UL >> +#define VSIPLL_FCLKO_MIN_FREQ 85700000UL >> +#define VSIPLL_SPREAD_RANGE 194 >> +#define VSIPLL_MODULATION_FREQ 50000 >> + >> +/* Clock Control Registers Offset */ >> +#define REG_CLK_PWRCTL (0x00) >> +#define REG_CLK_SYSCLK0 (0x04) >> +#define REG_CLK_SYSCLK1 (0x08) >> +#define REG_CLK_APBCLK0 (0x0C) >> +#define REG_CLK_APBCLK1 (0x10) >> +#define REG_CLK_APBCLK2 (0x14) >> +#define REG_CLK_CLKSEL0 (0x18) >> +#define REG_CLK_CLKSEL1 (0x1C) >> +#define REG_CLK_CLKSEL2 (0x20) >> +#define REG_CLK_CLKSEL3 (0x24) >> +#define REG_CLK_CLKSEL4 (0x28) >> +#define REG_CLK_CLKDIV0 (0x2C) >> +#define REG_CLK_CLKDIV1 (0x30) >> +#define REG_CLK_CLKDIV2 (0x34) >> +#define REG_CLK_CLKDIV3 (0x38) >> +#define REG_CLK_CLKDIV4 (0x3C) >> +#define REG_CLK_CLKOCTL (0x40) >> +#define REG_CLK_STATUS (0x50) >> +#define REG_CLK_PLL0CTL0 (0x60) >> +#define REG_CLK_PLL2CTL0 (0x80) >> +#define REG_CLK_PLL2CTL1 (0x84) >> +#define REG_CLK_PLL2CTL2 (0x88) >> +#define REG_CLK_PLL3CTL0 (0x90) >> +#define REG_CLK_PLL3CTL1 (0x94) >> +#define REG_CLK_PLL3CTL2 (0x98) >> +#define REG_CLK_PLL4CTL0 (0xA0) >> +#define REG_CLK_PLL4CTL1 (0xA4) >> +#define REG_CLK_PLL4CTL2 (0xA8) >> +#define REG_CLK_PLL5CTL0 (0xB0) >> +#define REG_CLK_PLL5CTL1 (0xB4) >> +#define REG_CLK_PLL5CTL2 (0xB8) >> +#define REG_CLK_CLKDCTL (0xC0) >> +#define REG_CLK_CLKDSTS (0xC4) >> +#define REG_CLK_CDUPB (0xC8) >> +#define REG_CLK_CDLOWB (0xCC) >> +#define REG_CLK_CKFLTRCTL (0xD0) >> +#define REG_CLK_TESTCLK (0xF0) >> +#define REG_CLK_PLLCTL (0x40) >> + >> +/* Constant Definitions for Clock Controller */ >> +#define SMICPLLCTL0_FBDIV_POS (0) >> +#define SMICPLLCTL0_FBDIV_MSK (0xfful << SMICPLLCTL0_FBDIV_POS) >> +#define SMICPLLCTL0_INDIV_POS (8) >> +#define SMICPLLCTL0_INDIV_MSK (0xful << SMICPLLCTL0_INDIV_POS) >> +#define SMICPLLCTL0_OUTDIV_POS (12) >> +#define SMICPLLCTL0_OUTDIV_MSK (0x3ul << SMICPLLCTL0_OUTDIV_POS) >> +#define SMICPLLCTL0_PD_POS (16) >> +#define SMICPLLCTL0_PD_MSK (0x1ul << SMICPLLCTL0_PD_POS) >> +#define SMICPLLCTL0_BP_POS (17) >> +#define SMICPLLCTL0_BP_MSK (0x1ul << SMICPLLCTL0_BP_POS) >> +#define VSIPLLCTL0_FBDIV_POS (0) >> +#define VSIPLLCTL0_FBDIV_MSK (0x7fful << VSIPLLCTL0_FBDIV_POS) >> +#define VSIPLLCTL0_INDIV_POS (12) >> +#define VSIPLLCTL0_INDIV_MSK (0x3ful << VSIPLLCTL0_INDIV_POS) >> +#define VSIPLLCTL0_MODE_POS (18) >> +#define VSIPLLCTL0_MODE_MSK (0x3ul << VSIPLLCTL0_MODE_POS) >> +#define VSIPLLCTL0_SSRATE_POS (20) >> +#define VSIPLLCTL0_SSRATE_MSK (0x7fful << VSIPLLCTL0_SSRATE_POS) >> +#define VSIPLLCTL1_PD_POS (0) >> +#define VSIPLLCTL1_PD_MSK (0x1ul << VSIPLLCTL1_PD_POS) >> +#define VSIPLLCTL1_BP_POS (1) >> +#define VSIPLLCTL1_BP_MSK (0x1ul << VSIPLLCTL1_BP_POS) >> +#define VSIPLLCTL1_OUTDIV_POS (4) >> +#define VSIPLLCTL1_OUTDIV_MSK (0x7ul << VSIPLLCTL1_OUTDIV_POS) >> +#define VSIPLLCTL1_FRAC_POS (8) >> +#define VSIPLLCTL1_FRAC_MSK (0xfffffful << VSIPLLCTL1_FRAC_POS) >> +#define VSIPLLCTL2_SLOPE_POS (0) >> +#define VSIPLLCTL2_SLOPE_MSK (0xfffffful << VSIPLLCTL2_SLOPE_POS) >> + >> +struct clk_hw *ma35d1_reg_clk_pll(enum ma35d1_pll_type type, u8 u8mode, >> + const char *name, const char *parent, >> + unsigned long targetFreq, >> + void __iomem *base, >> + struct regmap *regmap); >> + >> +struct clk_hw *ma35d1_reg_adc_clkdiv(struct device *dev, >> + const char *name, >> + const char *parent_name, >> + unsigned long flags, >> + void __iomem *reg, u8 shift, >> + u8 width, u32 mask_bit); >> + >> +extern spinlock_t ma35d1_lock; > Why this is here? We will remove it and use "static DEFINE_SPINLOCK(ma35d1_lock);" and have it used in clk-ma35d1-divider.c only. >> + >> +static inline struct clk_hw *ma35d1_clk_fixed(const char *name, int rate) >> +{ >> + return clk_hw_register_fixed_rate(NULL, name, NULL, 0, rate); >> +} >> + > Why all these are here? These should be static functions in clk-ma35d1.c. We will move these function to the C file in next version. >> + >> +#endif /* __DRV_CLK_NUVOTON_MA35D1_H */ > Best regards, > Krzysztof Best regards, Jacky Huang