From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752486AbdB1PRx (ORCPT <rfc822;w@1wt.eu>);
        Tue, 28 Feb 2017 10:17:53 -0500
Received: from lelnx194.ext.ti.com ([198.47.27.80]:60121 "EHLO
        lelnx194.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752388AbdB1PRt (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 28 Feb 2017 10:17:49 -0500
Subject: Re: [PATCH v2 4/4] usb: dwc3: Workaround for super-speed host on dra7
 in dual-role mode
To: <cwchoi00@gmail.com>
References: <1487250377-13653-1-git-send-email-rogerq@ti.com>
 <1487250377-13653-5-git-send-email-rogerq@ti.com>
 <CAGTfZH2ZEOc3mM=ao-wFco6b0U8KY9E0SF4H6kp3tYbkmef0QQ@mail.gmail.com>
CC: <balbi@kernel.org>, <vivek.gautam@codeaurora.org>,
        <linux-usb@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
From: Roger Quadros <rogerq@ti.com>
Message-ID: <822f7e4b-8c00-7d47-1c30-dc09841c05a9@ti.com>
Date: Tue, 28 Feb 2017 17:17:41 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.7.0
MIME-Version: 1.0
In-Reply-To: <CAGTfZH2ZEOc3mM=ao-wFco6b0U8KY9E0SF4H6kp3tYbkmef0QQ@mail.gmail.com>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 25/02/17 05:35, Chanwoo Choi wrote:
> Hi Roger,
> 
> [snip]
> 
>>  /* dwc->lock must be held */
>>  static void dwc3_otg_core_exit(struct dwc3 *dwc)
>>  {
>> +       if (dwc->edev)
>> +               return;
>> +
>>         /* disable all otg irqs */
>>         dwc3_otg_disable_events(dwc, DWC3_OTG_ALL_EVENTS);
>>         /* clear all events */
>> @@ -1286,6 +1364,57 @@ static int dwc3_drd_init(struct dwc3 *dwc)
>>
>>         INIT_WORK(&dwc->otg_work, dwc3_drd_work);
>>
>> +       /* If extcon device is present we don't rely on OTG core for ID event */
>> +       if (dwc->edev) {
>> +               int id, vbus;
>> +
>> +               dwc->edev_nb.notifier_call = dwc3_drd_notifier;
>> +               ret = extcon_register_notifier(dwc->edev, EXTCON_USB,
>> +                                              &dwc->edev_nb);
> 
> I recommend that you better to use the devm_extcon_register_notifier()

Got it.

> 
>> +               if (ret < 0) {
>> +                       dev_err(dwc->dev, "Couldn't register USB cable notifier\n");
>> +                       return -ENODEV;
>> +               }
>> +
>> +               ret = extcon_register_notifier(dwc->edev, EXTCON_USB_HOST,
>> +                                              &dwc->edev_nb);
> 
> Ditto.
> 
> [snip]
> 

-- 
cheers,
-roger