From: Heiner Kallweit <hkallweit1@gmail.com>
To: Matthew Garrett <mjg59@srcf.ucam.org>,
Bjorn Helgaas <helgaas@kernel.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Bjorn Helgaas <bhelgaas@google.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: Re: Lost PCIe PME after a914ff2d78ce ("PCI/ASPM: Don't select CONFIG_PCIEASPM by default")
Date: Sat, 30 May 2020 00:26:17 +0200 [thread overview]
Message-ID: <824d63d8-668c-22c8-a303-b44e30e805e1@gmail.com> (raw)
In-Reply-To: <20200529205900.whx3mxuvt6ijlqwg@srcf.ucam.org>
On 29.05.2020 22:59, Matthew Garrett wrote:
> On Fri, May 29, 2020 at 03:21:35PM -0500, Bjorn Helgaas wrote:
>
>> Yeah, that makes sense. I can't remember the details, but I'm pretty
>> sure there's a reason why we ask for the whole set of things. Seems
>> like it solved some problem. I think Matthew Garrett might have been
>> involved in that.
>
> This was https://bugzilla.redhat.com/show_bug.cgi?id=638912 - some
> firmware misbehaves unless you pass the same set of supported
> functionality as Windows does.
>
Current situation means that PME is unusable on all systems where
pcie_aspm_support_enabled() returns false, what is basically every
system except EXPERT mode is enabled and CONFIG_PCIEASPM is set.
So we definitely need to do something.
One question is whether the system from the 10yr old bug report
actually depends on OSC_PCI_EXPRESS_LTR_CONTROL control, or whether
some other change in recent years fixed the issue.
Not sure whether the system is still available for re-testing.
If worst case we have 10yr old systems breaking with a new kernel
then we still would have the workaround to enable CONFIG_PCIEASPM
on that system.
next prev parent reply other threads:[~2020-05-29 22:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-28 21:44 Lost PCIe PME after a914ff2d78ce ("PCI/ASPM: Don't select CONFIG_PCIEASPM by default") Heiner Kallweit
2020-05-29 18:50 ` Heiner Kallweit
2020-05-29 19:21 ` Bjorn Helgaas
2020-05-29 19:40 ` Heiner Kallweit
2020-05-29 20:09 ` Heiner Kallweit
2020-05-29 20:21 ` Bjorn Helgaas
2020-05-29 20:53 ` Heiner Kallweit
2020-05-29 20:59 ` Matthew Garrett
2020-05-29 22:26 ` Heiner Kallweit [this message]
2020-05-29 22:58 ` Matthew Garrett
2020-05-30 6:33 ` Heiner Kallweit
2020-05-30 7:14 ` Matthew Garrett
2020-05-30 11:33 ` Christoph Hellwig
2020-06-01 10:58 ` Rafael J. Wysocki
2020-06-01 15:13 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=824d63d8-668c-22c8-a303-b44e30e805e1@gmail.com \
--to=hkallweit1@gmail.com \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.