From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E222EC43217 for ; Thu, 20 Oct 2022 12:16:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230059AbiJTMQj (ORCPT ); Thu, 20 Oct 2022 08:16:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40596 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229767AbiJTMQh (ORCPT ); Thu, 20 Oct 2022 08:16:37 -0400 Received: from cpanel.siel.si (cpanel.siel.si [46.19.9.99]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 00CA115CB37; Thu, 20 Oct 2022 05:16:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=norik.com; s=default; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=NXisTPS0jjjvtpkKKzNomaefNbAzVqlaK/nCgzXTANs=; b=fi9Ieb0+KFO0zN7vKavd9vXnic XDb+w5UfwM0jZuT8H0iTHeKdsbpaoL5Q+kYqgVv17AFnEeAP1QCVi3rmDShtUh0Sx35/WONxib2zu lKqkyHvfTsBh2LIFfbx+HcVPctpsGGhiF7cyeCCrlNrPKhydWhz9ciTks9x9bvdxv3Iw3GwlR6uqv +Qph9Y4Z/LcC2aCeQNCezPGGlQ+M+cI+aOwR3yIS+U9FzUGS1BYx34gxOFm2YiefYi2O2xJgVU0lV dAZvNoB93NTJ+kh+9QAEsiVhDMk2ztA4MA4UOi8vm4onjzS75umkVvj+HJnSwHZh2woNjrNZseRIK bhjEFv2A==; Received: from 89-212-21-243.static.t-2.net ([89.212.21.243]:44048 helo=[192.168.69.85]) by cpanel.siel.si with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.95) (envelope-from ) id 1olUTM-00Dn70-AD; Thu, 20 Oct 2022 14:16:28 +0200 Message-ID: <825ad7f9-7f8b-9670-afdf-91df0ead8773@norik.com> Date: Thu, 20 Oct 2022 14:16:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH 0/3] Suspending i.MX watchdog in WAIT mode Content-Language: en-GB To: Krzysztof Kozlowski , linux-watchdog@vger.kernel.org Cc: shawnguo@kernel.org, linux@roeck-us.net, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-imx@nxp.com, festevam@gmail.com, kernel@pengutronix.de, s.hauer@pengutronix.de, wim@linux-watchdog.org, robh+dt@kernel.org References: <20221019111714.1953262-1-andrej.picej@norik.com> <5bf984f4-681c-7001-281f-f35bb7fdfc8b@linaro.org> <7b3bc437-6b92-4691-fd95-08e408b1c962@norik.com> <77b2cb61-2a31-39aa-69fe-a323a5e91b8d@linaro.org> From: Andrej Picej In-Reply-To: <77b2cb61-2a31-39aa-69fe-a323a5e91b8d@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - cpanel.siel.si X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - norik.com X-Get-Message-Sender-Via: cpanel.siel.si: authenticated_id: andrej.picej@norik.com X-Authenticated-Sender: cpanel.siel.si: andrej.picej@norik.com X-Source: X-Source-Args: X-Source-Dir: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20. 10. 22 14:04, Krzysztof Kozlowski wrote: > On 20/10/2022 01:49, Andrej Picej wrote: >> Hi Krzysztof, >> >> On 19. 10. 22 17:46, Krzysztof Kozlowski wrote: >>> On 19/10/2022 07:17, Andrej Picej wrote: >>>> The i.MX6 watchdog can't be stopped once started. This means that >>>> special hardware suspend needs to be configured when the device enters >>>> low-power modes. >>>> Usually i.MX devices have two bits which deal with this: >>>> - WDZST bit disables the timer in "deeper" low power modes and >>>> - WDW bit disables the timer in "WAIT" mode which corresponds with >>>> Linux's "freeze" low-power mode. >>>> >>>> WDZST bit support is already in place since 1a9c5efa576e ("watchdog: imx2_wdt: disable watchdog timer during low power mode"). >>>> WDW bit is not common for all imx2-wdt supported devices, therefore use >>>> a new device-tree property "fsl,suspend-in-wait" which suspends the >>>> watchdog in "WAIT" mode. >>>> >>>> Andrej Picej (3): >>>> watchdog: imx2_wdg: suspend watchdog in WAIT mode >>>> dt-bindings: watchdog: fsl-imx: document suspend in wait mode >>>> ARM: dts: imx6ul/ull: suspend i.MX6UL watchdog in wait mode >>>> >>>> .../devicetree/bindings/watchdog/fsl-imx-wdt.yaml | 5 +++++ >>> >>> Please use scripts/get_maintainers.pl to get a list of necessary people >>> and lists to CC. It might happen, that command when run on an older >>> kernel, gives you outdated entries. Therefore please be sure you base >>> your patches on recent Linux kernel. >> >> I thought I did. I run that script on linux-watchdog.git, master branch. >> I thought I should base my patches meant for watchdog subsystem there? > > Maintainer's tree should be fine, but then the issue is somewhere else, > because your CC list was not complete. > Ok I see that two email addresses were not added. Sorry for that. I will make sure that the CC list is complete next time. Thanks, Andrej From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 25D79C4332F for ; Thu, 20 Oct 2022 12:45:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GmeWXsjyMovXCyb1QaMVoO6T+Bm6hTmI13J3P12iwGA=; b=zWxbKJ6tLk/8Xk w0SsIkrNSrvtbNjgSW6dJ0b0rSqF4chxKqjZ+bOJD1FcQhBsub1nPbGx9/rrjeqShks/YjW2OW2zB QxsQN9ZrcNlbDs2R5SGAhwWuluj8b/pIbaPBLMgItffeUqORQetUCcv9G/eYVFgPx3sHJS0VAL5Ly xoR29aZuZZN5mVc/+phPzDD+NpQeOS8csYDozEM+K4kVixaDd8dv5zS6spGJ7mYup4W+SkUcAMEIA cGHNysocjnkpWs0fSfmegZseH7FNkHLc9FRVjAbm3lDmoqmkr/jBde4N/ZVqx0u/CsMGt8F933AIP ef60JT6m6gJV44DY5zAw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1olUuF-00ExpF-4j; Thu, 20 Oct 2022 12:44:15 +0000 Received: from cpanel.siel.si ([46.19.9.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1olUTY-00Edfw-SC for linux-arm-kernel@lists.infradead.org; Thu, 20 Oct 2022 12:16:42 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=norik.com; s=default; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=NXisTPS0jjjvtpkKKzNomaefNbAzVqlaK/nCgzXTANs=; b=fi9Ieb0+KFO0zN7vKavd9vXnic XDb+w5UfwM0jZuT8H0iTHeKdsbpaoL5Q+kYqgVv17AFnEeAP1QCVi3rmDShtUh0Sx35/WONxib2zu lKqkyHvfTsBh2LIFfbx+HcVPctpsGGhiF7cyeCCrlNrPKhydWhz9ciTks9x9bvdxv3Iw3GwlR6uqv +Qph9Y4Z/LcC2aCeQNCezPGGlQ+M+cI+aOwR3yIS+U9FzUGS1BYx34gxOFm2YiefYi2O2xJgVU0lV dAZvNoB93NTJ+kh+9QAEsiVhDMk2ztA4MA4UOi8vm4onjzS75umkVvj+HJnSwHZh2woNjrNZseRIK bhjEFv2A==; Received: from 89-212-21-243.static.t-2.net ([89.212.21.243]:44048 helo=[192.168.69.85]) by cpanel.siel.si with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.95) (envelope-from ) id 1olUTM-00Dn70-AD; Thu, 20 Oct 2022 14:16:28 +0200 Message-ID: <825ad7f9-7f8b-9670-afdf-91df0ead8773@norik.com> Date: Thu, 20 Oct 2022 14:16:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH 0/3] Suspending i.MX watchdog in WAIT mode Content-Language: en-GB To: Krzysztof Kozlowski , linux-watchdog@vger.kernel.org Cc: shawnguo@kernel.org, linux@roeck-us.net, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-imx@nxp.com, festevam@gmail.com, kernel@pengutronix.de, s.hauer@pengutronix.de, wim@linux-watchdog.org, robh+dt@kernel.org References: <20221019111714.1953262-1-andrej.picej@norik.com> <5bf984f4-681c-7001-281f-f35bb7fdfc8b@linaro.org> <7b3bc437-6b92-4691-fd95-08e408b1c962@norik.com> <77b2cb61-2a31-39aa-69fe-a323a5e91b8d@linaro.org> From: Andrej Picej In-Reply-To: <77b2cb61-2a31-39aa-69fe-a323a5e91b8d@linaro.org> X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - cpanel.siel.si X-AntiAbuse: Original Domain - lists.infradead.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - norik.com X-Get-Message-Sender-Via: cpanel.siel.si: authenticated_id: andrej.picej@norik.com X-Authenticated-Sender: cpanel.siel.si: andrej.picej@norik.com X-Source: X-Source-Args: X-Source-Dir: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221020_051641_132112_7ACC720B X-CRM114-Status: GOOD ( 12.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 20. 10. 22 14:04, Krzysztof Kozlowski wrote: > On 20/10/2022 01:49, Andrej Picej wrote: >> Hi Krzysztof, >> >> On 19. 10. 22 17:46, Krzysztof Kozlowski wrote: >>> On 19/10/2022 07:17, Andrej Picej wrote: >>>> The i.MX6 watchdog can't be stopped once started. This means that >>>> special hardware suspend needs to be configured when the device enters >>>> low-power modes. >>>> Usually i.MX devices have two bits which deal with this: >>>> - WDZST bit disables the timer in "deeper" low power modes and >>>> - WDW bit disables the timer in "WAIT" mode which corresponds with >>>> Linux's "freeze" low-power mode. >>>> >>>> WDZST bit support is already in place since 1a9c5efa576e ("watchdog: imx2_wdt: disable watchdog timer during low power mode"). >>>> WDW bit is not common for all imx2-wdt supported devices, therefore use >>>> a new device-tree property "fsl,suspend-in-wait" which suspends the >>>> watchdog in "WAIT" mode. >>>> >>>> Andrej Picej (3): >>>> watchdog: imx2_wdg: suspend watchdog in WAIT mode >>>> dt-bindings: watchdog: fsl-imx: document suspend in wait mode >>>> ARM: dts: imx6ul/ull: suspend i.MX6UL watchdog in wait mode >>>> >>>> .../devicetree/bindings/watchdog/fsl-imx-wdt.yaml | 5 +++++ >>> >>> Please use scripts/get_maintainers.pl to get a list of necessary people >>> and lists to CC. It might happen, that command when run on an older >>> kernel, gives you outdated entries. Therefore please be sure you base >>> your patches on recent Linux kernel. >> >> I thought I did. I run that script on linux-watchdog.git, master branch. >> I thought I should base my patches meant for watchdog subsystem there? > > Maintainer's tree should be fine, but then the issue is somewhere else, > because your CC list was not complete. > Ok I see that two email addresses were not added. Sorry for that. I will make sure that the CC list is complete next time. Thanks, Andrej _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel