From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1kKFZY-0007tw-52 for mharc-grub-devel@gnu.org; Mon, 21 Sep 2020 02:45:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53230) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kKFZW-0007tp-NB for grub-devel@gnu.org; Mon, 21 Sep 2020 02:45:10 -0400 Received: from mail-pg1-x544.google.com ([2607:f8b0:4864:20::544]:38210) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kKFZU-0004kp-UU for grub-devel@gnu.org; Mon, 21 Sep 2020 02:45:10 -0400 Received: by mail-pg1-x544.google.com with SMTP id l191so8177375pgd.5 for ; Sun, 20 Sep 2020 23:45:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficientek-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:message-id:in-reply-to:references:subject :mime-version:content-transfer-encoding; bh=IPwuR7YG17Sip01+fXCvRdEIcLX+OW2q4B8GRSQYKg4=; b=kCmxs5OvPKnypVnA/WtQdFBX8sx3zhExCEwkYrBxzXdcDS3gxep5ZKqr6uGDYUb1+s d2bW8VrKWfiOooQO4hI0Iq/d2j0/ZlkTfcWO01VX/raO58AZpuh/72Wwul4YOlB96liE YOJGoeRG/z8F7nIZ6vFqLe0yzSfhRY04fQAmBVwulzEY+F2tjTgvznnlL7W9Z8BNSsB7 XcmEh1DOBDQGoNxqRQyQ7VgukXKOfzZNyxQ4SR7wXHZpIM1NBj4+9mywHiAOeb1NLH5l i3Y2xjaUYKPvteUyz/hPfqa0KUwPMTlWbMTaKMQuYJrf+ONvmW38tcYXpayQ6HToOGPZ 4GYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:message-id:in-reply-to :references:subject:mime-version:content-transfer-encoding; bh=IPwuR7YG17Sip01+fXCvRdEIcLX+OW2q4B8GRSQYKg4=; b=c/Efw/Km8X1uWRDRETbH+nRJP5xmO+z3yVVxREeyf4NGRHiOjRqT2isAEcLdti4+hM Zu5Ws0VbmRvoUru9jyvy0TueFRTtiEuSIsWGFyYdoROMYDwzN02YrcNkhrqMV6+hjzKI ecVrFqLzJZZm7wyd3GIlntVeJNfPsS+PI0XTik3YJ9tfnkqdgt6qEK4tGKtrCbNOpjO/ pzvwoRlTx1XOOQSF7GkiLVnXIQ92cHD0hbgxBQ0rpAgVA3NIv4RVWK5LUsBNFq7rtMJX eTtPpPtYJ21Cp7qykLNg18PXgmMAYIdDzyVKaoPYA7n2PyyMsHWfFP6pj82cm+yBPWU3 Oasw== X-Gm-Message-State: AOAM530813UA4dnxzkiyT/JXTYoW1ASmKIT0KXqXigDeYqk4HaY2qic8 1aebrfnQiuhinUucq2PZ2VPQag== X-Google-Smtp-Source: ABdhPJziFX9HRF1g40O9TPhLoDycACsKbeYtn5+zUAo1dO+3nprHhQucPKovPamXsc3cIgMZSjaC0w== X-Received: by 2002:a65:68ca:: with SMTP id k10mr205542pgt.333.1600670707309; Sun, 20 Sep 2020 23:45:07 -0700 (PDT) Received: from [127.0.0.1] ([172.58.46.198]) by smtp.gmail.com with ESMTPSA id z129sm10556999pgb.84.2020.09.20.23.45.06 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 20 Sep 2020 23:45:06 -0700 (PDT) Date: Mon, 21 Sep 2020 06:45:04 +0000 (UTC) From: Glenn Washburn To: Daniel Kiper Cc: Patrick Steinhardt , grub-devel@gnu.org, Denis GNUtoo Carikli Message-ID: <82757e18-992e-4bfd-a5a0-ac96e5a497ed@efficientek.com> In-Reply-To: <20200908125833.veiqznw47a23dxc5@tomti.i.net-space.pl> References: <20200908125833.veiqznw47a23dxc5@tomti.i.net-space.pl> Subject: Re: [PATCH v3 3/9] luks2: Fix use of incorrect index and some error messages MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Correlation-ID: <82757e18-992e-4bfd-a5a0-ac96e5a497ed@efficientek.com> Received-SPF: pass client-ip=2607:f8b0:4864:20::544; envelope-from=development@efficientek.com; helo=mail-pg1-x544.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Sep 2020 06:45:10 -0000 Sep 8, 2020 6:58:48 AM Daniel Kiper : > On Mon, Sep 07, 2020 at 05:27:41PM +0200, Patrick Steinhardt wrote: >> From: Glenn Washburn > > It seems to me this patch should be split into two and and begs for > commit message improvement. In general it would be nice to know why > we need these fixes. This patch is doing two things, fixing a bug and making the code more understandable. My original patch just fixed the bug, then Patrick suggested making it more readable. I can split it into two patches. The bug it's fixing is that the keyslot index variable was being used to index the digests and segments, whereas the digest and segment index variables should be used to index their respective json arrays. Glenn