From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v4] eal: Set numa node value for system which not support it. Date: Fri, 23 Jun 2017 15:02:52 +0200 Message-ID: <8278174.tmcXUfVEQA@xps> References: <1494467793-19887-1-git-send-email-nic@opencloud.tech> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Sergio Gonzalez Monroy To: Tonghao Zhang Return-path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 42DE72BC3 for ; Fri, 23 Jun 2017 15:02:54 +0200 (CEST) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 22/06/2017 17:15, Sergio Gonzalez Monroy: > Just fyi, the summary line should be lowercase apart from acronyms (DPDK > guidelines). > > On 11/05/2017 02:56, Tonghao Zhang wrote: > > The NUMA node information for PCI devices provided through > > sysfs is invalid for AMD Opteron(TM) Processor 62xx and 63xx > > on Red Hat Enterprise Linux 6, and VMs on some hypervisors. > > It is good to see more checking for valid values. > > > > Signed-off-by: Tonghao Zhang > > --- > > IMHO the message could be slightly improved by adding some of the > replies that you made to your v3. > ie. Typical wrong numa node in VMs > > $ cat /sys/devices/pci0000:00/0000:00:18.6/numa_node > -1 [...] > The code changes look fine, so I leave it to Thomas regarding the commit > message :) > > Acked-by: Sergio Gonzalez Monroy Applied, thanks