From: Mark Brown <broonie@kernel.org>
To: Seven Lee <wtli@nuvoton.com>
Cc: lgirdwood@gmail.com, alsa-devel@alsa-project.org,
devicetree@vger.kernel.org, linux-sound@vger.kernel.org,
krzysztof.kozlowski+dt@linaro.org, linux-kernel@vger.kernel.org,
robh+dt@kernel.org, conor+dt@kernel.org, perex@perex.cz,
tiwai@suse.com, YHCHuang@nuvoton.com, KCHSU0@nuvoton.com,
CTLIN0@nuvoton.com, SJLIN0@nuvoton.com, scott6986@gmail.com,
supercraig0719@gmail.com, dardar923@gmail.com
Subject: Re: [PATCH v5 2/2] ASoC: nau8325: new driver
Date: Thu, 28 Mar 2024 15:22:07 +0000 [thread overview]
Message-ID: <8278611a-a46f-4d5e-9861-67ff1084db50@sirena.org.uk> (raw)
In-Reply-To: <20240327075755.3410381-3-wtli@nuvoton.com>
[-- Attachment #1: Type: text/plain, Size: 542 bytes --]
On Wed, Mar 27, 2024 at 03:57:55PM +0800, Seven Lee wrote:
> +static const char * const nau8325_dac_oversampl[] = {
> + "64", "256", "128", "", "32" };
> +
> +static const struct soc_enum nau8325_dac_oversampl_enum =
> + SOC_ENUM_SINGLE(NAU8325_R29_DAC_CTRL1, NAU8325_DAC_OVERSAMPLE_SFT,
> + ARRAY_SIZE(nau8325_dac_oversampl),
> + nau8325_dac_oversampl);
This should really be a SOC_VALUE_ENUM so you can just hide the fourth
value rather than having the empty (presumably invalid) option. Please
send an incremental patch doing this.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2024-03-28 15:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-27 7:57 [PATCH v5 0/2] ASoC: nau8325: Modify driver code and dtschema Seven Lee
2024-03-27 7:57 ` [PATCH v5 1/2] ASoC: dt-bindings: Added schema for "nuvoton,nau8325" Seven Lee
2024-03-27 17:32 ` Rob Herring
2024-03-27 7:57 ` [PATCH v5 2/2] ASoC: nau8325: new driver Seven Lee
2024-03-28 15:22 ` Mark Brown [this message]
2024-03-29 2:33 ` WTLI
2024-03-29 12:34 ` [PATCH v5 0/2] ASoC: nau8325: Modify driver code and dtschema Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8278611a-a46f-4d5e-9861-67ff1084db50@sirena.org.uk \
--to=broonie@kernel.org \
--cc=CTLIN0@nuvoton.com \
--cc=KCHSU0@nuvoton.com \
--cc=SJLIN0@nuvoton.com \
--cc=YHCHuang@nuvoton.com \
--cc=alsa-devel@alsa-project.org \
--cc=conor+dt@kernel.org \
--cc=dardar923@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=scott6986@gmail.com \
--cc=supercraig0719@gmail.com \
--cc=tiwai@suse.com \
--cc=wtli@nuvoton.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.