All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Graf <agraf@csgraf.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/1] efi_loader: bootmgr: print a message when loading from BootNext failed
Date: Wed, 29 May 2019 14:39:26 +0200	[thread overview]
Message-ID: <827BBEF7-1838-4B86-9DA0-43A0769E0D48@csgraf.de> (raw)
In-Reply-To: <c58a4698-a1da-2b55-2f6f-35c09e6f58cc@gmx.de>



> Am 29.05.2019 um 12:59 schrieb Heinrich Schuchardt <xypron.glpk@gmx.de>:
> 
>> On 5/29/19 11:40 AM, Alexander Graf wrote:
>> 
>>> On 28.05.19 12:13, Heinrich Schuchardt wrote:
>>> From: AKASHI Takahiro <takahiro.akashi@linaro.org>
>>> 
>>> If a user defines BootNext but not BootOrder and loading from BootNext
>>> fails, you will see only a message like this:
>>>     BootOrder not defined
>>> 
>>> This may confuse a user. Adding an error message will be helpful.
>>> 
>>> Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
>> 
>> 
>> Why is the SoB line in the middle of the patch description?
> 
> Everything below was not in Takahiros patch.

The SoB still comes at the end though :).

> 
>> 
>> 
>>> Adjust message for fallback from BootNext to BootOrder.
>>> 
>>> An example output looks like this:
>>> 
>>> => bootefi bootmgr
>>> Loading from Boot0010 failed
>>> Loading from BootNext failed, falling back to BootOrder
>>> Loading from Boot0002 failed
>>> Loading from Boot0003 failed
>>> Loading from Boot0004 failed
>> 
>> 
>> How hard would it be to print the device path for the respective
>> BootXXXX entries as well? Users usually don't think in boot entries.
> 
> The change is trivial. Output could look like
> 
> => efidebug boot add 0001 label1 scsi 0:1 "\path1\file1.efi"
> => efidebug boot add 0002 label2 scsi 0:1 "\path2\file2.efi"
> => efidebug boot order 0001 0002
> => bootefi bootmgr
> Loading from Boot0001
> (/VenHw(e61d73b9-a384-4acc-aeab-82e828f3628b)/Scsi(0,0)/HD(1,MBR,0x1bb2fc9c,0x800,0x3fffe)/\path1\file1.efi)
> failed
> Loading from Boot0002
> (/VenHw(e61d73b9-a384-4acc-aeab-82e828f3628b)/Scsi(0,0)/HD(1,MBR,0x1bb2fc9c,0x800,0x3fffe)/\path2\file2.efi)
> failed
> EFI boot manager: Cannot load any image
> =>
> 
> But as you see it does not fit into 80 character lines and the terminal
> might cut of the interesting part of the line. Failure may also depend
> on the command line parameters.
> 
> I think adding the label makes more sense.

I agree. Maybe even only the label.

Booting label1... failed
Booting label2...
Welcome to grub!


Alex

      reply	other threads:[~2019-05-29 12:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-28 10:13 [U-Boot] [PATCH 1/1] efi_loader: bootmgr: print a message when loading from BootNext failed Heinrich Schuchardt
2019-05-29  9:40 ` Alexander Graf
2019-05-29 10:59   ` Heinrich Schuchardt
2019-05-29 12:39     ` Alexander Graf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=827BBEF7-1838-4B86-9DA0-43A0769E0D48@csgraf.de \
    --to=agraf@csgraf.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.