From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934921AbdERNcF convert rfc822-to-8bit (ORCPT ); Thu, 18 May 2017 09:32:05 -0400 Received: from mx07-00178001.pphosted.com ([62.209.51.94]:35248 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755364AbdERNb6 (ORCPT ); Thu, 18 May 2017 09:31:58 -0400 From: Olivier MOYSAN To: Rob Herring CC: "lgirdwood@gmail.com" , "broonie@kernel.org" , "perex@perex.cz" , "tiwai@suse.com" , "mcoquelin.stm32@gmail.com" , Alexandre TORGUE , "alsa-devel@alsa-project.org" , "mark.rutland@arm.com" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "kernel@stlinux.com" , "linux-kernel@vger.kernel.org" , Arnaud POULIQUEN , Benjamin GAIGNARD Subject: Re: [PATCH v3 1/3] dt-bindings: Document STM32 I2S bindings Thread-Topic: [PATCH v3 1/3] dt-bindings: Document STM32 I2S bindings Thread-Index: AQHSy35cin9IqnedEkuvxWrf1uHHK6H5/OqA Date: Thu, 18 May 2017 13:29:03 +0000 Message-ID: <827a2860-1f2e-0296-d58c-4c8686858549@st.com> References: <1494495904-18898-1-git-send-email-olivier.moysan@st.com> <1494495904-18898-2-git-send-email-olivier.moysan@st.com> <20170513001753.hygunrcjqejpbwl6@rob-hp-laptop> In-Reply-To: <20170513001753.hygunrcjqejpbwl6@rob-hp-laptop> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.75.127.44] Content-Type: text/plain; charset="Windows-1252" Content-ID: <522EEE913D323E48BF1E987B2B9AF569@st.com> Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-05-18_04:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Rob, Thanks for your comment. On 05/13/2017 02:17 AM, Rob Herring wrote: > On Thu, May 11, 2017 at 11:45:02AM +0200, olivier moysan wrote: >> Add documentation of device tree bindings for STM32 SPI/I2S. >> >> Signed-off-by: olivier moysan >> --- >> .../devicetree/bindings/sound/st,stm32-i2s.txt | 68 ++++++++++++++++++++++ >> 1 file changed, 68 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/sound/st,stm32-i2s.txt >> >> diff --git a/Documentation/devicetree/bindings/sound/st,stm32-i2s.txt b/Documentation/devicetree/bindings/sound/st,stm32-i2s.txt >> new file mode 100644 >> index 0000000..67b854a >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/sound/st,stm32-i2s.txt >> @@ -0,0 +1,68 @@ >> +STMicroelectronics STM32 SPI/I2S Controller >> + >> +The SPI/I2S block supports I2S/PCM protocols when configured on I2S mode. >> +Only some SPI instances support I2S. >> + >> +Required properties: >> + - compatible: Must be "st,stm32h7-i2s" >> + - reg: Offset and length of the device's register set. >> + - interrupts: Must contain the interrupt line id. >> + - clocks: Must contain phandle and clock specifier pairs for each entry >> + in clock-names. >> + - clock-names: Must contain "i2sclk", "pclk", "x8k" and "x11k". >> + "i2sclk": clock which feeds the internal clock generator >> + "pclk": clock which feeds the peripheral bus interface >> + "x8k": I2S parent clock for sampling rates multiple of 8kHz. >> + "x11k": I2S parent clock for sampling rates multiple of 11.025kHz. >> + - dmas: DMA specifiers for tx and rx dma. >> + See Documentation/devicetree/bindings/dma/stm32-dma.txt. >> + - dma-names: Identifier for each DMA request line. Must be "tx" and "rx". >> + - pinctrl-names: should contain only value "default" >> + - pinctrl-0: see Documentation/devicetree/bindings/pinctrl/pinctrl-stm32.txt >> + >> +Optional properties: >> + - resets: Reference to a reset controller asserting the reset controller >> + >> +The device node should contain one 'port' child node with one child 'endpoint' >> +node, according to the bindings defined in Documentation/devicetree/bindings/ >> +graph.txt. >> + >> +Example: >> +sound_card { >> + compatible = "audio-graph-card"; >> + dais = <&i2s2_port 0>; > > What is the 0 representing? > This is no more relevant, so to be removed. >> +}; >> + >> +i2s2: audio-controller@40003800 { >> + compatible = "st,stm32h7-i2s"; >> + #sound-dai-cells = <0>; > > Should be dropped. > ok >> + reg = <0x40003800 0x400>; >> + interrupts = <36>; >> + clocks = <&rcc PCLK1>, <&rcc SPI2_CK>, <&rcc PLL1_Q>, <&rcc PLL2_P>; >> + clock-names = "pclk", "i2sclk", "x8k", "x11k"; >> + dmas = <&dmamux2 2 39 0x400 0x1>, >> + <&dmamux2 3 40 0x400 0x1>; >> + dma-names = "rx", "tx"; >> + pinctrl-names = "default"; >> + pinctrl-0 = <&pinctrl_i2s2>; >> + >> + i2s2_port: port@0 { >> + #address-cells = <1>; >> + #size-cells = <0>; > > This shouldn't even compile. You don't need these because because you > have no reg property in the endpoint. > > You have a unit-address here w/o a reg property. You don't need a reg > prop because you only have 1 port. > ok. >> + >> + cpu_endpoint: endpoint { >> + remote-endpoint = <&codec_endpoint>; >> + format = "i2s"; >> + bitclock-master = <&codec_endpoint>; >> + frame-master = <&codec_endpoint>; >> + }; >> + }; >> +}; >> + >> +audio-codec { >> + codec_port: port@0 { >> + codec_endpoint: endpoint { >> + remote-endpoint = <&cpu_endpoint>; >> + }; >> + }; >> +}; >> -- >> 1.9.1 >> BRs Olivier From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olivier MOYSAN Subject: Re: [PATCH v3 1/3] dt-bindings: Document STM32 I2S bindings Date: Thu, 18 May 2017 13:29:03 +0000 Message-ID: <827a2860-1f2e-0296-d58c-4c8686858549@st.com> References: <1494495904-18898-1-git-send-email-olivier.moysan@st.com> <1494495904-18898-2-git-send-email-olivier.moysan@st.com> <20170513001753.hygunrcjqejpbwl6@rob-hp-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20170513001753.hygunrcjqejpbwl6@rob-hp-laptop> Content-Language: en-US Content-ID: <522EEE913D323E48BF1E987B2B9AF569@st.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Rob Herring Cc: "mark.rutland@arm.com" , "devicetree@vger.kernel.org" , "alsa-devel@alsa-project.org" , Alexandre TORGUE , "linux-kernel@vger.kernel.org" , Arnaud POULIQUEN , "tiwai@suse.com" , "lgirdwood@gmail.com" , "broonie@kernel.org" , "mcoquelin.stm32@gmail.com" , Benjamin GAIGNARD , "linux-arm-kernel@lists.infradead.org" , "kernel@stlinux.com" List-Id: devicetree@vger.kernel.org Hello Rob, Thanks for your comment. On 05/13/2017 02:17 AM, Rob Herring wrote: > On Thu, May 11, 2017 at 11:45:02AM +0200, olivier moysan wrote: >> Add documentation of device tree bindings for STM32 SPI/I2S. >> >> Signed-off-by: olivier moysan >> --- >> .../devicetree/bindings/sound/st,stm32-i2s.txt | 68 ++++++++++++++++++++++ >> 1 file changed, 68 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/sound/st,stm32-i2s.txt >> >> diff --git a/Documentation/devicetree/bindings/sound/st,stm32-i2s.txt b/Documentation/devicetree/bindings/sound/st,stm32-i2s.txt >> new file mode 100644 >> index 0000000..67b854a >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/sound/st,stm32-i2s.txt >> @@ -0,0 +1,68 @@ >> +STMicroelectronics STM32 SPI/I2S Controller >> + >> +The SPI/I2S block supports I2S/PCM protocols when configured on I2S mode. >> +Only some SPI instances support I2S. >> + >> +Required properties: >> + - compatible: Must be "st,stm32h7-i2s" >> + - reg: Offset and length of the device's register set. >> + - interrupts: Must contain the interrupt line id. >> + - clocks: Must contain phandle and clock specifier pairs for each entry >> + in clock-names. >> + - clock-names: Must contain "i2sclk", "pclk", "x8k" and "x11k". >> + "i2sclk": clock which feeds the internal clock generator >> + "pclk": clock which feeds the peripheral bus interface >> + "x8k": I2S parent clock for sampling rates multiple of 8kHz. >> + "x11k": I2S parent clock for sampling rates multiple of 11.025kHz. >> + - dmas: DMA specifiers for tx and rx dma. >> + See Documentation/devicetree/bindings/dma/stm32-dma.txt. >> + - dma-names: Identifier for each DMA request line. Must be "tx" and "rx". >> + - pinctrl-names: should contain only value "default" >> + - pinctrl-0: see Documentation/devicetree/bindings/pinctrl/pinctrl-stm32.txt >> + >> +Optional properties: >> + - resets: Reference to a reset controller asserting the reset controller >> + >> +The device node should contain one 'port' child node with one child 'endpoint' >> +node, according to the bindings defined in Documentation/devicetree/bindings/ >> +graph.txt. >> + >> +Example: >> +sound_card { >> + compatible = "audio-graph-card"; >> + dais = <&i2s2_port 0>; > > What is the 0 representing? > This is no more relevant, so to be removed. >> +}; >> + >> +i2s2: audio-controller@40003800 { >> + compatible = "st,stm32h7-i2s"; >> + #sound-dai-cells = <0>; > > Should be dropped. > ok >> + reg = <0x40003800 0x400>; >> + interrupts = <36>; >> + clocks = <&rcc PCLK1>, <&rcc SPI2_CK>, <&rcc PLL1_Q>, <&rcc PLL2_P>; >> + clock-names = "pclk", "i2sclk", "x8k", "x11k"; >> + dmas = <&dmamux2 2 39 0x400 0x1>, >> + <&dmamux2 3 40 0x400 0x1>; >> + dma-names = "rx", "tx"; >> + pinctrl-names = "default"; >> + pinctrl-0 = <&pinctrl_i2s2>; >> + >> + i2s2_port: port@0 { >> + #address-cells = <1>; >> + #size-cells = <0>; > > This shouldn't even compile. You don't need these because because you > have no reg property in the endpoint. > > You have a unit-address here w/o a reg property. You don't need a reg > prop because you only have 1 port. > ok. >> + >> + cpu_endpoint: endpoint { >> + remote-endpoint = <&codec_endpoint>; >> + format = "i2s"; >> + bitclock-master = <&codec_endpoint>; >> + frame-master = <&codec_endpoint>; >> + }; >> + }; >> +}; >> + >> +audio-codec { >> + codec_port: port@0 { >> + codec_endpoint: endpoint { >> + remote-endpoint = <&cpu_endpoint>; >> + }; >> + }; >> +}; >> -- >> 1.9.1 >> BRs Olivier From mboxrd@z Thu Jan 1 00:00:00 1970 From: olivier.moysan@st.com (Olivier MOYSAN) Date: Thu, 18 May 2017 13:29:03 +0000 Subject: [PATCH v3 1/3] dt-bindings: Document STM32 I2S bindings In-Reply-To: <20170513001753.hygunrcjqejpbwl6@rob-hp-laptop> References: <1494495904-18898-1-git-send-email-olivier.moysan@st.com> <1494495904-18898-2-git-send-email-olivier.moysan@st.com> <20170513001753.hygunrcjqejpbwl6@rob-hp-laptop> Message-ID: <827a2860-1f2e-0296-d58c-4c8686858549@st.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hello Rob, Thanks for your comment. On 05/13/2017 02:17 AM, Rob Herring wrote: > On Thu, May 11, 2017 at 11:45:02AM +0200, olivier moysan wrote: >> Add documentation of device tree bindings for STM32 SPI/I2S. >> >> Signed-off-by: olivier moysan >> --- >> .../devicetree/bindings/sound/st,stm32-i2s.txt | 68 ++++++++++++++++++++++ >> 1 file changed, 68 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/sound/st,stm32-i2s.txt >> >> diff --git a/Documentation/devicetree/bindings/sound/st,stm32-i2s.txt b/Documentation/devicetree/bindings/sound/st,stm32-i2s.txt >> new file mode 100644 >> index 0000000..67b854a >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/sound/st,stm32-i2s.txt >> @@ -0,0 +1,68 @@ >> +STMicroelectronics STM32 SPI/I2S Controller >> + >> +The SPI/I2S block supports I2S/PCM protocols when configured on I2S mode. >> +Only some SPI instances support I2S. >> + >> +Required properties: >> + - compatible: Must be "st,stm32h7-i2s" >> + - reg: Offset and length of the device's register set. >> + - interrupts: Must contain the interrupt line id. >> + - clocks: Must contain phandle and clock specifier pairs for each entry >> + in clock-names. >> + - clock-names: Must contain "i2sclk", "pclk", "x8k" and "x11k". >> + "i2sclk": clock which feeds the internal clock generator >> + "pclk": clock which feeds the peripheral bus interface >> + "x8k": I2S parent clock for sampling rates multiple of 8kHz. >> + "x11k": I2S parent clock for sampling rates multiple of 11.025kHz. >> + - dmas: DMA specifiers for tx and rx dma. >> + See Documentation/devicetree/bindings/dma/stm32-dma.txt. >> + - dma-names: Identifier for each DMA request line. Must be "tx" and "rx". >> + - pinctrl-names: should contain only value "default" >> + - pinctrl-0: see Documentation/devicetree/bindings/pinctrl/pinctrl-stm32.txt >> + >> +Optional properties: >> + - resets: Reference to a reset controller asserting the reset controller >> + >> +The device node should contain one 'port' child node with one child 'endpoint' >> +node, according to the bindings defined in Documentation/devicetree/bindings/ >> +graph.txt. >> + >> +Example: >> +sound_card { >> + compatible = "audio-graph-card"; >> + dais = <&i2s2_port 0>; > > What is the 0 representing? > This is no more relevant, so to be removed. >> +}; >> + >> +i2s2: audio-controller at 40003800 { >> + compatible = "st,stm32h7-i2s"; >> + #sound-dai-cells = <0>; > > Should be dropped. > ok >> + reg = <0x40003800 0x400>; >> + interrupts = <36>; >> + clocks = <&rcc PCLK1>, <&rcc SPI2_CK>, <&rcc PLL1_Q>, <&rcc PLL2_P>; >> + clock-names = "pclk", "i2sclk", "x8k", "x11k"; >> + dmas = <&dmamux2 2 39 0x400 0x1>, >> + <&dmamux2 3 40 0x400 0x1>; >> + dma-names = "rx", "tx"; >> + pinctrl-names = "default"; >> + pinctrl-0 = <&pinctrl_i2s2>; >> + >> + i2s2_port: port at 0 { >> + #address-cells = <1>; >> + #size-cells = <0>; > > This shouldn't even compile. You don't need these because because you > have no reg property in the endpoint. > > You have a unit-address here w/o a reg property. You don't need a reg > prop because you only have 1 port. > ok. >> + >> + cpu_endpoint: endpoint { >> + remote-endpoint = <&codec_endpoint>; >> + format = "i2s"; >> + bitclock-master = <&codec_endpoint>; >> + frame-master = <&codec_endpoint>; >> + }; >> + }; >> +}; >> + >> +audio-codec { >> + codec_port: port at 0 { >> + codec_endpoint: endpoint { >> + remote-endpoint = <&cpu_endpoint>; >> + }; >> + }; >> +}; >> -- >> 1.9.1 >> BRs Olivier