From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH] drm/i915/pmu: Measure sampler intervals Date: Fri, 25 May 2018 18:31:35 +0100 Message-ID: <827eb4b5-34af-6b5c-a253-28a4498ad3e8@linux.intel.com> References: <20180525171111.6812-1-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id BEF006EA9C for ; Fri, 25 May 2018 17:31:38 +0000 (UTC) In-Reply-To: <20180525171111.6812-1-chris@chris-wilson.co.uk> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDI1LzA1LzIwMTggMTg6MTEsIENocmlzIFdpbHNvbiB3cm90ZToKPiBocnRpbWVyIGlzIG5v dCByZWxpYWJsZSBlbm91Z2ggdG8gYXNzdW1lIGZpeGVkIGludGVydmFscywgYW5kIHNvIGV2ZW4K PiBjb2Fyc2UgYWNjdXJhY3kgKGluIHRoZSBmYWNlIG9mIGthc2FuIGFuZCBzaW1pbGFyIGhlYXZ5 IGRlYnVnZ2luZykgd2UKPiBuZWVkIHRvIG1lYXN1cmUgdGhlIGFjdHVhbCBpbnRlcnZhbCBiZXR3 ZWVuIHNhbXBsZS4KCkl0IGRvZXNuJ3QgZXZlbiBhdmVyYWdlIG91dCB0byBzb21ldGhpbmcgYWNj ZXB0YWJsZSB1bmRlciBzdWNoIEtjb25maWdzPyAKSG9ycm9yLi4gcHJlY2lzZSBidXQgaW5hY2N1 cmF0ZS4gL09cCgo+IFdoaWxlIHVzaW5nIGEgc2luZ2xlIHRpbWVzdGFtcCB0byBjb21wdXRlIHRo ZSBpbnRlcnZhbCBkb2VzIG5vdCBhbGxvdwo+IHZlcnkgZmluZSBhY2N1cmFjeSAoY29uc2lkZXIg dGhlIGltcGFjdCBvZiBhIHNsb3cgZm9yY2V3YWtlIGJldHdlZW4KPiBkaWZmZXJlbnQgc2FtcGxl cyBhZnRlciB0aGUgdGltZXN0YW1wIGlzIHJlYWQpIGlzIG11Y2ggYmV0dGVyIHRoYW4KPiBhc3N1 bWluZyB0aGUgaW50ZXJ2YWwuCj4gCj4gVGVzdGNhc2U6IGlndC9wZXJmX3BtdSAjaXZiCj4gU2ln bmVkLW9mZi1ieTogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4gQ2M6 IFR2cnRrbyBVcnN1bGluIDx0dnJ0a28udXJzdWxpbkBpbnRlbC5jb20+Cj4gLS0tCj4gICBkcml2 ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3BtdS5jIHwgMjAgKysrKysrKysrKysrKy0tLS0tLS0KPiAg IGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcG11LmggfCAgNCArKysrCj4gICAyIGZpbGVzIGNo YW5nZWQsIDE3IGluc2VydGlvbnMoKyksIDcgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcG11LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p OTE1X3BtdS5jCj4gaW5kZXggZGM4Nzc5N2RiNTAwLi5mNTA4NzUxNWViNDMgMTAwNjQ0Cj4gLS0t IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9wbXUuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2k5MTVfcG11LmMKPiBAQCAtMTI3LDYgKzEyNyw3IEBAIHN0YXRpYyB2b2lkIF9faTkx NV9wbXVfbWF5YmVfc3RhcnRfdGltZXIoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmk5MTUpCj4g ICB7Cj4gICAJaWYgKCFpOTE1LT5wbXUudGltZXJfZW5hYmxlZCAmJiBwbXVfbmVlZHNfdGltZXIo aTkxNSwgdHJ1ZSkpIHsKPiAgIAkJaTkxNS0+cG11LnRpbWVyX2VuYWJsZWQgPSB0cnVlOwo+ICsJ CWk5MTUtPnBtdS50aW1lc3RhbXAgPSBrdGltZV9nZXQoKTsKPiAgIAkJaHJ0aW1lcl9zdGFydF9y YW5nZV9ucygmaTkxNS0+cG11LnRpbWVyLAo+ICAgCQkJCSAgICAgICBuc190b19rdGltZShQRVJJ T0QpLCAwLAo+ICAgCQkJCSAgICAgICBIUlRJTUVSX01PREVfUkVMX1BJTk5FRCk7Cj4gQEAgLTE2 MCw3ICsxNjEsNyBAQCB1cGRhdGVfc2FtcGxlKHN0cnVjdCBpOTE1X3BtdV9zYW1wbGUgKnNhbXBs ZSwgdTMyIHVuaXQsIHUzMiB2YWwpCj4gICAJc2FtcGxlLT5jdXIgKz0gbXVsX3UzMl91MzIodmFs LCB1bml0KTsKPiAgIH0KPiAgIAo+IC1zdGF0aWMgdm9pZCBlbmdpbmVzX3NhbXBsZShzdHJ1Y3Qg ZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gK3N0YXRpYyB2b2lkIGVuZ2luZXNfc2FtcGxl KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwgdTY0IHBlcmlvZCkKPiAgIHsKPiAg IAlzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmU7Cj4gICAJZW51bSBpbnRlbF9lbmdpbmVf aWQgaWQ7Cj4gQEAgLTE4Myw3ICsxODQsNyBAQCBzdGF0aWMgdm9pZCBlbmdpbmVzX3NhbXBsZShz dHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gICAJCXZhbCA9ICFpOTE1X3NlcW5v X3Bhc3NlZChjdXJyZW50X3NlcW5vLCBsYXN0X3NlcW5vKTsKPiAgIAo+ICAgCQl1cGRhdGVfc2Ft cGxlKCZlbmdpbmUtPnBtdS5zYW1wbGVbSTkxNV9TQU1QTEVfQlVTWV0sCj4gLQkJCSAgICAgIFBF UklPRCwgdmFsKTsKPiArCQkJICAgICAgcGVyaW9kLCB2YWwpOwo+ICAgCj4gICAJCWlmICh2YWwg JiYgKGVuZ2luZS0+cG11LmVuYWJsZSAmCj4gICAJCSAgICAoQklUKEk5MTVfU0FNUExFX1dBSVQp IHwgQklUKEk5MTVfU0FNUExFX1NFTUEpKSkpIHsKPiBAQCAtMTk1LDEwICsxOTYsMTAgQEAgc3Rh dGljIHZvaWQgZW5naW5lc19zYW1wbGUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2 KQo+ICAgCQl9Cj4gICAKPiAgIAkJdXBkYXRlX3NhbXBsZSgmZW5naW5lLT5wbXUuc2FtcGxlW0k5 MTVfU0FNUExFX1dBSVRdLAo+IC0JCQkgICAgICBQRVJJT0QsICEhKHZhbCAmIFJJTkdfV0FJVCkp Owo+ICsJCQkgICAgICBwZXJpb2QsICEhKHZhbCAmIFJJTkdfV0FJVCkpOwo+ICAgCj4gICAJCXVw ZGF0ZV9zYW1wbGUoJmVuZ2luZS0+cG11LnNhbXBsZVtJOTE1X1NBTVBMRV9TRU1BXSwKPiAtCQkJ ICAgICAgUEVSSU9ELCAhISh2YWwgJiBSSU5HX1dBSVRfU0VNQVBIT1JFKSk7Cj4gKwkJCSAgICAg IHBlcmlvZCwgISEodmFsICYgUklOR19XQUlUX1NFTUFQSE9SRSkpOwo+ICAgCX0KPiAgIAo+ICAg CWlmIChmdykKPiBAQCAtMjA3LDcgKzIwOCw3IEBAIHN0YXRpYyB2b2lkIGVuZ2luZXNfc2FtcGxl KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiAgIAlpbnRlbF9ydW50aW1lX3Bt X3B1dChkZXZfcHJpdik7Cj4gICB9Cj4gICAKPiAtc3RhdGljIHZvaWQgZnJlcXVlbmN5X3NhbXBs ZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gK3N0YXRpYyB2b2lkIGZyZXF1 ZW5jeV9zYW1wbGUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LCB1NjQgcGVyaW9k KQoKUGVyaW9kIGlzIHVudXNlZCBpbiB0aGlzIGZ1bmN0aW9uLgoKQnV0IG1vcmUgaW1wb3J0YW50 bHkgdGhhdCBsZWFkcyB0byBhIHByb2JsZW0uIFdoZW4gcmVhZGluZyB0aGUgY291bnRlciAKdGhl IGZyZXF1ZW5jaWVzIGFjY3VtdWxhdG9yIGlzIGRpdmlkZWQgYnkgRlJFUVVFTkNZIGRlZmluZSwg d2hpY2ggaXMgCmludmVyc2Ugb2YgUEVSSU9ELiBJZiB0aGUgZXJyb3IgaXMgYmlnIGVub3VnaCB0 byBtZXNzIHVwIHRoZSBlbmdpbmVzIApzYW1wbGluZywgaXMgaXQgYmlnIGVub3VnaCB0byBhZmZl Y3QgdGhlIGZyZXF1ZW5jaWVzIGFzIHdlbGw/CgpJbXByb3ZpbmcgdGhhdCB3b3VsZCBuZWVkIGF2 ZXJhZ2UgZnJlcXVlbmN5IGJldHdlZW4gdHdvIGNvdW50ZXIgcmVhZHMuIApXaGljaCBsb29rcyB0 cmlja3kgdG8gc2hvZWhvcm4gaW50byB0aGUgcG11IGFwaS4gTWF5YmUgcHJpbWl0aXZlIHJ1bm5p bmcgCmF2ZXJhZ2Ugd291bGQgZG8uCgo+ICAgewo+ICAgCWlmIChkZXZfcHJpdi0+cG11LmVuYWJs ZSAmCj4gICAJICAgIGNvbmZpZ19lbmFibGVkX21hc2soSTkxNV9QTVVfQUNUVUFMX0ZSRVFVRU5D WSkpIHsKPiBAQCAtMjM3LDEyICsyMzgsMTcgQEAgc3RhdGljIGVudW0gaHJ0aW1lcl9yZXN0YXJ0 IGk5MTVfc2FtcGxlKHN0cnVjdCBocnRpbWVyICpocnRpbWVyKQo+ICAgewo+ICAgCXN0cnVjdCBk cm1faTkxNV9wcml2YXRlICppOTE1ID0KPiAgIAkJY29udGFpbmVyX29mKGhydGltZXIsIHN0cnVj dCBkcm1faTkxNV9wcml2YXRlLCBwbXUudGltZXIpOwo+ICsJa3RpbWVfdCBub3csIHBlcmlvZDsK PiAgIAo+ICAgCWlmICghUkVBRF9PTkNFKGk5MTUtPnBtdS50aW1lcl9lbmFibGVkKSkKPiAgIAkJ cmV0dXJuIEhSVElNRVJfTk9SRVNUQVJUOwo+ICAgCj4gLQllbmdpbmVzX3NhbXBsZShpOTE1KTsK PiAtCWZyZXF1ZW5jeV9zYW1wbGUoaTkxNSk7Cj4gKwlub3cgPSBrdGltZV9nZXQoKTsKPiArCXBl cmlvZCA9IGt0aW1lX3N1Yihub3csIGk5MTUtPnBtdS50aW1lc3RhbXApOwo+ICsJaTkxNS0+cG11 LnRpbWVzdGFtcCA9IG5vdzsKPiArCj4gKwllbmdpbmVzX3NhbXBsZShpOTE1LCBwZXJpb2QpOwo+ ICsJZnJlcXVlbmN5X3NhbXBsZShpOTE1LCBwZXJpb2QpOwo+ICAgCj4gICAJaHJ0aW1lcl9mb3J3 YXJkX25vdyhocnRpbWVyLCBuc190b19rdGltZShQRVJJT0QpKTsKPiAgIAlyZXR1cm4gSFJUSU1F Ul9SRVNUQVJUOwo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3BtdS5o IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9wbXUuaAo+IGluZGV4IDJiYTczNTI5OWY3Yy4u MGYxZTQ2NDIwNzdlIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcG11 LmgKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3BtdS5oCj4gQEAgLTUyLDYgKzUy LDEwIEBAIHN0cnVjdCBpOTE1X3BtdSB7Cj4gICAJICogQHRpbWVyOiBUaW1lciBmb3IgaW50ZXJu YWwgaTkxNSBQTVUgc2FtcGxpbmcuCj4gICAJICovCj4gICAJc3RydWN0IGhydGltZXIgdGltZXI7 Cj4gKwkvKioKPiArCSAqIEB0aW1lc3RhbXA6IFRpbWVzdGFtcCBvZiBsYXN0IGludGVybmFsIGk5 MTUgUE1VIHNhbXBsaW5nLgo+ICsJICovCj4gKwlrdGltZV90IHRpbWVzdGFtcDsKPiAgIAkvKioK PiAgIAkgKiBAZW5hYmxlOiBCaXRtYXNrIG9mIGFsbCBjdXJyZW50bHkgZW5hYmxlZCBldmVudHMu Cj4gICAJICoKPiAKClBhdGNoIGxvb2tzIG9rYXksIGp1c3QgbG9zZXMgdGhlIHNvbWUgb2YgdGhl IG9wdGltaXNhdGlvbiBwb3RlbnRpYWwgc28gSSAKYW0gZ3Vlc3Npbmcgd2Ugd29uJ3QgYmUgdGhp bmtpbmcgYWJvdXQgcmVwbGFjaW5nIG11bHRpcGxpZXMgYW5kIGRpdmlkZXMgCndpdGggc2hpZnQg YW55IG1vcmUuIDopCgpCdXQgdGhlIHF1ZXN0aW9uIG9mIGZyZXF1ZW5jeSBjb3VudGVycyBpcyBu b3cgYm90aGVyaW5nIG1lLgoKQW5kIGlmIHRoaXMgcHJvYmxlbSBpcyBsaW1pdGVkIHRvIEthc2Fu IHRoZW4gaG93IG11Y2ggd2Ugd2FudCB0byAKY29tcGxpY2F0ZSB0aGluZ3MgdG8gbWFrZSB0aGF0 IHdvcms/CgpSZWdhcmRzLAoKVHZydGtvCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2ludGVsLWdmeAo=