From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC3B3C04AB5 for ; Mon, 3 Jun 2019 13:10:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C3B1F2800D for ; Mon, 3 Jun 2019 13:10:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728330AbfFCNKB (ORCPT ); Mon, 3 Jun 2019 09:10:01 -0400 Received: from smtprelay0056.hostedemail.com ([216.40.44.56]:46617 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726516AbfFCNKB (ORCPT ); Mon, 3 Jun 2019 09:10:01 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay05.hostedemail.com (Postfix) with ESMTP id 0B43F18029129; Mon, 3 Jun 2019 13:10:00 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: step10_3a06bdb8b0e14 X-Filterd-Recvd-Size: 2536 Received: from XPS-9350 (cpe-23-242-196-136.socal.res.rr.com [23.242.196.136]) (Authenticated sender: joe@perches.com) by omf09.hostedemail.com (Postfix) with ESMTPA; Mon, 3 Jun 2019 13:09:58 +0000 (UTC) Message-ID: <8285c867674b7fffd7286b9608fbb08affbb8d7f.camel@perches.com> Subject: Re: [PATCH 3/3] drivers/staging/rtl8192u: Fix of checkpatch-errors From: Joe Perches To: Christian =?ISO-8859-1?Q?M=FCller?= , gregkh@linuxfoundation.org Cc: johnfwhitmore@gmail.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, linux-kernel@i4.cs.fau.de, felix.trommer@hotmail.de Date: Mon, 03 Jun 2019 06:09:57 -0700 In-Reply-To: <20190603122104.2564-4-muellerch-privat@web.de> References: <20190603122104.2564-1-muellerch-privat@web.de> <20190603122104.2564-4-muellerch-privat@web.de> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.30.1-1build1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2019-06-03 at 14:21 +0200, Christian Müller wrote: > Fix issues that lead to multiple checkpatch warnings and errors, most of > them regarding formatting of code and comments. > Comments that contain only commented out code are removed as well. Generally, the quantity of changes in this patch makes it impossible to review and apply. It's better to do single issue fixes in separate patches. All single line whitespace only changes can generally be done in one patch as long as you verify that the object files have pre and post the patch have not changed. And the first block of this patch doesn't look like it could ever compile properly. > diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211.h b/drivers/staging/rtl8192u/ieee80211/ieee80211.h [] > @@ -446,26 +446,26 @@ typedef enum _InitialGainOpType { [] > #else > -#define IEEE80211_DEBUG (level, fmt, args...) do {} while (0) > -#define IEEE80211_DEBUG_DATA (level, data, datalen) do {} while(0) > +#define IEEE80211_DEBUG ((level, fmt, args...) do {} while (0)) > +#define IEEE80211_DEBUG_DATA ((level, data, datalen) do {} while (0)) These need to have the space removed after the macro identifier before the open parentheses and another level of parentheses removed instead. #define IEEE80211_DEBUG(level, fmt, args...) do {} while (0) #define IEEE80211_DEBUG_DATA(level, data, datalen) do {} while (0) Given that it's never been compiled, it might as well be removed in another patch. I didn't look at the rest.