All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johan Hedberg <johan.hedberg@gmail.com>
To: Inga Stotland <inga.stotland@intel.com>
Cc: linux-bluetooth@vger.kernel.org, "Gix,
	Brian" <brian.gix@intel.com>,
	Luiz Von Dentz <luiz.dentz@gmail.com>
Subject: Re: [PATCH BlueZ] test: Enable test-mesh to send raw vendor commands
Date: Fri, 22 Mar 2019 09:01:18 +0200	[thread overview]
Message-ID: <82D05BF3-3E54-4BB1-B22B-72F1C94051A5@gmail.com> (raw)
In-Reply-To: <20190322034927.6247-1-inga.stotland@intel.com>

Hi Inga,

On 22 Mar 2019, at 5.49, Inga Stotland <inga.stotland@intel.com> wrote:
> +#       5 - on/off model client menu
> +#       6 - send raw message
> +#       7 - exit

Please don’t use numeric identifiers for commands in interactive tools. Use intuitive, human readable strings like we do in the other interactive tools in the tree. Numbers might be convenient for computers, but they’re not particularly human friendly :)

Johan

  reply	other threads:[~2019-03-22  7:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-22  3:49 [PATCH BlueZ] test: Enable test-mesh to send raw vendor commands Inga Stotland
2019-03-22  7:01 ` Johan Hedberg [this message]
2019-03-22 14:00   ` Gix, Brian
2019-03-23 10:08     ` Johan Hedberg
2019-03-24  9:00       ` Luiz Augusto von Dentz
2019-03-25  7:02         ` Stotland, Inga

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=82D05BF3-3E54-4BB1-B22B-72F1C94051A5@gmail.com \
    --to=johan.hedberg@gmail.com \
    --cc=brian.gix@intel.com \
    --cc=inga.stotland@intel.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=luiz.dentz@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.