From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.codeaurora.org by pdx-caf-mail.web.codeaurora.org (Dovecot) with LMTP id V3grLLadGlsfSgAAmS7hNA ; Fri, 08 Jun 2018 15:16:22 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id A3F2B607E4; Fri, 8 Jun 2018 15:16:22 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI autolearn=ham autolearn_force=no version=3.4.0 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by smtp.codeaurora.org (Postfix) with ESMTP id 2C47D60590; Fri, 8 Jun 2018 15:16:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 2C47D60590 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752700AbeFHPQU convert rfc822-to-8bit (ORCPT + 25 others); Fri, 8 Jun 2018 11:16:20 -0400 Received: from mga12.intel.com ([192.55.52.136]:17986 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751524AbeFHPQS (ORCPT ); Fri, 8 Jun 2018 11:16:18 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Jun 2018 08:16:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,490,1520924400"; d="scan'208";a="57636373" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga003.jf.intel.com with ESMTP; 08 Jun 2018 08:16:17 -0700 Received: from fmsmsx112.amr.corp.intel.com (10.18.116.6) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 8 Jun 2018 08:16:16 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX112.amr.corp.intel.com (10.18.116.6) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 8 Jun 2018 08:16:16 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.82]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.70]) with mapi id 14.03.0319.002; Fri, 8 Jun 2018 23:16:15 +0800 From: "Kang, Luwei" To: Alexander Shishkin CC: "kvm@vger.kernel.org" , "tglx@linutronix.de" , "mingo@redhat.com" , "hpa@zytor.com" , "x86@kernel.org" , "chao.p.peng@linux.intel.com" , "thomas.lendacky@amd.com" , "bp@suse.de" , "Liang, Kan" , "Janakarajan.Natarajan@amd.com" , "dwmw@amazon.co.uk" , "linux-kernel@vger.kernel.org" , "peterz@infradead.org" , "mathieu.poirier@linaro.org" , "kstewart@linuxfoundation.org" , "gregkh@linuxfoundation.org" , "pbonzini@redhat.com" , "rkrcmar@redhat.com" , "david@redhat.com" , "bsd@redhat.com" , "yu.c.zhang@linux.intel.com" , "joro@8bytes.org" Subject: RE: [PATCH v9 11/12] KVM: x86: Set intercept for Intel PT MSRs read/write Thread-Topic: [PATCH v9 11/12] KVM: x86: Set intercept for Intel PT MSRs read/write Thread-Index: AQHT8XjYONN7dc9U5kOwdduVGGjOkKRUbL6AgAImpaA= Date: Fri, 8 Jun 2018 15:16:15 +0000 Message-ID: <82D7661F83C1A047AF7DC287873BF1E167FF021A@SHSMSX101.ccr.corp.intel.com> References: <1526964735-16566-1-git-send-email-luwei.kang@intel.com> <1526964735-16566-12-git-send-email-luwei.kang@intel.com> <20180607142201.btdz57ufzlogf25r@um.fi.intel.com> In-Reply-To: <20180607142201.btdz57ufzlogf25r@um.fi.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > From: Chao Peng > > > > Disable intercept Intel PT MSRs only when Intel PT is enabled in > > guest. But MSR_IA32_RTIT_CTL will alway be intercept. > > "I'd like to offer some suggestions as to how to make the commit message > friendlier for reviewing. > > Generally, for every patch, we want to explain the following: what we want, > why we want it and how we want to go about getting it. We also would > prefer to do it in english rather than in C, because for the latter we can just > look at the code." [1] > > I apologize for quoting myself or if I'm stating the obvious, but it looks > appropriate here. > > [1] https://marc.info/?l=linux-kernel&m=152233031020263 > Thank you very much. My English is not good and lack some experience of how to make description more clearly. Will improve it. Thanks, Luwei Kang From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Kang, Luwei" Subject: RE: [PATCH v9 11/12] KVM: x86: Set intercept for Intel PT MSRs read/write Date: Fri, 8 Jun 2018 15:16:15 +0000 Message-ID: <82D7661F83C1A047AF7DC287873BF1E167FF021A@SHSMSX101.ccr.corp.intel.com> References: <1526964735-16566-1-git-send-email-luwei.kang@intel.com> <1526964735-16566-12-git-send-email-luwei.kang@intel.com> <20180607142201.btdz57ufzlogf25r@um.fi.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT Cc: "kvm@vger.kernel.org" , "tglx@linutronix.de" , "mingo@redhat.com" , "hpa@zytor.com" , "x86@kernel.org" , "chao.p.peng@linux.intel.com" , "thomas.lendacky@amd.com" , "bp@suse.de" , "Liang, Kan" , "Janakarajan.Natarajan@amd.com" , "dwmw@amazon.co.uk" , "linux-kernel@vger.kernel.org" , "peterz@infradead.org" , "mathieu.poirier@linaro.org" , "kstewart@linuxfoundation.org" , "gregkh@linuxfoundation.org" , "pbonzini@redha To: Alexander Shishkin Return-path: In-Reply-To: <20180607142201.btdz57ufzlogf25r@um.fi.intel.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org > > From: Chao Peng > > > > Disable intercept Intel PT MSRs only when Intel PT is enabled in > > guest. But MSR_IA32_RTIT_CTL will alway be intercept. > > "I'd like to offer some suggestions as to how to make the commit message > friendlier for reviewing. > > Generally, for every patch, we want to explain the following: what we want, > why we want it and how we want to go about getting it. We also would > prefer to do it in english rather than in C, because for the latter we can just > look at the code." [1] > > I apologize for quoting myself or if I'm stating the obvious, but it looks > appropriate here. > > [1] https://marc.info/?l=linux-kernel&m=152233031020263 > Thank you very much. My English is not good and lack some experience of how to make description more clearly. Will improve it. Thanks, Luwei Kang