From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752820AbdDCLNw (ORCPT ); Mon, 3 Apr 2017 07:13:52 -0400 Received: from mail-db5eur01on0115.outbound.protection.outlook.com ([104.47.2.115]:53376 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751757AbdDCLNt (ORCPT ); Mon, 3 Apr 2017 07:13:49 -0400 Authentication-Results: vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=axentia.se; Subject: Re: [PATCH 9/9] [media] cx231xx: stop double error reporting To: Wolfram Sang References: <1491208718-32068-1-git-send-email-peda@axentia.se> <1491208718-32068-10-git-send-email-peda@axentia.se> <20170403102646.GA2750@katana> CC: , Peter Korsgaard , Guenter Roeck , Linus Walleij , Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Mauro Carvalho Chehab , , , From: Peter Rosin Organization: Axentia Technologies AB Message-ID: <82a2980a-732e-54f0-22f3-3d54bf99ef37@axentia.se> Date: Mon, 3 Apr 2017 13:13:41 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170403102646.GA2750@katana> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [81.224.171.159] X-ClientProxiedBy: AM3PR07CA0077.eurprd07.prod.outlook.com (10.165.222.11) To AM5PR0202MB2548.eurprd02.prod.outlook.com (10.173.89.9) X-MS-Office365-Filtering-Correlation-Id: c30f7f91-f8ca-4123-82a5-08d47a827ead X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(201703131423075);SRVR:AM5PR0202MB2548; X-Microsoft-Exchange-Diagnostics: 1;AM5PR0202MB2548;3:+bbXVppfRcpE8ynh4VQOvqqNfpkiDrKdTwLGPvWxlPWLe2uVzfQIJqxJVWZ9gbWLcM7UJENrOurLykquZFgOQ01rVt+w9e5O3XDysLI67t3Nw0hyOM/nUWw10CeOeRl0XjjTvSc6d4hXIEeDkqBXbywNNQ9CdeEfb+zBTPEhOavpcCzMFq2MYTisStwskXv7/A9Qkl4iCLAyASmT6rBFp/HcdDt+U3a4JTzc4fX9dNXJepT+KaGZqqXZX4xdDAsipBcxhATkX6kKVjHZ71aL9Spa7ULtonDVPVdTksg2hVZDRXHrMEH9TDFW1in5GxFV;25:E9BiyciuzXbHKmK/gPIXh5CLo6jZEZdzs4VZKlR0QiFD190q5Ttkl5K9bAXg4zlgvoMMZ6x3vwe8Z1SnTQDvftI9apzH8XghqH9dkaZJ1HSv+3OShBZ+F7lZV+nt4USStFBImPwh8prQEj1PJMgRtybuo7uckDWnROXWhV12QVDAlHMSgXUWNGsIvZyS4tuX3ji3OL0jzyW2DHuJipcBv0JJ8kYDf4xuYKp6Sqqr1M+lWjhKE3Nb03/R1K0f9IbvZg2LP2r/CSis2zgA0WapXiXqeyooM0uaath/DjXD09J21VM4nLcxCmPMcFclkyje0XG/K7p1hXM5fRQFAPYhITNuD/fnCaycOTI3OIMMJOJkIk73gDuEZoUr86XXoTeWuyW2PMsYTaXamfFlQZmorZ6km6GAw44VBXQ3yb0h3kHSOMAJ/M465YyMBQd+TSt7YO3DdPLZ1gdwMkBNM9eJhQ== X-Microsoft-Exchange-Diagnostics: 1;AM5PR0202MB2548;31:ntIkDNMNYfzLqPosi7rimM1dsTRxb91g5lHTFLsZqDnZwg3POf30BxQ1VDA4SqsDGey6N/NSdd9vuqgb+zIM56n+gZnb8NRdoUWzLUgNqbOMLsX1E4JsuUvjO7AvBAMWzS1H6TirwJY5oOx3IWrbCqfEqtEsj3/XxaRwy7CUJbtu4Bix3oQNA/SL21nuG0PBMFjeVE/xQn604UyKhMHyH+H0xL3Eb8XZixD0tTuVIJFpO8QBEI4LvaSPeWbXa4nODoXSfWhvwxL4Xr0J9i1YXQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(211171220733660); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(10201501046)(6041248)(20161123562025)(20161123564025)(20161123560025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(2016111802025)(6043046)(6072148);SRVR:AM5PR0202MB2548;BCL:0;PCL:0;RULEID:;SRVR:AM5PR0202MB2548; X-Microsoft-Exchange-Diagnostics: 1;AM5PR0202MB2548;4:kimPPXzYjxLe76UmCTbI7sUko+O3u1OEiLFZzFZ3XV+r60X/QOGifj1F4iNhr5BSgpdqWa0wMTlgLMOwZEjzViafpL7hgYciP+/gfOsc0UqfB7BwD5S+vVFfg4VKcJaliOvbPPqffHK9Ue6jFzIWJoZr5n58JVZtkn0/vvz0F86uYmFRoWn+7khhkRVEL+8pWX0ZcMzcAdS+DoIMk6FZsZ2va8T4lJfJl2iPRa4Enr/eMI0Iznux7E9IFEWLSnJWSWsXnOk2bK7i7J0/wL3gQOk3hJMWvAg6htICmUbsjAhTCut33fpUGww/rj60FcGX4uSpZqN8rbvG3CY0oYY0uKD8+GQlkIg3bQe0F4Gi9xXa7kjJyV4ydmRN2SZx6VlLZhe7Ilx64wPKSIGNIq1vszOjgWfs0wMfNPWFDRNPODjrQw9WEE+/hQP/N0gbjolCJmp/MNh9G/kXfrvuSJ6/gZDc6dx+yMfNviOB3qK++u4LgwsK99rOYv4nhVww3Udzya60mX5eHE0yhQzDQg6vC95Pl35jsSzQpdry+GdUc6yZhBIaGHfkRQ2c9yjFWPgFSs3lSVUUYqnKeynVjIq1tl8wcNWBPwz2oEq0KiI3O3CSuMzyZ6eaZ+CdHQfgJFMG7yJUYYrqUezcOZGjyzPCbETLu+V9n4K63cemnEYS3seNjGxwMAei7NXW67QBbwfo4XLudfpVhGIbY2wbaUhUkq2B5rm1hr6SOwC8cY1wm6WBN3j19rDZW4kiP6yh+gev0N6pR+9B3tWCkskmYaEuMtpYSMQ4Pljln0KtQTLE8P/UU8cEUlVEp8w697v1TIDD X-Forefront-PRVS: 0266491E90 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(6049001)(39450400003)(39400400002)(39410400002)(39840400002)(377424004)(24454002)(53546009)(6246003)(38730400002)(54356999)(47776003)(110136004)(5660300001)(189998001)(65826007)(7416002)(81166006)(4001350100001)(50466002)(8676002)(42186005)(31686004)(50986999)(36756003)(229853002)(4326008)(6486002)(33646002)(6116002)(230700001)(3846002)(83506001)(8666007)(53936002)(54906002)(6916009)(305945005)(2950100002)(74482002)(76176999)(6666003)(117156002)(66066001)(77096006)(2906002)(31696002)(23746002)(25786009)(7736002)(90366009)(86362001)(42262002);DIR:OUT;SFP:1102;SCL:1;SRVR:AM5PR0202MB2548;H:[192.168.0.125];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;AM5PR0202MB2548;23:sQdhF5gJ0X8Jz0suuXgebHxMcohIqVVYRQB?= =?Windows-1252?Q?MIrpa6cxxRaOhncOoq2qoU/7hkQdtoDJ6qDjZwqC7h8io7m8Eeu9o0Dn?= =?Windows-1252?Q?GQASVgDsyRMV5XgE654MNA6XuDfeZxsJwpUuZnBnpOmo3wLgQ5IexQpp?= =?Windows-1252?Q?nn/P9idLEQ5HaJ9Hr0M7Jqg9Ld9QdE9ipp23dx+qgANBR9JVMjKArUzw?= =?Windows-1252?Q?aDdowYYlz4kxta85XYQ/igiipi+uqUhcNKGIs1l2lAvIeftdeBSm7aQ4?= =?Windows-1252?Q?1ZZWCgVl64YAISqhvz/Mffpxu7Z+nAAUXxFRrr/2mVtSJGd3Iq8+yZIn?= =?Windows-1252?Q?izj/OVnSfIfAxqrdF56j/n90ZnGJ+nw4+KBtq9i1az44+NX4ZYaQcu9i?= =?Windows-1252?Q?znLQigNYmISWeDrEk0yRt7ja9eJYZ0T4P4kSHefg+eetgA0N1XPwqZWP?= =?Windows-1252?Q?ctOPESvqnmyPbqJKuB44BKvX3wz2FbXWKMKl9EF699UfJQT2CmfkkOA9?= =?Windows-1252?Q?lSdRkvltyTbYn1ZECpGz0IpxyHAyv8bbP5eKPFhNodrmv2oK4lL2q1ab?= =?Windows-1252?Q?V26Xth1pp5oSX8fVWnNlX2Dyy1R2j+lHjk8GqFg2B/fke+wd2E+1IJej?= =?Windows-1252?Q?I/3nLqP610FZrBdERgcjNDWgYu6bne30m7IqOBUbeLWGPFpqlNV5SowY?= =?Windows-1252?Q?CTntu9MyL8ls+PBjsJl3Y61sytoT0KmtHEcYXwngU+qUMWEUTwalwRyA?= =?Windows-1252?Q?z95usSQWnr1NH6oOgKMD5igtCZLBSiWjJ7PFPnLhfwBhkMvFX8WYXQ2s?= =?Windows-1252?Q?OKfwgJZ51jZYkzKXoHKn2eoa3Uuze+j/YxnJHFBX2J4i4hzhd2AqWnPt?= =?Windows-1252?Q?BYgmo+qDSXAxzUI9ENLG28HXco3IFYapC97DQndsFBc4Tf8kSgYgGaH5?= =?Windows-1252?Q?48Sx4FHeS8Nw4+q+b4LS5E4fE3RwJFFb4ALm8WlzadnFzKs6ohpXwVZr?= =?Windows-1252?Q?I3JtNqZQfIVVgkuHR+VIQA6RefZ98hPQNn26xo1CPnGBN9Ixly9D6OS9?= =?Windows-1252?Q?qErqJBzygzr/vOZUHOa3Bd6cONYbieRVE2cv1BrdTz3Fj3hVyEcX0aDg?= =?Windows-1252?Q?ZjGgMHrko+hwxELt92Lb+KKlR6HRrFzS5HVPIqJcrQozPuAtlctuMhA+?= =?Windows-1252?Q?vWEPV8J6KKxE4xkLOkURuO1kpOnTutXW4m+t6FyOKD4t9PK6LdGnTMQ8?= =?Windows-1252?Q?8FI8zoJ5lYPDE3TqWil0uhvmK+Ym4YfCfNBuB7g/ZtzUueLsBTdUO3Pg?= =?Windows-1252?Q?8o0HsPEpt4opKGpOkuGJRzuc1EtAFcQI5ngmJG87tyyCnjSgIAahfZqL?= =?Windows-1252?Q?wPmyuqetcHB6V7rYyDXVK9gk2V2rxJuzjDQfvNEzMh25KUN9MtRV0MBU?= =?Windows-1252?Q?/LPic02SGu4XtLaXQVepC?= X-Microsoft-Exchange-Diagnostics: 1;AM5PR0202MB2548;6:GC0sSqV49oQ1nz2bDcVlukp8lAl1gKOY5zBjxQUM5YcIKlEme983lfzDCB4U+3wXdkMEqTYHfi08BtpSddyhnmBGpCXG8PIKN6CNQYZk8sd4CmVdzw+e0m8naa85Vmxc1hC6iZv/eW6VhCZVkXP1B12Zq7tyrUtvYzEc62EEZTxzKQsgVmHuT8WEEj6RFCYQf6vCcQRSbR92vbAX81G3YUANLKFDaXf9dBGdtQzTTyGsor7lMF6OwcOsdzk2+BcvqZ6nXGsKrUcSr6dSmT/LHYUuFnaNSfKdI1Vj6yifI6X6DN9scJZB7VHrG28WvCq/kmm+vAgkVG4VYNQZL2MQ1AiSX7yfpf4J8eBFNP4J15lE3IU9gesB75OO0PHCytEkYLP5yO/onFl2Z2d72IeG+w==;5:hGGMz+PARDSVpwZvVd53NpcHynk22XvJCQCrTPqYWNfeMnSqKhx4LtcblWPS3/Y0P2iv7AIcWk5/bDwL3OUskXurbIZqNqUVXt6pb4oDH9C6gsWQYNySDXmLV5U7stJCeG04yvVObm9cxPQtTnIFZeEpVMaSrcent1Fe1v2PDnk=;24:3G23Lm1/BF4pvA93lj8xEGzdVUJ8Gx0n4m4++NDCIUb0cwfEr0sHMmsJijqlCOIlTKFkedp+loGc8oJGUuFvADSv2f6vhNAvAk8ciKPWyPw= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;AM5PR0202MB2548;7:M8JhpVnI73dltvplHlEpHnPVBzjn77sK2Lj0s9CK7Jm9SqP6CCnFrLSpgow1g2byxSnQRQmLU47EsS4k6XHZkqUZSaf6zHoOTGIkjtMLsDIwI83SGZQ2a8RUN9v2hPOF9RVRQWHZflInw4kRC+tk3L1BV4pPHnDoYomr7clJMYG6Bty8FApuxUQvStk1cF3UgVvi8E1a9gaL/SzRlHuEbBxb/5QPW2gQGAzElBJpfWph861RCwXii3dKidGTqTpp7/7+821JD0pidDvnil+fvJVsuC31uB4mBfJy8isnPm0mFcoD5Wm+srnp1ttHzWBaxceggp8KdH1XeY+wSLzMzg== X-OriginatorOrg: axentia.se X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Apr 2017 11:13:44.5563 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0202MB2548 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017-04-03 12:26, Wolfram Sang wrote: > On Mon, Apr 03, 2017 at 10:38:38AM +0200, Peter Rosin wrote: >> i2c_mux_add_adapter already logs a message on failure. >> >> Signed-off-by: Peter Rosin >> --- >> drivers/media/usb/cx231xx/cx231xx-i2c.c | 15 ++++----------- >> 1 file changed, 4 insertions(+), 11 deletions(-) >> >> diff --git a/drivers/media/usb/cx231xx/cx231xx-i2c.c b/drivers/media/usb/cx231xx/cx231xx-i2c.c >> index 35e9acfe63d3..dff514e147da 100644 >> --- a/drivers/media/usb/cx231xx/cx231xx-i2c.c >> +++ b/drivers/media/usb/cx231xx/cx231xx-i2c.c >> @@ -576,17 +576,10 @@ int cx231xx_i2c_mux_create(struct cx231xx *dev) >> >> int cx231xx_i2c_mux_register(struct cx231xx *dev, int mux_no) >> { >> - int rc; >> - >> - rc = i2c_mux_add_adapter(dev->muxc, >> - 0, >> - mux_no /* chan_id */, >> - 0 /* class */); >> - if (rc) >> - dev_warn(dev->dev, >> - "i2c mux %d register FAILED\n", mux_no); >> - >> - return rc; >> + return i2c_mux_add_adapter(dev->muxc, >> + 0, >> + mux_no /* chan_id */, >> + 0 /* class */); > > Could be argued that the whole function is obsolete now and the > c231xx-core can call i2c_mux_add_adapter() directly. But maybe this is a > seperate patch. Agreed on all counts. BTW, the ..._unregister function below is equally "obsolete". I'm going to leave the removal of both functions at the discretion of whomever takes care of cx231xx maintenance... Cheers, peda >> } >> >> void cx231xx_i2c_mux_unregister(struct cx231xx *dev) >> -- >> 2.1.4 >> From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Rosin Subject: Re: [PATCH 9/9] [media] cx231xx: stop double error reporting Date: Mon, 3 Apr 2017 13:13:41 +0200 Message-ID: <82a2980a-732e-54f0-22f3-3d54bf99ef37@axentia.se> References: <1491208718-32068-1-git-send-email-peda@axentia.se> <1491208718-32068-10-git-send-email-peda@axentia.se> <20170403102646.GA2750@katana> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20170403102646.GA2750@katana> Sender: linux-media-owner@vger.kernel.org To: Wolfram Sang Cc: linux-kernel@vger.kernel.org, Peter Korsgaard , Guenter Roeck , Linus Walleij , Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Mauro Carvalho Chehab , linux-i2c@vger.kernel.org, linux-iio@vger.kernel.org, linux-media@vger.kernel.org List-Id: linux-i2c@vger.kernel.org On 2017-04-03 12:26, Wolfram Sang wrote: > On Mon, Apr 03, 2017 at 10:38:38AM +0200, Peter Rosin wrote: >> i2c_mux_add_adapter already logs a message on failure. >> >> Signed-off-by: Peter Rosin >> --- >> drivers/media/usb/cx231xx/cx231xx-i2c.c | 15 ++++----------- >> 1 file changed, 4 insertions(+), 11 deletions(-) >> >> diff --git a/drivers/media/usb/cx231xx/cx231xx-i2c.c b/drivers/media/usb/cx231xx/cx231xx-i2c.c >> index 35e9acfe63d3..dff514e147da 100644 >> --- a/drivers/media/usb/cx231xx/cx231xx-i2c.c >> +++ b/drivers/media/usb/cx231xx/cx231xx-i2c.c >> @@ -576,17 +576,10 @@ int cx231xx_i2c_mux_create(struct cx231xx *dev) >> >> int cx231xx_i2c_mux_register(struct cx231xx *dev, int mux_no) >> { >> - int rc; >> - >> - rc = i2c_mux_add_adapter(dev->muxc, >> - 0, >> - mux_no /* chan_id */, >> - 0 /* class */); >> - if (rc) >> - dev_warn(dev->dev, >> - "i2c mux %d register FAILED\n", mux_no); >> - >> - return rc; >> + return i2c_mux_add_adapter(dev->muxc, >> + 0, >> + mux_no /* chan_id */, >> + 0 /* class */); > > Could be argued that the whole function is obsolete now and the > c231xx-core can call i2c_mux_add_adapter() directly. But maybe this is a > seperate patch. Agreed on all counts. BTW, the ..._unregister function below is equally "obsolete". I'm going to leave the removal of both functions at the discretion of whomever takes care of cx231xx maintenance... Cheers, peda >> } >> >> void cx231xx_i2c_mux_unregister(struct cx231xx *dev) >> -- >> 2.1.4 >>