From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45851) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bKpFC-0005uX-IZ for qemu-devel@nongnu.org; Wed, 06 Jul 2016 12:00:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bKpF6-00037M-Vv for qemu-devel@nongnu.org; Wed, 06 Jul 2016 12:00:09 -0400 References: <1467732272-23368-1-git-send-email-clord@redhat.com> <1467732272-23368-18-git-send-email-clord@redhat.com> From: Max Reitz Message-ID: <82a46074-ea26-dcae-bc03-bdeab432736a@redhat.com> Date: Wed, 6 Jul 2016 17:59:52 +0200 MIME-Version: 1.0 In-Reply-To: <1467732272-23368-18-git-send-email-clord@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="laauHiO17nAbJCSuR1j7I4rsVwuWo85GC" Subject: Re: [Qemu-devel] [PATCH v3 17/32] blockdev: Separate bochs probe from its driver List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Colin Lord , qemu-devel@nongnu.org Cc: kwolf@redhat.com, qemu-block@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --laauHiO17nAbJCSuR1j7I4rsVwuWo85GC From: Max Reitz To: Colin Lord , qemu-devel@nongnu.org Cc: kwolf@redhat.com, qemu-block@nongnu.org Message-ID: <82a46074-ea26-dcae-bc03-bdeab432736a@redhat.com> Subject: Re: [PATCH v3 17/32] blockdev: Separate bochs probe from its driver References: <1467732272-23368-1-git-send-email-clord@redhat.com> <1467732272-23368-18-git-send-email-clord@redhat.com> In-Reply-To: <1467732272-23368-18-git-send-email-clord@redhat.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 05.07.2016 17:24, Colin Lord wrote: > Modifies the bochs probe to return the format name as well as the > score as the final step of separating the probe function from the > driver. This keeps the probe completely independent of the driver, > making future modularization easier to accomplish. Returning the format= > name as well as the score allows the score to be correlated to the > driver without the probe function needing to be part of the driver. >=20 > Signed-off-by: Colin Lord > --- > block.c | 19 +++++++++++++++++++ > block/bochs.c | 1 - > block/probe/bochs.c | 25 ++++++++++++++++--------- > include/block/probe.h | 3 ++- > 4 files changed, 37 insertions(+), 11 deletions(-) Oh, and another comment: I think it would be better to split this patch into a part that modifies block.c (introducing the format_probes array and using it in bdrv_probe_all()) and another one that actually does the bochs-specific stuff. Max --laauHiO17nAbJCSuR1j7I4rsVwuWo85GC Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEvBAEBCAAZBQJXfSr4EhxtcmVpdHpAcmVkaGF0LmNvbQAKCRA7sUIC6DisrSd+ CACu5p7FETTkxsp2CaaSE8FeB41AWxf1x0MUul2/2mkrI1AkiQHibgUs5h9Riqzn gjxaxFvgSQ3KXdvPOhWI+FJJM4vsRjsLk6pxV9ts6Lof38pVEix9F719tumPUr4Z 55mt/pt/RT5S6/klSrt0hmdW2VaX//B7Uy+s+YzrZZb1cuEjU9YgeLF0edCHC4NZ L3YVudetA00qvkVKxS0tNwB3cGWdpNE8XcHzLGnMvG6tsSbvrUGViMJM2ARNYzgc TV+RQqYrl1nR9WvMCJxglR2ieQIocr7h/BU8DYFqVBDxw6V7FWOi2nIOvPPJxiCx ps/gXMk+lcEBnyMZTX4+Z4s2 =7pS3 -----END PGP SIGNATURE----- --laauHiO17nAbJCSuR1j7I4rsVwuWo85GC--