From: Saeed Mahameed <saeedm@mellanox.com>
To: "kuba@kernel.org" <kuba@kernel.org>
Cc: Parav Pandit <parav@mellanox.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Bodong Wang <bodong@mellanox.com>
Subject: Re: [net-next 07/14] net/mlx5: E-Switch, Update VF vports config when num of VFs changed
Date: Sat, 14 Mar 2020 06:13:43 +0000 [thread overview]
Message-ID: <82a53bad75c33302461a19953b962ca22089d7e2.camel@mellanox.com> (raw)
In-Reply-To: <20200313193638.6d9fdff8@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On Fri, 2020-03-13 at 19:36 -0700, Jakub Kicinski wrote:
> On Fri, 13 Mar 2020 18:16:15 -0700 Saeed Mahameed wrote:
> > From: Bodong Wang <bodong@mellanox.com>
> >
> > Currently, ECPF eswitch manager does one-time only configuration
> > for
> > VF vports when device switches to offloads mode. However, when num
> > of
> > VFs changed from host side, driver doesn't update VF vports
> > configurations.
> >
> > Hence, perform VFs vport configuration update whenever num_vfs
> > change
> > event occurs.
>
> Oh, I thought you kept max_vfs number of reprs on the ECPF, always.
> Or was that just the initial plan?
No, Smartnic's ECPF switchdev was required to be loaded only after host
PF enables sriov, so it will get the correct num_vfs and initialize
eswitch and reps accordingly.
3 reasons to change this:
1. Remove the dependency of when to load the switchdev mode in ECPF and
make the admin life easier
2. better code dynamics and vport management.
3. pave the way for future support of dynamically created Sub-
functions..
next prev parent reply other threads:[~2020-03-15 1:31 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-14 1:16 [pull request][net-next 00/14] Mellanox, mlx5 updates 2020-03-13 Saeed Mahameed
2020-03-14 1:16 ` [net-next 01/14] net/mlx5: E-Switch, Remove redundant check of eswitch manager cap Saeed Mahameed
2020-03-14 1:16 ` [net-next 02/14] net/mlx5: E-Switch, Hold mutex when querying drop counter in legacy mode Saeed Mahameed
2020-03-14 1:16 ` [net-next 03/14] net/mlx5: E-Switch, Remove redundant warning when QoS enable failed Saeed Mahameed
2020-03-14 1:16 ` [net-next 04/14] net/mlx5: E-Switch, Prepare for vport enable/disable refactor Saeed Mahameed
2020-03-14 1:16 ` [net-next 05/14] net/mlx5: E-switch, Make vport setup/cleanup sequence symmetric Saeed Mahameed
2020-03-14 1:16 ` [net-next 06/14] net/mlx5: E-Switch, Introduce per vport configuration for eswitch modes Saeed Mahameed
2020-03-14 1:16 ` [net-next 07/14] net/mlx5: E-Switch, Update VF vports config when num of VFs changed Saeed Mahameed
2020-03-14 2:36 ` Jakub Kicinski
2020-03-14 6:13 ` Saeed Mahameed [this message]
2020-03-14 1:16 ` [net-next 08/14] net/mlx5: E-Switch, Refactor unload all reps per rep type Saeed Mahameed
2020-03-14 1:16 ` [net-next 09/14] net/mlx5: Accept flow rules without match Saeed Mahameed
2020-03-14 1:16 ` [net-next 10/14] net/mlx5: E-switch, Annotate termtbl_mutex mutex destroy Saeed Mahameed
2020-03-14 1:16 ` [net-next 11/14] net/mlx5: E-switch, Annotate esw state_lock " Saeed Mahameed
2020-03-14 1:16 ` [net-next 12/14] net/mlx5: Avoid deriving mlx5_core_dev second time Saeed Mahameed
2020-03-14 1:16 ` [net-next 13/14] net/mlx5: DR, Add support for flow table id destination action Saeed Mahameed
2020-03-14 2:36 ` Jakub Kicinski
2020-03-14 6:23 ` Saeed Mahameed
2020-03-14 9:57 ` Leon Romanovsky
2020-03-14 1:16 ` [net-next 14/14] net/mlx5: DR, Remove unneeded functions deceleration Saeed Mahameed
2020-03-14 2:37 ` [pull request][net-next 00/14] Mellanox, mlx5 updates 2020-03-13 Jakub Kicinski
2020-03-14 4:04 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=82a53bad75c33302461a19953b962ca22089d7e2.camel@mellanox.com \
--to=saeedm@mellanox.com \
--cc=bodong@mellanox.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=parav@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.