Re: [PATCH 1/2] hwmon: lm75: Add NXP LM75A to of_match list

From: Guenter Roeck <linux@roeck-us.net>
To: "Matwey V. Kornilov" <matwey@sai.msu.ru>,
	Jean Delvare <jdelvare@suse.com>,
	"open list:HARDWARE MONITORING" <linux-hwmon@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>
Cc: matwey.kornilov@gmail.com
Subject: Re: [PATCH 1/2] hwmon: lm75: Add NXP LM75A to of_match list
Date: Sat, 30 Jan 2021 07:41:03 -0800	[thread overview]
Message-ID: <82abc622-a625-b1bc-39b4-f9e1849036ee@roeck-us.net> (raw)
In-Reply-To: <20210130103823.28914-1-matwey@sai.msu.ru>

On 1/30/21 2:38 AM, Matwey V. Kornilov wrote:
> NXP LM75A is compatible with original LM75A while it has improved
> 11-bit precision.
> 
> https://www.nxp.com/docs/en/data-sheet/LM75A.pdf
> 
> Signed-off-by: Matwey V. Kornilov <matwey@sai.msu.ru>
> ---
>  drivers/hwmon/lm75.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/hwmon/lm75.c b/drivers/hwmon/lm75.c
> index 3aa7f9454f57..37dc903ebf54 100644
> --- a/drivers/hwmon/lm75.c
> +++ b/drivers/hwmon/lm75.c
> @@ -699,6 +699,10 @@ static const struct of_device_id __maybe_unused lm75_of_match[] = {
>  		.compatible = "national,lm75b",
>  		.data = (void *)lm75b
>  	},
> +	{
> +		.compatible = "nxp,lm75a",
> +		.data = (void *)lm75b

This should get a different identifier (such as lm75a_nxp or whatever)
because otherwise the results would be different on non-devicetree
systems which would only match "lm75a".

> +	},
>  	{
>  		.compatible = "maxim,max6625",
>  		.data = (void *)max6625
> 

Both "nxp,lm75a" and "nxp,lm75b" need to be added to
Documentation/devicetree/bindings/hwmon/lm75.yaml (in a separate
patch with copy to dt maintainers for review).

Guenter