From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751632AbdFIINC (ORCPT ); Fri, 9 Jun 2017 04:13:02 -0400 Received: from mail-wr0-f196.google.com ([209.85.128.196]:35582 "EHLO mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751562AbdFIIMy (ORCPT ); Fri, 9 Jun 2017 04:12:54 -0400 Subject: Re: [PATCH 2/3] arm: dts: mt2701: Add display bls related nodes for MT2701 To: Erin Lo Cc: srv_heupstream@mediatek.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, YT Shen , Weiqing Kong References: <1496297324-21091-1-git-send-email-erin.lo@mediatek.com> <1496297324-21091-3-git-send-email-erin.lo@mediatek.com> From: Matthias Brugger Message-ID: <82c8b877-ec34-bd37-7428-8af86191a66e@gmail.com> Date: Fri, 9 Jun 2017 10:12:50 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <1496297324-21091-3-git-send-email-erin.lo@mediatek.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/06/17 08:08, Erin Lo wrote: > From: YT Shen I miss the Singed-off-by from YT Shen. > > This patch adds the device node of display backlight for MT2701 > > Signed-off-by: Weiqing Kong > Signed-off-by: Erin Lo > --- > arch/arm/boot/dts/mt2701-evb.dts | 29 +++++++++++++++++++++++++++++ > arch/arm/boot/dts/mt2701.dtsi | 9 +++++++++ > 2 files changed, 38 insertions(+) > > diff --git a/arch/arm/boot/dts/mt2701-evb.dts b/arch/arm/boot/dts/mt2701-evb.dts > index a483798..e49c2b7 100644 > --- a/arch/arm/boot/dts/mt2701-evb.dts > +++ b/arch/arm/boot/dts/mt2701-evb.dts > @@ -22,6 +22,35 @@ > memory { > reg = <0 0x80000000 0 0x40000000>; > }; > + > + backlight_lcd: backlight_lcd { > + compatible = "pwm-backlight"; > + pwms = <&bls 0 100000>; > + brightness-levels = < > + 0 16 32 48 64 80 96 112 > + 128 144 160 176 192 208 224 240 > + 255 > + >; > + default-brightness-level = <9>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pwm_bls_gpio>; > + }; > +}; > + > +&bls { > + status = "okay"; > +}; > + > +&mmsys { > + status = "okay"; > +}; > + > +&pio { > + pwm_bls_gpio: pwm_bls_gpio { > + pins_cmd_dat { > + pinmux = ; > + }; > + }; > }; > > &auxadc { > diff --git a/arch/arm/boot/dts/mt2701.dtsi b/arch/arm/boot/dts/mt2701.dtsi > index de88bd7..4f110d5 100644 > --- a/arch/arm/boot/dts/mt2701.dtsi > +++ b/arch/arm/boot/dts/mt2701.dtsi > @@ -366,6 +366,15 @@ > #clock-cells = <1>; > }; > > + bls: bls@1400a000 { > + compatible = "mediatek,mt2701-disp-pwm"; > + reg = <0 0x1400a000 0 0x1000>; > + #pwm-cells = <2>; > + clocks = <&mmsys CLK_MM_MDP_BLS_26M>, <&mmsys CLK_MM_DISP_BLS>; > + clock-names = "main", "mm"; > + status = "disabled"; > + }; > + Can you make this a new patch please. It's preferred to have one patch for the dtsi and another one for the actual board. Thanks, Matthias > larb0: larb@14010000 { > compatible = "mediatek,mt2701-smi-larb"; > reg = <0 0x14010000 0 0x1000>; > From mboxrd@z Thu Jan 1 00:00:00 1970 From: matthias.bgg@gmail.com (Matthias Brugger) Date: Fri, 9 Jun 2017 10:12:50 +0200 Subject: [PATCH 2/3] arm: dts: mt2701: Add display bls related nodes for MT2701 In-Reply-To: <1496297324-21091-3-git-send-email-erin.lo@mediatek.com> References: <1496297324-21091-1-git-send-email-erin.lo@mediatek.com> <1496297324-21091-3-git-send-email-erin.lo@mediatek.com> Message-ID: <82c8b877-ec34-bd37-7428-8af86191a66e@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 01/06/17 08:08, Erin Lo wrote: > From: YT Shen I miss the Singed-off-by from YT Shen. > > This patch adds the device node of display backlight for MT2701 > > Signed-off-by: Weiqing Kong > Signed-off-by: Erin Lo > --- > arch/arm/boot/dts/mt2701-evb.dts | 29 +++++++++++++++++++++++++++++ > arch/arm/boot/dts/mt2701.dtsi | 9 +++++++++ > 2 files changed, 38 insertions(+) > > diff --git a/arch/arm/boot/dts/mt2701-evb.dts b/arch/arm/boot/dts/mt2701-evb.dts > index a483798..e49c2b7 100644 > --- a/arch/arm/boot/dts/mt2701-evb.dts > +++ b/arch/arm/boot/dts/mt2701-evb.dts > @@ -22,6 +22,35 @@ > memory { > reg = <0 0x80000000 0 0x40000000>; > }; > + > + backlight_lcd: backlight_lcd { > + compatible = "pwm-backlight"; > + pwms = <&bls 0 100000>; > + brightness-levels = < > + 0 16 32 48 64 80 96 112 > + 128 144 160 176 192 208 224 240 > + 255 > + >; > + default-brightness-level = <9>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pwm_bls_gpio>; > + }; > +}; > + > +&bls { > + status = "okay"; > +}; > + > +&mmsys { > + status = "okay"; > +}; > + > +&pio { > + pwm_bls_gpio: pwm_bls_gpio { > + pins_cmd_dat { > + pinmux = ; > + }; > + }; > }; > > &auxadc { > diff --git a/arch/arm/boot/dts/mt2701.dtsi b/arch/arm/boot/dts/mt2701.dtsi > index de88bd7..4f110d5 100644 > --- a/arch/arm/boot/dts/mt2701.dtsi > +++ b/arch/arm/boot/dts/mt2701.dtsi > @@ -366,6 +366,15 @@ > #clock-cells = <1>; > }; > > + bls: bls at 1400a000 { > + compatible = "mediatek,mt2701-disp-pwm"; > + reg = <0 0x1400a000 0 0x1000>; > + #pwm-cells = <2>; > + clocks = <&mmsys CLK_MM_MDP_BLS_26M>, <&mmsys CLK_MM_DISP_BLS>; > + clock-names = "main", "mm"; > + status = "disabled"; > + }; > + Can you make this a new patch please. It's preferred to have one patch for the dtsi and another one for the actual board. Thanks, Matthias > larb0: larb at 14010000 { > compatible = "mediatek,mt2701-smi-larb"; > reg = <0 0x14010000 0 0x1000>; >