From: Bart Van Assche <bvanassche@acm.org>
To: j-young.choi@samsung.com, ALIM AKHTAR <alim.akhtar@samsung.com>,
"avri.altman@wdc.com" <avri.altman@wdc.com>,
"jejb@linux.ibm.com" <jejb@linux.ibm.com>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"beanhuo@micron.com" <beanhuo@micron.com>,
"adrian.hunter@intel.com" <adrian.hunter@intel.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 3/6] scsi: ufs: wb: Add explicit flush sysfs attribute
Date: Fri, 29 Jul 2022 13:31:21 -0700 [thread overview]
Message-ID: <82d1e6da-df4b-31bb-ec46-76099d7c3288@acm.org> (raw)
In-Reply-To: <20220729045600epcms2p45c0f8a5a0a76c7fe85b0961570de89ce@epcms2p4>
On 7/28/22 21:56, Jinyoung CHOI wrote:
> diff --git a/Documentation/ABI/testing/sysfs-driver-ufs b/Documentation/ABI/testing/sysfs-driver-ufs
> index 6b248abb1bd7..7e9e1db55d60 100644
> --- a/Documentation/ABI/testing/sysfs-driver-ufs
> +++ b/Documentation/ABI/testing/sysfs-driver-ufs
> @@ -1417,6 +1417,16 @@ Description: This node is used to set or display whether UFS WriteBooster is
> platform that doesn't support UFSHCD_CAP_CLK_SCALING, we can
> disable/enable WriteBooster through this sysfs node.
>
> +What: /sys/bus/platform/drivers/ufshcd/*/wb_buf_flush_en
> +What: /sys/bus/platform/devices/*.ufs/wb_buf_flush_en
> +Date: July 2022
> +Contact: Jinyoung Choi <j-young.choi@samsung.com>
> +Description: This node is used to set or display whether WriteBooster
^^^^
Please change "node" into "attribute" (here and below). Sysfs files are
called attributes.
> + buffer flusing is enabled. The data written in the WriteBooster
^^^^^^^
flushing?
> + Buffer can be flushed by an explicit host command or
> + implicitly while in hibernate (HIBERN8) state.
The above sentence is misleading because it suggests that setting this
attribute causes the WB buffer to be flushed in its entirety. That is
not correct - what this attribute controls is whether or not the UFS
device is allowed to start with flushing the WB buffer.
> + if (!ufshcd_is_wb_allowed(hba) ||
> + (hba->quirks & UFSHCI_QUIRK_SKIP_MANUAL_WB_FLUSH_CTRL)) {
> + dev_warn(dev, "It is not allowed to configure WB buf flush!\n");
flush -> flushing
> + ufshcd_rpm_get_sync(hba);
> + res = ufshcd_wb_toggle_buf_flush(hba, wb_buf_flush_en);
> + ufshcd_rpm_put_sync(hba);
> +out:
> + up(&hba->host_sem);
> + return res < 0 ? res : count;
> +}
Please leave a blank line above goto labels as requested by the kernel
coding style guide.
Thanks,
Bart.
next prev parent reply other threads:[~2022-07-29 20:31 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20220729045045epcms2p8caf00317889ed4da8531b7466ec6e368@epcms2p8>
2022-07-29 4:50 ` [PATCH v5 0/6] scsi: ufs: wb: Add sysfs attribute and cleanup Jinyoung CHOI
[not found] ` <CGME20220729045045epcms2p8caf00317889ed4da8531b7466ec6e368@epcms2p7>
2022-07-29 4:52 ` [PATCH v5 1/6] scsi: ufs: wb: Change wb_enabled condition test Jinyoung CHOI
2022-07-29 20:16 ` Bart Van Assche
2022-07-31 13:01 ` Stanley Chu
2022-07-29 4:54 ` [PATCH v5 2/6] scsi: ufs: wb: Change functions name and modify parameter name Jinyoung CHOI
2022-07-29 20:22 ` Bart Van Assche
[not found] ` <CGME20220729045045epcms2p8caf00317889ed4da8531b7466ec6e368@epcms2p2>
2022-08-01 3:45 ` Jinyoung CHOI
[not found] ` <CGME20220729045045epcms2p8caf00317889ed4da8531b7466ec6e368@epcms2p4>
2022-07-29 4:56 ` [PATCH v5 3/6] scsi: ufs: wb: Add explicit flush sysfs attribute Jinyoung CHOI
2022-07-29 20:31 ` Bart Van Assche [this message]
2022-07-29 4:57 ` [PATCH v5 5/6] scsi: ufs: wb: Modify messages Jinyoung CHOI
2022-07-29 20:34 ` Bart Van Assche
[not found] ` <CGME20220729045045epcms2p8caf00317889ed4da8531b7466ec6e368@epcms2p3>
2022-08-01 5:35 ` Jinyoung CHOI
[not found] ` <CGME20220729045045epcms2p8caf00317889ed4da8531b7466ec6e368@epcms2p5>
2022-07-29 4:59 ` [PATCH v5 6/6] scsi: ufs: wb: Move the comment to the right position Jinyoung CHOI
2022-07-29 20:34 ` Bart Van Assche
[not found] ` <CGME20220729045045epcms2p8caf00317889ed4da8531b7466ec6e368@epcms2p1>
2022-07-29 4:56 ` [PATCH v5 4/6] scsi: ufs: wb: Add ufshcd_is_wb_buf_flush_allowed() Jinyoung CHOI
2022-07-29 20:32 ` Bart Van Assche
2022-08-01 5:27 ` RE:(2) [PATCH v5 3/6] scsi: ufs: wb: Add explicit flush sysfs attribute Jinyoung CHOI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=82d1e6da-df4b-31bb-ec46-76099d7c3288@acm.org \
--to=bvanassche@acm.org \
--cc=adrian.hunter@intel.com \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=j-young.choi@samsung.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.