* [U-Boot] [PATCH v7 00/10] STiH410-B2260: add reset, usb and fastboot support
@ 2017-06-01 12:05 patrice.chotard at st.com
2017-06-01 12:05 ` [U-Boot] [PATCH v7 01/10] mmc: sti_sdhci: Rework sti_mmc_core_config() patrice.chotard at st.com
` (9 more replies)
0 siblings, 10 replies; 22+ messages in thread
From: patrice.chotard at st.com @ 2017-06-01 12:05 UTC (permalink / raw)
To: u-boot
From: Patrice Chotard <patrice.chotard@st.com>
This series adds :
_ update existing sdhci driver to use reset framework
_ add usb phy driver
_ add fastboot support
With all this feature enable, it's now possible to
_ boot on usb mass storage device
_ boot from kernel image and dtb previously loaded using tftp
_ update mmc partiton using fastboot
v7: _ rebase on top of dm/master to use last livetree update
_ replace fdtdec_parse_phandle_with_args() by dev_read_phandle_with_args() in patch 4
_ replace uclass_get_device_by_of_offset() by uclass_get_device_by_ofnode() in patch 4
v6: _ generic ehci/ohci drivers extension has been send separately
_ add reviewed-by Simon Glass
v5: _ extend generic ehci with phy
_ extend generic ohci with clock, reset and phy
_ remove specifi STi ehci and ohci drivers and use generic ohci/ehci
ones
_ update stih410-b2260 device tree to use ehci and ohci generic
drivers
v4: _ use PHY uclass currently available on dm-next branch,
update sti ehci, ohci and xhci drivers to use new PHY uclass.
v3: _ remove reset driver (already applied on u-boot-dm tree by Simon
Glass)
_ patch 4: add new USB PHY uclass requested by Simon Glass
_ patch 5: convert STi usb phy driver to new USB PHY uclass
_ patch 6/7: update echi/ohci drivers to use USB PHY uclass
_ patch 8/9: rework xhci-sti.c and dwc3-sti.c. Previously, xhci-sti driver binded
dwc3-sti (STi glue driver) which was not correct. Now we respect the device
tree hierarchy, ie the STi dwc3 glue driver is first probed, then bind the
xhci-sti driver.
v2: _ add Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com> in patches 2,3 and 4
_ fix remarks done by Marek Vasut :
_ patch 5 : replace bitfield_replace() by clrsetbits_le32()
_ patch 6 : update error messages and add remove callback
_ patch 8 : put board specific defines in a separate patch
_ patch 7: use setbits_le32() instead of read, modify, write
sequence and add missing parenthesis
_ squash previous patches 7,9,11,12,14,16,17,18,19,20 and 21
in patch 14
Patrice Chotard (10):
mmc: sti_sdhci: Rework sti_mmc_core_config()
ARM: dts: stih410-family: Add missing reset_names for mmc1 node
mmc: sti_sdhci: Use reset framework
usb: phy: Add STi USB2 PHY
STiH410-B2260: enable USB Host Networking
STiH410-B2260: enable USB, fastboot, reset, PHY related flags
usb: dwc3: Add dwc3 glue driver support for STi
ARM: dts: STiH410: set DWC3 dual role mode to peripheral
ARM: dts: STiH410: update ehci and ohci compatible
board: STiH410-B2260: add fastboot support
arch/arm/dts/stih407-family.dtsi | 3 +-
arch/arm/dts/stih410.dtsi | 11 +-
arch/arm/include/asm/arch-stih410/sys_proto.h | 11 +
board/st/stih410-b2260/board.c | 41 ++++
configs/stih410-b2260_defconfig | 39 +++-
doc/device-tree-bindings/phy/phy-stih407-usb.txt | 24 +++
doc/device-tree-bindings/usb/dwc3-st.txt | 60 ++++++
drivers/mmc/sti_sdhci.c | 56 +++--
drivers/phy/Kconfig | 8 +
drivers/phy/Makefile | 1 +
drivers/phy/sti_usb_phy.c | 181 ++++++++++++++++
drivers/usb/host/Kconfig | 9 +
drivers/usb/host/Makefile | 1 +
drivers/usb/host/dwc3-sti-glue.c | 256 +++++++++++++++++++++++
include/configs/stih410-b2260.h | 16 ++
include/dwc3-sti-glue.h | 43 ++++
16 files changed, 730 insertions(+), 30 deletions(-)
create mode 100644 arch/arm/include/asm/arch-stih410/sys_proto.h
create mode 100644 doc/device-tree-bindings/phy/phy-stih407-usb.txt
create mode 100644 doc/device-tree-bindings/usb/dwc3-st.txt
create mode 100644 drivers/phy/sti_usb_phy.c
create mode 100644 drivers/usb/host/dwc3-sti-glue.c
create mode 100644 include/dwc3-sti-glue.h
--
1.9.1
^ permalink raw reply [flat|nested] 22+ messages in thread
* [U-Boot] [PATCH v7 01/10] mmc: sti_sdhci: Rework sti_mmc_core_config()
2017-06-01 12:05 [U-Boot] [PATCH v7 00/10] STiH410-B2260: add reset, usb and fastboot support patrice.chotard at st.com
@ 2017-06-01 12:05 ` patrice.chotard at st.com
2017-06-01 12:05 ` [U-Boot] [PATCH v7 02/10] ARM: dts: stih410-family: Add missing reset_names for mmc1 node patrice.chotard at st.com
` (8 subsequent siblings)
9 siblings, 0 replies; 22+ messages in thread
From: patrice.chotard at st.com @ 2017-06-01 12:05 UTC (permalink / raw)
To: u-boot
From: Patrice Chotard <patrice.chotard@st.com>
Use struct udevice* as input parameter. Previous
parameters are retrieved through plat and priv data.
This to prepare to use the reset framework.
Signed-off-by: Patrice Chotard <patrice.chotard@st.com>
Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
---
v7: _ none
v6: _ add reviewed-by Simon Glass
v5: _ none
v4: _ none
v3: _ none
v2: _ none
drivers/mmc/sti_sdhci.c | 33 ++++++++++++++++++---------------
1 file changed, 18 insertions(+), 15 deletions(-)
diff --git a/drivers/mmc/sti_sdhci.c b/drivers/mmc/sti_sdhci.c
index f85f6b4..714afd9 100644
--- a/drivers/mmc/sti_sdhci.c
+++ b/drivers/mmc/sti_sdhci.c
@@ -16,6 +16,7 @@ DECLARE_GLOBAL_DATA_PTR;
struct sti_sdhci_plat {
struct mmc_config cfg;
struct mmc mmc;
+ int instance;
};
/*
@@ -26,8 +27,8 @@ struct sti_sdhci_plat {
/**
* sti_mmc_core_config: configure the Arasan HC
- * @regbase: base address
- * @mmc_instance: mmc instance id
+ * @dev : udevice
+ *
* Description: this function is to configure the Arasan MMC HC.
* This should be called when the system starts in case of, on the SoC,
* it is needed to configure the host controller.
@@ -36,33 +37,35 @@ struct sti_sdhci_plat {
* W/o these settings the SDHCI could configure and use the embedded controller
* with limited features.
*/
-static void sti_mmc_core_config(const u32 regbase, int mmc_instance)
+static void sti_mmc_core_config(struct udevice *dev)
{
+ struct sti_sdhci_plat *plat = dev_get_platdata(dev);
+ struct sdhci_host *host = dev_get_priv(dev);
unsigned long *sysconf;
/* only MMC1 has a reset line */
- if (mmc_instance) {
+ if (plat->instance) {
sysconf = (unsigned long *)(STIH410_SYSCONF5_BASE +
ST_MMC_CCONFIG_REG_5);
generic_set_bit(SYSCONF_MMC1_ENABLE_BIT, sysconf);
}
writel(STI_FLASHSS_MMC_CORE_CONFIG_1,
- regbase + FLASHSS_MMC_CORE_CONFIG_1);
+ host->ioaddr + FLASHSS_MMC_CORE_CONFIG_1);
- if (mmc_instance) {
+ if (plat->instance) {
writel(STI_FLASHSS_MMC_CORE_CONFIG2,
- regbase + FLASHSS_MMC_CORE_CONFIG_2);
+ host->ioaddr + FLASHSS_MMC_CORE_CONFIG_2);
writel(STI_FLASHSS_MMC_CORE_CONFIG3,
- regbase + FLASHSS_MMC_CORE_CONFIG_3);
+ host->ioaddr + FLASHSS_MMC_CORE_CONFIG_3);
} else {
writel(STI_FLASHSS_SDCARD_CORE_CONFIG2,
- regbase + FLASHSS_MMC_CORE_CONFIG_2);
+ host->ioaddr + FLASHSS_MMC_CORE_CONFIG_2);
writel(STI_FLASHSS_SDCARD_CORE_CONFIG3,
- regbase + FLASHSS_MMC_CORE_CONFIG_3);
+ host->ioaddr + FLASHSS_MMC_CORE_CONFIG_3);
}
writel(STI_FLASHSS_MMC_CORE_CONFIG4,
- regbase + FLASHSS_MMC_CORE_CONFIG_4);
+ host->ioaddr + FLASHSS_MMC_CORE_CONFIG_4);
}
static int sti_sdhci_probe(struct udevice *dev)
@@ -70,7 +73,7 @@ static int sti_sdhci_probe(struct udevice *dev)
struct mmc_uclass_priv *upriv = dev_get_uclass_priv(dev);
struct sti_sdhci_plat *plat = dev_get_platdata(dev);
struct sdhci_host *host = dev_get_priv(dev);
- int ret, mmc_instance;
+ int ret;
/*
* identify current mmc instance, mmc1 has a reset, not mmc0
@@ -79,11 +82,11 @@ static int sti_sdhci_probe(struct udevice *dev)
*/
if (fdt_getprop(gd->fdt_blob, dev_of_offset(dev), "resets", NULL))
- mmc_instance = 1;
+ plat->instance = 1;
else
- mmc_instance = 0;
+ plat->instance = 0;
- sti_mmc_core_config((const u32) host->ioaddr, mmc_instance);
+ sti_mmc_core_config(dev);
host->quirks = SDHCI_QUIRK_WAIT_SEND_CMD |
SDHCI_QUIRK_32BIT_DMA_ADDR |
--
1.9.1
^ permalink raw reply related [flat|nested] 22+ messages in thread
* [U-Boot] [PATCH v7 02/10] ARM: dts: stih410-family: Add missing reset_names for mmc1 node
2017-06-01 12:05 [U-Boot] [PATCH v7 00/10] STiH410-B2260: add reset, usb and fastboot support patrice.chotard at st.com
2017-06-01 12:05 ` [U-Boot] [PATCH v7 01/10] mmc: sti_sdhci: Rework sti_mmc_core_config() patrice.chotard at st.com
@ 2017-06-01 12:05 ` patrice.chotard at st.com
2017-06-01 12:05 ` [U-Boot] [PATCH v7 03/10] mmc: sti_sdhci: Use reset framework patrice.chotard at st.com
` (7 subsequent siblings)
9 siblings, 0 replies; 22+ messages in thread
From: patrice.chotard at st.com @ 2017-06-01 12:05 UTC (permalink / raw)
To: u-boot
From: Patrice Chotard <patrice.chotard@st.com>
reset-names property is needed to use the reset
API for STi sdhci driver.
Signed-off-by: Patrice Chotard <patrice.chotard@st.com>
Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
---
v7: _ none
v6: _ add reviewed-by Simon Glass
v5: _ none
v4: _ none
v3: _ none
v2: _ none
arch/arm/dts/stih407-family.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/dts/stih407-family.dtsi b/arch/arm/dts/stih407-family.dtsi
index af66b53..452ac1c 100644
--- a/arch/arm/dts/stih407-family.dtsi
+++ b/arch/arm/dts/stih407-family.dtsi
@@ -563,6 +563,7 @@
clocks = <&clk_s_c0_flexgen CLK_MMC_1>,
<&clk_s_c0_flexgen CLK_RX_ICN_HVA>;
resets = <&softreset STIH407_MMC1_SOFTRESET>;
+ reset-names = "softreset";
bus-width = <4>;
};
--
1.9.1
^ permalink raw reply related [flat|nested] 22+ messages in thread
* [U-Boot] [PATCH v7 03/10] mmc: sti_sdhci: Use reset framework
2017-06-01 12:05 [U-Boot] [PATCH v7 00/10] STiH410-B2260: add reset, usb and fastboot support patrice.chotard at st.com
2017-06-01 12:05 ` [U-Boot] [PATCH v7 01/10] mmc: sti_sdhci: Rework sti_mmc_core_config() patrice.chotard at st.com
2017-06-01 12:05 ` [U-Boot] [PATCH v7 02/10] ARM: dts: stih410-family: Add missing reset_names for mmc1 node patrice.chotard at st.com
@ 2017-06-01 12:05 ` patrice.chotard at st.com
2017-06-01 12:05 ` [U-Boot] [PATCH v7 04/10] usb: phy: Add STi USB2 PHY patrice.chotard at st.com
` (6 subsequent siblings)
9 siblings, 0 replies; 22+ messages in thread
From: patrice.chotard at st.com @ 2017-06-01 12:05 UTC (permalink / raw)
To: u-boot
From: Patrice Chotard <patrice.chotard@st.com>
Signed-off-by: Patrice Chotard <patrice.chotard@st.com>
Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
---
v7: _ none
v6: _ add reviewed-by Simon Glass
v5: _ none
v4: _ none
v3: _ none
v2: _ none
drivers/mmc/sti_sdhci.c | 29 ++++++++++++++++++++---------
1 file changed, 20 insertions(+), 9 deletions(-)
diff --git a/drivers/mmc/sti_sdhci.c b/drivers/mmc/sti_sdhci.c
index 714afd9..c0436f8 100644
--- a/drivers/mmc/sti_sdhci.c
+++ b/drivers/mmc/sti_sdhci.c
@@ -8,6 +8,7 @@
#include <common.h>
#include <dm.h>
#include <mmc.h>
+#include <reset-uclass.h>
#include <sdhci.h>
#include <asm/arch/sdhci.h>
@@ -16,6 +17,7 @@ DECLARE_GLOBAL_DATA_PTR;
struct sti_sdhci_plat {
struct mmc_config cfg;
struct mmc mmc;
+ struct reset_ctl reset;
int instance;
};
@@ -37,17 +39,19 @@ struct sti_sdhci_plat {
* W/o these settings the SDHCI could configure and use the embedded controller
* with limited features.
*/
-static void sti_mmc_core_config(struct udevice *dev)
+static int sti_mmc_core_config(struct udevice *dev)
{
struct sti_sdhci_plat *plat = dev_get_platdata(dev);
struct sdhci_host *host = dev_get_priv(dev);
- unsigned long *sysconf;
+ int ret;
/* only MMC1 has a reset line */
if (plat->instance) {
- sysconf = (unsigned long *)(STIH410_SYSCONF5_BASE +
- ST_MMC_CCONFIG_REG_5);
- generic_set_bit(SYSCONF_MMC1_ENABLE_BIT, sysconf);
+ ret = reset_deassert(&plat->reset);
+ if (ret < 0) {
+ error("MMC1 deassert failed: %d", ret);
+ return ret;
+ }
}
writel(STI_FLASHSS_MMC_CORE_CONFIG_1,
@@ -66,6 +70,8 @@ static void sti_mmc_core_config(struct udevice *dev)
}
writel(STI_FLASHSS_MMC_CORE_CONFIG4,
host->ioaddr + FLASHSS_MMC_CORE_CONFIG_4);
+
+ return 0;
}
static int sti_sdhci_probe(struct udevice *dev)
@@ -80,13 +86,18 @@ static int sti_sdhci_probe(struct udevice *dev)
* MMC0 is wired to the SD slot,
* MMC1 is wired on the high speed connector
*/
-
- if (fdt_getprop(gd->fdt_blob, dev_of_offset(dev), "resets", NULL))
+ ret = reset_get_by_index(dev, 0, &plat->reset);
+ if (!ret)
plat->instance = 1;
else
- plat->instance = 0;
+ if (ret == -ENOENT)
+ plat->instance = 0;
+ else
+ return ret;
- sti_mmc_core_config(dev);
+ ret = sti_mmc_core_config(dev);
+ if (ret)
+ return ret;
host->quirks = SDHCI_QUIRK_WAIT_SEND_CMD |
SDHCI_QUIRK_32BIT_DMA_ADDR |
--
1.9.1
^ permalink raw reply related [flat|nested] 22+ messages in thread
* [U-Boot] [PATCH v7 04/10] usb: phy: Add STi USB2 PHY
2017-06-01 12:05 [U-Boot] [PATCH v7 00/10] STiH410-B2260: add reset, usb and fastboot support patrice.chotard at st.com
` (2 preceding siblings ...)
2017-06-01 12:05 ` [U-Boot] [PATCH v7 03/10] mmc: sti_sdhci: Use reset framework patrice.chotard at st.com
@ 2017-06-01 12:05 ` patrice.chotard at st.com
2017-06-02 2:56 ` Simon Glass
2017-06-03 6:08 ` Marek Vasut
2017-06-01 12:05 ` [U-Boot] [PATCH v7 05/10] STiH410-B2260: enable USB Host Networking patrice.chotard at st.com
` (5 subsequent siblings)
9 siblings, 2 replies; 22+ messages in thread
From: patrice.chotard at st.com @ 2017-06-01 12:05 UTC (permalink / raw)
To: u-boot
From: Patrice Chotard <patrice.chotard@st.com>
This is the generic phy driver for the picoPHY ports
used by USB2/1.1 controllers. It is found on STiH407 SoC
family from STMicroelectronics.
Signed-off-by: Patrice Chotard <patrice.chotard@st.com>
Reviewed-by: Marek Vasut <marex@denx.de>
---
v7: _ replace fdtdec_parse_phandle_with_args() by dev_read_phandle_with_args()
_ replace uclass_get_device_by_of_offset() by uclass_get_device_by_ofnode()
v6: _ none
v5: _ add Reviewed-by: Marek Vasut <marex@denx.de>
v4: _ update to use the new PHY uclass currently available on dm-next branch
v3: _ convert driver to USB PHY uclass
v2: _ replace bitfield_replace() by clrsetbits_le32()
doc/device-tree-bindings/phy/phy-stih407-usb.txt | 24 +++
drivers/phy/Kconfig | 8 +
drivers/phy/Makefile | 1 +
drivers/phy/sti_usb_phy.c | 181 +++++++++++++++++++++++
4 files changed, 214 insertions(+)
create mode 100644 doc/device-tree-bindings/phy/phy-stih407-usb.txt
create mode 100644 drivers/phy/sti_usb_phy.c
diff --git a/doc/device-tree-bindings/phy/phy-stih407-usb.txt b/doc/device-tree-bindings/phy/phy-stih407-usb.txt
new file mode 100644
index 0000000..de6a706
--- /dev/null
+++ b/doc/device-tree-bindings/phy/phy-stih407-usb.txt
@@ -0,0 +1,24 @@
+ST STiH407 USB PHY controller
+
+This file documents the dt bindings for the usb picoPHY driver which is the PHY for both USB2 and USB3
+host controllers (when controlling usb2/1.1 devices) available on STiH407 SoC family from STMicroelectronics.
+
+Required properties:
+- compatible : should be "st,stih407-usb2-phy"
+- st,syscfg : phandle of sysconfig bank plus integer array containing phyparam and phyctrl register offsets
+- resets : list of phandle and reset specifier pairs. There should be two entries, one
+ for the whole phy and one for the port
+- reset-names : list of reset signal names. Should be "global" and "port"
+See: Documentation/devicetree/bindings/reset/st,sti-powerdown.txt
+See: Documentation/devicetree/bindings/reset/reset.txt
+
+Example:
+
+usb2_picophy0: usbpicophy at f8 {
+ compatible = "st,stih407-usb2-phy";
+ #phy-cells = <0>;
+ st,syscfg = <&syscfg_core 0x100 0xf4>;
+ resets = <&softreset STIH407_PICOPHY_SOFTRESET>,
+ <&picophyreset STIH407_PICOPHY0_RESET>;
+ reset-names = "global", "port";
+};
diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
index a91a694..4330b36 100644
--- a/drivers/phy/Kconfig
+++ b/drivers/phy/Kconfig
@@ -59,4 +59,12 @@ config SPL_PIPE3_PHY
This PHY is found on omap devices supporting SATA such as dra7, am57x
and omap5
+config STI_USB_PHY
+ bool "STMicroelectronics USB2 picoPHY driver for STiH407 family"
+ depends on PHY && ARCH_STI
+ help
+ This is the generic phy driver for the picoPHY ports
+ used by USB2 and USB3 Host controllers available on
+ STiH407 SoC families.
+
endmenu
diff --git a/drivers/phy/Makefile b/drivers/phy/Makefile
index 6ce96d2..22d92d3 100644
--- a/drivers/phy/Makefile
+++ b/drivers/phy/Makefile
@@ -8,3 +8,4 @@
obj-$(CONFIG_$(SPL_)PHY) += phy-uclass.o
obj-$(CONFIG_PHY_SANDBOX) += sandbox-phy.o
obj-$(CONFIG_$(SPL_)PIPE3_PHY) += ti-pipe3-phy.o
+obj-$(CONFIG_STI_USB_PHY) += sti_usb_phy.o
diff --git a/drivers/phy/sti_usb_phy.c b/drivers/phy/sti_usb_phy.c
new file mode 100644
index 0000000..0e0b1c0
--- /dev/null
+++ b/drivers/phy/sti_usb_phy.c
@@ -0,0 +1,181 @@
+/*
+ * Copyright (c) 2017
+ * Patrice Chotard <patrice.chotard@st.com>
+ *
+ * SPDX-License-Identifier: GPL-2.0+
+ */
+
+#include <common.h>
+#include <asm/io.h>
+#include <bitfield.h>
+#include <dm.h>
+#include <errno.h>
+#include <fdtdec.h>
+#include <generic-phy.h>
+#include <libfdt.h>
+#include <regmap.h>
+#include <reset-uclass.h>
+#include <syscon.h>
+#include <wait_bit.h>
+
+#include <linux/bitops.h>
+#include <linux/compat.h>
+
+DECLARE_GLOBAL_DATA_PTR;
+
+/* Default PHY_SEL and REFCLKSEL configuration */
+#define STIH407_USB_PICOPHY_CTRL_PORT_CONF 0x6
+
+/* ports parameters overriding */
+#define STIH407_USB_PICOPHY_PARAM_DEF 0x39a4dc
+
+#define PHYPARAM_REG 1
+#define PHYCTRL_REG 2
+#define PHYPARAM_NB 3
+
+struct sti_usb_phy {
+ struct regmap *regmap;
+ struct reset_ctl global_ctl;
+ struct reset_ctl port_ctl;
+ int param;
+ int ctrl;
+};
+
+static int sti_usb_phy_deassert(struct sti_usb_phy *phy)
+{
+ int ret;
+
+ ret = reset_deassert(&phy->global_ctl);
+ if (ret < 0) {
+ error("PHY global deassert failed: %d", ret);
+ return ret;
+ }
+
+ ret = reset_deassert(&phy->port_ctl);
+ if (ret < 0)
+ error("PHY port deassert failed: %d", ret);
+
+ return ret;
+}
+
+static int sti_usb_phy_init(struct phy *usb_phy)
+{
+ struct udevice *dev = usb_phy->dev;
+ struct sti_usb_phy *phy = dev_get_priv(dev);
+ void __iomem *reg;
+
+ /* set ctrl picophy value */
+ reg = (void __iomem *)phy->regmap->base + phy->ctrl;
+ /* CTRL_PORT mask is 0x1f */
+ clrsetbits_le32(reg, 0x1f, STIH407_USB_PICOPHY_CTRL_PORT_CONF);
+
+ /* set ports parameters overriding */
+ reg = (void __iomem *)phy->regmap->base + phy->param;
+ /* PARAM_DEF mask is 0xffffffff */
+ clrsetbits_le32(reg, 0xffffffff, STIH407_USB_PICOPHY_PARAM_DEF);
+
+ return sti_usb_phy_deassert(phy);
+}
+
+static int sti_usb_phy_exit(struct phy *usb_phy)
+{
+ struct udevice *dev = usb_phy->dev;
+ struct sti_usb_phy *phy = dev_get_priv(dev);
+ int ret;
+
+ ret = reset_assert(&phy->port_ctl);
+ if (ret < 0) {
+ error("PHY port assert failed: %d", ret);
+ return ret;
+ }
+
+ ret = reset_assert(&phy->global_ctl);
+ if (ret < 0)
+ error("PHY global assert failed: %d", ret);
+
+ return ret;
+}
+
+struct phy_ops sti_usb_phy_ops = {
+ .init = sti_usb_phy_init,
+ .exit = sti_usb_phy_exit,
+};
+
+int sti_usb_phy_probe(struct udevice *dev)
+{
+ struct sti_usb_phy *priv = dev_get_priv(dev);
+ struct udevice *syscon;
+ struct ofnode_phandle_args syscfg_phandle;
+ u32 cells[PHYPARAM_NB];
+ int ret, count;
+
+ /* get corresponding syscon phandle */
+ ret = dev_read_phandle_with_args(dev, "st,syscfg", NULL, 0, 0,
+ &syscfg_phandle);
+
+ if (ret < 0) {
+ error("Can't get syscfg phandle: %d\n", ret);
+ return ret;
+ }
+
+ ret = uclass_get_device_by_ofnode(UCLASS_SYSCON, syscfg_phandle.node,
+ &syscon);
+ if (ret) {
+ error("unable to find syscon device (%d)\n", ret);
+ return ret;
+ }
+
+ priv->regmap = syscon_get_regmap(syscon);
+ if (!priv->regmap) {
+ error("unable to find regmap\n");
+ return -ENODEV;
+ }
+
+ /* get phy param offset */
+ count = fdtdec_get_int_array_count(gd->fdt_blob, dev_of_offset(dev),
+ "st,syscfg", cells,
+ ARRAY_SIZE(cells));
+
+ if (count < 0) {
+ error("Bad PHY st,syscfg property %d\n", count);
+ return -EINVAL;
+ }
+
+ if (count > PHYPARAM_NB) {
+ error("Unsupported PHY param count %d\n", count);
+ return -EINVAL;
+ }
+
+ priv->param = cells[PHYPARAM_REG];
+ priv->ctrl = cells[PHYCTRL_REG];
+
+ /* get global reset control */
+ ret = reset_get_by_name(dev, "global", &priv->global_ctl);
+ if (ret) {
+ error("can't get global reset for %s (%d)", dev->name, ret);
+ return ret;
+ }
+
+ /* get port reset control */
+ ret = reset_get_by_name(dev, "port", &priv->port_ctl);
+ if (ret) {
+ error("can't get port reset for %s (%d)", dev->name, ret);
+ return ret;
+ }
+
+ return 0;
+}
+
+static const struct udevice_id sti_usb_phy_ids[] = {
+ { .compatible = "st,stih407-usb2-phy" },
+ { }
+};
+
+U_BOOT_DRIVER(sti_usb_phy) = {
+ .name = "sti_usb_phy",
+ .id = UCLASS_PHY,
+ .of_match = sti_usb_phy_ids,
+ .probe = sti_usb_phy_probe,
+ .ops = &sti_usb_phy_ops,
+ .priv_auto_alloc_size = sizeof(struct sti_usb_phy),
+};
--
1.9.1
^ permalink raw reply related [flat|nested] 22+ messages in thread
* [U-Boot] [PATCH v7 05/10] STiH410-B2260: enable USB Host Networking
2017-06-01 12:05 [U-Boot] [PATCH v7 00/10] STiH410-B2260: add reset, usb and fastboot support patrice.chotard at st.com
` (3 preceding siblings ...)
2017-06-01 12:05 ` [U-Boot] [PATCH v7 04/10] usb: phy: Add STi USB2 PHY patrice.chotard at st.com
@ 2017-06-01 12:05 ` patrice.chotard at st.com
2017-06-01 12:05 ` [U-Boot] [PATCH v7 06/10] STiH410-B2260: enable USB, fastboot, reset, PHY related flags patrice.chotard at st.com
` (4 subsequent siblings)
9 siblings, 0 replies; 22+ messages in thread
From: patrice.chotard at st.com @ 2017-06-01 12:05 UTC (permalink / raw)
To: u-boot
From: Patrice Chotard <patrice.chotard@st.com>
Enable USB Host Networking support by enabling Ethernet/USB
adaptors support and by enabling some BOOTP flags
Signed-off-by: Patrice Chotard <patrice.chotard@st.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
---
v7: _ none
v6: _ add reviewed-by Simon Glass
_ add missing comment in commit message
v5: _ none
v4: _ none
v3: _ none
v2: _ none
include/configs/stih410-b2260.h | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/include/configs/stih410-b2260.h b/include/configs/stih410-b2260.h
index 6f4070f..6c84e9b 100644
--- a/include/configs/stih410-b2260.h
+++ b/include/configs/stih410-b2260.h
@@ -52,4 +52,20 @@
#define CONFIG_SKIP_LOWLEVEL_INIT
+/* USB Configs */
+#define CONFIG_USB_OHCI_NEW
+#define CONFIG_SYS_USB_OHCI_MAX_ROOT_PORTS 2
+#define CONFIG_SYS_USB_XHCI_MAX_ROOT_PORTS 2
+
+#define CONFIG_USB_HOST_ETHER
+#define CONFIG_USB_ETHER_ASIX
+#define CONFIG_USB_ETHER_MCS7830
+#define CONFIG_USB_ETHER_SMSC95XX
+
+/* NET Configs */
+#define CONFIG_BOOTP_SUBNETMASK
+#define CONFIG_BOOTP_GATEWAY
+#define CONFIG_BOOTP_HOSTNAME
+#define CONFIG_BOOTP_BOOTPATH
+
#endif /* __CONFIG_H */
--
1.9.1
^ permalink raw reply related [flat|nested] 22+ messages in thread
* [U-Boot] [PATCH v7 06/10] STiH410-B2260: enable USB, fastboot, reset, PHY related flags
2017-06-01 12:05 [U-Boot] [PATCH v7 00/10] STiH410-B2260: add reset, usb and fastboot support patrice.chotard at st.com
` (4 preceding siblings ...)
2017-06-01 12:05 ` [U-Boot] [PATCH v7 05/10] STiH410-B2260: enable USB Host Networking patrice.chotard at st.com
@ 2017-06-01 12:05 ` patrice.chotard at st.com
2017-06-01 12:05 ` [U-Boot] [PATCH v7 07/10] usb: dwc3: Add dwc3 glue driver support for STi patrice.chotard at st.com
` (3 subsequent siblings)
9 siblings, 0 replies; 22+ messages in thread
From: patrice.chotard at st.com @ 2017-06-01 12:05 UTC (permalink / raw)
To: u-boot
From: Patrice Chotard <patrice.chotard@st.com>
Signed-off-by: Patrice Chotard <patrice.chotard@st.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
---
v7: _ none
v6: _ add reviewed-by Simon Glass
v5: _ remove CONFIG_USB_OHCI_STI and CONFIG_USB_EHCI_STI
_ enable CONFIG_USB_EHCI_GENERIC and CONFIG_USB_OHCI_GENERIC
v4: _ enable CONFIG_PHY and CONFIG_STI_USB_PHY
v3: _ none
v2: _ none
configs/stih410-b2260_defconfig | 39 +++++++++++++++++++++++++++++++++++----
1 file changed, 35 insertions(+), 4 deletions(-)
diff --git a/configs/stih410-b2260_defconfig b/configs/stih410-b2260_defconfig
index 4e6942f..0107c4f 100644
--- a/configs/stih410-b2260_defconfig
+++ b/configs/stih410-b2260_defconfig
@@ -2,25 +2,56 @@ CONFIG_ARM=y
CONFIG_ARCH_STI=y
CONFIG_IDENT_STRING="STMicroelectronics STiH410-B2260"
CONFIG_DEFAULT_DEVICE_TREE="stih410-b2260"
+CONFIG_DISTRO_DEFAULTS=y
CONFIG_FIT=y
CONFIG_FIT_VERBOSE=y
# CONFIG_DISPLAY_CPUINFO is not set
CONFIG_SYS_PROMPT="stih410-b2260 => "
+CONFIG_FASTBOOT=y
+CONFIG_USB_FUNCTION_FASTBOOT=y
+CONFIG_CMD_FASTBOOT=y
+CONFIG_ANDROID_BOOT_IMAGE=y
+CONFIG_FASTBOOT_BUF_ADDR=0x40000000
+CONFIG_FASTBOOT_BUF_SIZE=0x3DF00000
+CONFIG_FASTBOOT_FLASH=y
+CONFIG_FASTBOOT_FLASH_MMC_DEV=0
# CONFIG_CMD_IMLS is not set
+CONFIG_CMD_GPT=y
CONFIG_CMD_MMC=y
+CONFIG_CMD_USB=y
CONFIG_CMD_TIME=y
CONFIG_CMD_TIMER=y
-CONFIG_CMD_EXT2=y
-CONFIG_CMD_EXT4=y
-CONFIG_CMD_FAT=y
-CONFIG_CMD_FS_GENERIC=y
+CONFIG_CMD_EXT4_WRITE=y
+# CONFIG_ISO_PARTITION is not set
CONFIG_OF_CONTROL=y
CONFIG_REGMAP=y
CONFIG_SYSCON=y
+CONFIG_CLK=y
+CONFIG_MISC=y
CONFIG_MMC_SDHCI=y
CONFIG_MMC_SDHCI_STI=y
+CONFIG_PHY=y
+CONFIG_STI_USB_PHY=y
CONFIG_PINCTRL=y
+CONFIG_STI_RESET=y
CONFIG_STI_ASC_SERIAL=y
CONFIG_SYSRESET=y
CONFIG_TIMER=y
+CONFIG_USB=y
+CONFIG_DM_USB=y
+CONFIG_USB_XHCI_HCD=y
+CONFIG_USB_XHCI_DWC3=y
+CONFIG_USB_EHCI_HCD=y
+CONFIG_USB_EHCI_GENERIC=y
+CONFIG_USB_OHCI_HCD=y
+CONFIG_USB_OHCI_GENERIC=y
+CONFIG_USB_DWC3=y
+CONFIG_USB_DWC3_GADGET=y
+CONFIG_USB_STORAGE=y
+CONFIG_USB_GADGET=y
+CONFIG_USB_GADGET_DOWNLOAD=y
+CONFIG_G_DNL_MANUFACTURER="STMicroelectronics"
+CONFIG_G_DNL_VENDOR_NUM=0x483
+CONFIG_G_DNL_PRODUCT_NUM=0x7270
+CONFIG_OF_LIBFDT_OVERLAY=y
CONFIG_SPL_OF_LIBFDT=y
--
1.9.1
^ permalink raw reply related [flat|nested] 22+ messages in thread
* [U-Boot] [PATCH v7 07/10] usb: dwc3: Add dwc3 glue driver support for STi
2017-06-01 12:05 [U-Boot] [PATCH v7 00/10] STiH410-B2260: add reset, usb and fastboot support patrice.chotard at st.com
` (5 preceding siblings ...)
2017-06-01 12:05 ` [U-Boot] [PATCH v7 06/10] STiH410-B2260: enable USB, fastboot, reset, PHY related flags patrice.chotard at st.com
@ 2017-06-01 12:05 ` patrice.chotard at st.com
2017-06-03 6:06 ` Marek Vasut
2017-06-01 12:05 ` [U-Boot] [PATCH v7 08/10] ARM: dts: STiH410: set DWC3 dual role mode to peripheral patrice.chotard at st.com
` (2 subsequent siblings)
9 siblings, 1 reply; 22+ messages in thread
From: patrice.chotard at st.com @ 2017-06-01 12:05 UTC (permalink / raw)
To: u-boot
From: Patrice Chotard <patrice.chotard@st.com>
This patch adds the ST glue logic to manage the DWC3 HC
on STiH407 SoC family. It configures the internal glue
logic and syscfg registers.
Part of this code been extracted from kernel.org driver
(drivers/usb/dwc3/dwc3-st.c)
Signed-off-by: Patrice Chotard <patrice.chotard@st.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
---
v7: _ none
v6: _ add reviewed-by Simon Glass
_ put #define <common.h> first
v5: _ none
v4: _ none
v3: _ rename dwc3-sti.c to dwc3-sti-glue.c
_ respect device tree hierarchy, this driver is now responsible
for xhci-sti binding (done in sti_dwc3_glue_bind())
v2: _ use setbits_le32() instead of read, modify, write sequence
_ add missing parenthesis
arch/arm/include/asm/arch-stih410/sys_proto.h | 11 ++
doc/device-tree-bindings/usb/dwc3-st.txt | 60 ++++++
drivers/usb/host/Kconfig | 9 +
drivers/usb/host/Makefile | 1 +
drivers/usb/host/dwc3-sti-glue.c | 256 ++++++++++++++++++++++++++
include/dwc3-sti-glue.h | 43 +++++
6 files changed, 380 insertions(+)
create mode 100644 arch/arm/include/asm/arch-stih410/sys_proto.h
create mode 100644 doc/device-tree-bindings/usb/dwc3-st.txt
create mode 100644 drivers/usb/host/dwc3-sti-glue.c
create mode 100644 include/dwc3-sti-glue.h
diff --git a/arch/arm/include/asm/arch-stih410/sys_proto.h b/arch/arm/include/asm/arch-stih410/sys_proto.h
new file mode 100644
index 0000000..5c40d3b
--- /dev/null
+++ b/arch/arm/include/asm/arch-stih410/sys_proto.h
@@ -0,0 +1,11 @@
+/*
+ * Copyright (c) 2017
+ * Patrice Chotard <patrice.chotard@st.com>
+ *
+ * SPDX-License-Identifier: GPL-2.0+
+ */
+
+#ifndef _ASM_ARCH_SYS_PROTO_H
+#define _ASM_ARCH_SYS_PROTO_H
+
+#endif /* _ASM_ARCH_SYS_PROTO_H */
diff --git a/doc/device-tree-bindings/usb/dwc3-st.txt b/doc/device-tree-bindings/usb/dwc3-st.txt
new file mode 100644
index 0000000..a26a139
--- /dev/null
+++ b/doc/device-tree-bindings/usb/dwc3-st.txt
@@ -0,0 +1,60 @@
+ST DWC3 glue logic
+
+This file documents the parameters for the dwc3-st driver.
+This driver controls the glue logic used to configure the dwc3 core on
+STiH407 based platforms.
+
+Required properties:
+ - compatible : must be "st,stih407-dwc3"
+ - reg : glue logic base address and USB syscfg ctrl register offset
+ - reg-names : should be "reg-glue" and "syscfg-reg"
+ - st,syscon : should be phandle to system configuration node which
+ encompasses the glue registers
+ - resets : list of phandle and reset specifier pairs. There should be two entries, one
+ for the powerdown and softreset lines of the usb3 IP
+ - reset-names : list of reset signal names. Names should be "powerdown" and "softreset"
+
+ - #address-cells, #size-cells : should be '1' if the device has sub-nodes
+ with 'reg' property
+
+ - pinctl-names : A pinctrl state named "default" must be defined
+
+ - pinctrl-0 : Pin control group
+
+ - ranges : allows valid 1:1 translation between child's address space and
+ parent's address space
+
+Sub-nodes:
+The dwc3 core should be added as subnode to ST DWC3 glue as shown in the
+example below.
+
+NB: The dr_mode property is NOT optional for this driver, as the default value
+is "otg", which isn't supported by this SoC. Valid dr_mode values for dwc3-st are
+either "host" or "device".
+
+Example:
+
+st_dwc3: dwc3 at 8f94000 {
+ status = "disabled";
+ compatible = "st,stih407-dwc3";
+ reg = <0x08f94000 0x1000>, <0x110 0x4>;
+ reg-names = "reg-glue", "syscfg-reg";
+ st,syscfg = <&syscfg_core>;
+ resets = <&powerdown STIH407_USB3_POWERDOWN>,
+ <&softreset STIH407_MIPHY2_SOFTRESET>;
+ reset-names = "powerdown", "softreset";
+ #address-cells = <1>;
+ #size-cells = <1>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_usb3>;
+ ranges;
+
+ dwc3: dwc3 at 9900000 {
+ compatible = "snps,dwc3";
+ reg = <0x09900000 0x100000>;
+ interrupts = <GIC_SPI 155 IRQ_TYPE_NONE>;
+ dr_mode = "host";
+ phy-names = "usb2-phy", "usb3-phy";
+ phys = <&usb2_picophy2>, <&phy_port2 PHY_TYPE_USB3>;
+ };
+};
diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
index b824eec..80589cf 100644
--- a/drivers/usb/host/Kconfig
+++ b/drivers/usb/host/Kconfig
@@ -38,6 +38,15 @@ config USB_XHCI_ROCKCHIP
help
Enables support for the on-chip xHCI controller on Rockchip SoCs.
+config USB_XHCI_STI
+ bool "Support for STMicroelectronics STiH407 family on-chip xHCI USB controller"
+ depends on ARCH_STI
+ default y
+ help
+ Enables support for the on-chip xHCI controller on STMicroelectronics
+ STiH407 family SoCs. This is a driver for the dwc3 to provide the glue logic
+ to configure the controller.
+
config USB_XHCI_ZYNQMP
bool "Support for Xilinx ZynqMP on-chip xHCI USB controller"
depends on ARCH_ZYNQMP
diff --git a/drivers/usb/host/Makefile b/drivers/usb/host/Makefile
index 4ece0a2..1bf66fa 100644
--- a/drivers/usb/host/Makefile
+++ b/drivers/usb/host/Makefile
@@ -65,6 +65,7 @@ obj-$(CONFIG_USB_XHCI_FSL) += xhci-fsl.o
obj-$(CONFIG_USB_XHCI_MVEBU) += xhci-mvebu.o
obj-$(CONFIG_USB_XHCI_OMAP) += xhci-omap.o
obj-$(CONFIG_USB_XHCI_PCI) += xhci-pci.o
+obj-$(CONFIG_USB_XHCI_STI) += dwc3-sti-glue.o
# designware
obj-$(CONFIG_USB_DWC2) += dwc2.o
diff --git a/drivers/usb/host/dwc3-sti-glue.c b/drivers/usb/host/dwc3-sti-glue.c
new file mode 100644
index 0000000..1c593fe
--- /dev/null
+++ b/drivers/usb/host/dwc3-sti-glue.c
@@ -0,0 +1,256 @@
+/*
+ * STiH407 family DWC3 specific Glue layer
+ *
+ * Copyright (c) 2017
+ * Patrice Chotard <patrice.chotard@st.com>
+ *
+ * SPDX-License-Identifier: GPL-2.0+
+ */
+
+#include <common.h>
+#include <asm/io.h>
+#include <dm.h>
+#include <dwc3-sti-glue.h>
+#include <errno.h>
+#include <fdtdec.h>
+#include <libfdt.h>
+#include <dm/lists.h>
+#include <regmap.h>
+#include <reset-uclass.h>
+#include <syscon.h>
+#include <usb.h>
+
+#include <linux/usb/dwc3.h>
+
+DECLARE_GLOBAL_DATA_PTR;
+
+/*
+ * struct sti_dwc3_glue_platdata - dwc3 STi glue driver private structure
+ * @syscfg_base: addr for the glue syscfg
+ * @glue_base: addr for the glue registers
+ * @syscfg_offset: usb syscfg control offset
+ * @powerdown_ctl: rest controller for powerdown signal
+ * @softreset_ctl: reset controller for softreset signal
+ * @mode: drd static host/device config
+ */
+struct sti_dwc3_glue_platdata {
+ phys_addr_t syscfg_base;
+ phys_addr_t glue_base;
+ phys_addr_t syscfg_offset;
+ struct reset_ctl powerdown_ctl;
+ struct reset_ctl softreset_ctl;
+ enum usb_dr_mode mode;
+};
+
+static int sti_dwc3_glue_drd_init(struct sti_dwc3_glue_platdata *plat)
+{
+ unsigned long val;
+
+ val = readl(plat->syscfg_base + plat->syscfg_offset);
+
+ val &= USB3_CONTROL_MASK;
+
+ switch (plat->mode) {
+ case USB_DR_MODE_PERIPHERAL:
+ val &= ~(USB3_DELAY_VBUSVALID
+ | USB3_SEL_FORCE_OPMODE | USB3_FORCE_OPMODE(0x3)
+ | USB3_SEL_FORCE_DPPULLDOWN2 | USB3_FORCE_DPPULLDOWN2
+ | USB3_SEL_FORCE_DMPULLDOWN2 | USB3_FORCE_DMPULLDOWN2);
+
+ val |= USB3_DEVICE_NOT_HOST | USB3_FORCE_VBUSVALID;
+ break;
+
+ case USB_DR_MODE_HOST:
+ val &= ~(USB3_DEVICE_NOT_HOST | USB3_FORCE_VBUSVALID
+ | USB3_SEL_FORCE_OPMODE | USB3_FORCE_OPMODE(0x3)
+ | USB3_SEL_FORCE_DPPULLDOWN2 | USB3_FORCE_DPPULLDOWN2
+ | USB3_SEL_FORCE_DMPULLDOWN2 | USB3_FORCE_DMPULLDOWN2);
+
+ val |= USB3_DELAY_VBUSVALID;
+ break;
+
+ default:
+ error("Unsupported mode of operation %d\n", plat->mode);
+ return -EINVAL;
+ }
+ writel(val, plat->syscfg_base + plat->syscfg_offset);
+
+ return 0;
+}
+
+static void sti_dwc3_glue_init(struct sti_dwc3_glue_platdata *plat)
+{
+ unsigned long reg;
+
+ reg = readl(plat->glue_base + CLKRST_CTRL);
+
+ reg |= AUX_CLK_EN | EXT_CFG_RESET_N | XHCI_REVISION;
+ reg &= ~SW_PIPEW_RESET_N;
+
+ writel(reg, plat->glue_base + CLKRST_CTRL);
+
+ /* configure mux for vbus, powerpresent and bvalid signals */
+ reg = readl(plat->glue_base + USB2_VBUS_MNGMNT_SEL1);
+
+ reg |= SEL_OVERRIDE_VBUSVALID(USB2_VBUS_UTMIOTG) |
+ SEL_OVERRIDE_POWERPRESENT(USB2_VBUS_UTMIOTG) |
+ SEL_OVERRIDE_BVALID(USB2_VBUS_UTMIOTG);
+
+ writel(reg, plat->glue_base + USB2_VBUS_MNGMNT_SEL1);
+
+ setbits_le32(plat->glue_base + CLKRST_CTRL, SW_PIPEW_RESET_N);
+}
+
+static int sti_dwc3_glue_ofdata_to_platdata(struct udevice *dev)
+{
+ struct sti_dwc3_glue_platdata *plat = dev_get_platdata(dev);
+ struct udevice *syscon;
+ struct regmap *regmap;
+ int ret;
+ u32 reg[4];
+
+ ret = fdtdec_get_int_array(gd->fdt_blob, dev_of_offset(dev),
+ "reg", reg, ARRAY_SIZE(reg));
+ if (ret) {
+ error("unable to find st,stih407-dwc3 reg property(%d)\n", ret);
+ return ret;
+ }
+
+ plat->glue_base = reg[0];
+ plat->syscfg_offset = reg[2];
+
+ /* get corresponding syscon phandle */
+ ret = uclass_get_device_by_phandle(UCLASS_SYSCON, dev, "st,syscfg",
+ &syscon);
+ if (ret) {
+ error("unable to find syscon device (%d)\n", ret);
+ return ret;
+ }
+
+ /* get syscfg-reg base address */
+ regmap = syscon_get_regmap(syscon);
+ if (!regmap) {
+ error("unable to find regmap\n");
+ return -ENODEV;
+ }
+ plat->syscfg_base = regmap->base;
+
+ /* get powerdown reset */
+ ret = reset_get_by_name(dev, "powerdown", &plat->powerdown_ctl);
+ if (ret) {
+ error("can't get powerdown reset for %s (%d)", dev->name, ret);
+ return ret;
+ }
+
+ /* get softreset reset */
+ ret = reset_get_by_name(dev, "softreset", &plat->softreset_ctl);
+ if (ret)
+ error("can't get soft reset for %s (%d)", dev->name, ret);
+
+ return ret;
+};
+
+static int sti_dwc3_glue_bind(struct udevice *dev)
+{
+ struct sti_dwc3_glue_platdata *plat = dev_get_platdata(dev);
+ int dwc3_node;
+
+ /* check if one subnode is present */
+ dwc3_node = fdt_first_subnode(gd->fdt_blob, dev_of_offset(dev));
+ if (dwc3_node <= 0) {
+ error("Can't find subnode for %s\n", dev->name);
+ return -ENODEV;
+ }
+
+ /* check if the subnode compatible string is the dwc3 one*/
+ if (fdt_node_check_compatible(gd->fdt_blob, dwc3_node,
+ "snps,dwc3") != 0) {
+ error("Can't find dwc3 subnode for %s\n", dev->name);
+ return -ENODEV;
+ }
+
+ /* retrieve the DWC3 dual role mode */
+ plat->mode = usb_get_dr_mode(dwc3_node);
+ if (plat->mode == USB_DR_MODE_UNKNOWN)
+ /* by default set dual role mode to HOST */
+ plat->mode = USB_DR_MODE_HOST;
+
+ return dm_scan_fdt_dev(dev);
+}
+
+static int sti_dwc3_glue_probe(struct udevice *dev)
+{
+ struct sti_dwc3_glue_platdata *plat = dev_get_platdata(dev);
+ int ret;
+
+ /* deassert both powerdown and softreset */
+ ret = reset_deassert(&plat->powerdown_ctl);
+ if (ret < 0) {
+ error("DWC3 powerdown reset deassert failed: %d", ret);
+ return ret;
+ }
+
+ ret = reset_deassert(&plat->softreset_ctl);
+ if (ret < 0) {
+ error("DWC3 soft reset deassert failed: %d", ret);
+ goto err1;
+ }
+
+ ret = sti_dwc3_glue_drd_init(plat);
+ if (ret)
+ goto err2;
+
+ sti_dwc3_glue_init(plat);
+
+ return 0;
+
+err2:
+ ret = reset_assert(&plat->softreset_ctl);
+ if (ret < 0) {
+ error("DWC3 soft reset deassert failed: %d", ret);
+ return ret;
+ }
+
+err1:
+ ret = reset_assert(&plat->powerdown_ctl);
+ if (ret < 0)
+ error("DWC3 powerdown reset deassert failed: %d", ret);
+
+ return ret;
+}
+
+static int sti_dwc3_glue_remove(struct udevice *dev)
+{
+ struct sti_dwc3_glue_platdata *plat = dev_get_platdata(dev);
+ int ret;
+
+ /* assert both powerdown and softreset */
+ ret = reset_assert(&plat->powerdown_ctl);
+ if (ret < 0) {
+ error("DWC3 powerdown reset deassert failed: %d", ret);
+ return ret;
+ }
+
+ ret = reset_assert(&plat->softreset_ctl);
+ if (ret < 0)
+ error("DWC3 soft reset deassert failed: %d", ret);
+
+ return ret;
+}
+
+static const struct udevice_id sti_dwc3_glue_ids[] = {
+ { .compatible = "st,stih407-dwc3" },
+ { }
+};
+
+U_BOOT_DRIVER(dwc3_sti_glue) = {
+ .name = "dwc3_sti_glue",
+ .id = UCLASS_MISC,
+ .of_match = sti_dwc3_glue_ids,
+ .ofdata_to_platdata = sti_dwc3_glue_ofdata_to_platdata,
+ .probe = sti_dwc3_glue_probe,
+ .remove = sti_dwc3_glue_remove,
+ .bind = sti_dwc3_glue_bind,
+ .platdata_auto_alloc_size = sizeof(struct sti_dwc3_glue_platdata),
+ .flags = DM_FLAG_ALLOC_PRIV_DMA,
+};
diff --git a/include/dwc3-sti-glue.h b/include/dwc3-sti-glue.h
new file mode 100644
index 0000000..2083427
--- /dev/null
+++ b/include/dwc3-sti-glue.h
@@ -0,0 +1,43 @@
+/*
+ * Copyright (c) 2017
+ * Patrice Chotard <patrice.chotard@st.com>
+ *
+ * SPDX-License-Identifier: GPL-2.0+
+ */
+
+#ifndef __DWC3_STI_UBOOT_H_
+#define __DWC3_STI_UBOOT_H_
+
+#include <linux/usb/otg.h>
+
+/* glue registers */
+#define CLKRST_CTRL 0x00
+#define AUX_CLK_EN BIT(0)
+#define SW_PIPEW_RESET_N BIT(4)
+#define EXT_CFG_RESET_N BIT(8)
+
+#define XHCI_REVISION BIT(12)
+
+#define USB2_VBUS_MNGMNT_SEL1 0x2C
+#define USB2_VBUS_UTMIOTG 0x1
+
+#define SEL_OVERRIDE_VBUSVALID(n) ((n) << 0)
+#define SEL_OVERRIDE_POWERPRESENT(n) ((n) << 4)
+#define SEL_OVERRIDE_BVALID(n) ((n) << 8)
+
+/* Static DRD configuration */
+#define USB3_CONTROL_MASK 0xf77
+
+#define USB3_DEVICE_NOT_HOST BIT(0)
+#define USB3_FORCE_VBUSVALID BIT(1)
+#define USB3_DELAY_VBUSVALID BIT(2)
+#define USB3_SEL_FORCE_OPMODE BIT(4)
+#define USB3_FORCE_OPMODE(n) ((n) << 5)
+#define USB3_SEL_FORCE_DPPULLDOWN2 BIT(8)
+#define USB3_FORCE_DPPULLDOWN2 BIT(9)
+#define USB3_SEL_FORCE_DMPULLDOWN2 BIT(10)
+#define USB3_FORCE_DMPULLDOWN2 BIT(11)
+
+int sti_dwc3_init(enum usb_dr_mode mode);
+
+#endif /* __DWC3_STI_UBOOT_H_ */
--
1.9.1
^ permalink raw reply related [flat|nested] 22+ messages in thread
* [U-Boot] [PATCH v7 08/10] ARM: dts: STiH410: set DWC3 dual role mode to peripheral
2017-06-01 12:05 [U-Boot] [PATCH v7 00/10] STiH410-B2260: add reset, usb and fastboot support patrice.chotard at st.com
` (6 preceding siblings ...)
2017-06-01 12:05 ` [U-Boot] [PATCH v7 07/10] usb: dwc3: Add dwc3 glue driver support for STi patrice.chotard at st.com
@ 2017-06-01 12:05 ` patrice.chotard at st.com
2017-06-02 2:56 ` Simon Glass
2017-06-01 12:05 ` [U-Boot] [PATCH v7 09/10] ARM: dts: STiH410: update ehci and ohci compatible patrice.chotard at st.com
2017-06-01 12:05 ` [U-Boot] [PATCH v7 10/10] board: STiH410-B2260: add fastboot support patrice.chotard at st.com
9 siblings, 1 reply; 22+ messages in thread
From: patrice.chotard at st.com @ 2017-06-01 12:05 UTC (permalink / raw)
To: u-boot
From: Patrice Chotard <patrice.chotard@st.com>
On STi 96boards, configure by default the micro USB connector
(managed by DWC3 hardware block) in peripheral mode.
This will allow to use fastboot feature.
Signed-off-by: Patrice Chotard <patrice.chotard@st.com>
---
v7: _ none
arch/arm/dts/stih407-family.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/dts/stih407-family.dtsi b/arch/arm/dts/stih407-family.dtsi
index 452ac1c..6c6de58 100644
--- a/arch/arm/dts/stih407-family.dtsi
+++ b/arch/arm/dts/stih407-family.dtsi
@@ -655,7 +655,7 @@
compatible = "snps,dwc3";
reg = <0x09900000 0x100000>;
interrupts = <GIC_SPI 155 IRQ_TYPE_NONE>;
- dr_mode = "host";
+ dr_mode = "peripheral";
phy-names = "usb2-phy", "usb3-phy";
phys = <&usb2_picophy0>,
<&phy_port2 PHY_TYPE_USB3>;
--
1.9.1
^ permalink raw reply related [flat|nested] 22+ messages in thread
* [U-Boot] [PATCH v7 09/10] ARM: dts: STiH410: update ehci and ohci compatible
2017-06-01 12:05 [U-Boot] [PATCH v7 00/10] STiH410-B2260: add reset, usb and fastboot support patrice.chotard at st.com
` (7 preceding siblings ...)
2017-06-01 12:05 ` [U-Boot] [PATCH v7 08/10] ARM: dts: STiH410: set DWC3 dual role mode to peripheral patrice.chotard at st.com
@ 2017-06-01 12:05 ` patrice.chotard at st.com
2017-06-02 2:56 ` Simon Glass
2017-06-01 12:05 ` [U-Boot] [PATCH v7 10/10] board: STiH410-B2260: add fastboot support patrice.chotard at st.com
9 siblings, 1 reply; 22+ messages in thread
From: patrice.chotard at st.com @ 2017-06-01 12:05 UTC (permalink / raw)
To: u-boot
From: Patrice Chotard <patrice.chotard@st.com>
Update ehci and ohci node's compatible string in order to
use ehci-generic and ohci-generic drivers.
Signed-off-by: Patrice Chotard <patrice.chotard@st.com>
---
v7: _ none
arch/arm/dts/stih410.dtsi | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/arch/arm/dts/stih410.dtsi b/arch/arm/dts/stih410.dtsi
index f118a9e..b59b110 100644
--- a/arch/arm/dts/stih410.dtsi
+++ b/arch/arm/dts/stih410.dtsi
@@ -83,7 +83,7 @@
};
ohci0: usb at 9a03c00 {
- compatible = "st,st-ohci-300x";
+ compatible = "generic-ohci";
reg = <0x9a03c00 0x100>;
interrupts = <GIC_SPI 180 IRQ_TYPE_NONE>;
clocks = <&clk_s_c0_flexgen CLK_TX_ICN_DISP_0>,
@@ -91,6 +91,7 @@
resets = <&powerdown STIH407_USB2_PORT0_POWERDOWN>,
<&softreset STIH407_USB2_PORT0_SOFTRESET>;
reset-names = "power", "softreset";
+
phys = <&usb2_picophy1>;
phy-names = "usb";
@@ -98,7 +99,7 @@
};
ehci0: usb at 9a03e00 {
- compatible = "st,st-ehci-300x";
+ compatible = "generic-ehci";
reg = <0x9a03e00 0x100>;
interrupts = <GIC_SPI 151 IRQ_TYPE_NONE>;
pinctrl-names = "default";
@@ -115,7 +116,7 @@
};
ohci1: usb at 9a83c00 {
- compatible = "st,st-ohci-300x";
+ compatible = "generic-ohci";
reg = <0x9a83c00 0x100>;
interrupts = <GIC_SPI 181 IRQ_TYPE_NONE>;
clocks = <&clk_s_c0_flexgen CLK_TX_ICN_DISP_0>,
@@ -123,6 +124,7 @@
resets = <&powerdown STIH407_USB2_PORT1_POWERDOWN>,
<&softreset STIH407_USB2_PORT1_SOFTRESET>;
reset-names = "power", "softreset";
+
phys = <&usb2_picophy2>;
phy-names = "usb";
@@ -130,7 +132,7 @@
};
ehci1: usb at 9a83e00 {
- compatible = "st,st-ehci-300x";
+ compatible = "generic-ehci";
reg = <0x9a83e00 0x100>;
interrupts = <GIC_SPI 153 IRQ_TYPE_NONE>;
pinctrl-names = "default";
@@ -140,6 +142,7 @@
resets = <&powerdown STIH407_USB2_PORT1_POWERDOWN>,
<&softreset STIH407_USB2_PORT1_SOFTRESET>;
reset-names = "power", "softreset";
+
phys = <&usb2_picophy2>;
phy-names = "usb";
--
1.9.1
^ permalink raw reply related [flat|nested] 22+ messages in thread
* [U-Boot] [PATCH v7 10/10] board: STiH410-B2260: add fastboot support
2017-06-01 12:05 [U-Boot] [PATCH v7 00/10] STiH410-B2260: add reset, usb and fastboot support patrice.chotard at st.com
` (8 preceding siblings ...)
2017-06-01 12:05 ` [U-Boot] [PATCH v7 09/10] ARM: dts: STiH410: update ehci and ohci compatible patrice.chotard at st.com
@ 2017-06-01 12:05 ` patrice.chotard at st.com
9 siblings, 0 replies; 22+ messages in thread
From: patrice.chotard at st.com @ 2017-06-01 12:05 UTC (permalink / raw)
To: u-boot
From: Patrice Chotard <patrice.chotard@st.com>
Add usb_gadget_handle_interrupts(), board_usb_init(),
board_usb_cleanup() and g_dnl_board_usb_cable_connected()
callbacks needed for FASTBOOT support
Signed-off-by: Patrice Chotard <patrice.chotard@st.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
---
v7: _ none
v6: _ add reviewed-by Simon Glass
v5: _ none
v4: _ none
v3: _ none
v2: _ none
board/st/stih410-b2260/board.c | 41 +++++++++++++++++++++++++++++++++++++++++
1 file changed, 41 insertions(+)
diff --git a/board/st/stih410-b2260/board.c b/board/st/stih410-b2260/board.c
index 92b0695..e097fa1 100644
--- a/board/st/stih410-b2260/board.c
+++ b/board/st/stih410-b2260/board.c
@@ -7,6 +7,9 @@
*/
#include <common.h>
+#include <dwc3-sti-glue.h>
+#include <dwc3-uboot.h>
+#include <usb.h>
DECLARE_GLOBAL_DATA_PTR;
@@ -36,3 +39,41 @@ int board_init(void)
{
return 0;
}
+
+#ifdef CONFIG_USB_DWC3
+static struct dwc3_device dwc3_device_data = {
+ .maximum_speed = USB_SPEED_HIGH,
+ .dr_mode = USB_DR_MODE_PERIPHERAL,
+ .index = 0,
+};
+
+int usb_gadget_handle_interrupts(int index)
+{
+ dwc3_uboot_handle_interrupt(index);
+ return 0;
+}
+
+int board_usb_init(int index, enum usb_init_type init)
+{
+ int node;
+ const void *blob = gd->fdt_blob;
+
+ /* find the snps,dwc3 node */
+ node = fdt_node_offset_by_compatible(blob, -1, "snps,dwc3");
+
+ dwc3_device_data.base = fdtdec_get_addr(blob, node, "reg");
+
+ return dwc3_uboot_init(&dwc3_device_data);
+}
+
+int board_usb_cleanup(int index, enum usb_init_type init)
+{
+ dwc3_uboot_exit(index);
+ return 0;
+}
+
+int g_dnl_board_usb_cable_connected(void)
+{
+ return 1;
+}
+#endif
--
1.9.1
^ permalink raw reply related [flat|nested] 22+ messages in thread
* [U-Boot] [PATCH v7 04/10] usb: phy: Add STi USB2 PHY
2017-06-01 12:05 ` [U-Boot] [PATCH v7 04/10] usb: phy: Add STi USB2 PHY patrice.chotard at st.com
@ 2017-06-02 2:56 ` Simon Glass
2017-06-03 6:08 ` Marek Vasut
1 sibling, 0 replies; 22+ messages in thread
From: Simon Glass @ 2017-06-02 2:56 UTC (permalink / raw)
To: u-boot
On 1 June 2017 at 06:05, <patrice.chotard@st.com> wrote:
> From: Patrice Chotard <patrice.chotard@st.com>
>
> This is the generic phy driver for the picoPHY ports
> used by USB2/1.1 controllers. It is found on STiH407 SoC
> family from STMicroelectronics.
>
> Signed-off-by: Patrice Chotard <patrice.chotard@st.com>
> Reviewed-by: Marek Vasut <marex@denx.de>
> ---
> v7: _ replace fdtdec_parse_phandle_with_args() by dev_read_phandle_with_args()
> _ replace uclass_get_device_by_of_offset() by uclass_get_device_by_ofnode()
>
> v6: _ none
>
> v5: _ add Reviewed-by: Marek Vasut <marex@denx.de>
>
> v4: _ update to use the new PHY uclass currently available on dm-next branch
>
> v3: _ convert driver to USB PHY uclass
>
> v2: _ replace bitfield_replace() by clrsetbits_le32()
>
> doc/device-tree-bindings/phy/phy-stih407-usb.txt | 24 +++
> drivers/phy/Kconfig | 8 +
> drivers/phy/Makefile | 1 +
> drivers/phy/sti_usb_phy.c | 181 +++++++++++++++++++++++
> 4 files changed, 214 insertions(+)
> create mode 100644 doc/device-tree-bindings/phy/phy-stih407-usb.txt
> create mode 100644 drivers/phy/sti_usb_phy.c
>
Reviewed-by: Simon Glass <sjg@chromium.org>
^ permalink raw reply [flat|nested] 22+ messages in thread
* [U-Boot] [PATCH v7 08/10] ARM: dts: STiH410: set DWC3 dual role mode to peripheral
2017-06-01 12:05 ` [U-Boot] [PATCH v7 08/10] ARM: dts: STiH410: set DWC3 dual role mode to peripheral patrice.chotard at st.com
@ 2017-06-02 2:56 ` Simon Glass
0 siblings, 0 replies; 22+ messages in thread
From: Simon Glass @ 2017-06-02 2:56 UTC (permalink / raw)
To: u-boot
On 1 June 2017 at 06:05, <patrice.chotard@st.com> wrote:
> From: Patrice Chotard <patrice.chotard@st.com>
>
> On STi 96boards, configure by default the micro USB connector
> (managed by DWC3 hardware block) in peripheral mode.
> This will allow to use fastboot feature.
>
> Signed-off-by: Patrice Chotard <patrice.chotard@st.com>
> ---
>
> v7: _ none
>
> arch/arm/dts/stih407-family.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Simon Glass <sjg@chromium.org>
^ permalink raw reply [flat|nested] 22+ messages in thread
* [U-Boot] [PATCH v7 09/10] ARM: dts: STiH410: update ehci and ohci compatible
2017-06-01 12:05 ` [U-Boot] [PATCH v7 09/10] ARM: dts: STiH410: update ehci and ohci compatible patrice.chotard at st.com
@ 2017-06-02 2:56 ` Simon Glass
0 siblings, 0 replies; 22+ messages in thread
From: Simon Glass @ 2017-06-02 2:56 UTC (permalink / raw)
To: u-boot
On 1 June 2017 at 06:05, <patrice.chotard@st.com> wrote:
> From: Patrice Chotard <patrice.chotard@st.com>
>
> Update ehci and ohci node's compatible string in order to
> use ehci-generic and ohci-generic drivers.
>
> Signed-off-by: Patrice Chotard <patrice.chotard@st.com>
> ---
> v7: _ none
>
> arch/arm/dts/stih410.dtsi | 11 +++++++----
> 1 file changed, 7 insertions(+), 4 deletions(-)
>
Reviewed-by: Simon Glass <sjg@chromium.org>
^ permalink raw reply [flat|nested] 22+ messages in thread
* [U-Boot] [PATCH v7 07/10] usb: dwc3: Add dwc3 glue driver support for STi
2017-06-01 12:05 ` [U-Boot] [PATCH v7 07/10] usb: dwc3: Add dwc3 glue driver support for STi patrice.chotard at st.com
@ 2017-06-03 6:06 ` Marek Vasut
2017-06-05 6:40 ` Patrice CHOTARD
0 siblings, 1 reply; 22+ messages in thread
From: Marek Vasut @ 2017-06-03 6:06 UTC (permalink / raw)
To: u-boot
On 06/01/2017 02:05 PM, patrice.chotard at st.com wrote:
> From: Patrice Chotard <patrice.chotard@st.com>
>
> This patch adds the ST glue logic to manage the DWC3 HC
> on STiH407 SoC family. It configures the internal glue
> logic and syscfg registers.
>
> Part of this code been extracted from kernel.org driver
> (drivers/usb/dwc3/dwc3-st.c)
>
> Signed-off-by: Patrice Chotard <patrice.chotard@st.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>
> ---
>
> v7: _ none
>
> v6: _ add reviewed-by Simon Glass
> _ put #define <common.h> first
>
> v5: _ none
>
> v4: _ none
>
> v3: _ rename dwc3-sti.c to dwc3-sti-glue.c
> _ respect device tree hierarchy, this driver is now responsible
> for xhci-sti binding (done in sti_dwc3_glue_bind())
>
> v2: _ use setbits_le32() instead of read, modify, write sequence
> _ add missing parenthesis
>
> arch/arm/include/asm/arch-stih410/sys_proto.h | 11 ++
> doc/device-tree-bindings/usb/dwc3-st.txt | 60 ++++++
> drivers/usb/host/Kconfig | 9 +
> drivers/usb/host/Makefile | 1 +
> drivers/usb/host/dwc3-sti-glue.c | 256 ++++++++++++++++++++++++++
> include/dwc3-sti-glue.h | 43 +++++
> 6 files changed, 380 insertions(+)
> create mode 100644 arch/arm/include/asm/arch-stih410/sys_proto.h
> create mode 100644 doc/device-tree-bindings/usb/dwc3-st.txt
> create mode 100644 drivers/usb/host/dwc3-sti-glue.c
> create mode 100644 include/dwc3-sti-glue.h
>
> diff --git a/arch/arm/include/asm/arch-stih410/sys_proto.h b/arch/arm/include/asm/arch-stih410/sys_proto.h
> new file mode 100644
> index 0000000..5c40d3b
> --- /dev/null
> +++ b/arch/arm/include/asm/arch-stih410/sys_proto.h
> @@ -0,0 +1,11 @@
> +/*
> + * Copyright (c) 2017
> + * Patrice Chotard <patrice.chotard@st.com>
> + *
> + * SPDX-License-Identifier: GPL-2.0+
> + */
> +
> +#ifndef _ASM_ARCH_SYS_PROTO_H
> +#define _ASM_ARCH_SYS_PROTO_H
> +
> +#endif /* _ASM_ARCH_SYS_PROTO_H */
> diff --git a/doc/device-tree-bindings/usb/dwc3-st.txt b/doc/device-tree-bindings/usb/dwc3-st.txt
> new file mode 100644
> index 0000000..a26a139
> --- /dev/null
> +++ b/doc/device-tree-bindings/usb/dwc3-st.txt
> @@ -0,0 +1,60 @@
> +ST DWC3 glue logic
Is this DT binding imported from Linux ?
> +This file documents the parameters for the dwc3-st driver.
> +This driver controls the glue logic used to configure the dwc3 core on
> +STiH407 based platforms.
> +
> +Required properties:
> + - compatible : must be "st,stih407-dwc3"
> + - reg : glue logic base address and USB syscfg ctrl register offset
> + - reg-names : should be "reg-glue" and "syscfg-reg"
> + - st,syscon : should be phandle to system configuration node which
> + encompasses the glue registers
> + - resets : list of phandle and reset specifier pairs. There should be two entries, one
> + for the powerdown and softreset lines of the usb3 IP
> + - reset-names : list of reset signal names. Names should be "powerdown" and "softreset"
> +
> + - #address-cells, #size-cells : should be '1' if the device has sub-nodes
> + with 'reg' property
> +
> + - pinctl-names : A pinctrl state named "default" must be defined
> +
> + - pinctrl-0 : Pin control group
> +
> + - ranges : allows valid 1:1 translation between child's address space and
> + parent's address space
> +
> +Sub-nodes:
> +The dwc3 core should be added as subnode to ST DWC3 glue as shown in the
> +example below.
> +
> +NB: The dr_mode property is NOT optional for this driver, as the default value
> +is "otg", which isn't supported by this SoC. Valid dr_mode values for dwc3-st are
> +either "host" or "device".
> +
> +Example:
> +
> +st_dwc3: dwc3 at 8f94000 {
> + status = "disabled";
> + compatible = "st,stih407-dwc3";
> + reg = <0x08f94000 0x1000>, <0x110 0x4>;
> + reg-names = "reg-glue", "syscfg-reg";
> + st,syscfg = <&syscfg_core>;
> + resets = <&powerdown STIH407_USB3_POWERDOWN>,
> + <&softreset STIH407_MIPHY2_SOFTRESET>;
> + reset-names = "powerdown", "softreset";
> + #address-cells = <1>;
> + #size-cells = <1>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_usb3>;
> + ranges;
> +
> + dwc3: dwc3 at 9900000 {
> + compatible = "snps,dwc3";
> + reg = <0x09900000 0x100000>;
> + interrupts = <GIC_SPI 155 IRQ_TYPE_NONE>;
> + dr_mode = "host";
> + phy-names = "usb2-phy", "usb3-phy";
> + phys = <&usb2_picophy2>, <&phy_port2 PHY_TYPE_USB3>;
> + };
> +};
> diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
> index b824eec..80589cf 100644
> --- a/drivers/usb/host/Kconfig
> +++ b/drivers/usb/host/Kconfig
> @@ -38,6 +38,15 @@ config USB_XHCI_ROCKCHIP
> help
> Enables support for the on-chip xHCI controller on Rockchip SoCs.
>
> +config USB_XHCI_STI
> + bool "Support for STMicroelectronics STiH407 family on-chip xHCI USB controller"
> + depends on ARCH_STI
> + default y
> + help
> + Enables support for the on-chip xHCI controller on STMicroelectronics
> + STiH407 family SoCs. This is a driver for the dwc3 to provide the glue logic
> + to configure the controller.
> +
> config USB_XHCI_ZYNQMP
> bool "Support for Xilinx ZynqMP on-chip xHCI USB controller"
> depends on ARCH_ZYNQMP
> diff --git a/drivers/usb/host/Makefile b/drivers/usb/host/Makefile
> index 4ece0a2..1bf66fa 100644
> --- a/drivers/usb/host/Makefile
> +++ b/drivers/usb/host/Makefile
> @@ -65,6 +65,7 @@ obj-$(CONFIG_USB_XHCI_FSL) += xhci-fsl.o
> obj-$(CONFIG_USB_XHCI_MVEBU) += xhci-mvebu.o
> obj-$(CONFIG_USB_XHCI_OMAP) += xhci-omap.o
> obj-$(CONFIG_USB_XHCI_PCI) += xhci-pci.o
> +obj-$(CONFIG_USB_XHCI_STI) += dwc3-sti-glue.o
>
> # designware
> obj-$(CONFIG_USB_DWC2) += dwc2.o
> diff --git a/drivers/usb/host/dwc3-sti-glue.c b/drivers/usb/host/dwc3-sti-glue.c
> new file mode 100644
> index 0000000..1c593fe
> --- /dev/null
> +++ b/drivers/usb/host/dwc3-sti-glue.c
> @@ -0,0 +1,256 @@
> +/*
> + * STiH407 family DWC3 specific Glue layer
> + *
> + * Copyright (c) 2017
> + * Patrice Chotard <patrice.chotard@st.com>
> + *
> + * SPDX-License-Identifier: GPL-2.0+
> + */
> +
> +#include <common.h>
> +#include <asm/io.h>
> +#include <dm.h>
> +#include <dwc3-sti-glue.h>
> +#include <errno.h>
> +#include <fdtdec.h>
> +#include <libfdt.h>
> +#include <dm/lists.h>
> +#include <regmap.h>
> +#include <reset-uclass.h>
> +#include <syscon.h>
> +#include <usb.h>
> +
> +#include <linux/usb/dwc3.h>
> +
> +DECLARE_GLOBAL_DATA_PTR;
> +
> +/*
> + * struct sti_dwc3_glue_platdata - dwc3 STi glue driver private structure
> + * @syscfg_base: addr for the glue syscfg
> + * @glue_base: addr for the glue registers
> + * @syscfg_offset: usb syscfg control offset
> + * @powerdown_ctl: rest controller for powerdown signal
> + * @softreset_ctl: reset controller for softreset signal
> + * @mode: drd static host/device config
> + */
> +struct sti_dwc3_glue_platdata {
> + phys_addr_t syscfg_base;
> + phys_addr_t glue_base;
> + phys_addr_t syscfg_offset;
> + struct reset_ctl powerdown_ctl;
> + struct reset_ctl softreset_ctl;
> + enum usb_dr_mode mode;
> +};
> +
> +static int sti_dwc3_glue_drd_init(struct sti_dwc3_glue_platdata *plat)
> +{
> + unsigned long val;
> +
> + val = readl(plat->syscfg_base + plat->syscfg_offset);
> +
> + val &= USB3_CONTROL_MASK;
> +
> + switch (plat->mode) {
> + case USB_DR_MODE_PERIPHERAL:
> + val &= ~(USB3_DELAY_VBUSVALID
> + | USB3_SEL_FORCE_OPMODE | USB3_FORCE_OPMODE(0x3)
> + | USB3_SEL_FORCE_DPPULLDOWN2 | USB3_FORCE_DPPULLDOWN2
> + | USB3_SEL_FORCE_DMPULLDOWN2 | USB3_FORCE_DMPULLDOWN2);
> +
> + val |= USB3_DEVICE_NOT_HOST | USB3_FORCE_VBUSVALID;
> + break;
> +
> + case USB_DR_MODE_HOST:
> + val &= ~(USB3_DEVICE_NOT_HOST | USB3_FORCE_VBUSVALID
> + | USB3_SEL_FORCE_OPMODE | USB3_FORCE_OPMODE(0x3)
> + | USB3_SEL_FORCE_DPPULLDOWN2 | USB3_FORCE_DPPULLDOWN2
> + | USB3_SEL_FORCE_DMPULLDOWN2 | USB3_FORCE_DMPULLDOWN2);
> +
> + val |= USB3_DELAY_VBUSVALID;
> + break;
> +
> + default:
> + error("Unsupported mode of operation %d\n", plat->mode);
> + return -EINVAL;
> + }
> + writel(val, plat->syscfg_base + plat->syscfg_offset);
> +
> + return 0;
> +}
> +
> +static void sti_dwc3_glue_init(struct sti_dwc3_glue_platdata *plat)
> +{
> + unsigned long reg;
> +
> + reg = readl(plat->glue_base + CLKRST_CTRL);
> +
> + reg |= AUX_CLK_EN | EXT_CFG_RESET_N | XHCI_REVISION;
> + reg &= ~SW_PIPEW_RESET_N;
> +
> + writel(reg, plat->glue_base + CLKRST_CTRL);
> +
> + /* configure mux for vbus, powerpresent and bvalid signals */
> + reg = readl(plat->glue_base + USB2_VBUS_MNGMNT_SEL1);
> +
> + reg |= SEL_OVERRIDE_VBUSVALID(USB2_VBUS_UTMIOTG) |
> + SEL_OVERRIDE_POWERPRESENT(USB2_VBUS_UTMIOTG) |
> + SEL_OVERRIDE_BVALID(USB2_VBUS_UTMIOTG);
> +
> + writel(reg, plat->glue_base + USB2_VBUS_MNGMNT_SEL1);
> +
> + setbits_le32(plat->glue_base + CLKRST_CTRL, SW_PIPEW_RESET_N);
> +}
> +
> +static int sti_dwc3_glue_ofdata_to_platdata(struct udevice *dev)
> +{
> + struct sti_dwc3_glue_platdata *plat = dev_get_platdata(dev);
> + struct udevice *syscon;
> + struct regmap *regmap;
> + int ret;
> + u32 reg[4];
> +
> + ret = fdtdec_get_int_array(gd->fdt_blob, dev_of_offset(dev),
> + "reg", reg, ARRAY_SIZE(reg));
> + if (ret) {
> + error("unable to find st,stih407-dwc3 reg property(%d)\n", ret);
> + return ret;
> + }
> +
> + plat->glue_base = reg[0];
> + plat->syscfg_offset = reg[2];
> +
> + /* get corresponding syscon phandle */
> + ret = uclass_get_device_by_phandle(UCLASS_SYSCON, dev, "st,syscfg",
> + &syscon);
> + if (ret) {
> + error("unable to find syscon device (%d)\n", ret);
> + return ret;
> + }
> +
> + /* get syscfg-reg base address */
> + regmap = syscon_get_regmap(syscon);
> + if (!regmap) {
> + error("unable to find regmap\n");
> + return -ENODEV;
> + }
> + plat->syscfg_base = regmap->base;
> +
> + /* get powerdown reset */
> + ret = reset_get_by_name(dev, "powerdown", &plat->powerdown_ctl);
> + if (ret) {
> + error("can't get powerdown reset for %s (%d)", dev->name, ret);
> + return ret;
> + }
> +
> + /* get softreset reset */
> + ret = reset_get_by_name(dev, "softreset", &plat->softreset_ctl);
> + if (ret)
> + error("can't get soft reset for %s (%d)", dev->name, ret);
> +
> + return ret;
> +};
> +
> +static int sti_dwc3_glue_bind(struct udevice *dev)
> +{
> + struct sti_dwc3_glue_platdata *plat = dev_get_platdata(dev);
> + int dwc3_node;
> +
> + /* check if one subnode is present */
> + dwc3_node = fdt_first_subnode(gd->fdt_blob, dev_of_offset(dev));
> + if (dwc3_node <= 0) {
> + error("Can't find subnode for %s\n", dev->name);
> + return -ENODEV;
> + }
> +
> + /* check if the subnode compatible string is the dwc3 one*/
> + if (fdt_node_check_compatible(gd->fdt_blob, dwc3_node,
> + "snps,dwc3") != 0) {
> + error("Can't find dwc3 subnode for %s\n", dev->name);
> + return -ENODEV;
> + }
> +
> + /* retrieve the DWC3 dual role mode */
> + plat->mode = usb_get_dr_mode(dwc3_node);
> + if (plat->mode == USB_DR_MODE_UNKNOWN)
> + /* by default set dual role mode to HOST */
> + plat->mode = USB_DR_MODE_HOST;
> +
> + return dm_scan_fdt_dev(dev);
> +}
> +
> +static int sti_dwc3_glue_probe(struct udevice *dev)
> +{
> + struct sti_dwc3_glue_platdata *plat = dev_get_platdata(dev);
> + int ret;
> +
> + /* deassert both powerdown and softreset */
> + ret = reset_deassert(&plat->powerdown_ctl);
> + if (ret < 0) {
> + error("DWC3 powerdown reset deassert failed: %d", ret);
> + return ret;
> + }
> +
> + ret = reset_deassert(&plat->softreset_ctl);
> + if (ret < 0) {
> + error("DWC3 soft reset deassert failed: %d", ret);
> + goto err1;
> + }
> +
> + ret = sti_dwc3_glue_drd_init(plat);
> + if (ret)
> + goto err2;
> +
> + sti_dwc3_glue_init(plat);
> +
> + return 0;
> +
> +err2:
Invent some more descriptive failpath label names please
> + ret = reset_assert(&plat->softreset_ctl);
> + if (ret < 0) {
> + error("DWC3 soft reset deassert failed: %d", ret);
> + return ret;
> + }
> +
> +err1:
> + ret = reset_assert(&plat->powerdown_ctl);
> + if (ret < 0)
> + error("DWC3 powerdown reset deassert failed: %d", ret);
> +
> + return ret;
> +}
> +
> +static int sti_dwc3_glue_remove(struct udevice *dev)
> +{
> + struct sti_dwc3_glue_platdata *plat = dev_get_platdata(dev);
> + int ret;
> +
> + /* assert both powerdown and softreset */
> + ret = reset_assert(&plat->powerdown_ctl);
> + if (ret < 0) {
> + error("DWC3 powerdown reset deassert failed: %d", ret);
> + return ret;
> + }
> +
> + ret = reset_assert(&plat->softreset_ctl);
> + if (ret < 0)
> + error("DWC3 soft reset deassert failed: %d", ret);
> +
> + return ret;
> +}
> +
> +static const struct udevice_id sti_dwc3_glue_ids[] = {
> + { .compatible = "st,stih407-dwc3" },
> + { }
> +};
> +
> +U_BOOT_DRIVER(dwc3_sti_glue) = {
> + .name = "dwc3_sti_glue",
> + .id = UCLASS_MISC,
> + .of_match = sti_dwc3_glue_ids,
> + .ofdata_to_platdata = sti_dwc3_glue_ofdata_to_platdata,
> + .probe = sti_dwc3_glue_probe,
> + .remove = sti_dwc3_glue_remove,
> + .bind = sti_dwc3_glue_bind,
> + .platdata_auto_alloc_size = sizeof(struct sti_dwc3_glue_platdata),
> + .flags = DM_FLAG_ALLOC_PRIV_DMA,
> +};
> diff --git a/include/dwc3-sti-glue.h b/include/dwc3-sti-glue.h
> new file mode 100644
> index 0000000..2083427
> --- /dev/null
> +++ b/include/dwc3-sti-glue.h
> @@ -0,0 +1,43 @@
> +/*
> + * Copyright (c) 2017
> + * Patrice Chotard <patrice.chotard@st.com>
> + *
> + * SPDX-License-Identifier: GPL-2.0+
> + */
> +
> +#ifndef __DWC3_STI_UBOOT_H_
> +#define __DWC3_STI_UBOOT_H_
> +
> +#include <linux/usb/otg.h>
Does this have to be in a separate header file ?
> +/* glue registers */
> +#define CLKRST_CTRL 0x00
> +#define AUX_CLK_EN BIT(0)
> +#define SW_PIPEW_RESET_N BIT(4)
> +#define EXT_CFG_RESET_N BIT(8)
> +
> +#define XHCI_REVISION BIT(12)
> +
> +#define USB2_VBUS_MNGMNT_SEL1 0x2C
> +#define USB2_VBUS_UTMIOTG 0x1
> +
> +#define SEL_OVERRIDE_VBUSVALID(n) ((n) << 0)
> +#define SEL_OVERRIDE_POWERPRESENT(n) ((n) << 4)
> +#define SEL_OVERRIDE_BVALID(n) ((n) << 8)
> +
> +/* Static DRD configuration */
> +#define USB3_CONTROL_MASK 0xf77
> +
> +#define USB3_DEVICE_NOT_HOST BIT(0)
> +#define USB3_FORCE_VBUSVALID BIT(1)
> +#define USB3_DELAY_VBUSVALID BIT(2)
> +#define USB3_SEL_FORCE_OPMODE BIT(4)
> +#define USB3_FORCE_OPMODE(n) ((n) << 5)
> +#define USB3_SEL_FORCE_DPPULLDOWN2 BIT(8)
> +#define USB3_FORCE_DPPULLDOWN2 BIT(9)
> +#define USB3_SEL_FORCE_DMPULLDOWN2 BIT(10)
> +#define USB3_FORCE_DMPULLDOWN2 BIT(11)
> +
> +int sti_dwc3_init(enum usb_dr_mode mode);
> +
> +#endif /* __DWC3_STI_UBOOT_H_ */
>
--
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 22+ messages in thread
* [U-Boot] [PATCH v7 04/10] usb: phy: Add STi USB2 PHY
2017-06-01 12:05 ` [U-Boot] [PATCH v7 04/10] usb: phy: Add STi USB2 PHY patrice.chotard at st.com
2017-06-02 2:56 ` Simon Glass
@ 2017-06-03 6:08 ` Marek Vasut
2017-06-05 6:58 ` Patrice CHOTARD
1 sibling, 1 reply; 22+ messages in thread
From: Marek Vasut @ 2017-06-03 6:08 UTC (permalink / raw)
To: u-boot
On 06/01/2017 02:05 PM, patrice.chotard at st.com wrote:
> From: Patrice Chotard <patrice.chotard@st.com>
>
> This is the generic phy driver for the picoPHY ports
> used by USB2/1.1 controllers. It is found on STiH407 SoC
> family from STMicroelectronics.
>
> Signed-off-by: Patrice Chotard <patrice.chotard@st.com>
> Reviewed-by: Marek Vasut <marex@denx.de>
> ---
> v7: _ replace fdtdec_parse_phandle_with_args() by dev_read_phandle_with_args()
> _ replace uclass_get_device_by_of_offset() by uclass_get_device_by_ofnode()
>
You should drop RB if you do significant changes.
>
> v5: _ add Reviewed-by: Marek Vasut <marex@denx.de>
>
> v4: _ update to use the new PHY uclass currently available on dm-next branch
>
> v3: _ convert driver to USB PHY uclass
>
> v2: _ replace bitfield_replace() by clrsetbits_le32()
>
> doc/device-tree-bindings/phy/phy-stih407-usb.txt | 24 +++
> drivers/phy/Kconfig | 8 +
> drivers/phy/Makefile | 1 +
> drivers/phy/sti_usb_phy.c | 181 +++++++++++++++++++++++
> 4 files changed, 214 insertions(+)
> create mode 100644 doc/device-tree-bindings/phy/phy-stih407-usb.txt
> create mode 100644 drivers/phy/sti_usb_phy.c
>
> diff --git a/doc/device-tree-bindings/phy/phy-stih407-usb.txt b/doc/device-tree-bindings/phy/phy-stih407-usb.txt
> new file mode 100644
> index 0000000..de6a706
> --- /dev/null
> +++ b/doc/device-tree-bindings/phy/phy-stih407-usb.txt
> @@ -0,0 +1,24 @@
> +ST STiH407 USB PHY controller
> +
> +This file documents the dt bindings for the usb picoPHY driver which is the PHY for both USB2 and USB3
> +host controllers (when controlling usb2/1.1 devices) available on STiH407 SoC family from STMicroelectronics.
> +
> +Required properties:
> +- compatible : should be "st,stih407-usb2-phy"
> +- st,syscfg : phandle of sysconfig bank plus integer array containing phyparam and phyctrl register offsets
> +- resets : list of phandle and reset specifier pairs. There should be two entries, one
> + for the whole phy and one for the port
> +- reset-names : list of reset signal names. Should be "global" and "port"
> +See: Documentation/devicetree/bindings/reset/st,sti-powerdown.txt
> +See: Documentation/devicetree/bindings/reset/reset.txt
> +
> +Example:
> +
> +usb2_picophy0: usbpicophy at f8 {
This example uses address, but has no reg property ?
> + compatible = "st,stih407-usb2-phy";
> + #phy-cells = <0>;
> + st,syscfg = <&syscfg_core 0x100 0xf4>;
> + resets = <&softreset STIH407_PICOPHY_SOFTRESET>,
> + <&picophyreset STIH407_PICOPHY0_RESET>;
> + reset-names = "global", "port";
> +};
> diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
> index a91a694..4330b36 100644
> --- a/drivers/phy/Kconfig
> +++ b/drivers/phy/Kconfig
> @@ -59,4 +59,12 @@ config SPL_PIPE3_PHY
> This PHY is found on omap devices supporting SATA such as dra7, am57x
> and omap5
>
> +config STI_USB_PHY
> + bool "STMicroelectronics USB2 picoPHY driver for STiH407 family"
> + depends on PHY && ARCH_STI
> + help
> + This is the generic phy driver for the picoPHY ports
> + used by USB2 and USB3 Host controllers available on
> + STiH407 SoC families.
> +
> endmenu
> diff --git a/drivers/phy/Makefile b/drivers/phy/Makefile
> index 6ce96d2..22d92d3 100644
> --- a/drivers/phy/Makefile
> +++ b/drivers/phy/Makefile
> @@ -8,3 +8,4 @@
> obj-$(CONFIG_$(SPL_)PHY) += phy-uclass.o
> obj-$(CONFIG_PHY_SANDBOX) += sandbox-phy.o
> obj-$(CONFIG_$(SPL_)PIPE3_PHY) += ti-pipe3-phy.o
> +obj-$(CONFIG_STI_USB_PHY) += sti_usb_phy.o
> diff --git a/drivers/phy/sti_usb_phy.c b/drivers/phy/sti_usb_phy.c
> new file mode 100644
> index 0000000..0e0b1c0
> --- /dev/null
> +++ b/drivers/phy/sti_usb_phy.c
> @@ -0,0 +1,181 @@
> +/*
> + * Copyright (c) 2017
> + * Patrice Chotard <patrice.chotard@st.com>
> + *
> + * SPDX-License-Identifier: GPL-2.0+
> + */
> +
> +#include <common.h>
> +#include <asm/io.h>
> +#include <bitfield.h>
> +#include <dm.h>
> +#include <errno.h>
> +#include <fdtdec.h>
> +#include <generic-phy.h>
> +#include <libfdt.h>
> +#include <regmap.h>
> +#include <reset-uclass.h>
> +#include <syscon.h>
> +#include <wait_bit.h>
> +
> +#include <linux/bitops.h>
> +#include <linux/compat.h>
> +
> +DECLARE_GLOBAL_DATA_PTR;
> +
> +/* Default PHY_SEL and REFCLKSEL configuration */
> +#define STIH407_USB_PICOPHY_CTRL_PORT_CONF 0x6
> +
> +/* ports parameters overriding */
> +#define STIH407_USB_PICOPHY_PARAM_DEF 0x39a4dc
> +
> +#define PHYPARAM_REG 1
> +#define PHYCTRL_REG 2
> +#define PHYPARAM_NB 3
> +
> +struct sti_usb_phy {
> + struct regmap *regmap;
> + struct reset_ctl global_ctl;
> + struct reset_ctl port_ctl;
> + int param;
> + int ctrl;
> +};
> +
> +static int sti_usb_phy_deassert(struct sti_usb_phy *phy)
> +{
> + int ret;
> +
> + ret = reset_deassert(&phy->global_ctl);
> + if (ret < 0) {
> + error("PHY global deassert failed: %d", ret);
> + return ret;
> + }
> +
> + ret = reset_deassert(&phy->port_ctl);
> + if (ret < 0)
> + error("PHY port deassert failed: %d", ret);
> +
> + return ret;
> +}
> +
> +static int sti_usb_phy_init(struct phy *usb_phy)
> +{
> + struct udevice *dev = usb_phy->dev;
> + struct sti_usb_phy *phy = dev_get_priv(dev);
> + void __iomem *reg;
> +
> + /* set ctrl picophy value */
> + reg = (void __iomem *)phy->regmap->base + phy->ctrl;
> + /* CTRL_PORT mask is 0x1f */
> + clrsetbits_le32(reg, 0x1f, STIH407_USB_PICOPHY_CTRL_PORT_CONF);
> +
> + /* set ports parameters overriding */
> + reg = (void __iomem *)phy->regmap->base + phy->param;
> + /* PARAM_DEF mask is 0xffffffff */
> + clrsetbits_le32(reg, 0xffffffff, STIH407_USB_PICOPHY_PARAM_DEF);
> +
> + return sti_usb_phy_deassert(phy);
> +}
> +
> +static int sti_usb_phy_exit(struct phy *usb_phy)
> +{
> + struct udevice *dev = usb_phy->dev;
> + struct sti_usb_phy *phy = dev_get_priv(dev);
> + int ret;
> +
> + ret = reset_assert(&phy->port_ctl);
> + if (ret < 0) {
> + error("PHY port assert failed: %d", ret);
> + return ret;
> + }
> +
> + ret = reset_assert(&phy->global_ctl);
> + if (ret < 0)
> + error("PHY global assert failed: %d", ret);
> +
> + return ret;
> +}
> +
> +struct phy_ops sti_usb_phy_ops = {
> + .init = sti_usb_phy_init,
> + .exit = sti_usb_phy_exit,
> +};
> +
> +int sti_usb_phy_probe(struct udevice *dev)
> +{
> + struct sti_usb_phy *priv = dev_get_priv(dev);
> + struct udevice *syscon;
> + struct ofnode_phandle_args syscfg_phandle;
> + u32 cells[PHYPARAM_NB];
> + int ret, count;
> +
> + /* get corresponding syscon phandle */
> + ret = dev_read_phandle_with_args(dev, "st,syscfg", NULL, 0, 0,
> + &syscfg_phandle);
> +
> + if (ret < 0) {
> + error("Can't get syscfg phandle: %d\n", ret);
> + return ret;
> + }
> +
> + ret = uclass_get_device_by_ofnode(UCLASS_SYSCON, syscfg_phandle.node,
> + &syscon);
> + if (ret) {
> + error("unable to find syscon device (%d)\n", ret);
> + return ret;
> + }
> +
> + priv->regmap = syscon_get_regmap(syscon);
> + if (!priv->regmap) {
> + error("unable to find regmap\n");
> + return -ENODEV;
> + }
> +
> + /* get phy param offset */
> + count = fdtdec_get_int_array_count(gd->fdt_blob, dev_of_offset(dev),
> + "st,syscfg", cells,
> + ARRAY_SIZE(cells));
> +
> + if (count < 0) {
> + error("Bad PHY st,syscfg property %d\n", count);
> + return -EINVAL;
> + }
> +
> + if (count > PHYPARAM_NB) {
> + error("Unsupported PHY param count %d\n", count);
> + return -EINVAL;
> + }
> +
> + priv->param = cells[PHYPARAM_REG];
> + priv->ctrl = cells[PHYCTRL_REG];
> +
> + /* get global reset control */
> + ret = reset_get_by_name(dev, "global", &priv->global_ctl);
> + if (ret) {
> + error("can't get global reset for %s (%d)", dev->name, ret);
> + return ret;
> + }
> +
> + /* get port reset control */
> + ret = reset_get_by_name(dev, "port", &priv->port_ctl);
> + if (ret) {
> + error("can't get port reset for %s (%d)", dev->name, ret);
> + return ret;
> + }
> +
> + return 0;
> +}
> +
> +static const struct udevice_id sti_usb_phy_ids[] = {
> + { .compatible = "st,stih407-usb2-phy" },
> + { }
> +};
> +
> +U_BOOT_DRIVER(sti_usb_phy) = {
> + .name = "sti_usb_phy",
> + .id = UCLASS_PHY,
> + .of_match = sti_usb_phy_ids,
> + .probe = sti_usb_phy_probe,
> + .ops = &sti_usb_phy_ops,
> + .priv_auto_alloc_size = sizeof(struct sti_usb_phy),
> +};
>
--
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 22+ messages in thread
* [U-Boot] [PATCH v7 07/10] usb: dwc3: Add dwc3 glue driver support for STi
2017-06-03 6:06 ` Marek Vasut
@ 2017-06-05 6:40 ` Patrice CHOTARD
2017-06-05 11:22 ` Marek Vasut
0 siblings, 1 reply; 22+ messages in thread
From: Patrice CHOTARD @ 2017-06-05 6:40 UTC (permalink / raw)
To: u-boot
Hi Marek
On 06/03/2017 08:06 AM, Marek Vasut wrote:
> On 06/01/2017 02:05 PM, patrice.chotard at st.com wrote:
>> From: Patrice Chotard <patrice.chotard@st.com>
>>
>> This patch adds the ST glue logic to manage the DWC3 HC
>> on STiH407 SoC family. It configures the internal glue
>> logic and syscfg registers.
>>
>> Part of this code been extracted from kernel.org driver
>> (drivers/usb/dwc3/dwc3-st.c)
>>
>> Signed-off-by: Patrice Chotard <patrice.chotard@st.com>
>> Reviewed-by: Simon Glass <sjg@chromium.org>
>> ---
>>
>> v7: _ none
>>
>> v6: _ add reviewed-by Simon Glass
>> _ put #define <common.h> first
>>
>> v5: _ none
>>
>> v4: _ none
>>
>> v3: _ rename dwc3-sti.c to dwc3-sti-glue.c
>> _ respect device tree hierarchy, this driver is now responsible
>> for xhci-sti binding (done in sti_dwc3_glue_bind())
>>
>> v2: _ use setbits_le32() instead of read, modify, write sequence
>> _ add missing parenthesis
>>
>> arch/arm/include/asm/arch-stih410/sys_proto.h | 11 ++
>> doc/device-tree-bindings/usb/dwc3-st.txt | 60 ++++++
>> drivers/usb/host/Kconfig | 9 +
>> drivers/usb/host/Makefile | 1 +
>> drivers/usb/host/dwc3-sti-glue.c | 256 ++++++++++++++++++++++++++
>> include/dwc3-sti-glue.h | 43 +++++
>> 6 files changed, 380 insertions(+)
>> create mode 100644 arch/arm/include/asm/arch-stih410/sys_proto.h
>> create mode 100644 doc/device-tree-bindings/usb/dwc3-st.txt
>> create mode 100644 drivers/usb/host/dwc3-sti-glue.c
>> create mode 100644 include/dwc3-sti-glue.h
>>
>> diff --git a/arch/arm/include/asm/arch-stih410/sys_proto.h b/arch/arm/include/asm/arch-stih410/sys_proto.h
>> new file mode 100644
>> index 0000000..5c40d3b
>> --- /dev/null
>> +++ b/arch/arm/include/asm/arch-stih410/sys_proto.h
>> @@ -0,0 +1,11 @@
>> +/*
>> + * Copyright (c) 2017
>> + * Patrice Chotard <patrice.chotard@st.com>
>> + *
>> + * SPDX-License-Identifier: GPL-2.0+
>> + */
>> +
>> +#ifndef _ASM_ARCH_SYS_PROTO_H
>> +#define _ASM_ARCH_SYS_PROTO_H
>> +
>> +#endif /* _ASM_ARCH_SYS_PROTO_H */
>> diff --git a/doc/device-tree-bindings/usb/dwc3-st.txt b/doc/device-tree-bindings/usb/dwc3-st.txt
>> new file mode 100644
>> index 0000000..a26a139
>> --- /dev/null
>> +++ b/doc/device-tree-bindings/usb/dwc3-st.txt
>> @@ -0,0 +1,60 @@
>> +ST DWC3 glue logic
>
> Is this DT binding imported from Linux ?
Yes
>
>> +This file documents the parameters for the dwc3-st driver.
>> +This driver controls the glue logic used to configure the dwc3 core on
>> +STiH407 based platforms.
>> +
>> +Required properties:
>> + - compatible : must be "st,stih407-dwc3"
>> + - reg : glue logic base address and USB syscfg ctrl register offset
>> + - reg-names : should be "reg-glue" and "syscfg-reg"
>> + - st,syscon : should be phandle to system configuration node which
>> + encompasses the glue registers
>> + - resets : list of phandle and reset specifier pairs. There should be two entries, one
>> + for the powerdown and softreset lines of the usb3 IP
>> + - reset-names : list of reset signal names. Names should be "powerdown" and "softreset"
>> +
>> + - #address-cells, #size-cells : should be '1' if the device has sub-nodes
>> + with 'reg' property
>> +
>> + - pinctl-names : A pinctrl state named "default" must be defined
>> +
>> + - pinctrl-0 : Pin control group
>> +
>> + - ranges : allows valid 1:1 translation between child's address space and
>> + parent's address space
>> +
>> +Sub-nodes:
>> +The dwc3 core should be added as subnode to ST DWC3 glue as shown in the
>> +example below.
>> +
>> +NB: The dr_mode property is NOT optional for this driver, as the default value
>> +is "otg", which isn't supported by this SoC. Valid dr_mode values for dwc3-st are
>> +either "host" or "device".
>> +
[...]
>> +static int sti_dwc3_glue_probe(struct udevice *dev)
>> +{
>> + struct sti_dwc3_glue_platdata *plat = dev_get_platdata(dev);
>> + int ret;
>> +
>> + /* deassert both powerdown and softreset */
>> + ret = reset_deassert(&plat->powerdown_ctl);
>> + if (ret < 0) {
>> + error("DWC3 powerdown reset deassert failed: %d", ret);
>> + return ret;
>> + }
>> +
>> + ret = reset_deassert(&plat->softreset_ctl);
>> + if (ret < 0) {
>> + error("DWC3 soft reset deassert failed: %d", ret);
>> + goto err1;
>> + }
>> +
>> + ret = sti_dwc3_glue_drd_init(plat);
>> + if (ret)
>> + goto err2;
>> +
>> + sti_dwc3_glue_init(plat);
>> +
>> + return 0;
>> +
>> +err2:
>
> Invent some more descriptive failpath label names please
Ok
>
>> + ret = reset_assert(&plat->softreset_ctl);
>> + if (ret < 0) {
>> + error("DWC3 soft reset deassert failed: %d", ret);
>> + return ret;
>> + }
>> +
>> +err1:
>> + ret = reset_assert(&plat->powerdown_ctl);
>> + if (ret < 0)
>> + error("DWC3 powerdown reset deassert failed: %d", ret);
>> +
>> + return ret;
>> +}
>> +
>> +static int sti_dwc3_glue_remove(struct udevice *dev)
>> +{
>> + struct sti_dwc3_glue_platdata *plat = dev_get_platdata(dev);
>> + int ret;
>> +
>> + /* assert both powerdown and softreset */
>> + ret = reset_assert(&plat->powerdown_ctl);
>> + if (ret < 0) {
>> + error("DWC3 powerdown reset deassert failed: %d", ret);
>> + return ret;
>> + }
>> +
>> + ret = reset_assert(&plat->softreset_ctl);
>> + if (ret < 0)
>> + error("DWC3 soft reset deassert failed: %d", ret);
>> +
>> + return ret;
>> +}
>> +
>> +static const struct udevice_id sti_dwc3_glue_ids[] = {
>> + { .compatible = "st,stih407-dwc3" },
>> + { }
>> +};
>> +
>> +U_BOOT_DRIVER(dwc3_sti_glue) = {
>> + .name = "dwc3_sti_glue",
>> + .id = UCLASS_MISC,
>> + .of_match = sti_dwc3_glue_ids,
>> + .ofdata_to_platdata = sti_dwc3_glue_ofdata_to_platdata,
>> + .probe = sti_dwc3_glue_probe,
>> + .remove = sti_dwc3_glue_remove,
>> + .bind = sti_dwc3_glue_bind,
>> + .platdata_auto_alloc_size = sizeof(struct sti_dwc3_glue_platdata),
>> + .flags = DM_FLAG_ALLOC_PRIV_DMA,
>> +};
>> diff --git a/include/dwc3-sti-glue.h b/include/dwc3-sti-glue.h
>> new file mode 100644
>> index 0000000..2083427
>> --- /dev/null
>> +++ b/include/dwc3-sti-glue.h
>> @@ -0,0 +1,43 @@
>> +/*
>> + * Copyright (c) 2017
>> + * Patrice Chotard <patrice.chotard@st.com>
>> + *
>> + * SPDX-License-Identifier: GPL-2.0+
>> + */
>> +
>> +#ifndef __DWC3_STI_UBOOT_H_
>> +#define __DWC3_STI_UBOOT_H_
>> +
>> +#include <linux/usb/otg.h>
>
> Does this have to be in a separate header file ?
This is needed for enum usb_dr_mode used in int sti_dwc3_init()
prototype below.
>
>> +/* glue registers */
>> +#define CLKRST_CTRL 0x00
>> +#define AUX_CLK_EN BIT(0)
>> +#define SW_PIPEW_RESET_N BIT(4)
>> +#define EXT_CFG_RESET_N BIT(8)
>> +
>> +#define XHCI_REVISION BIT(12)
>> +
>> +#define USB2_VBUS_MNGMNT_SEL1 0x2C
>> +#define USB2_VBUS_UTMIOTG 0x1
>> +
>> +#define SEL_OVERRIDE_VBUSVALID(n) ((n) << 0)
>> +#define SEL_OVERRIDE_POWERPRESENT(n) ((n) << 4)
>> +#define SEL_OVERRIDE_BVALID(n) ((n) << 8)
>> +
>> +/* Static DRD configuration */
>> +#define USB3_CONTROL_MASK 0xf77
>> +
>> +#define USB3_DEVICE_NOT_HOST BIT(0)
>> +#define USB3_FORCE_VBUSVALID BIT(1)
>> +#define USB3_DELAY_VBUSVALID BIT(2)
>> +#define USB3_SEL_FORCE_OPMODE BIT(4)
>> +#define USB3_FORCE_OPMODE(n) ((n) << 5)
>> +#define USB3_SEL_FORCE_DPPULLDOWN2 BIT(8)
>> +#define USB3_FORCE_DPPULLDOWN2 BIT(9)
>> +#define USB3_SEL_FORCE_DMPULLDOWN2 BIT(10)
>> +#define USB3_FORCE_DMPULLDOWN2 BIT(11)
>> +
>> +int sti_dwc3_init(enum usb_dr_mode mode);
>> +
>> +#endif /* __DWC3_STI_UBOOT_H_ */
>>
>
>
^ permalink raw reply [flat|nested] 22+ messages in thread
* [U-Boot] [PATCH v7 04/10] usb: phy: Add STi USB2 PHY
2017-06-03 6:08 ` Marek Vasut
@ 2017-06-05 6:58 ` Patrice CHOTARD
2017-06-05 11:21 ` Marek Vasut
0 siblings, 1 reply; 22+ messages in thread
From: Patrice CHOTARD @ 2017-06-05 6:58 UTC (permalink / raw)
To: u-boot
Hi Marek
On 06/03/2017 08:08 AM, Marek Vasut wrote:
> On 06/01/2017 02:05 PM, patrice.chotard at st.com wrote:
>> From: Patrice Chotard <patrice.chotard@st.com>
>>
>> This is the generic phy driver for the picoPHY ports
>> used by USB2/1.1 controllers. It is found on STiH407 SoC
>> family from STMicroelectronics.
>>
>> Signed-off-by: Patrice Chotard <patrice.chotard@st.com>
>> Reviewed-by: Marek Vasut <marex@denx.de>
>> ---
>> v7: _ replace fdtdec_parse_phandle_with_args() by dev_read_phandle_with_args()
>> _ replace uclass_get_device_by_of_offset() by uclass_get_device_by_ofnode()
>>
>
> You should drop RB if you do significant changes.
>
>>
>> v5: _ add Reviewed-by: Marek Vasut <marex@denx.de>
>>
>> v4: _ update to use the new PHY uclass currently available on dm-next branch
>>
>> v3: _ convert driver to USB PHY uclass
>>
>> v2: _ replace bitfield_replace() by clrsetbits_le32()
>>
>> doc/device-tree-bindings/phy/phy-stih407-usb.txt | 24 +++
>> drivers/phy/Kconfig | 8 +
>> drivers/phy/Makefile | 1 +
>> drivers/phy/sti_usb_phy.c | 181 +++++++++++++++++++++++
>> 4 files changed, 214 insertions(+)
>> create mode 100644 doc/device-tree-bindings/phy/phy-stih407-usb.txt
>> create mode 100644 drivers/phy/sti_usb_phy.c
>>
>> diff --git a/doc/device-tree-bindings/phy/phy-stih407-usb.txt b/doc/device-tree-bindings/phy/phy-stih407-usb.txt
>> new file mode 100644
>> index 0000000..de6a706
>> --- /dev/null
>> +++ b/doc/device-tree-bindings/phy/phy-stih407-usb.txt
>> @@ -0,0 +1,24 @@
>> +ST STiH407 USB PHY controller
>> +
>> +This file documents the dt bindings for the usb picoPHY driver which is the PHY for both USB2 and USB3
>> +host controllers (when controlling usb2/1.1 devices) available on STiH407 SoC family from STMicroelectronics.
>> +
>> +Required properties:
>> +- compatible : should be "st,stih407-usb2-phy"
>> +- st,syscfg : phandle of sysconfig bank plus integer array containing phyparam and phyctrl register offsets
>> +- resets : list of phandle and reset specifier pairs. There should be two entries, one
>> + for the whole phy and one for the port
>> +- reset-names : list of reset signal names. Should be "global" and "port"
>> +See: Documentation/devicetree/bindings/reset/st,sti-powerdown.txt
>> +See: Documentation/devicetree/bindings/reset/reset.txt
>> +
>> +Example:
>> +
>> +usb2_picophy0: usbpicophy at f8 {
>
> This example uses address, but has no reg property ?
Agree, but following advices from Arnd Bergman about not mixing address
space and sysconfig registers int the reg property, the reg property was
removed.
For more details, see https://patches.linaro.org/patch/44081/
>
>> + compatible = "st,stih407-usb2-phy";
>> + #phy-cells = <0>;
>> + st,syscfg = <&syscfg_core 0x100 0xf4>;
>> + resets = <&softreset STIH407_PICOPHY_SOFTRESET>,
>> + <&picophyreset STIH407_PICOPHY0_RESET>;
>> + reset-names = "global", "port";
>> +};
>> diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
>> index a91a694..4330b36 100644
>> --- a/drivers/phy/Kconfig
>> +++ b/drivers/phy/Kconfig
>> @@ -59,4 +59,12 @@ config SPL_PIPE3_PHY
>> This PHY is found on omap devices supporting SATA such as dra7, am57x
>> and omap5
>>
>> +config STI_USB_PHY
>> + bool "STMicroelectronics USB2 picoPHY driver for STiH407 family"
>> + depends on PHY && ARCH_STI
>> + help
>> + This is the generic phy driver for the picoPHY ports
>> + used by USB2 and USB3 Host controllers available on
>> + STiH407 SoC families.
>> +
>> endmenu
>> diff --git a/drivers/phy/Makefile b/drivers/phy/Makefile
>> index 6ce96d2..22d92d3 100644
>> --- a/drivers/phy/Makefile
>> +++ b/drivers/phy/Makefile
>> @@ -8,3 +8,4 @@
>> obj-$(CONFIG_$(SPL_)PHY) += phy-uclass.o
>> obj-$(CONFIG_PHY_SANDBOX) += sandbox-phy.o
>> obj-$(CONFIG_$(SPL_)PIPE3_PHY) += ti-pipe3-phy.o
>> +obj-$(CONFIG_STI_USB_PHY) += sti_usb_phy.o
>> diff --git a/drivers/phy/sti_usb_phy.c b/drivers/phy/sti_usb_phy.c
>> new file mode 100644
>> index 0000000..0e0b1c0
>> --- /dev/null
>> +++ b/drivers/phy/sti_usb_phy.c
>> @@ -0,0 +1,181 @@
>> +/*
>> + * Copyright (c) 2017
>> + * Patrice Chotard <patrice.chotard@st.com>
>> + *
>> + * SPDX-License-Identifier: GPL-2.0+
>> + */
>> +
>> +#include <common.h>
>> +#include <asm/io.h>
>> +#include <bitfield.h>
>> +#include <dm.h>
>> +#include <errno.h>
>> +#include <fdtdec.h>
>> +#include <generic-phy.h>
>> +#include <libfdt.h>
>> +#include <regmap.h>
>> +#include <reset-uclass.h>
>> +#include <syscon.h>
>> +#include <wait_bit.h>
>> +
>> +#include <linux/bitops.h>
>> +#include <linux/compat.h>
>> +
>> +DECLARE_GLOBAL_DATA_PTR;
>> +
>> +/* Default PHY_SEL and REFCLKSEL configuration */
>> +#define STIH407_USB_PICOPHY_CTRL_PORT_CONF 0x6
>> +
>> +/* ports parameters overriding */
>> +#define STIH407_USB_PICOPHY_PARAM_DEF 0x39a4dc
>> +
>> +#define PHYPARAM_REG 1
>> +#define PHYCTRL_REG 2
>> +#define PHYPARAM_NB 3
>> +
>> +struct sti_usb_phy {
>> + struct regmap *regmap;
>> + struct reset_ctl global_ctl;
>> + struct reset_ctl port_ctl;
>> + int param;
>> + int ctrl;
>> +};
>> +
>> +static int sti_usb_phy_deassert(struct sti_usb_phy *phy)
>> +{
>> + int ret;
>> +
>> + ret = reset_deassert(&phy->global_ctl);
>> + if (ret < 0) {
>> + error("PHY global deassert failed: %d", ret);
>> + return ret;
>> + }
>> +
>> + ret = reset_deassert(&phy->port_ctl);
>> + if (ret < 0)
>> + error("PHY port deassert failed: %d", ret);
>> +
>> + return ret;
>> +}
>> +
>> +static int sti_usb_phy_init(struct phy *usb_phy)
>> +{
>> + struct udevice *dev = usb_phy->dev;
>> + struct sti_usb_phy *phy = dev_get_priv(dev);
>> + void __iomem *reg;
>> +
>> + /* set ctrl picophy value */
>> + reg = (void __iomem *)phy->regmap->base + phy->ctrl;
>> + /* CTRL_PORT mask is 0x1f */
>> + clrsetbits_le32(reg, 0x1f, STIH407_USB_PICOPHY_CTRL_PORT_CONF);
>> +
>> + /* set ports parameters overriding */
>> + reg = (void __iomem *)phy->regmap->base + phy->param;
>> + /* PARAM_DEF mask is 0xffffffff */
>> + clrsetbits_le32(reg, 0xffffffff, STIH407_USB_PICOPHY_PARAM_DEF);
>> +
>> + return sti_usb_phy_deassert(phy);
>> +}
>> +
>> +static int sti_usb_phy_exit(struct phy *usb_phy)
>> +{
>> + struct udevice *dev = usb_phy->dev;
>> + struct sti_usb_phy *phy = dev_get_priv(dev);
>> + int ret;
>> +
>> + ret = reset_assert(&phy->port_ctl);
>> + if (ret < 0) {
>> + error("PHY port assert failed: %d", ret);
>> + return ret;
>> + }
>> +
>> + ret = reset_assert(&phy->global_ctl);
>> + if (ret < 0)
>> + error("PHY global assert failed: %d", ret);
>> +
>> + return ret;
>> +}
>> +
>> +struct phy_ops sti_usb_phy_ops = {
>> + .init = sti_usb_phy_init,
>> + .exit = sti_usb_phy_exit,
>> +};
>> +
>> +int sti_usb_phy_probe(struct udevice *dev)
>> +{
>> + struct sti_usb_phy *priv = dev_get_priv(dev);
>> + struct udevice *syscon;
>> + struct ofnode_phandle_args syscfg_phandle;
>> + u32 cells[PHYPARAM_NB];
>> + int ret, count;
>> +
>> + /* get corresponding syscon phandle */
>> + ret = dev_read_phandle_with_args(dev, "st,syscfg", NULL, 0, 0,
>> + &syscfg_phandle);
>> +
>> + if (ret < 0) {
>> + error("Can't get syscfg phandle: %d\n", ret);
>> + return ret;
>> + }
>> +
>> + ret = uclass_get_device_by_ofnode(UCLASS_SYSCON, syscfg_phandle.node,
>> + &syscon);
>> + if (ret) {
>> + error("unable to find syscon device (%d)\n", ret);
>> + return ret;
>> + }
>> +
>> + priv->regmap = syscon_get_regmap(syscon);
>> + if (!priv->regmap) {
>> + error("unable to find regmap\n");
>> + return -ENODEV;
>> + }
>> +
>> + /* get phy param offset */
>> + count = fdtdec_get_int_array_count(gd->fdt_blob, dev_of_offset(dev),
>> + "st,syscfg", cells,
>> + ARRAY_SIZE(cells));
>> +
>> + if (count < 0) {
>> + error("Bad PHY st,syscfg property %d\n", count);
>> + return -EINVAL;
>> + }
>> +
>> + if (count > PHYPARAM_NB) {
>> + error("Unsupported PHY param count %d\n", count);
>> + return -EINVAL;
>> + }
>> +
>> + priv->param = cells[PHYPARAM_REG];
>> + priv->ctrl = cells[PHYCTRL_REG];
>> +
>> + /* get global reset control */
>> + ret = reset_get_by_name(dev, "global", &priv->global_ctl);
>> + if (ret) {
>> + error("can't get global reset for %s (%d)", dev->name, ret);
>> + return ret;
>> + }
>> +
>> + /* get port reset control */
>> + ret = reset_get_by_name(dev, "port", &priv->port_ctl);
>> + if (ret) {
>> + error("can't get port reset for %s (%d)", dev->name, ret);
>> + return ret;
>> + }
>> +
>> + return 0;
>> +}
>> +
>> +static const struct udevice_id sti_usb_phy_ids[] = {
>> + { .compatible = "st,stih407-usb2-phy" },
>> + { }
>> +};
>> +
>> +U_BOOT_DRIVER(sti_usb_phy) = {
>> + .name = "sti_usb_phy",
>> + .id = UCLASS_PHY,
>> + .of_match = sti_usb_phy_ids,
>> + .probe = sti_usb_phy_probe,
>> + .ops = &sti_usb_phy_ops,
>> + .priv_auto_alloc_size = sizeof(struct sti_usb_phy),
>> +};
>>
>
>
^ permalink raw reply [flat|nested] 22+ messages in thread
* [U-Boot] [PATCH v7 04/10] usb: phy: Add STi USB2 PHY
2017-06-05 6:58 ` Patrice CHOTARD
@ 2017-06-05 11:21 ` Marek Vasut
2017-06-06 7:16 ` Patrice CHOTARD
0 siblings, 1 reply; 22+ messages in thread
From: Marek Vasut @ 2017-06-05 11:21 UTC (permalink / raw)
To: u-boot
On 06/05/2017 08:58 AM, Patrice CHOTARD wrote:
> Hi Marek
>
> On 06/03/2017 08:08 AM, Marek Vasut wrote:
>> On 06/01/2017 02:05 PM, patrice.chotard at st.com wrote:
>>> From: Patrice Chotard <patrice.chotard@st.com>
>>>
>>> This is the generic phy driver for the picoPHY ports
>>> used by USB2/1.1 controllers. It is found on STiH407 SoC
>>> family from STMicroelectronics.
>>>
>>> Signed-off-by: Patrice Chotard <patrice.chotard@st.com>
>>> Reviewed-by: Marek Vasut <marex@denx.de>
>>> ---
>>> v7: _ replace fdtdec_parse_phandle_with_args() by dev_read_phandle_with_args()
>>> _ replace uclass_get_device_by_of_offset() by uclass_get_device_by_ofnode()
>>>
>>
>> You should drop RB if you do significant changes.
>>
>>>
>>> v5: _ add Reviewed-by: Marek Vasut <marex@denx.de>
>>>
>>> v4: _ update to use the new PHY uclass currently available on dm-next branch
>>>
>>> v3: _ convert driver to USB PHY uclass
>>>
>>> v2: _ replace bitfield_replace() by clrsetbits_le32()
>>>
>>> doc/device-tree-bindings/phy/phy-stih407-usb.txt | 24 +++
>>> drivers/phy/Kconfig | 8 +
>>> drivers/phy/Makefile | 1 +
>>> drivers/phy/sti_usb_phy.c | 181 +++++++++++++++++++++++
>>> 4 files changed, 214 insertions(+)
>>> create mode 100644 doc/device-tree-bindings/phy/phy-stih407-usb.txt
>>> create mode 100644 drivers/phy/sti_usb_phy.c
>>>
>>> diff --git a/doc/device-tree-bindings/phy/phy-stih407-usb.txt b/doc/device-tree-bindings/phy/phy-stih407-usb.txt
>>> new file mode 100644
>>> index 0000000..de6a706
>>> --- /dev/null
>>> +++ b/doc/device-tree-bindings/phy/phy-stih407-usb.txt
>>> @@ -0,0 +1,24 @@
>>> +ST STiH407 USB PHY controller
>>> +
>>> +This file documents the dt bindings for the usb picoPHY driver which is the PHY for both USB2 and USB3
>>> +host controllers (when controlling usb2/1.1 devices) available on STiH407 SoC family from STMicroelectronics.
>>> +
>>> +Required properties:
>>> +- compatible : should be "st,stih407-usb2-phy"
>>> +- st,syscfg : phandle of sysconfig bank plus integer array containing phyparam and phyctrl register offsets
>>> +- resets : list of phandle and reset specifier pairs. There should be two entries, one
>>> + for the whole phy and one for the port
>>> +- reset-names : list of reset signal names. Should be "global" and "port"
>>> +See: Documentation/devicetree/bindings/reset/st,sti-powerdown.txt
>>> +See: Documentation/devicetree/bindings/reset/reset.txt
>>> +
>>> +Example:
>>> +
>>> +usb2_picophy0: usbpicophy at f8 {
>>
>> This example uses address, but has no reg property ?
>
> Agree, but following advices from Arnd Bergman about not mixing address
> space and sysconfig registers int the reg property, the reg property was
> removed.
>
> For more details, see https://patches.linaro.org/patch/44081/
Then you should remove it from usbpicophy at f8 too .
[...]
--
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 22+ messages in thread
* [U-Boot] [PATCH v7 07/10] usb: dwc3: Add dwc3 glue driver support for STi
2017-06-05 6:40 ` Patrice CHOTARD
@ 2017-06-05 11:22 ` Marek Vasut
2017-06-06 7:26 ` Patrice CHOTARD
0 siblings, 1 reply; 22+ messages in thread
From: Marek Vasut @ 2017-06-05 11:22 UTC (permalink / raw)
To: u-boot
On 06/05/2017 08:40 AM, Patrice CHOTARD wrote:
> Hi Marek
Hi,
[...]
>>> diff --git a/include/dwc3-sti-glue.h b/include/dwc3-sti-glue.h
>>> new file mode 100644
>>> index 0000000..2083427
>>> --- /dev/null
>>> +++ b/include/dwc3-sti-glue.h
>>> @@ -0,0 +1,43 @@
>>> +/*
>>> + * Copyright (c) 2017
>>> + * Patrice Chotard <patrice.chotard@st.com>
>>> + *
>>> + * SPDX-License-Identifier: GPL-2.0+
>>> + */
>>> +
>>> +#ifndef __DWC3_STI_UBOOT_H_
>>> +#define __DWC3_STI_UBOOT_H_
>>> +
>>> +#include <linux/usb/otg.h>
>>
>> Does this have to be in a separate header file ?
>
> This is needed for enum usb_dr_mode used in int sti_dwc3_init()
> prototype below.
So just wrap it into dwc3-sti-glue.c ?
>>> +/* glue registers */
>>> +#define CLKRST_CTRL 0x00
>>> +#define AUX_CLK_EN BIT(0)
>>> +#define SW_PIPEW_RESET_N BIT(4)
>>> +#define EXT_CFG_RESET_N BIT(8)
>>> +
>>> +#define XHCI_REVISION BIT(12)
>>> +
>>> +#define USB2_VBUS_MNGMNT_SEL1 0x2C
>>> +#define USB2_VBUS_UTMIOTG 0x1
>>> +
>>> +#define SEL_OVERRIDE_VBUSVALID(n) ((n) << 0)
>>> +#define SEL_OVERRIDE_POWERPRESENT(n) ((n) << 4)
>>> +#define SEL_OVERRIDE_BVALID(n) ((n) << 8)
>>> +
>>> +/* Static DRD configuration */
>>> +#define USB3_CONTROL_MASK 0xf77
>>> +
>>> +#define USB3_DEVICE_NOT_HOST BIT(0)
>>> +#define USB3_FORCE_VBUSVALID BIT(1)
>>> +#define USB3_DELAY_VBUSVALID BIT(2)
>>> +#define USB3_SEL_FORCE_OPMODE BIT(4)
>>> +#define USB3_FORCE_OPMODE(n) ((n) << 5)
>>> +#define USB3_SEL_FORCE_DPPULLDOWN2 BIT(8)
>>> +#define USB3_FORCE_DPPULLDOWN2 BIT(9)
>>> +#define USB3_SEL_FORCE_DMPULLDOWN2 BIT(10)
>>> +#define USB3_FORCE_DMPULLDOWN2 BIT(11)
>>> +
>>> +int sti_dwc3_init(enum usb_dr_mode mode);
>>> +
>>> +#endif /* __DWC3_STI_UBOOT_H_ */
>>>
>>
--
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 22+ messages in thread
* [U-Boot] [PATCH v7 04/10] usb: phy: Add STi USB2 PHY
2017-06-05 11:21 ` Marek Vasut
@ 2017-06-06 7:16 ` Patrice CHOTARD
0 siblings, 0 replies; 22+ messages in thread
From: Patrice CHOTARD @ 2017-06-06 7:16 UTC (permalink / raw)
To: u-boot
Hi Marek
On 06/05/2017 01:21 PM, Marek Vasut wrote:
> On 06/05/2017 08:58 AM, Patrice CHOTARD wrote:
>> Hi Marek
>>
>> On 06/03/2017 08:08 AM, Marek Vasut wrote:
>>> On 06/01/2017 02:05 PM, patrice.chotard at st.com wrote:
>>>> From: Patrice Chotard <patrice.chotard@st.com>
>>>>
>>>> This is the generic phy driver for the picoPHY ports
>>>> used by USB2/1.1 controllers. It is found on STiH407 SoC
>>>> family from STMicroelectronics.
>>>>
>>>> Signed-off-by: Patrice Chotard <patrice.chotard@st.com>
>>>> Reviewed-by: Marek Vasut <marex@denx.de>
>>>> ---
>>>> v7: _ replace fdtdec_parse_phandle_with_args() by dev_read_phandle_with_args()
>>>> _ replace uclass_get_device_by_of_offset() by uclass_get_device_by_ofnode()
>>>>
>>>
>>> You should drop RB if you do significant changes.
>>>
>>>>
>>>> v5: _ add Reviewed-by: Marek Vasut <marex@denx.de>
>>>>
>>>> v4: _ update to use the new PHY uclass currently available on dm-next branch
>>>>
>>>> v3: _ convert driver to USB PHY uclass
>>>>
>>>> v2: _ replace bitfield_replace() by clrsetbits_le32()
>>>>
>>>> doc/device-tree-bindings/phy/phy-stih407-usb.txt | 24 +++
>>>> drivers/phy/Kconfig | 8 +
>>>> drivers/phy/Makefile | 1 +
>>>> drivers/phy/sti_usb_phy.c | 181 +++++++++++++++++++++++
>>>> 4 files changed, 214 insertions(+)
>>>> create mode 100644 doc/device-tree-bindings/phy/phy-stih407-usb.txt
>>>> create mode 100644 drivers/phy/sti_usb_phy.c
>>>>
>>>> diff --git a/doc/device-tree-bindings/phy/phy-stih407-usb.txt b/doc/device-tree-bindings/phy/phy-stih407-usb.txt
>>>> new file mode 100644
>>>> index 0000000..de6a706
>>>> --- /dev/null
>>>> +++ b/doc/device-tree-bindings/phy/phy-stih407-usb.txt
>>>> @@ -0,0 +1,24 @@
>>>> +ST STiH407 USB PHY controller
>>>> +
>>>> +This file documents the dt bindings for the usb picoPHY driver which is the PHY for both USB2 and USB3
>>>> +host controllers (when controlling usb2/1.1 devices) available on STiH407 SoC family from STMicroelectronics.
>>>> +
>>>> +Required properties:
>>>> +- compatible : should be "st,stih407-usb2-phy"
>>>> +- st,syscfg : phandle of sysconfig bank plus integer array containing phyparam and phyctrl register offsets
>>>> +- resets : list of phandle and reset specifier pairs. There should be two entries, one
>>>> + for the whole phy and one for the port
>>>> +- reset-names : list of reset signal names. Should be "global" and "port"
>>>> +See: Documentation/devicetree/bindings/reset/st,sti-powerdown.txt
>>>> +See: Documentation/devicetree/bindings/reset/reset.txt
>>>> +
>>>> +Example:
>>>> +
>>>> +usb2_picophy0: usbpicophy at f8 {
>>>
>>> This example uses address, but has no reg property ?
>>
>> Agree, but following advices from Arnd Bergman about not mixing address
>> space and sysconfig registers int the reg property, the reg property was
>> removed.
>>
>> For more details, see https://patches.linaro.org/patch/44081/
>
> Then you should remove it from usbpicophy at f8 too .
Ok
>
> [...]
>
^ permalink raw reply [flat|nested] 22+ messages in thread
* [U-Boot] [PATCH v7 07/10] usb: dwc3: Add dwc3 glue driver support for STi
2017-06-05 11:22 ` Marek Vasut
@ 2017-06-06 7:26 ` Patrice CHOTARD
0 siblings, 0 replies; 22+ messages in thread
From: Patrice CHOTARD @ 2017-06-06 7:26 UTC (permalink / raw)
To: u-boot
Hi Marek
On 06/05/2017 01:22 PM, Marek Vasut wrote:
> On 06/05/2017 08:40 AM, Patrice CHOTARD wrote:
>> Hi Marek
>
> Hi,
>
> [...]
>
>>>> diff --git a/include/dwc3-sti-glue.h b/include/dwc3-sti-glue.h
>>>> new file mode 100644
>>>> index 0000000..2083427
>>>> --- /dev/null
>>>> +++ b/include/dwc3-sti-glue.h
>>>> @@ -0,0 +1,43 @@
>>>> +/*
>>>> + * Copyright (c) 2017
>>>> + * Patrice Chotard <patrice.chotard@st.com>
>>>> + *
>>>> + * SPDX-License-Identifier: GPL-2.0+
>>>> + */
>>>> +
>>>> +#ifndef __DWC3_STI_UBOOT_H_
>>>> +#define __DWC3_STI_UBOOT_H_
>>>> +
>>>> +#include <linux/usb/otg.h>
>>>
>>> Does this have to be in a separate header file ?
>>
>> This is needed for enum usb_dr_mode used in int sti_dwc3_init()
>> prototype below.
>
> So just wrap it into dwc3-sti-glue.c ?
>
ok
>>>> +/* glue registers */
>>>> +#define CLKRST_CTRL 0x00
>>>> +#define AUX_CLK_EN BIT(0)
>>>> +#define SW_PIPEW_RESET_N BIT(4)
>>>> +#define EXT_CFG_RESET_N BIT(8)
>>>> +
>>>> +#define XHCI_REVISION BIT(12)
>>>> +
>>>> +#define USB2_VBUS_MNGMNT_SEL1 0x2C
>>>> +#define USB2_VBUS_UTMIOTG 0x1
>>>> +
>>>> +#define SEL_OVERRIDE_VBUSVALID(n) ((n) << 0)
>>>> +#define SEL_OVERRIDE_POWERPRESENT(n) ((n) << 4)
>>>> +#define SEL_OVERRIDE_BVALID(n) ((n) << 8)
>>>> +
>>>> +/* Static DRD configuration */
>>>> +#define USB3_CONTROL_MASK 0xf77
>>>> +
>>>> +#define USB3_DEVICE_NOT_HOST BIT(0)
>>>> +#define USB3_FORCE_VBUSVALID BIT(1)
>>>> +#define USB3_DELAY_VBUSVALID BIT(2)
>>>> +#define USB3_SEL_FORCE_OPMODE BIT(4)
>>>> +#define USB3_FORCE_OPMODE(n) ((n) << 5)
>>>> +#define USB3_SEL_FORCE_DPPULLDOWN2 BIT(8)
>>>> +#define USB3_FORCE_DPPULLDOWN2 BIT(9)
>>>> +#define USB3_SEL_FORCE_DMPULLDOWN2 BIT(10)
>>>> +#define USB3_FORCE_DMPULLDOWN2 BIT(11)
>>>> +
>>>> +int sti_dwc3_init(enum usb_dr_mode mode);
>>>> +
>>>> +#endif /* __DWC3_STI_UBOOT_H_ */
>>>>
>>>
>
>
^ permalink raw reply [flat|nested] 22+ messages in thread
end of thread, other threads:[~2017-06-06 7:26 UTC | newest]
Thread overview: 22+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-01 12:05 [U-Boot] [PATCH v7 00/10] STiH410-B2260: add reset, usb and fastboot support patrice.chotard at st.com
2017-06-01 12:05 ` [U-Boot] [PATCH v7 01/10] mmc: sti_sdhci: Rework sti_mmc_core_config() patrice.chotard at st.com
2017-06-01 12:05 ` [U-Boot] [PATCH v7 02/10] ARM: dts: stih410-family: Add missing reset_names for mmc1 node patrice.chotard at st.com
2017-06-01 12:05 ` [U-Boot] [PATCH v7 03/10] mmc: sti_sdhci: Use reset framework patrice.chotard at st.com
2017-06-01 12:05 ` [U-Boot] [PATCH v7 04/10] usb: phy: Add STi USB2 PHY patrice.chotard at st.com
2017-06-02 2:56 ` Simon Glass
2017-06-03 6:08 ` Marek Vasut
2017-06-05 6:58 ` Patrice CHOTARD
2017-06-05 11:21 ` Marek Vasut
2017-06-06 7:16 ` Patrice CHOTARD
2017-06-01 12:05 ` [U-Boot] [PATCH v7 05/10] STiH410-B2260: enable USB Host Networking patrice.chotard at st.com
2017-06-01 12:05 ` [U-Boot] [PATCH v7 06/10] STiH410-B2260: enable USB, fastboot, reset, PHY related flags patrice.chotard at st.com
2017-06-01 12:05 ` [U-Boot] [PATCH v7 07/10] usb: dwc3: Add dwc3 glue driver support for STi patrice.chotard at st.com
2017-06-03 6:06 ` Marek Vasut
2017-06-05 6:40 ` Patrice CHOTARD
2017-06-05 11:22 ` Marek Vasut
2017-06-06 7:26 ` Patrice CHOTARD
2017-06-01 12:05 ` [U-Boot] [PATCH v7 08/10] ARM: dts: STiH410: set DWC3 dual role mode to peripheral patrice.chotard at st.com
2017-06-02 2:56 ` Simon Glass
2017-06-01 12:05 ` [U-Boot] [PATCH v7 09/10] ARM: dts: STiH410: update ehci and ohci compatible patrice.chotard at st.com
2017-06-02 2:56 ` Simon Glass
2017-06-01 12:05 ` [U-Boot] [PATCH v7 10/10] board: STiH410-B2260: add fastboot support patrice.chotard at st.com
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.