All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Parag Warudkar" <parag.warudkar@gmail.com>
To: xiyou.wangcong@gmail.com
Cc: linux-kernel@vger.kernel.org
Subject: RE: [-mm3 PATCH] (Retry) Check the return value of kobject_add and etc.
Date: Sun, 1 Apr 2007 04:22:30 -0400	[thread overview]
Message-ID: <82e4877d0704010122g24fcd0f2r717f98b1494225e6@mail.gmail.com> (raw)

>-	kobject_add(&p->kobj);
>+	if (kobject_add(&p->kobj)) {
>+		kfree(p);
>+		return;

Please add a printk warning before the return statement to log a
proper warning stating what happened, which file and line etc. That
way people can know why something did not work as expected and
hopefully do something about it.

Parag

             reply	other threads:[~2007-04-01  8:22 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-01  8:22 Parag Warudkar [this message]
2007-04-01 13:46 ` [-mm3 PATCH] (Retry) Check the return value of kobject_add and etc Parag Warudkar
  -- strict thread matches above, loose matches on Subject: below --
2007-04-01  7:32 Cong WANG
2007-04-02 11:01 ` Cornelia Huck
2007-04-05  4:54   ` WANG Cong
2007-04-05  9:11     ` Cornelia Huck
2007-04-05 14:44       ` WANG Cong
2007-04-05 15:05         ` Cornelia Huck
2007-04-05 15:27           ` WANG Cong
2007-04-05 16:00             ` Cornelia Huck
2007-04-06  2:53               ` WANG Cong
2007-04-10 12:31                 ` Cornelia Huck
2007-04-10 14:08                   ` WANG Cong
2007-04-10 22:18                     ` Andrew Morton
2007-04-11  6:45                       ` WANG Cong
2007-04-11  7:19                         ` Andrew Morton
2007-04-11  9:24                       ` Cornelia Huck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=82e4877d0704010122g24fcd0f2r717f98b1494225e6@mail.gmail.com \
    --to=parag.warudkar@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.