From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Saravana Kannan" Subject: Re: [PATCH 1/2] clk: Fix error handling in fixed clock hardware type register fn Date: Tue, 20 Mar 2012 23:33:05 -0700 (PDT) Message-ID: <82f47abcdd341a5071f8c0a178d52310.squirrel@www.codeaurora.org> References: <1332214706-675-1-git-send-email-skannan@codeaurora.org> <20120320071957.GH3852@pengutronix.de> <348585ed29fb3ff171267c03658e6c0d.squirrel@www.codeaurora.org> <4F693DD8.7070305@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT Return-path: Received: from wolverine02.qualcomm.com ([199.106.114.251]:5912 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754890Ab2CUGdG (ORCPT ); Wed, 21 Mar 2012 02:33:06 -0400 In-Reply-To: Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: "Turquette, Mike" Cc: Saravana Kannan , Sascha Hauer , Andrew Lunn , Grant Likely , Jamie Iles , Jeremy Kerr , Magnus Damm , Deepak Saxena , linux-arm-kernel@lists.infradead.org, Arnd Bergman , linux-arm-msm@vger.kernel.org, Rob Herring , Russell King , Thomas Gleixner , Richard Zhao , Shawn Guo , Paul Walmsley , Linus Walleij , Mark Brown , Stephen Boyd , linux-kernel@vger.kernel.org, Amit Kucheria On Tue, March 20, 2012 10:45 pm, Turquette, Mike wrote: > IIRC, that discussion was with respect to the .parent member of struct > clk. It was decided that having .parent = NULL does not imply that a > clock is a root clock, but instead we rely on the CLK_IS_ROOT flag. I > can't think of any other instance where a NULL clk when returned from > a registration function would be useful. I wasn't referring to a discussion with regards to this patch series. I'm referring to what I believe was a discussion with Russell King on whether a NULL from clk_get() should be considered a clock and whether it should be usable as a "clock" with the clock APIs. That's the reason clk_get() returns -ENOENT instead of NULL. -Saravana -- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756648Ab2CUGdH (ORCPT ); Wed, 21 Mar 2012 02:33:07 -0400 Received: from wolverine02.qualcomm.com ([199.106.114.251]:5912 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754890Ab2CUGdG (ORCPT ); Wed, 21 Mar 2012 02:33:06 -0400 X-IronPort-AV: E=McAfee;i="5400,1158,6655"; a="172026760" Message-ID: <82f47abcdd341a5071f8c0a178d52310.squirrel@www.codeaurora.org> In-Reply-To: References: <1332214706-675-1-git-send-email-skannan@codeaurora.org> <20120320071957.GH3852@pengutronix.de> <348585ed29fb3ff171267c03658e6c0d.squirrel@www.codeaurora.org> <4F693DD8.7070305@codeaurora.org> Date: Tue, 20 Mar 2012 23:33:05 -0700 (PDT) Subject: Re: [PATCH 1/2] clk: Fix error handling in fixed clock hardware type register fn From: "Saravana Kannan" To: "Turquette, Mike" Cc: "Saravana Kannan" , "Sascha Hauer" , "Andrew Lunn" , "Grant Likely" , "Jamie Iles" , "Jeremy Kerr" , "Magnus Damm" , "Deepak Saxena" , linux-arm-kernel@lists.infradead.org, "Arnd Bergman" , linux-arm-msm@vger.kernel.org, "Rob Herring" , "Russell King" , "Thomas Gleixner" , "Richard Zhao" , "Shawn Guo" , "Paul Walmsley" , "Linus Walleij" , "Mark Brown" , "Stephen Boyd" , linux-kernel@vger.kernel.org, "Amit Kucheria" User-Agent: SquirrelMail/1.4.17 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT X-Priority: 3 (Normal) Importance: Normal Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, March 20, 2012 10:45 pm, Turquette, Mike wrote: > IIRC, that discussion was with respect to the .parent member of struct > clk. It was decided that having .parent = NULL does not imply that a > clock is a root clock, but instead we rely on the CLK_IS_ROOT flag. I > can't think of any other instance where a NULL clk when returned from > a registration function would be useful. I wasn't referring to a discussion with regards to this patch series. I'm referring to what I believe was a discussion with Russell King on whether a NULL from clk_get() should be considered a clock and whether it should be usable as a "clock" with the clock APIs. That's the reason clk_get() returns -ENOENT instead of NULL. -Saravana -- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum. From mboxrd@z Thu Jan 1 00:00:00 1970 From: skannan@codeaurora.org (Saravana Kannan) Date: Tue, 20 Mar 2012 23:33:05 -0700 (PDT) Subject: [PATCH 1/2] clk: Fix error handling in fixed clock hardware type register fn In-Reply-To: References: <1332214706-675-1-git-send-email-skannan@codeaurora.org> <20120320071957.GH3852@pengutronix.de> <348585ed29fb3ff171267c03658e6c0d.squirrel@www.codeaurora.org> <4F693DD8.7070305@codeaurora.org> Message-ID: <82f47abcdd341a5071f8c0a178d52310.squirrel@www.codeaurora.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, March 20, 2012 10:45 pm, Turquette, Mike wrote: > IIRC, that discussion was with respect to the .parent member of struct > clk. It was decided that having .parent = NULL does not imply that a > clock is a root clock, but instead we rely on the CLK_IS_ROOT flag. I > can't think of any other instance where a NULL clk when returned from > a registration function would be useful. I wasn't referring to a discussion with regards to this patch series. I'm referring to what I believe was a discussion with Russell King on whether a NULL from clk_get() should be considered a clock and whether it should be usable as a "clock" with the clock APIs. That's the reason clk_get() returns -ENOENT instead of NULL. -Saravana -- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.