From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:38829) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hG57N-0005R3-GT for qemu-devel@nongnu.org; Mon, 15 Apr 2019 13:10:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hG57L-0000bb-LW for qemu-devel@nongnu.org; Mon, 15 Apr 2019 13:10:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54342) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hG57I-0000a1-Om for qemu-devel@nongnu.org; Mon, 15 Apr 2019 13:10:01 -0400 References: <20190415154503.6758-1-berrange@redhat.com> From: Eric Blake Message-ID: <83042152-1af4-a237-92a1-f56841623e89@redhat.com> Date: Mon, 15 Apr 2019 12:09:53 -0500 MIME-Version: 1.0 In-Reply-To: <20190415154503.6758-1-berrange@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ymvTUbF3rQUKbeYrVBWgwO5OqalrLIFOE" Subject: Re: [Qemu-devel] [PATCH for-4.0? 0/3] usb-mtp: fix ObjectInfo request handling List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= , qemu-devel@nongnu.org Cc: Peter Maydell , Thomas Huth , Greg Kurz , Bandan Das , Gerd Hoffmann This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ymvTUbF3rQUKbeYrVBWgwO5OqalrLIFOE From: Eric Blake To: =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= , qemu-devel@nongnu.org Cc: Peter Maydell , Thomas Huth , Greg Kurz , Bandan Das , Gerd Hoffmann Message-ID: <83042152-1af4-a237-92a1-f56841623e89@redhat.com> Subject: Re: [Qemu-devel] [PATCH for-4.0? 0/3] usb-mtp: fix ObjectInfo request handling References: <20190415154503.6758-1-berrange@redhat.com> In-Reply-To: <20190415154503.6758-1-berrange@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 4/15/19 10:45 AM, Daniel P. Berrang=C3=A9 wrote: > Two previous attempts to fix this due to GCC 9 highlighting > unaligned data access. My attempt: >=20 > https://lists.gnu.org/archive/html/qemu-devel/2019-03/msg07763.html >=20 > And a previous one: >=20 > https://lists.gnu.org/archive/html/qemu-devel/2019-02/msg07923.html > https://lists.gnu.org/archive/html/qemu-devel/2019-03/msg00162.html >=20 > There are a number of bugs in the USB MTP usb_mtp_write_metadata > method handling the filename character set conversion. >=20 > The 2nd patch in this series is a security flaw fix since the > code was not correctly validating guest provided data length. Given that this is a security flaw, I've added this series to https://wiki.qemu.org/Planning/4.0 in case you're hoping to get it in -rc= 4. --=20 Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org --ymvTUbF3rQUKbeYrVBWgwO5OqalrLIFOE Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEccLMIrHEYCkn0vOqp6FrSiUnQ2oFAly0uuEACgkQp6FrSiUn Q2qtrAf9FBnDMipEPR1LxroU6iUSRcgJAAC8V2LFFCBNABhfNRY9zycrjQicUSuP Jg3G9aqLqsmHEi3vIFSnVJCb4zoNZacpH+2L705AhWfzryLXujbEA7FVfjPBIRZ8 mXfL7UEnj7IuaSoh9xUdCRJra9twzztrJL4WwGWCkF6OaKg3gTxIlEipbLzZ67HV Cq0VTurx+riwGnXOyQbvbrsnG15PZ8X8I2FcaXcHBR9c3R83vMdxb7hIh14ywPY1 AgX3amSNAfcE+xP9YybgmYCwUb4tGnwOJvfcl2jawUO6JlLSMM7/qMdYO87bNB75 SobAKQGALjiMQ8/Z/gGWQImptAJi5A== =cnl7 -----END PGP SIGNATURE----- --ymvTUbF3rQUKbeYrVBWgwO5OqalrLIFOE-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9578BC10F0E for ; Mon, 15 Apr 2019 17:11:03 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6764F2075B for ; Mon, 15 Apr 2019 17:11:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6764F2075B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:53440 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hG58I-0005uF-FQ for qemu-devel@archiver.kernel.org; Mon, 15 Apr 2019 13:11:02 -0400 Received: from eggs.gnu.org ([209.51.188.92]:38829) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hG57N-0005R3-GT for qemu-devel@nongnu.org; Mon, 15 Apr 2019 13:10:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hG57L-0000bb-LW for qemu-devel@nongnu.org; Mon, 15 Apr 2019 13:10:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54342) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hG57I-0000a1-Om for qemu-devel@nongnu.org; Mon, 15 Apr 2019 13:10:01 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B7704308794C; Mon, 15 Apr 2019 17:09:59 +0000 (UTC) Received: from [10.3.117.110] (ovpn-117-110.phx2.redhat.com [10.3.117.110]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9E8A95C1A1; Mon, 15 Apr 2019 17:09:54 +0000 (UTC) To: =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= , qemu-devel@nongnu.org References: <20190415154503.6758-1-berrange@redhat.com> From: Eric Blake Openpgp: preference=signencrypt Autocrypt: addr=eblake@redhat.com; keydata= xsBNBEvHyWwBCACw7DwsQIh0kAbUXyqhfiKAKOTVu6OiMGffw2w90Ggrp4bdVKmCaEXlrVLU xphBM8mb+wsFkU+pq9YR621WXo9REYVIl0FxKeQo9dyQBZ/XvmUMka4NOmHtFg74nvkpJFCD TUNzmqfcjdKhfFV0d7P/ixKQeZr2WP1xMcjmAQY5YvQ2lUoHP43m8TtpB1LkjyYBCodd+LkV GmCx2Bop1LSblbvbrOm2bKpZdBPjncRNob73eTpIXEutvEaHH72LzpzksfcKM+M18cyRH+nP sAd98xIbVjm3Jm4k4d5oQyE2HwOur+trk2EcxTgdp17QapuWPwMfhaNq3runaX7x34zhABEB AAHNHkVyaWMgQmxha2UgPGVibGFrZUByZWRoYXQuY29tPsLAegQTAQgAJAIbAwULCQgHAwUV CgkICwUWAgMBAAIeAQIXgAUCS8fL9QIZAQAKCRCnoWtKJSdDahBHCACbl/5FGkUqJ89GAjeX RjpAeJtdKhujir0iS4CMSIng7fCiGZ0fNJCpL5RpViSo03Q7l37ss+No+dJI8KtAp6ID+PMz wTJe5Egtv/KGUKSDvOLYJ9WIIbftEObekP+GBpWP2+KbpADsc7EsNd70sYxExD3liwVJYqLc Rw7so1PEIFp+Ni9A1DrBR5NaJBnno2PHzHPTS9nmZVYm/4I32qkLXOcdX0XElO8VPDoVobG6 gELf4v/vIImdmxLh/w5WctUpBhWWIfQDvSOW2VZDOihm7pzhQodr3QP/GDLfpK6wI7exeu3P pfPtqwa06s1pae3ad13mZGzkBdNKs1HEm8x6zsBNBEvHyWwBCADGkMFzFjmmyqAEn5D+Mt4P zPdO8NatsDw8Qit3Rmzu+kUygxyYbz52ZO40WUu7EgQ5kDTOeRPnTOd7awWDQcl1gGBXgrkR pAlQ0l0ReO57Q0eglFydLMi5bkwYhfY+TwDPMh3aOP5qBXkm4qIYSsxb8A+i00P72AqFb9Q7 3weG/flxSPApLYQE5qWGSXjOkXJv42NGS6o6gd4RmD6Ap5e8ACo1lSMPfTpGzXlt4aRkBfvb NCfNsQikLZzFYDLbQgKBA33BDeV6vNJ9Cj0SgEGOkYyed4I6AbU0kIy1hHAm1r6+sAnEdIKj cHi3xWH/UPrZW5flM8Kqo14OTDkI9EtlABEBAAHCwF8EGAEIAAkFAkvHyWwCGwwACgkQp6Fr SiUnQ2q03wgAmRFGDeXzc58NX0NrDijUu0zx3Lns/qZ9VrkSWbNZBFjpWKaeL1fdVeE4TDGm I5mRRIsStjQzc2R9b+2VBUhlAqY1nAiBDv0Qnt+9cLiuEICeUwlyl42YdwpmY0ELcy5+u6wz mK/jxrYOpzXKDwLq5k4X+hmGuSNWWAN3gHiJqmJZPkhFPUIozZUCeEc76pS/IUN72NfprZmF Dp6/QDjDFtfS39bHSWXKVZUbqaMPqlj/z6Ugk027/3GUjHHr8WkeL1ezWepYDY7WSoXwfoAL 2UXYsMAr/uUncSKlfjvArhsej0S4zbqim2ZY6S8aRWw94J3bSvJR+Nwbs34GPTD4Pg== Organization: Red Hat, Inc. Message-ID: <83042152-1af4-a237-92a1-f56841623e89@redhat.com> Date: Mon, 15 Apr 2019 12:09:53 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190415154503.6758-1-berrange@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ymvTUbF3rQUKbeYrVBWgwO5OqalrLIFOE" X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.45]); Mon, 15 Apr 2019 17:09:59 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 X-Content-Filtered-By: Mailman/MimeDel 2.1.21 Subject: Re: [Qemu-devel] [PATCH for-4.0? 0/3] usb-mtp: fix ObjectInfo request handling X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bandan Das , Peter Maydell , Thomas Huth , Greg Kurz , Gerd Hoffmann Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Message-ID: <20190415170953.HfbEbNq3zsh7eCpWKYN_xGIr1_fX0rHdTmwKIFK9e1g@z> This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ymvTUbF3rQUKbeYrVBWgwO5OqalrLIFOE From: Eric Blake To: =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= , qemu-devel@nongnu.org Cc: Peter Maydell , Thomas Huth , Greg Kurz , Bandan Das , Gerd Hoffmann Message-ID: <83042152-1af4-a237-92a1-f56841623e89@redhat.com> Subject: Re: [Qemu-devel] [PATCH for-4.0? 0/3] usb-mtp: fix ObjectInfo request handling References: <20190415154503.6758-1-berrange@redhat.com> In-Reply-To: <20190415154503.6758-1-berrange@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 4/15/19 10:45 AM, Daniel P. Berrang=C3=A9 wrote: > Two previous attempts to fix this due to GCC 9 highlighting > unaligned data access. My attempt: >=20 > https://lists.gnu.org/archive/html/qemu-devel/2019-03/msg07763.html >=20 > And a previous one: >=20 > https://lists.gnu.org/archive/html/qemu-devel/2019-02/msg07923.html > https://lists.gnu.org/archive/html/qemu-devel/2019-03/msg00162.html >=20 > There are a number of bugs in the USB MTP usb_mtp_write_metadata > method handling the filename character set conversion. >=20 > The 2nd patch in this series is a security flaw fix since the > code was not correctly validating guest provided data length. Given that this is a security flaw, I've added this series to https://wiki.qemu.org/Planning/4.0 in case you're hoping to get it in -rc= 4. --=20 Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org --ymvTUbF3rQUKbeYrVBWgwO5OqalrLIFOE Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEccLMIrHEYCkn0vOqp6FrSiUnQ2oFAly0uuEACgkQp6FrSiUn Q2qtrAf9FBnDMipEPR1LxroU6iUSRcgJAAC8V2LFFCBNABhfNRY9zycrjQicUSuP Jg3G9aqLqsmHEi3vIFSnVJCb4zoNZacpH+2L705AhWfzryLXujbEA7FVfjPBIRZ8 mXfL7UEnj7IuaSoh9xUdCRJra9twzztrJL4WwGWCkF6OaKg3gTxIlEipbLzZ67HV Cq0VTurx+riwGnXOyQbvbrsnG15PZ8X8I2FcaXcHBR9c3R83vMdxb7hIh14ywPY1 AgX3amSNAfcE+xP9YybgmYCwUb4tGnwOJvfcl2jawUO6JlLSMM7/qMdYO87bNB75 SobAKQGALjiMQ8/Z/gGWQImptAJi5A== =cnl7 -----END PGP SIGNATURE----- --ymvTUbF3rQUKbeYrVBWgwO5OqalrLIFOE--