From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dpdk-stable] [PATCH v2] eventdev: make ethernet
	port identifiers 16 bit
Date: Thu, 10 May 2018 17:45:10 +0200
Message-ID: <8310826.PepUDZemRM@xps>
References: <1525893452-155596-1-git-send-email-nikhil.rao@intel.com>
 <1779610.xE5Tc50yFF@xps> <20180510151642.GA25202@jerin>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: Nikhil Rao <nikhil.rao@intel.com>, ferruh.yigit@intel.com,
 lei.a.yao@intel.com, dev@dpdk.org
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 87A271BB76
 for <dev@dpdk.org>; Thu, 10 May 2018 17:45:13 +0200 (CEST)
In-Reply-To: <20180510151642.GA25202@jerin>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

10/05/2018 17:16, Jerin Jacob:
> From: Thomas Monjalon <thomas@monjalon.net>
> > 10/05/2018 16:30, Jerin Jacob:
> > > From: Thomas Monjalon <thomas@monjalon.net>
> > > > 10/05/2018 06:31, Jerin Jacob:
> > > > > > Date: Thu, 10 May 2018 02:22:40 +0530
> > > > > > From: Nikhil Rao <nikhil.rao@intel.com>
> > > > > > 
> > > > > > Ethernet port ID data size has been extended to 16 bits size 17.11
> > > > > > Update the Rx event adapter interface and implementation accordingly.
> > > > > > 
> > > > > > Fixes: 9c38b704d280 ("eventdev: add eth Rx adapter implementation")
> > > > > > Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
> > > > > > Cc: stable@dpdk.org
> > > > > 
> > > > > Since it is an ABI change, please bump the library version.
> > > > > eth_rx_adapter still under experimental tag, IMO, no deprecation notice is
> > > > > required.
> > > > 
> > > > The ABI changes must be described in the release notes too.
> > > > 
> > > > There is no deprecation notice for this ABI change.
> > > > According the the policy, you must send a notice in 18.05,
> > > > and do the change in 18.08.
> > > 
> > > Even for the APIs with experimental tag?
> > 
> > No, experimental can change without prior notice.
> > 
> > > If so, I don't see any
> > > difference between experimental vs non experimental API? 
> > 
> > Rx adapter is not experimental as far as I know.
> 
> It is experimental. Please see the links.
> 
> http://dpdk.org/browse/dpdk/tree/MAINTAINERS#n351
> http://dpdk.org/browse/dpdk/tree/lib/librte_eventdev/rte_event_eth_rx_adapter.h#n276

Yes, you're right.
I've looked at the map file, where the symbols are not in EXPERIMENTAL block.

> If you agree then take dropped patch.

I'll take it.