From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B90E1C10F27 for ; Tue, 10 Mar 2020 11:36:22 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 874A52467F for ; Tue, 10 Mar 2020 11:36:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="zGZc/zjl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 874A52467F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:58348 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jBdBN-0000tW-Nb for qemu-devel@archiver.kernel.org; Tue, 10 Mar 2020 07:36:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49519) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jBdAi-0000US-Gf for qemu-devel@nongnu.org; Tue, 10 Mar 2020 07:35:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jBdAh-00064R-9i for qemu-devel@nongnu.org; Tue, 10 Mar 2020 07:35:40 -0400 Received: from aserp2120.oracle.com ([141.146.126.78]:34492) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jBdAg-0005xi-VD for qemu-devel@nongnu.org; Tue, 10 Mar 2020 07:35:39 -0400 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 02ABT6wk020636; Tue, 10 Mar 2020 11:35:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=cBLAl7RM52/EsqCDd+Y3gCDQDCxsCbb0AG102+zQYgg=; b=zGZc/zjl0d/9R8PzLGwEKkrMzvfuc4D7DoLhbA20n4k9kio9FORp27H/wfukUvxr3NSr GuNkjWKEYU5yClL8dL3uVvvdnJ0Q+oWNEKrY0N5vg3aGoRXaqH6LN7gT5NHmsdiyUMRM qjK62/RWwM1rjyJcyu/HK6tY9njgwGuVQnucj1f1JUEb/FJYGtPAZWYnUdygwr/WjlH9 OZDZ7DMSUNnFuXVqMLRMbLDI8Pnxj5vpddo1kY4eZyhe+VJkS+Fc8eMO2dUbNiZUwCvY F1Pq+sHFbnA5dUDggJZTj45tyHFTF2ZeTtvE0+RKaHlJWpwkbZEQMh5k3kKkIfdpKHXo WA== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by aserp2120.oracle.com with ESMTP id 2yp9v602ns-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 10 Mar 2020 11:35:34 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 02ABYJot003520; Tue, 10 Mar 2020 11:35:34 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by aserp3030.oracle.com with ESMTP id 2yp8pr2j8s-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 10 Mar 2020 11:35:33 +0000 Received: from abhmp0013.oracle.com (abhmp0013.oracle.com [141.146.116.19]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 02ABZVNJ021766; Tue, 10 Mar 2020 11:35:31 GMT Received: from [192.168.14.112] (/79.181.212.171) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 10 Mar 2020 04:35:30 -0700 Subject: Re: [PATCH 07/14] hw/i386/vmport: Add support for CMD_GETBIOSUUID To: "Michael S. Tsirkin" References: <20200309235411.76587-1-liran.alon@oracle.com> <20200309235411.76587-8-liran.alon@oracle.com> <20200310053305-mutt-send-email-mst@kernel.org> <9213671d-75e9-b4d6-6e3d-c9221c2b7cc4@oracle.com> <20200310071934-mutt-send-email-mst@kernel.org> From: Liran Alon Message-ID: <83140efe-8357-d8c6-500e-4618efc60144@oracle.com> Date: Tue, 10 Mar 2020 13:35:26 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200310071934-mutt-send-email-mst@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9555 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 malwarescore=0 mlxlogscore=999 bulkscore=0 suspectscore=0 mlxscore=0 spamscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2001150001 definitions=main-2003100077 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9555 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 spamscore=0 mlxscore=0 priorityscore=1501 lowpriorityscore=0 bulkscore=0 mlxlogscore=999 phishscore=0 adultscore=0 clxscore=1015 impostorscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2001150001 definitions=main-2003100077 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy] X-Received-From: 141.146.126.78 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ehabkost@redhat.com, qemu-devel@nongnu.org, Nikita Leshenko , pbonzini@redhat.com, rth@twiddle.net Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 10/03/2020 13:22, Michael S. Tsirkin wrote: > On Tue, Mar 10, 2020 at 01:13:21PM +0200, Liran Alon wrote: >> On 10/03/2020 11:34, Michael S. Tsirkin wrote: >>> On Tue, Mar 10, 2020 at 01:54:04AM +0200, Liran Alon wrote: >>>> This is VMware documented functionallity that some guests rely on. >>>> Returns the BIOS UUID of the current virtual machine. >>>> >>>> Reviewed-by: Nikita Leshenko >>>> Signed-off-by: Liran Alon >>> So this at least seems guest-visible. >>> >>> So I suspect you need to add properties to >>> disable this for old machine types, to avoid >>> breaking compatibility with live-migration. >> It is indeed guest visible. >> In theory, you are right that for every guest-visible change, we should make >> sure to expose it to only new machine-types. >> >> However, in this case, I feel it just unnecessary over-complicates the code. >> I don't see how a guest which previously failed to use this command, will >> fail because after Live-Migration it could succeed. > The reverse can happen, start guest on a new qemu, command seems to > work, then we migrate and it fails. > > And I guess this applies to the version right? Hmm good point. For backwards migration this could indeed be an issue. Making the existence of these commands tied to machine-type should suffice. Regarding vmx-version, because we haven't changed it yet (only created property), we should be fine. On first patch that changes it, we need to tie it to machine-type as-well. > >> If you insist, I will add such functionality. In that case, do you think a >> single flag will suffice for the addition of all new commands >> (i.e. "commands-version" that it's number specifies set of commands to >> expose), or you want to have a per-command flag? >> >> -Liran > Can be a single flag but I'd just do it a boolean that enables a group > of commands. E.g. "commands-v2". Ok. Will do. Thanks, -Liran