From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ross Philipson <Ross.Philipson@citrix.com>
Subject: RE: FLR support in xl tool stack
Date: Fri, 28 Jan 2011 11:10:47 -0500
Message-ID: <831D55AF5A11D64C9B4B43F59EEBF7205F92409A6D@FTLPMAILBOX02.citrite.net>
References: <987664A83D2D224EAE907B061CE93D53019438F9F8@orsmsx505.amr.corp.intel.com>
	<AANLkTikW-Rub9WtYCW7k2P1mDFZ=L3tUoFHPL9-JukQQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <AANLkTikW-Rub9WtYCW7k2P1mDFZ=L3tUoFHPL9-JukQQ@mail.gmail.com>
Content-Language: en-US
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Jean Guyader <jean.guyader@gmail.com>, "Kay, Allen M" <allen.m.kay@intel.com>
Cc: Thomas, xen-devel <xen-devel@lists.xensource.com>, Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>, Wilk <konrad.wilk@oracle.com>, Jean Guyader <Jean.Guyader@citrix.com>, Ian Campbell <Ian.Campbell@eu.citrix.com>, Horsten <thomas.horsten@citrix.com>
List-Id: xen-devel@lists.xenproject.org

Yeah when I first implemented this in pciback is was looking for a common p=
lace since the existing FLR logic was in the xend tool-stack (which we were=
 not using). Also folks on xen-devel had suggested it go in pciback at the =
time.

I am not familiar with what reset functionality is in pci in newer kernels =
(there was not a lot in the .27 one) but a lot of what I put in pciback was=
 specific to resetting the Intel graphics device on GM45 and Q45 chipsets.

Thanks
Ross

-----Original Message-----
From: Jean Guyader [mailto:jean.guyader@gmail.com]=20
Sent: Thursday, January 27, 2011 11:20 PM
To: Kay, Allen M
Cc: xen-devel; Wilk; Stefano Stabellini; Jean Guyader; Ian Campbell; Thomas=
 Horsten; Ross Philipson
Subject: Re: [Xen-devel] FLR support in xl tool stack

On 28 January 2011 08:38, Kay, Allen M <allen.m.kay@intel.com> wrote:
> In xm tool stack, there is a function called do_FLR() located in python/x=
en/util/pci.py that takes care of issuing FLR to passthrough PCI devices. =
=A0This function is responsible for looking at the device and figure out th=
e most appropriate way to reset the device (PCI/PCIe FLR, secondary bus res=
et, etc...).
>
> In xl tool stack, I see there is a libxl_device_pci_reset() in libxl/libx=
l_pci.c that suppose to do the similar thing. =A0It references /sys/bus/pci=
/drivers/pciback/do_flr and tries to write something to it. =A0However, pci=
back driver in 2.6.32.27 pvops kernel does not seem to have this do_flr fun=
ctionality.
>
> Is this something being worked on but not checked in to pvops dom0 kernel=
 yet?
>
> If not, I would prefer implementing all of the do_FLR() functionaility in=
 libxl and not to depend on pciback driver given it is not part of the upst=
ream kernel. =A0This will make using newer kernels such as 2.6.38 much easi=
er.
>
> Comments?
>

On the newest kernels (I don't know from which version), the reset function=
 has been moved under the pci device tree directly. So /sys/bus/pci/device/=
<BDF>/reset.

Jean