All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nathan Chancellor <nathan@kernel.org>
To: Dmitry Osipenko <digetx@gmail.com>,
	Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Stephen Boyd <sboyd@kernel.org>,
	Mikko Perttunen <mperttunen@nvidia.com>
Cc: linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org,
	linux-clk@vger.kernel.org
Subject: Re: [PATCH v2 3/4] memory: tegra124-emc: Fix compilation warnings on 64bit platforms
Date: Sun, 16 May 2021 23:26:51 -0700	[thread overview]
Message-ID: <831d3af5-1e4a-f3c0-f69d-3fff145fde08@kernel.org> (raw)
In-Reply-To: <20210516161214.4693-4-digetx@gmail.com>

On 5/16/2021 9:12 AM, Dmitry Osipenko wrote:
> Fix compilation warning on 64bit platforms caused by implicit promotion
> of 32bit signed integer to a 64bit unsigned value which happens after
> enabling compile-testing of the driver.
> 
> Suggested-by: Nathan Chancellor <nathan@kernel.org>
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>

Reviewed-by: Nathan Chancellor <nathan@kernel.org>

> ---
>   drivers/memory/tegra/tegra124-emc.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/memory/tegra/tegra124-emc.c b/drivers/memory/tegra/tegra124-emc.c
> index 5699d909abc2..c9eb948cf4df 100644
> --- a/drivers/memory/tegra/tegra124-emc.c
> +++ b/drivers/memory/tegra/tegra124-emc.c
> @@ -272,8 +272,8 @@
>   #define EMC_PUTERM_ADJ				0x574
>   
>   #define DRAM_DEV_SEL_ALL			0
> -#define DRAM_DEV_SEL_0				(2 << 30)
> -#define DRAM_DEV_SEL_1				(1 << 30)
> +#define DRAM_DEV_SEL_0				(2u << 30)
> +#define DRAM_DEV_SEL_1				(1u << 30)
>   
>   #define EMC_CFG_POWER_FEATURES_MASK		\
>   	(EMC_CFG_DYN_SREF | EMC_CFG_DRAM_ACPD | EMC_CFG_DRAM_CLKSTOP_SR | \
> 


  reply	other threads:[~2021-05-17  6:26 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-16 16:12 [PATCH v2 0/4] Enable compile-testing of Tegra memory drivers Dmitry Osipenko
2021-05-16 16:12 ` [PATCH v2 1/4] soc/tegra: fuse: Add missing stubs Dmitry Osipenko
2021-05-16 16:12 ` [PATCH v2 2/4] clk: tegra: Add stubs needed for compile-testing Dmitry Osipenko
2021-05-16 16:12 ` [PATCH v2 3/4] memory: tegra124-emc: Fix compilation warnings on 64bit platforms Dmitry Osipenko
2021-05-17  6:26   ` Nathan Chancellor [this message]
2021-05-17 11:28   ` Krzysztof Kozlowski
2021-05-17 13:35     ` Dmitry Osipenko
2021-05-17 13:39       ` Krzysztof Kozlowski
2021-05-17 13:47         ` Dmitry Osipenko
2021-05-17 14:04           ` Krzysztof Kozlowski
2021-05-17 14:23             ` Dmitry Osipenko
2021-05-17 14:24   ` Krzysztof Kozlowski
2021-05-17 14:53     ` Dmitry Osipenko
2021-05-16 16:12 ` [PATCH v2 4/4] memory: tegra: Enable compile testing for all drivers Dmitry Osipenko
2021-05-17 11:33   ` Krzysztof Kozlowski
2021-05-17 11:32 ` [PATCH v2 0/4] Enable compile-testing of Tegra memory drivers Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=831d3af5-1e4a-f3c0-f69d-3fff145fde08@kernel.org \
    --to=nathan@kernel.org \
    --cc=digetx@gmail.com \
    --cc=jonathanh@nvidia.com \
    --cc=krzysztof.kozlowski@canonical.com \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=mperttunen@nvidia.com \
    --cc=sboyd@kernel.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.