From: Laurent Vivier <laurent@vivier.eu>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Subject: Re: [PATCH 1/5] linux-user/alpha: Fix sigsuspend for big-endian hosts
Date: Tue, 22 Mar 2022 10:58:20 +0100 [thread overview]
Message-ID: <831d87d4-49fb-e738-bed8-2b5af96bfa4f@vivier.eu> (raw)
In-Reply-To: <20220315084308.433109-2-richard.henderson@linaro.org>
Le 15/03/2022 à 09:43, Richard Henderson a écrit :
> On alpha, the sigset argument for sigsuspend is in a register.
> When we drop that into memory that happens in host-endianness,
> but target_to_host_old_sigset will treat it as target-endianness.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> linux-user/syscall.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index b9b18a7eaf..ecd00382a8 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -9559,7 +9559,8 @@ static abi_long do_syscall1(void *cpu_env, int num, abi_long arg1,
> {
> TaskState *ts = cpu->opaque;
> #if defined(TARGET_ALPHA)
> - abi_ulong mask = arg1;
> + /* target_to_host_old_sigset will bswap back */
> + abi_ulong mask = tswapal(arg1);
> target_to_host_old_sigset(&ts->sigsuspend_mask, &mask);
> #else
> if (!(p = lock_user(VERIFY_READ, arg1, sizeof(target_sigset_t), 1)))
And what about target_set in TARGET_NR_ssetmask, mask in TARGET_NR_sigprocmask and in
TARGET_NR_osf_sigprocmask?
Thanks,
Laurent
next prev parent reply other threads:[~2022-03-22 10:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-15 8:43 [PATCH 0/5] linux-user: signal mask fixes for pselect et al Richard Henderson
2022-03-15 8:43 ` [PATCH 1/5] linux-user/alpha: Fix sigsuspend for big-endian hosts Richard Henderson
2022-03-22 9:58 ` Laurent Vivier [this message]
2022-03-22 11:31 ` Laurent Vivier
2022-03-15 8:43 ` [PATCH 2/5] linux-user: Split out helpers for sigsuspend Richard Henderson
2022-03-22 10:12 ` Laurent Vivier
2022-03-15 8:43 ` [PATCH 3/5] linux-user: Properly handle sigset arg to pselect Richard Henderson
2022-03-22 11:26 ` Laurent Vivier
2022-03-15 8:43 ` [PATCH 4/5] linux-user: Properly handle sigset arg to epoll_pwait Richard Henderson
2022-03-22 11:27 ` Laurent Vivier
2022-03-15 8:43 ` [PATCH 5/5] linux-user: Properly handle sigset arg to ppoll Richard Henderson
2022-03-22 11:28 ` Laurent Vivier
2022-03-22 11:32 ` [PATCH 0/5] linux-user: signal mask fixes for pselect et al Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=831d87d4-49fb-e738-bed8-2b5af96bfa4f@vivier.eu \
--to=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.