All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hui Wang <hui.wang@canonical.com>
To: alsa-devel@alsa-project.org
Subject: Re: [PATCH] ALSA: hda/hdmi: let new platforms assign the pcm slot dynamically
Date: Wed, 24 Feb 2021 10:24:59 +0800	[thread overview]
Message-ID: <831dac8a-a36d-8ed7-556a-ff0e848f53be@canonical.com> (raw)
In-Reply-To: <s5hpn0rue0e.wl-tiwai@suse.de>


On 2/23/21 9:09 PM, Takashi Iwai wrote:
> On Tue, 23 Feb 2021 13:22:05 +0100,
> Hui Wang wrote:
>> If the platform set the dyn_pcm_assign to true, it will call
>> hdmi_find_pcm_slot() to find a pcm slot when hdmi/dp monitor is
>> connected and need to create a pcm.
>>
>> So far only intel_hsw_common_init() and patch_nvhdmi() set the
>> dyn_pcm_assign to true, here we let tgl platforms assign the pcm slot
>> dynamically first, if the driver runs for a period of time and there
>> is no regression reported, we could set no_fixed_assgin to true in
>> the intel_hsw_common_init(), and then set it to true in the
>> patch_nvhdmi().
>>
>> This change comes from the discussion between Takashi and
>> Kai Vehmanen. Please refer to:
>> https://github.com/alsa-project/alsa-lib/pull/118
>>
>> Signed-off-by: Hui Wang <hui.wang@canonical.com>
> As this would "fix" actual use cases, I'd love to merge this for 5.12,
> but of course it needs to be verified beforehand.
>
> So this was actually tested in your side, right?
>
I tested it on TGL machines with Ubuntu,  both sof and legacy hda, so 
far there is no regression.

Regards,

Hui.

> thanks,
>
> Takashi
>

  reply	other threads:[~2021-02-24  2:26 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-23 12:22 [PATCH] ALSA: hda/hdmi: let new platforms assign the pcm slot dynamically Hui Wang
2021-02-23 13:09 ` Takashi Iwai
2021-02-24  2:24   ` Hui Wang [this message]
2021-02-23 14:14 ` Kai Vehmanen
2021-02-23 16:25   ` Jaroslav Kysela
2021-02-23 16:33     ` Takashi Iwai
2021-02-23 17:51       ` Kai Vehmanen
2021-02-24  2:22         ` Hui Wang
2021-02-24 10:17           ` Kai Vehmanen
2021-02-25  8:35             ` Hui Wang
2021-02-24  2:32   ` Hui Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=831dac8a-a36d-8ed7-556a-ff0e848f53be@canonical.com \
    --to=hui.wang@canonical.com \
    --cc=alsa-devel@alsa-project.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.