All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chanwoo Choi <cwchoi00@gmail.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Rob Herring <robh+dt@kernel.org>,
	Chanwoo Choi <cw00.choi@samsung.com>,
	MyungJoo Ham <myungjoo.ham@samsung.com>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-pm@vger.kernel.org
Cc: Marek Szyprowski <m.szyprowski@samsung.com>,
	Sylwester Nawrocki <snawrocki@kernel.org>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: Re: [PATCH v2 1/3] devfreq: exynos-ppmu: use node names with hyphens
Date: Wed, 22 Sep 2021 16:55:37 +0900	[thread overview]
Message-ID: <83206dd4-c779-1090-9394-2519d4747206@gmail.com> (raw)
In-Reply-To: <20210920071753.38560-1-krzysztof.kozlowski@canonical.com>

Hi Krzysztof,

On 21. 9. 20. 오후 4:17, Krzysztof Kozlowski wrote:
> Devicetree naming convention requires device node names to use hyphens
> instead of underscore, so Exynos5422 devfreq event name
> "ppmu-event3-dmc0_0" should be "ppmu-event3-dmc0-0".  Newly introduced
> dtschema enforces this, however the driver still expects old name with
> an underscore.
> 
> Add new events for Exynos5422 while still accepting old name for
> backwards compatibility.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
>   drivers/devfreq/event/exynos-ppmu.c | 7 ++++++-
>   1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/devfreq/event/exynos-ppmu.c b/drivers/devfreq/event/exynos-ppmu.c
> index 17ed980d9099..541bd13ab61d 100644
> --- a/drivers/devfreq/event/exynos-ppmu.c
> +++ b/drivers/devfreq/event/exynos-ppmu.c
> @@ -94,11 +94,16 @@ static struct __exynos_ppmu_events {
>   	PPMU_EVENT(d1-general),
>   	PPMU_EVENT(d1-rt),
>   
> -	/* For Exynos5422 SoC */
> +	/* For Exynos5422 SoC, deprecated (backwards compatible) */
>   	PPMU_EVENT(dmc0_0),
>   	PPMU_EVENT(dmc0_1),
>   	PPMU_EVENT(dmc1_0),
>   	PPMU_EVENT(dmc1_1),
> +	/* For Exynos5422 SoC */
> +	PPMU_EVENT(dmc0-0),
> +	PPMU_EVENT(dmc0-1),
> +	PPMU_EVENT(dmc1-0),
> +	PPMU_EVENT(dmc1-1),
>   };
>   
>   static int __exynos_ppmu_find_ppmu_id(const char *edev_name)
> 

Applied it. Thanks.

-- 
Best Regards,
Samsung Electronics
Chanwoo Choi

WARNING: multiple messages have this Message-ID
From: Chanwoo Choi <cwchoi00@gmail.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Rob Herring <robh+dt@kernel.org>,
	Chanwoo Choi <cw00.choi@samsung.com>,
	MyungJoo Ham <myungjoo.ham@samsung.com>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-pm@vger.kernel.org
Cc: Marek Szyprowski <m.szyprowski@samsung.com>,
	Sylwester Nawrocki <snawrocki@kernel.org>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: Re: [PATCH v2 1/3] devfreq: exynos-ppmu: use node names with hyphens
Date: Wed, 22 Sep 2021 16:55:37 +0900	[thread overview]
Message-ID: <83206dd4-c779-1090-9394-2519d4747206@gmail.com> (raw)
In-Reply-To: <20210920071753.38560-1-krzysztof.kozlowski@canonical.com>

Hi Krzysztof,

On 21. 9. 20. 오후 4:17, Krzysztof Kozlowski wrote:
> Devicetree naming convention requires device node names to use hyphens
> instead of underscore, so Exynos5422 devfreq event name
> "ppmu-event3-dmc0_0" should be "ppmu-event3-dmc0-0".  Newly introduced
> dtschema enforces this, however the driver still expects old name with
> an underscore.
> 
> Add new events for Exynos5422 while still accepting old name for
> backwards compatibility.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
>   drivers/devfreq/event/exynos-ppmu.c | 7 ++++++-
>   1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/devfreq/event/exynos-ppmu.c b/drivers/devfreq/event/exynos-ppmu.c
> index 17ed980d9099..541bd13ab61d 100644
> --- a/drivers/devfreq/event/exynos-ppmu.c
> +++ b/drivers/devfreq/event/exynos-ppmu.c
> @@ -94,11 +94,16 @@ static struct __exynos_ppmu_events {
>   	PPMU_EVENT(d1-general),
>   	PPMU_EVENT(d1-rt),
>   
> -	/* For Exynos5422 SoC */
> +	/* For Exynos5422 SoC, deprecated (backwards compatible) */
>   	PPMU_EVENT(dmc0_0),
>   	PPMU_EVENT(dmc0_1),
>   	PPMU_EVENT(dmc1_0),
>   	PPMU_EVENT(dmc1_1),
> +	/* For Exynos5422 SoC */
> +	PPMU_EVENT(dmc0-0),
> +	PPMU_EVENT(dmc0-1),
> +	PPMU_EVENT(dmc1-0),
> +	PPMU_EVENT(dmc1-1),
>   };
>   
>   static int __exynos_ppmu_find_ppmu_id(const char *edev_name)
> 

Applied it. Thanks.

-- 
Best Regards,
Samsung Electronics
Chanwoo Choi

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-09-22  7:55 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20210920071554eucas1p195184c73f79e7bc12ea83cb43e14adc5@eucas1p1.samsung.com>
2021-09-20  7:15 ` [PATCH v2 0/3] devfreq: exynos-ppmu: conform to dt naming convention Krzysztof Kozlowski
2021-09-20  7:15   ` Krzysztof Kozlowski
2021-09-20  7:17   ` [PATCH v2 1/3] devfreq: exynos-ppmu: use node names with hyphens Krzysztof Kozlowski
2021-09-20  7:17     ` Krzysztof Kozlowski
2021-09-22  7:55     ` Chanwoo Choi [this message]
2021-09-22  7:55       ` Chanwoo Choi
2021-09-20  7:17   ` [PATCH v2 2/3] devfreq: exynos-ppmu: simplify parsing event-type from DT Krzysztof Kozlowski
2021-09-20  7:17     ` Krzysztof Kozlowski
2021-09-22  8:05     ` Chanwoo Choi
2021-09-22  8:05       ` Chanwoo Choi
2021-09-20  7:17   ` [PATCH v2 3/3] ARM: dts: exynos: align PPMU event node names with dtschema Krzysztof Kozlowski
2021-09-20  7:17     ` Krzysztof Kozlowski
2021-09-23  2:22     ` Chanwoo Choi
2021-09-23  2:22       ` Chanwoo Choi
2022-02-18 13:18     ` (subset) " Krzysztof Kozlowski
2022-02-18 13:18       ` Krzysztof Kozlowski
2021-09-20  9:38   ` [PATCH v2 0/3] devfreq: exynos-ppmu: conform to dt naming convention Marek Szyprowski
2021-09-20  9:38     ` Marek Szyprowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83206dd4-c779-1090-9394-2519d4747206@gmail.com \
    --to=cwchoi00@gmail.com \
    --cc=b.zolnierkie@samsung.com \
    --cc=cw00.choi@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski@canonical.com \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=myungjoo.ham@samsung.com \
    --cc=robh+dt@kernel.org \
    --cc=snawrocki@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.