From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2D08C433E6 for ; Tue, 9 Mar 2021 15:54:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AFA6F6528C for ; Tue, 9 Mar 2021 15:54:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231239AbhCIPyM (ORCPT ); Tue, 9 Mar 2021 10:54:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48746 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230449AbhCIPxn (ORCPT ); Tue, 9 Mar 2021 10:53:43 -0500 Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [IPv6:2607:f8b0:4864:20::1032]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 09CBBC06174A; Tue, 9 Mar 2021 07:53:43 -0800 (PST) Received: by mail-pj1-x1032.google.com with SMTP id kk2-20020a17090b4a02b02900c777aa746fso5427531pjb.3; Tue, 09 Mar 2021 07:53:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=XTQS0aC3ey6iJ5CioVwvjyd2BBYlfManBKXsa0QRx38=; b=N2VU1bE2NI0JllfDLBDTjxn6GpHBmKr1208qsPb2633LxmyDpjKeFG87S8ZLoXw5W1 NeOErweovjja04p9BUE1j+U8LlD1JXTQdZn0EWbl72ZsyM2LLkjLNUw+vLn63kOupDbn cH/HjFSRLdUJz8dALKkOjrZJVSiV6f2W7NNEABSEYeinPNDM9gC8kMLQ8YdFHCInNbBI voIpfXkrPj/UNndN6u0ODW7XJzKvboiDwzJeC9bMtlseMOByOXif50B4cCVRLaksPSfB MPQ29b9kC6vls/8UDDf4OVMl4TN6r6KQjmaIMXyso8vO6cBvr1uuS/UVgv7ugSHk+mUe aA1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=XTQS0aC3ey6iJ5CioVwvjyd2BBYlfManBKXsa0QRx38=; b=Ma8enpBRHGTtOWpxuEWS6ITVS2LQEQVunYrQRXbFUTV5sabfjnqPtpvXsw0A4oLNl+ U78vu5hd23WgDmDUC621SsBiMwlELPGTIBxJPV7HussPi08OrGekZhR+2GDpBxNxNIKp w5y2R+mHkUV+3sgNsO6hcZdZS+ahP2JTQlseBTkSf2NDmdnCgoH0GWeOjv4fGUmGNqLk RmemWaO6CcRWFGnYkH4uUB4qcFVL7xILLfrL6jp0CsPv9u/L9Y/XYO5C5Tf6vTPg3ADU JocZ2/hLtvwNmrJwajdD+lO1WQtvTfrzLXi4hPh3x8JAOMU5f9Q7kbB9xZmR0vnLBPBx whcg== X-Gm-Message-State: AOAM533g6LGHfhaitaUcJ5Y17NNCIfkbFLoXVXFwS8MZRcPD54/HfuIF XrW1jE39OIfsKMMqVBlGy1w= X-Google-Smtp-Source: ABdhPJwSX8n16QaBIIKFvWEyLq3CvrFuMfoFjsnbbRN31EnAPKwunPWxeewBvXTHkj6XyqkVrEdwIA== X-Received: by 2002:a17:90b:344c:: with SMTP id lj12mr5490610pjb.208.1615305222453; Tue, 09 Mar 2021 07:53:42 -0800 (PST) Received: from [172.30.1.19] ([14.32.163.5]) by smtp.gmail.com with ESMTPSA id x9sm3313983pjp.29.2021.03.09.07.53.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Mar 2021 07:53:41 -0800 (PST) Subject: Re: [PATCH 05/11] PM / devfreq: use more accurate returned new_freq as resume_freq To: Dong Aisheng , linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: dongas86@gmail.com, kernel@pengutronix.de, shawnguo@kernel.org, linux-imx@nxp.com, linux-kernel@vger.kernel.org, myungjoo.ham@samsung.com, kyungmin.park@samsung.com, cw00.choi@samsung.com, abel.vesa@nxp.com References: <1615294733-22761-1-git-send-email-aisheng.dong@nxp.com> <1615294733-22761-6-git-send-email-aisheng.dong@nxp.com> From: Chanwoo Choi Message-ID: <83240e9d-383a-74a9-3222-68cf42d3d0e1@gmail.com> Date: Wed, 10 Mar 2021 00:53:35 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <1615294733-22761-6-git-send-email-aisheng.dong@nxp.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21. 3. 9. 오후 9:58, Dong Aisheng wrote: > Use the more accurate returned new_freq as resume_freq. > It's the same as how devfreq->previous_freq was updated. > > Signed-off-by: Dong Aisheng > --- > drivers/devfreq/devfreq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c > index 6e80bf70e7b3..ce569bd9adfa 100644 > --- a/drivers/devfreq/devfreq.c > +++ b/drivers/devfreq/devfreq.c > @@ -390,7 +390,7 @@ static int devfreq_set_target(struct devfreq *devfreq, unsigned long new_freq, > devfreq->previous_freq = new_freq; > > if (devfreq->suspend_freq) > - devfreq->resume_freq = cur_freq; > + devfreq->resume_freq = new_freq; > > return err; > } > This patch fixes the previous patch[1]. So that you need to add 'Fixes' tag as following: Fixes: 83f8ca45afbf0 ("PM / devfreq: add support for suspend/resume of a devfreq device") commit 83f8ca45afbf041e312909f442128b99657d90b7 Refs: v4.20-rc6-2-g83f8ca45afbf Author: Lukasz Luba AuthorDate: Wed Dec 5 12:05:53 2018 +0100 Commit: MyungJoo Ham CommitDate: Tue Dec 11 11:09:47 2018 +0900 PM / devfreq: add support for suspend/resume of a devfreq device -- Best Regards, Samsung Electronics Chanwoo Choi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C221C433E0 for ; Tue, 9 Mar 2021 15:55:14 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DCD0A65253 for ; Tue, 9 Mar 2021 15:55:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DCD0A65253 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5THIVvZzbBXIRF8sYoPcY+DrCAiRuOYisPXVcXvjM08=; b=OzAuAODSv5UmxUu6f4s6oF51i YIm6sPDxNk6Gy9Okk1MNjBCoaJxm27VI4WWsuk34ERorZ+EwH4zkt+Z5lIE90evtCcTIs67rwAYwi KdtevR/ebuzn3LkmoarAFXDeiNoi65z83bUMAfEfkx5SjSvN6/SJmtgv/6ueHOeAKIbzqFvDQ2ryQ sdx2BAsEPG88BHSIIQKCeRFLz9w6FRsr9WZJwt3lsiVyLByRzwQ8Jxlzwl+6FLp8RgojhVa/YFmvu 8CoKtOINok0EyX5e0s1bko2AOfi0eJR4lQjTxoTvsnuVOvwSYLQi1IwQG1qyI/8eesq3RoMbkMsT1 mT5B8dI0g==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lJeg9-0050Qh-He; Tue, 09 Mar 2021 15:53:49 +0000 Received: from mail-pj1-x1029.google.com ([2607:f8b0:4864:20::1029]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lJeg3-0050Q0-Ra for linux-arm-kernel@lists.infradead.org; Tue, 09 Mar 2021 15:53:45 +0000 Received: by mail-pj1-x1029.google.com with SMTP id x7-20020a17090a2b07b02900c0ea793940so5232835pjc.2 for ; Tue, 09 Mar 2021 07:53:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=XTQS0aC3ey6iJ5CioVwvjyd2BBYlfManBKXsa0QRx38=; b=N2VU1bE2NI0JllfDLBDTjxn6GpHBmKr1208qsPb2633LxmyDpjKeFG87S8ZLoXw5W1 NeOErweovjja04p9BUE1j+U8LlD1JXTQdZn0EWbl72ZsyM2LLkjLNUw+vLn63kOupDbn cH/HjFSRLdUJz8dALKkOjrZJVSiV6f2W7NNEABSEYeinPNDM9gC8kMLQ8YdFHCInNbBI voIpfXkrPj/UNndN6u0ODW7XJzKvboiDwzJeC9bMtlseMOByOXif50B4cCVRLaksPSfB MPQ29b9kC6vls/8UDDf4OVMl4TN6r6KQjmaIMXyso8vO6cBvr1uuS/UVgv7ugSHk+mUe aA1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=XTQS0aC3ey6iJ5CioVwvjyd2BBYlfManBKXsa0QRx38=; b=o9SEICF9yibuu0Z5zmRI//u2PCF51LeQd5EX6aAXWTmEq/6mwlywdZma+wu1uSmpNO WrvmxIN2NxvoT/GD/WikKVLRbAyxnedAXqfTiWER+fjrwsqmJAO4+BmQ96BA1vwKCrLq XjPpDCHJoO8rgwZTwDOP0qKilZOn23SEiHb0FeAFQFkjXrYfWU/hlsLxl++VyiFXkFwg IIiBHr3APFtuE7H99oT7EhOkwiqz+8y86rI/Sm3yfUmLYH4ZVd4Ubz4LD8XRq4xwdX37 BelhgJUIuuqo6CuOjAXXqru1tKPq8FaHHTbQerDU7DtmyMXkcw5NE+OQ7l6RljiF/H8O bgGA== X-Gm-Message-State: AOAM533kX1suzPhfWFA0jqcDQjXEuS45KvFNfqfCtUGVP4y38IcD0yFR iT9puyCoaRt6/fAFVox1cME= X-Google-Smtp-Source: ABdhPJwSX8n16QaBIIKFvWEyLq3CvrFuMfoFjsnbbRN31EnAPKwunPWxeewBvXTHkj6XyqkVrEdwIA== X-Received: by 2002:a17:90b:344c:: with SMTP id lj12mr5490610pjb.208.1615305222453; Tue, 09 Mar 2021 07:53:42 -0800 (PST) Received: from [172.30.1.19] ([14.32.163.5]) by smtp.gmail.com with ESMTPSA id x9sm3313983pjp.29.2021.03.09.07.53.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Mar 2021 07:53:41 -0800 (PST) Subject: Re: [PATCH 05/11] PM / devfreq: use more accurate returned new_freq as resume_freq To: Dong Aisheng , linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: dongas86@gmail.com, kernel@pengutronix.de, shawnguo@kernel.org, linux-imx@nxp.com, linux-kernel@vger.kernel.org, myungjoo.ham@samsung.com, kyungmin.park@samsung.com, cw00.choi@samsung.com, abel.vesa@nxp.com References: <1615294733-22761-1-git-send-email-aisheng.dong@nxp.com> <1615294733-22761-6-git-send-email-aisheng.dong@nxp.com> From: Chanwoo Choi Message-ID: <83240e9d-383a-74a9-3222-68cf42d3d0e1@gmail.com> Date: Wed, 10 Mar 2021 00:53:35 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <1615294733-22761-6-git-send-email-aisheng.dong@nxp.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210309_155344_042226_43633C3F X-CRM114-Status: GOOD ( 21.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMjEuIDMuIDkuIOyYpO2bhCA5OjU4LCBEb25nIEFpc2hlbmcgd3JvdGU6Cj4gVXNlIHRoZSBt b3JlIGFjY3VyYXRlIHJldHVybmVkIG5ld19mcmVxIGFzIHJlc3VtZV9mcmVxLgo+IEl0J3MgdGhl IHNhbWUgYXMgaG93IGRldmZyZXEtPnByZXZpb3VzX2ZyZXEgd2FzIHVwZGF0ZWQuCj4gCj4gU2ln bmVkLW9mZi1ieTogRG9uZyBBaXNoZW5nIDxhaXNoZW5nLmRvbmdAbnhwLmNvbT4KPiAtLS0KPiAg IGRyaXZlcnMvZGV2ZnJlcS9kZXZmcmVxLmMgfCAyICstCj4gICAxIGZpbGUgY2hhbmdlZCwgMSBp bnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9kZXZm cmVxL2RldmZyZXEuYyBiL2RyaXZlcnMvZGV2ZnJlcS9kZXZmcmVxLmMKPiBpbmRleCA2ZTgwYmY3 MGU3YjMuLmNlNTY5YmQ5YWRmYSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2RldmZyZXEvZGV2ZnJl cS5jCj4gKysrIGIvZHJpdmVycy9kZXZmcmVxL2RldmZyZXEuYwo+IEBAIC0zOTAsNyArMzkwLDcg QEAgc3RhdGljIGludCBkZXZmcmVxX3NldF90YXJnZXQoc3RydWN0IGRldmZyZXEgKmRldmZyZXEs IHVuc2lnbmVkIGxvbmcgbmV3X2ZyZXEsCj4gICAJZGV2ZnJlcS0+cHJldmlvdXNfZnJlcSA9IG5l d19mcmVxOwo+ICAgCj4gICAJaWYgKGRldmZyZXEtPnN1c3BlbmRfZnJlcSkKPiAtCQlkZXZmcmVx LT5yZXN1bWVfZnJlcSA9IGN1cl9mcmVxOwo+ICsJCWRldmZyZXEtPnJlc3VtZV9mcmVxID0gbmV3 X2ZyZXE7Cj4gICAKPiAgIAlyZXR1cm4gZXJyOwo+ICAgfQo+IAoKVGhpcyBwYXRjaCBmaXhlcyB0 aGUgcHJldmlvdXMgcGF0Y2hbMV0uIFNvIHRoYXQgeW91IG5lZWQgdG8KYWRkICdGaXhlcycgdGFn IGFzIGZvbGxvd2luZzoKCkZpeGVzOiA4M2Y4Y2E0NWFmYmYwICgiUE0gLyBkZXZmcmVxOiBhZGQg c3VwcG9ydCBmb3Igc3VzcGVuZC9yZXN1bWUgb2YgYSAKZGV2ZnJlcSBkZXZpY2UiKQoKY29tbWl0 IDgzZjhjYTQ1YWZiZjA0MWUzMTI5MDlmNDQyMTI4Yjk5NjU3ZDkwYjcKUmVmczogdjQuMjAtcmM2 LTItZzgzZjhjYTQ1YWZiZgpBdXRob3I6ICAgICBMdWthc3ogTHViYSA8bHVrYXN6Lmx1YmFAYXJt LmNvbT4KQXV0aG9yRGF0ZTogV2VkIERlYyA1IDEyOjA1OjUzIDIwMTggKzAxMDAKQ29tbWl0OiAg ICAgTXl1bmdKb28gSGFtIDxteXVuZ2pvby5oYW1Ac2Ftc3VuZy5jb20+CkNvbW1pdERhdGU6IFR1 ZSBEZWMgMTEgMTE6MDk6NDcgMjAxOCArMDkwMAoKICAgICBQTSAvIGRldmZyZXE6IGFkZCBzdXBw b3J0IGZvciBzdXNwZW5kL3Jlc3VtZSBvZiBhIGRldmZyZXEgZGV2aWNlCgoKLS0gCkJlc3QgUmVn YXJkcywKU2Ftc3VuZyBFbGVjdHJvbmljcwpDaGFud29vIENob2kKCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBs aXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5m cmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK