[Buildroot] [PATCH 1/2] package/exim: remove libnsl linking with Glibc.

[Buildroot] [PATCH 1/2] package/exim: remove libnsl linking with Glibc.

[Romain Naour]

libnsl has been deprecated from Glibc and no other libc provide it.
Also there is no libnsl package in Buildroot yet, so remove -lnsl for
all toolchains.

libnsl is now a library that can be packaged later if needed. [1]

Note: Fedora 28 has switched to the new libnsl library that bring
IPV6 support. [2]

[1] https://github.com/thkukuk/libnsl.git
[2] https://fedoraproject.org/wiki/Changes/NISIPv6

Signed-off-by: Romain Naour <romain.naour@gmail.com>
Cc: Baruch Siach <baruch@tkos.co.il>
---
 package/exim/exim.mk | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/package/exim/exim.mk b/package/exim/exim.mk
index 37eab501a4..bc3a8eefd5 100644
--- a/package/exim/exim.mk
+++ b/package/exim/exim.mk
@@ -72,13 +72,13 @@ define EXIM_USE_DEFAULT_CONFIG_FILE_OPENSSL
 endef
 endif
 
-# only glibc provides libnsl, remove -lnsl for all other toolchains
+# libnsl has been deprecated from Glibc and no other libc provide it.
+# There is no libnsl package in Buildroot yet.
+# Remove -lnsl for all toolchains.
 # http://bugs.exim.org/show_bug.cgi?id=1564
-ifeq ($(BR2_TOOLCHAIN_USES_GLIBC),)
 define EXIM_REMOVE_LIBNSL_FROM_MAKEFILE
 	$(SED) 's/-lnsl//g' $(@D)/OS/Makefile-Linux
 endef
-endif
 
 # musl does not provide struct ip_options nor struct ip_opts (but it is
 # available with both glibc and uClibc)
-- 
2.14.3

[Buildroot] [PATCH 2/2] Revert "glibc: install the obsolete libnsl"

[Romain Naour]

libnsl from Glibc is deprecated and should not be used anymore.
libnsl is now an separate library that can be packaged later if
necessary [1].

Note: libnsl from Glibc doesn't build with gcc 8 due new warning [2].

[1] https://github.com/thkukuk/libnsl.git
[2] http://patchwork.sourceware.org/patch/26437

This reverts commit 398747f5fafca8c07e696612d8eded53d4f935c7.

Signed-off-by: Romain Naour <romain.naour@gmail.com>
Cc: Baruch Siach <baruch@tkos.co.il>
---
 package/glibc/glibc.mk | 1 -
 1 file changed, 1 deletion(-)

diff --git a/package/glibc/glibc.mk b/package/glibc/glibc.mk
index 3ab673c0cc..0d406c195e 100644
--- a/package/glibc/glibc.mk
+++ b/package/glibc/glibc.mk
@@ -100,7 +100,6 @@ define GLIBC_CONFIGURE_CMDS
 		--disable-profile \
 		--without-gd \
 		--enable-obsolete-rpc \
-		--enable-obsolete-nsl \
 		--enable-kernel=$(call qstrip,$(BR2_TOOLCHAIN_HEADERS_AT_LEAST)) \
 		--with-headers=$(STAGING_DIR)/usr/include)
 	$(GLIBC_ADD_MISSING_STUB_H)
-- 
2.14.3

[Buildroot] [PATCH 2/2] Revert "glibc: install the obsolete libnsl"

[Romain Naour]

All,

Le 01/05/2018 ? 22:05, Romain Naour a ?crit?:
> libnsl from Glibc is deprecated and should not be used anymore.
> libnsl is now an separate library that can be packaged later if
> necessary [1].
> 
> Note: libnsl from Glibc doesn't build with gcc 8 due new warning [2].
> 
> [1] https://github.com/thkukuk/libnsl.git
> [2] http://patchwork.sourceware.org/patch/26437
> 
> This reverts commit 398747f5fafca8c07e696612d8eded53d4f935c7.

I missed libnsl.so.* from GLIBC_LIBS_LIB list. It should be removed.
Same for libnsl.so.* from TOOLCHAIN_EXTERNAL_LIBS.

Thoughts?

Best regards,
Romain

> 
> Signed-off-by: Romain Naour <romain.naour@gmail.com>
> Cc: Baruch Siach <baruch@tkos.co.il>
> ---
>  package/glibc/glibc.mk | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/package/glibc/glibc.mk b/package/glibc/glibc.mk
> index 3ab673c0cc..0d406c195e 100644
> --- a/package/glibc/glibc.mk
> +++ b/package/glibc/glibc.mk
> @@ -100,7 +100,6 @@ define GLIBC_CONFIGURE_CMDS
>  		--disable-profile \
>  		--without-gd \
>  		--enable-obsolete-rpc \
> -		--enable-obsolete-nsl \
>  		--enable-kernel=$(call qstrip,$(BR2_TOOLCHAIN_HEADERS_AT_LEAST)) \
>  		--with-headers=$(STAGING_DIR)/usr/include)
>  	$(GLIBC_ADD_MISSING_STUB_H)
> 

[Buildroot] [PATCH 1/2] package/exim: remove libnsl linking with Glibc.

[Thomas Petazzoni]

Hello,

On Tue,  1 May 2018 22:05:07 +0200, Romain Naour wrote:
> libnsl has been deprecated from Glibc and no other libc provide it.
> Also there is no libnsl package in Buildroot yet, so remove -lnsl for
> all toolchains.
> 
> libnsl is now a library that can be packaged later if needed. [1]
> 
> Note: Fedora 28 has switched to the new libnsl library that bring
> IPV6 support. [2]
> 
> [1] https://github.com/thkukuk/libnsl.git
> [2] https://fedoraproject.org/wiki/Changes/NISIPv6

This commit log doesn't really explain the motivation for the change.
What is the ultimate goal here ?

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH 1/2] package/exim: remove libnsl linking with Glibc.

[Romain Naour]

Hi Thomas,

Le 01/05/2018 ? 22:12, Thomas Petazzoni a ?crit?:
> Hello,
> 
> On Tue,  1 May 2018 22:05:07 +0200, Romain Naour wrote:
>> libnsl has been deprecated from Glibc and no other libc provide it.
>> Also there is no libnsl package in Buildroot yet, so remove -lnsl for
>> all toolchains.
>>
>> libnsl is now a library that can be packaged later if needed. [1]
>>
>> Note: Fedora 28 has switched to the new libnsl library that bring
>> IPV6 support. [2]
>>
>> [1] https://github.com/thkukuk/libnsl.git
>> [2] https://fedoraproject.org/wiki/Changes/NISIPv6
> 
> This commit log doesn't really explain the motivation for the change.
> What is the ultimate goal here ?

The motivation is to remove libnsl provided by Glibc. Since the new libnsl is
not packaged in Buildroot. Remove -lnsl from the exim Makefile.

Best regards,
Romain

> 
> Thomas
> 

[Buildroot] [PATCH 1/2] package/exim: remove libnsl linking with Glibc.

[Thomas Petazzoni]

Hello,

On Tue, 1 May 2018 22:19:13 +0200, Romain Naour wrote:

> Le 01/05/2018 ? 22:12, Thomas Petazzoni a ?crit?:
> > Hello,
> > 
> > On Tue,  1 May 2018 22:05:07 +0200, Romain Naour wrote:  
> >> libnsl has been deprecated from Glibc and no other libc provide it.
> >> Also there is no libnsl package in Buildroot yet, so remove -lnsl for
> >> all toolchains.
> >>
> >> libnsl is now a library that can be packaged later if needed. [1]
> >>
> >> Note: Fedora 28 has switched to the new libnsl library that bring
> >> IPV6 support. [2]
> >>
> >> [1] https://github.com/thkukuk/libnsl.git
> >> [2] https://fedoraproject.org/wiki/Changes/NISIPv6  
> > 
> > This commit log doesn't really explain the motivation for the change.
> > What is the ultimate goal here ?  
> 
> The motivation is to remove libnsl provided by Glibc. Since the new libnsl is
> not packaged in Buildroot. Remove -lnsl from the exim Makefile.

I think the explanation in the commit log should be improved then.

Perhaps something like:

""""
glibc now considers its built-in libnsl as being obsolete, and requires
passing --enable-obsolete-libnsl to have it built and installed. libnsl
is now provided as a separate project, but it isn't packaged yet in
Buildroot.

In preparation for dropping --enable-obsolete-libnsl from the glibc
package, this commit ensures that exim doesn't use libnsl. It was
already the case for uclibc and musl toolchains, so this commit simply
extends that to make sure libnsl is also not used with glibc toolchains.
""""

Does this capture the problem properly ?

Remains some questions though: why is exim linking with libnsl in the
first place ? Doesn't it use symbols from this library ?

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH 1/2] package/exim: remove libnsl linking with Glibc.

[Romain Naour]

Hi Thomas, Baruch,

Le 01/05/2018 ? 22:37, Thomas Petazzoni a ?crit?:
> Hello,
> 
> On Tue, 1 May 2018 22:19:13 +0200, Romain Naour wrote:
> 
>> Le 01/05/2018 ? 22:12, Thomas Petazzoni a ?crit?:
>>> Hello,
>>>
>>> On Tue,  1 May 2018 22:05:07 +0200, Romain Naour wrote:  
>>>> libnsl has been deprecated from Glibc and no other libc provide it.
>>>> Also there is no libnsl package in Buildroot yet, so remove -lnsl for
>>>> all toolchains.
>>>>
>>>> libnsl is now a library that can be packaged later if needed. [1]
>>>>
>>>> Note: Fedora 28 has switched to the new libnsl library that bring
>>>> IPV6 support. [2]
>>>>
>>>> [1] https://github.com/thkukuk/libnsl.git
>>>> [2] https://fedoraproject.org/wiki/Changes/NISIPv6  
>>>
>>> This commit log doesn't really explain the motivation for the change.
>>> What is the ultimate goal here ?  
>>
>> The motivation is to remove libnsl provided by Glibc. Since the new libnsl is
>> not packaged in Buildroot. Remove -lnsl from the exim Makefile.
> 
> I think the explanation in the commit log should be improved then.
> 
> Perhaps something like:
> 
> """"
> glibc now considers its built-in libnsl as being obsolete, and requires
> passing --enable-obsolete-libnsl to have it built and installed. libnsl
> is now provided as a separate project, but it isn't packaged yet in
> Buildroot.
> 
> In preparation for dropping --enable-obsolete-libnsl from the glibc
> package, this commit ensures that exim doesn't use libnsl. It was
> already the case for uclibc and musl toolchains, so this commit simply
> extends that to make sure libnsl is also not used with glibc toolchains.
> """"
> 
> Does this capture the problem properly ?

Yes

> 
> Remains some questions though: why is exim linking with libnsl in the
> first place ? Doesn't it use symbols from this library ?

Exim itself doesn't need libnsl.
Only Exim's nis.so and nisplus.so lookup modules require libnsl but they are not
even build by default.

For now, we can safely remove -lnsl from exim Makefile.

Best regards,
Romain

> 
> Thomas
>