From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57072)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <douly.fnst@cn.fujitsu.com>) id 1bc45U-0003YD-U8
	for qemu-devel@nongnu.org; Tue, 23 Aug 2016 01:17:25 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <douly.fnst@cn.fujitsu.com>) id 1bc45P-0002LY-Sh
	for qemu-devel@nongnu.org; Tue, 23 Aug 2016 01:17:24 -0400
Received: from [59.151.112.132] (port=63068 helo=heian.cn.fujitsu.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <douly.fnst@cn.fujitsu.com>) id 1bc45P-0002L3-Dq
	for qemu-devel@nongnu.org; Tue, 23 Aug 2016 01:17:19 -0400
References: <1471485050-26747-1-git-send-email-douly.fnst@cn.fujitsu.com>
	<218747645.338872.1471856165532.JavaMail.zimbra@oxygem.tv>
From: Dou Liyang <douly.fnst@cn.fujitsu.com>
Message-ID: <8342e17b-937d-28c9-8784-a3a6722ed433@cn.fujitsu.com>
Date: Tue, 23 Aug 2016 13:17:01 +0800
MIME-Version: 1.0
In-Reply-To: <218747645.338872.1471856165532.JavaMail.zimbra@oxygem.tv>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v7] docs: add cpu-hotplug.txt
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexandre DERUMIER <aderumier@odiso.com>
Cc: qemu-devel <qemu-devel@nongnu.org>, drjones@redhat.com, ehabkost <ehabkost@redhat.com>, Markus Armbruster <armbru@redhat.com>, bharata@linux.vnet.ibm.com, Fam Zheng <famz@redhat.com>, Igor Mammedov <imammedo@redhat.com>, david@gibson.dropbear.id.au

Hi Alexandre,

At 08/22/2016 04:56 PM, Alexandre DERUMIER wrote:
> Hello,
>
> I'm looking to implement cpu hotplug,
>
> and I have a question about cpu flags
>
> currently I have something like
>
> -cpu qemu64,+lahf_lm,+sep,+kvm_pv_unhalt,+kvm_pv_eoi,enforce
> -smp 4,sockets=2,cores=2,maxcpus=4
>
>
> Does I need to define flags like:
>
> -smp 2,sockets=2,cores=2,maxcpus=4
> -device qemu64-x86_64-cpu,+lahf_lm,+sep,+kvm_pv_unhalt,+kvm_pv_eoi,enforce,id=cpu1,socket-id=1,core-id=1,thread-id=0

I think we don't need to do that.
In my option, just like this:

-device qemu64-x86_64-cpu,id=cpu1,socket-id=1,..

Because QEMU sets the "-cpu" options in MachineState:

   current_machine->cpu_model = cpu_model;

when you add a CPU, QEMU can get the flag from the MachineState.

> ...
>
> ?
>
>
> Another question,
> is -smp mandatory ?  (if I want coldplug all cpus)

it's not mandatory. such as this:

   ./x86_64-softmmu/qemu-system-x86_64 -m 1G /image/fedora.img
   -enable-kvm -monitor stdio

  (qemu) info cpus
   * CPU #0: pc=0xffffffff81060586 (halted) thread_id=4032

the default number of CPUs is 1.

>
> -smp sockets=2,cores=2,maxcpus=4

> -device qemu64-x86_64-cpu,id=cpu1,socket-id=1,core-id=1,thread-id=0
> -device qemu64-x86_64-cpu,id=cpu1,socket-id=1,core-id=2,thread-id=0
> -device qemu64-x86_64-cpu,id=cpu3,socket-id=2,core-id=1,thread-id=0
> -device qemu64-x86_64-cpu,id=cpu4,socket-id=2,core-id=2,thread-id=0
>
> or does I need minimum 1 non unplugable cpu
>
> -smp 1,sockets=2,cores=2,maxcpus=4
> -device qemu64-x86_64-cpu,id=cpu1,socket-id=1,core-id=2,thread-id=0
> -device qemu64-x86_64-cpu,id=cpu3,socket-id=2,core-id=1,thread-id=0
> -device qemu64-x86_64-cpu,id=cpu4,socket-id=2,core-id=2,thread-id=0
>

I think that is better, and the socket-id/core-id/thread-id starts at
index 0

I am new to the community. Please don't mind, and take with a grain of
salt.	

Thanks,
Dou