From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753081AbdGGAFi (ORCPT ); Thu, 6 Jul 2017 20:05:38 -0400 Received: from mail.kernel.org ([198.145.29.99]:48768 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752937AbdGGAFh (ORCPT ); Thu, 6 Jul 2017 20:05:37 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4783721C9B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=chao@kernel.org Subject: Re: [f2fs-dev] [PATCH] f2fs: relax permission for atomic/volatile ioctls To: Jaegeuk Kim , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net References: <20170706022326.52594-1-jaegeuk@kernel.org> From: Chao Yu Message-ID: <8346aeca-c28b-e5b9-5973-b5648b015c88@kernel.org> Date: Fri, 7 Jul 2017 08:04:32 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170706022326.52594-1-jaegeuk@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017/7/6 10:23, Jaegeuk Kim wrote: > This patch allows atomic/volatile ioctls for sqlite under sdcardfs. Out of curiosity, we will lose some capable when passing through sdcardfs? Thanks, > > Signed-off-by: Jaegeuk Kim > --- > fs/f2fs/file.c | 15 --------------- > 1 file changed, 15 deletions(-) > > diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c > index f5d6357e8360..dd8f5d2caa48 100644 > --- a/fs/f2fs/file.c > +++ b/fs/f2fs/file.c > @@ -1587,9 +1587,6 @@ static int f2fs_ioc_start_atomic_write(struct file *filp) > struct inode *inode = file_inode(filp); > int ret; > > - if (!inode_owner_or_capable(inode)) > - return -EACCES; > - > if (!S_ISREG(inode->i_mode)) > return -EINVAL; > > @@ -1636,9 +1633,6 @@ static int f2fs_ioc_commit_atomic_write(struct file *filp) > struct inode *inode = file_inode(filp); > int ret; > > - if (!inode_owner_or_capable(inode)) > - return -EACCES; > - > ret = mnt_want_write_file(filp); > if (ret) > return ret; > @@ -1672,9 +1666,6 @@ static int f2fs_ioc_start_volatile_write(struct file *filp) > struct inode *inode = file_inode(filp); > int ret; > > - if (!inode_owner_or_capable(inode)) > - return -EACCES; > - > if (!S_ISREG(inode->i_mode)) > return -EINVAL; > > @@ -1707,9 +1698,6 @@ static int f2fs_ioc_release_volatile_write(struct file *filp) > struct inode *inode = file_inode(filp); > int ret; > > - if (!inode_owner_or_capable(inode)) > - return -EACCES; > - > ret = mnt_want_write_file(filp); > if (ret) > return ret; > @@ -1736,9 +1724,6 @@ static int f2fs_ioc_abort_volatile_write(struct file *filp) > struct inode *inode = file_inode(filp); > int ret; > > - if (!inode_owner_or_capable(inode)) > - return -EACCES; > - > ret = mnt_want_write_file(filp); > if (ret) > return ret; > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chao Yu Subject: Re: [PATCH] f2fs: relax permission for atomic/volatile ioctls Date: Fri, 7 Jul 2017 08:04:32 +0800 Message-ID: <8346aeca-c28b-e5b9-5973-b5648b015c88@kernel.org> References: <20170706022326.52594-1-jaegeuk@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from sog-mx-1.v43.ch3.sourceforge.com ([172.29.43.191] helo=mx.sourceforge.net) by sfs-ml-2.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1dTGmE-0004oR-Lg for linux-f2fs-devel@lists.sourceforge.net; Fri, 07 Jul 2017 00:05:42 +0000 Received: from mail.kernel.org ([198.145.29.99]) by sog-mx-1.v43.ch3.sourceforge.com with esmtps (TLSv1:AES256-SHA:256) (Exim 4.76) id 1dTGmD-0005r6-Un for linux-f2fs-devel@lists.sourceforge.net; Fri, 07 Jul 2017 00:05:42 +0000 In-Reply-To: <20170706022326.52594-1-jaegeuk@kernel.org> Content-Language: en-US List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net To: Jaegeuk Kim , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net On 2017/7/6 10:23, Jaegeuk Kim wrote: > This patch allows atomic/volatile ioctls for sqlite under sdcardfs. Out of curiosity, we will lose some capable when passing through sdcardfs? Thanks, > > Signed-off-by: Jaegeuk Kim > --- > fs/f2fs/file.c | 15 --------------- > 1 file changed, 15 deletions(-) > > diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c > index f5d6357e8360..dd8f5d2caa48 100644 > --- a/fs/f2fs/file.c > +++ b/fs/f2fs/file.c > @@ -1587,9 +1587,6 @@ static int f2fs_ioc_start_atomic_write(struct file *filp) > struct inode *inode = file_inode(filp); > int ret; > > - if (!inode_owner_or_capable(inode)) > - return -EACCES; > - > if (!S_ISREG(inode->i_mode)) > return -EINVAL; > > @@ -1636,9 +1633,6 @@ static int f2fs_ioc_commit_atomic_write(struct file *filp) > struct inode *inode = file_inode(filp); > int ret; > > - if (!inode_owner_or_capable(inode)) > - return -EACCES; > - > ret = mnt_want_write_file(filp); > if (ret) > return ret; > @@ -1672,9 +1666,6 @@ static int f2fs_ioc_start_volatile_write(struct file *filp) > struct inode *inode = file_inode(filp); > int ret; > > - if (!inode_owner_or_capable(inode)) > - return -EACCES; > - > if (!S_ISREG(inode->i_mode)) > return -EINVAL; > > @@ -1707,9 +1698,6 @@ static int f2fs_ioc_release_volatile_write(struct file *filp) > struct inode *inode = file_inode(filp); > int ret; > > - if (!inode_owner_or_capable(inode)) > - return -EACCES; > - > ret = mnt_want_write_file(filp); > if (ret) > return ret; > @@ -1736,9 +1724,6 @@ static int f2fs_ioc_abort_volatile_write(struct file *filp) > struct inode *inode = file_inode(filp); > int ret; > > - if (!inode_owner_or_capable(inode)) > - return -EACCES; > - > ret = mnt_want_write_file(filp); > if (ret) > return ret; > ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot