Re: [PATCH] bitmap: add scan init at given position

From: Thomas Monjalon <thomas@monjalon.net>
To: Cristian Dumitrescu <cristian.dumitrescu@intel.com>,
	Volodymyr Fialko <vfialko@marvell.com>
Cc: dev@dpdk.org, jerinj@marvell.com, anoobj@marvell.com
Subject: Re: [PATCH] bitmap: add scan init at given position
Date: Thu, 01 Jun 2023 17:26:24 +0200	[thread overview]
Message-ID: <8347303.5OynTdThKG@thomas> (raw)
In-Reply-To: <20230414083943.270651-1-vfialko@marvell.com>

Cristian, please could you review this patch?

14/04/2023 10:39, Volodymyr Fialko:
> Currently, in the case when we search for a bit set after a particular
> value, the bitmap has to be scanned from the beginning and
> rte_bitmap_scan() has to be called multiple times until we hit the value.
> 
> Add a new __rte_bitmap_scan_init_at() function to initialize scan state at
> the given position, this will allow getting the next bit set after some
> value within one rte_bitmap_scan() call.
> 
> Signed-off-by: Volodymyr Fialko <vfialko@marvell.com>
[...]
> +__rte_experimental
> +static inline void
> +__rte_bitmap_scan_init_at(struct rte_bitmap *bmp, uint32_t pos)
> +{
> +	bmp->index1 = pos >> (RTE_BITMAP_SLAB_BIT_SIZE_LOG2 + RTE_BITMAP_CL_BIT_SIZE_LOG2);
> +	bmp->offset1 = (pos >> RTE_BITMAP_CL_BIT_SIZE_LOG2) & RTE_BITMAP_SLAB_BIT_MASK;
> +	bmp->index2 = pos >> RTE_BITMAP_SLAB_BIT_SIZE_LOG2;
> +	bmp->go2 = 1;
> +}

It is supposed to be an internal (inlined) function
but it is not used.