Re: [PATCH] drm/ast: Create threshold values for AST2600

From: Thomas Zimmermann <tzimmermann@suse.de>
To: KuoHsiang Chou <kuohsiang_chou@aspeedtech.com>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Cc: hungju_huang@aspeedtech.com, airlied@linux.ie,
	tommy_huang@aspeedtech.com, airlied@redhat.com,
	arc_sung@aspeedtech.com, luke_chen@aspeedtech.com
Subject: Re: [PATCH] drm/ast: Create threshold values for AST2600
Date: Wed, 19 Jan 2022 16:54:47 +0100	[thread overview]
Message-ID: <83484eca-8562-bf76-78f1-75b626a59029@suse.de> (raw)
In-Reply-To: <20220117083643.41493-1-kuohsiang_chou@aspeedtech.com>

[-- Attachment #1.1: Type: text/plain, Size: 1364 bytes --]

Hi

Am 17.01.22 um 09:36 schrieb KuoHsiang Chou:
> The threshold value is used for AST2600 only.
> 
> Signed-off-by: KuoHsiang Chou <kuohsiang_chou@aspeedtech.com>
> ---
>   drivers/gpu/drm/ast/ast_mode.c | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/ast/ast_mode.c b/drivers/gpu/drm/ast/ast_mode.c
> index 1c7a57a03..7f2e248a6 100644
> --- a/drivers/gpu/drm/ast/ast_mode.c
> +++ b/drivers/gpu/drm/ast/ast_mode.c
> @@ -471,7 +471,10 @@ static void ast_set_color_reg(struct ast_private *ast,
>   static void ast_set_crtthd_reg(struct ast_private *ast)
>   {
>   	/* Set Threshold */
> -	if (ast->chip == AST2300 || ast->chip == AST2400 ||
> +	if (ast->chip == AST2600) {
> +		ast_set_index_reg(ast, AST_IO_CRTC_PORT, 0xa7, 0xe0);
> +		ast_set_index_reg(ast, AST_IO_CRTC_PORT, 0xa6, 0xa0);
> +	} else if (ast->chip == AST2300 || ast->chip == AST2400 ||
>   	    ast->chip == AST2500) {
>   		ast_set_index_reg(ast, AST_IO_CRTC_PORT, 0xa7, 0x78);
>   		ast_set_index_reg(ast, AST_IO_CRTC_PORT, 0xa6, 0x60);
> --
> 2.27.0
> 

Merged into drm-misc-next. Thanks for the patch.

Best regards
Thomas

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]