All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Stancek <jstancek@redhat.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] tst_test: Fix exit value on tst_brk(TCONF, ...)
Date: Wed, 17 Jan 2018 10:03:19 -0500 (EST)	[thread overview]
Message-ID: <83504737.1024347.1516201399150.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20180117145846.21303-1-chrubis@suse.cz>


----- Original Message -----
> We decided not to propagate TCONF into the test exit value in a case
> that the test had at least one TPASS in:
> 
> commit 5390d6ea36578c1fac8adc416b6f91aa4a330a08
> Author: Cyril Hrubis <chrubis@suse.cz>
> Date:   Thu Sep 7 15:47:22 2017 +0200
> 
>     lib/tst_test: Report 0 if test has both TPASS and TCONF
> 
> However this commit missed a case when TCONF is passed directly to the
> do_exit() function. This may happen in two cases actually, one of the is
> tst_brk(TCONF, ...) called from a test and second one is more subtle and
> happens when the last result in the run_tcases_per_fs() produces TCONF
> which is then propagated to the do_exit() function.
> 
> This commit simply mask the TCONF from the exit value in this cases if
> we happen to have non-zero success counter.

Makes sense to me, ACK.

Regards,
Jan

  reply	other threads:[~2018-01-17 15:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-17 14:58 [LTP] [PATCH] tst_test: Fix exit value on tst_brk(TCONF, ...) Cyril Hrubis
2018-01-17 15:03 ` Jan Stancek [this message]
2018-01-17 15:15   ` Cyril Hrubis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83504737.1024347.1516201399150.JavaMail.zimbra@redhat.com \
    --to=jstancek@redhat.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.