* [PATCH] dmaengine: qcom_hidma: Remove useless DMA-32 fallback configuration
@ 2022-01-15 7:26 Christophe JAILLET
2022-01-15 7:30 ` Christophe JAILLET
0 siblings, 1 reply; 2+ messages in thread
From: Christophe JAILLET @ 2022-01-15 7:26 UTC (permalink / raw)
To: Vinod Koul; +Cc: linux-kernel, kernel-janitors, Christophe JAILLET, dmaengine
As stated in [1], dma_set_mask() with a 64-bit mask never fails if
dev->dma_mask is non-NULL.
So, if it fails, the 32 bits case will also fail for the same reason.
Simplify code and remove some dead code accordingly.
[1]: https://lore.kernel.org/linux-kernel/YL3vSPK5DXTNvgdx@infradead.org/#t
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
drivers/dma/ioat/init.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/dma/ioat/init.c b/drivers/dma/ioat/init.c
index 373b8dac6c9b..5d707ff63554 100644
--- a/drivers/dma/ioat/init.c
+++ b/drivers/dma/ioat/init.c
@@ -1364,8 +1364,6 @@ static int ioat_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id)
return -ENOMEM;
err = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64));
- if (err)
- err = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32));
if (err)
return err;
--
2.32.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] dmaengine: qcom_hidma: Remove useless DMA-32 fallback configuration
2022-01-15 7:26 [PATCH] dmaengine: qcom_hidma: Remove useless DMA-32 fallback configuration Christophe JAILLET
@ 2022-01-15 7:30 ` Christophe JAILLET
0 siblings, 0 replies; 2+ messages in thread
From: Christophe JAILLET @ 2022-01-15 7:30 UTC (permalink / raw)
To: Vinod Koul; +Cc: linux-kernel, kernel-janitors, dmaengine
Le 15/01/2022 à 08:26, Christophe JAILLET a écrit :
> As stated in [1], dma_set_mask() with a 64-bit mask never fails if
> dev->dma_mask is non-NULL.
> So, if it fails, the 32 bits case will also fail for the same reason.
>
> Simplify code and remove some dead code accordingly.
>
> [1]: https://lore.kernel.org/linux-kernel/YL3vSPK5DXTNvgdx@infradead.org/#t
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> drivers/dma/ioat/init.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/dma/ioat/init.c b/drivers/dma/ioat/init.c
> index 373b8dac6c9b..5d707ff63554 100644
> --- a/drivers/dma/ioat/init.c
> +++ b/drivers/dma/ioat/init.c
> @@ -1364,8 +1364,6 @@ static int ioat_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id)
> return -ENOMEM;
>
> err = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64));
> - if (err)
> - err = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32));
> if (err)
> return err;
>
>
NACK, wrong driver name in the subject. I'll resend.
CJ
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-01-15 7:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-15 7:26 [PATCH] dmaengine: qcom_hidma: Remove useless DMA-32 fallback configuration Christophe JAILLET
2022-01-15 7:30 ` Christophe JAILLET
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.