From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Harrison Subject: Re: [PATCH 17/46] drm/i915: Syntatic sugar for using intel_runtime_pm Date: Wed, 9 Jan 2019 16:24:06 -0800 Message-ID: <836b01e0-20fa-3336-876b-6d78497685f9@Intel.com> References: <20190107115509.12523-1-chris@chris-wilson.co.uk> <20190107115509.12523-17-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 332CA6E627 for ; Thu, 10 Jan 2019 00:24:08 +0000 (UTC) In-Reply-To: <20190107115509.12523-17-chris@chris-wilson.co.uk> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org Cc: Jani Nikula List-Id: intel-gfx@lists.freedesktop.org T24gMS83LzIwMTkgMDM6NTQsIENocmlzIFdpbHNvbiB3cm90ZToKPiBGcmVxdWVudGx5LCB3ZSB1 c2UgaW50ZWxfcnVudGltZV9wbV9nZXQvX3B1dCBhcm91bmQgYSBzbWFsbCBibG9jay4KPiBGb3Jt YWxpc2UgdGhhdCB1c2FnZSBieSBwcm92aWRpbmcgYSBtYWNybyB0byBkZWZpbmUgc3VjaCBhIGJs b2NrIHdpdGggYW4KPiBhdXRvbWF0aWMgY2xvc3VyZSB0byBzY29wZSB0aGUgaW50ZWxfcnVudGlt ZV9wbSB3YWtlcmVmIHRvIHRoYXQgYmxvY2ssCj4gaS5lLiBtYWNybyBhYnVzZSBzbWVsbGluZyBv ZiBweXRob24uCj4KPiBTaWduZWQtb2ZmLWJ5OiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdp bHNvbi5jby51az4KPiBDYzogSmFuaSBOaWt1bGEgPGphbmkubmlrdWxhQGludGVsLmNvbT4KPiAt LS0KPiAgIAo+ICsjZGVmaW5lIHdpdGhfaW50ZWxfcnVudGltZV9wbShpOTE1LCB3ZikgXAo+ICsJ Zm9yICh3ZiA9IGludGVsX3J1bnRpbWVfcG1fZ2V0KGk5MTUpOyB3ZjsgXAo+ICsJICAgICBpbnRl bF9ydW50aW1lX3BtX3B1dChpOTE1LCB3ZiksIHdmID0gMCkKPiArCj4gKyNkZWZpbmUgd2l0aF9p bnRlbF9ydW50aW1lX3BtX2lmX2luX3VzZShpOTE1LCB3ZikgXAo+ICsJZm9yICh3ZiA9IGludGVs X3J1bnRpbWVfcG1fZ2V0X2lmX2luX3VzZShpOTE1KTsgd2Y7IFwKPiArCSAgICAgaW50ZWxfcnVu dGltZV9wbV9wdXQoaTkxNSwgd2YpLCB3ZiA9IDApCj4gKwpUaGlzIGlzIGEgcG90ZW50aWFsIGNo YW5nZSBpbiBiZWhhdmlvdXIuIFByZXZpb3VzbHkgdGhlIHNpbXBsZSAnZ2V0JyAKdmVyc2lvbiB3 b3VsZCB1bmNvbmRpdGlvbmFsbHkgZXhlY3V0ZSB0aGUgd3JhcHBlZCBjb2RlLiBXaGVyZWFzIG5v dywgaWYgCnRoZSBnZXQgZnVuY3Rpb24gZmFpbHMgZm9yIHNvbWUgcmVhc29uIGFuZCByZXR1cm5z IHplcm8sIHRoZSB3cmFwcGVkIApjb2RlIHdpbGwgYmUgc2tpcHBlZC4gQ3VycmVudGx5LCB0aGUg Z2V0KCkgZnVuY3Rpb24gY2FuJ3QgcmV0dXJuIHplcm8gLSAKaXQgcmV0dXJucyAtMSBpbiB0aGUg Y2FzZSBvZiB0aGUgdHJhY2tpbmcgY29kZSBmYWlsaW5nIHRvIGFsbG9jYXRlIG9yIApzaW1pbGFy LiBCdXQgaXMgdGhhdCBndWFyYW50ZWVkIHRvIGJlIHRoZSBjYXNlIGZvcmV2ZXJtb3JlPyBJdCB3 b3VsZCBiZSAKYSBiZXR0ZXIgbWF0Y2ggZm9yIHRoZSBvcmlnaW5hbCBiZWhhdmlvdXIgaWYgdGhl ICdmb3InIGxvb3Agb2YgdGhlICdnZXQnIAp2ZXJzaW9uIHdhcyB1bmNvbmRpdGlvbmFsIGFuZCBv bmx5IHRoZSAnZ2V0X2lmX2luX3VzZScgdmVyc2lvbiBjb3VsZCAKc2tpcC4gRS5nLiBzb21ldGhp bmcgbGlrZToKIMKgwqAgZm9yIChpbnRlbF93YWtlcmVmX3QgbG9vcCA9IC0xLCB3ZiA9IGludGVs X3J1bnRpbWVfcG1fZ2V0KGk5MTUpIDsgCmxvb3A7IGludGVsX3J1bnRpbWVfcG1fcHV0KGk5MTUs IHdmKSwgd2YgPSBsb29wID0gMCkKCkFsdGhvdWdoIHRoYXQgZG9lcyBtZWFuIHRoZSB3ZiBiZWNv bWVzIGxvY2FsIHRvIHRoZSBsb29wLiBPbiB0aGUgb3RoZXIgCmhhbmQsIEknbSBhbHNvIG5vdCBz dXJlIHdoeSBpdCBuZWVkcyB0byBiZSBleHRlcm5hbCBhbnl3YXk/IElmIGl0IGlzIApndWFyYW50 ZWVkIHRvIGJlIHplcm8gb24gZXhpdCBhbmQgYW55IHZhbHVlIG9uIGVudHJ5IGlzIG92ZXJ3cml0 dGVuLCAKdGhlbiB3aHkgaGF2ZSBpdCBleHRlcm5hbCBhdCBhbGw/IFdvdWxkIGl0IG5vdCBiZSBu ZWF0ZXIvc21hbGxlciBzb3VyY2UgCnRvIGdldCByaWQgb2YgYWxsIHRoZSBsb2NhbCBpbnN0YW50 aWF0aW9ucz8KCkpvaG4uCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRl bC1nZngK