From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37E52C2D0E4 for ; Mon, 23 Nov 2020 11:10:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D5D6920773 for ; Mon, 23 Nov 2020 11:10:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WHelm+4Q" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726481AbgKWLJj (ORCPT ); Mon, 23 Nov 2020 06:09:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43316 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728493AbgKWLJj (ORCPT ); Mon, 23 Nov 2020 06:09:39 -0500 Received: from mail-lj1-x243.google.com (mail-lj1-x243.google.com [IPv6:2a00:1450:4864:20::243]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 00167C0613CF; Mon, 23 Nov 2020 03:09:38 -0800 (PST) Received: by mail-lj1-x243.google.com with SMTP id y10so2055631ljc.7; Mon, 23 Nov 2020 03:09:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=HjhWcAaLBjKIfTeObnhdOKRy227KwdAp+UqnwppLEWI=; b=WHelm+4QW3NjS5hvpThLZGiJxH5KsGlwbrRwZby2wckI/my8pTg1phIaEVYb5x3nnf HEkYvOiUAJmXgZnqtSXVyRbMM4ZJ55iBpMuPvtwJSeS8GvMiFcja1PeVAHJ/btpbpSte 38U4fZ83Jqww1DP6RKVdhfR4hA3xYVOqDDax7sdr59HG59roaCv5Mui48v/LMDWKNYin W/E8Zp9fi/qP1wlba8m2I3h7wVWQDhbCRdlE97WIRVZ4vU/kHOc9zsZTTAcdl7XrlxFp W8NKttWDUTzB6sFWOa674LGXhTBnf6RhvDfm4t4PGp6FYefLP9q26r7HW4mMtDgv5B5J KYCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=HjhWcAaLBjKIfTeObnhdOKRy227KwdAp+UqnwppLEWI=; b=U2wMzVGeOYAYeTTcWKo1J36oWPHdDkILLhcNUzAilYaWWZXo65ydzSqLQWDouJJ64Q oRJWPCkfyyEgMl+l2X2ACgf2vio+N1RjNpS9AxqcILd1GmtwnfsI7iZoEJVZ9eTUwRHB PsS08SfNWiRmT5F4SPfxNWnHP4Pz7nOx1KoQlv2/jGyOh8DPXVbDn276PmJFHPNNHl9C YZEE/41zDsCKCYEFrXVyBfm/YHQgNwPcugom+IR2OLPlDhTj5W6Xtr4uaRVLvIe4pS5v Mxhh88FdU1DB7bLxO/Acr7H/H5liPtZSQkjykTyPNBItgXKf0YmX4D6Y2d3OrZj+DAVF VScQ== X-Gm-Message-State: AOAM533K4uodWjeSwHxAmdmSN/7cHsb+5dBLStm+xzmQucCs2+PosQTC /jlRp2lKJYm8J53o8+WSlok= X-Google-Smtp-Source: ABdhPJyOFvVIdsi0jiEe2T330ZoRH2zbRtblSjL0rkMfbu56kP8aihxZt4/W61FVuc6ZGdm5iYBUgQ== X-Received: by 2002:a2e:924e:: with SMTP id v14mr13723829ljg.264.1606129777498; Mon, 23 Nov 2020 03:09:37 -0800 (PST) Received: from [192.168.2.145] (109-252-193-159.dynamic.spd-mgts.ru. [109.252.193.159]) by smtp.googlemail.com with ESMTPSA id h4sm1339738lfk.224.2020.11.23.03.09.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Nov 2020 03:09:36 -0800 (PST) Subject: Re: [PATCH v5 2/4] staging: media: Introduce NVIDIA Tegra video decoder driver To: Ezequiel Garcia Cc: Thierry Reding , Jonathan Hunter , Stephen Warren , Greg Kroah-Hartman , Mauro Carvalho Chehab , Hans Verkuil , Vladimir Zapolskiy , Rob Herring , Dan Carpenter , linux-media , devel@driverdev.osuosl.org, devicetree , linux-tegra@vger.kernel.org, Linux Kernel Mailing List , Nicolas Dufresne References: <3d565db80f8dccafd14224924305243b37b75a07.1513038011.git.digetx@gmail.com> <5665b221-04d7-6be9-2377-8006b9563d4b@gmail.com> From: Dmitry Osipenko Message-ID: <8372dd41-64b9-64e1-960d-7b20717d5c1e@gmail.com> Date: Mon, 23 Nov 2020 14:09:20 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org 23.11.2020 06:07, Ezequiel Garcia пишет: > On Sat, 21 Nov 2020 at 23:01, Dmitry Osipenko wrote: >> >> 22.11.2020 04:02, Ezequiel Garcia пишет: >>> Hi Dmitry, >>> >> ... >>>> +++ b/drivers/staging/media/tegra-vde/TODO >>>> @@ -0,0 +1,4 @@ >>>> +TODO: >>>> + - Implement V4L2 API once it gains support for stateless decoders. >>>> + >>>> +Contact: Dmitry Osipenko >>> >>> The API for H264 stateless decoding is ready. >>> See https://lkml.org/lkml/2020/11/18/795. >> >> Hello Ezequiel, >> >> Thank you for the notification! My last attempt at implementing V4L API >> support was about a year ago and it stopped once I realized that there >> is no userspace which uses that API. FFMPEG and chromium browser had >> some kind of V4L support, but it all was oriented at downstream driver >> stacks, and thus, not usable. Do you know what is the current status? >> > > The bulk of the API, which relies on the stateless decoder interface [1], > and H264 stateless V4L2 controls has been ready for some time now, > and there are various implementations supporting it. > > Chromium supports it [2], and I've tested it on chromebooks, > through chromeos builds. We haven't tried a non-chromeos build, > and I would say it's quite some work. > > GStreamer support is available as well. See [3] which should > work for the latest H264 controls (the ones being moved out of staging). > > LibreELEC developers maintain an Ffmpeg branch [4], I expect it will > be updated for the latest H264 controls soon, and hopefully merged > in mainline Ffmpeg. > > GStreamer and Ffmpeg are relatively straightforward to build and test. > > Thanks, > Ezequiel > > [1] https://www.kernel.org/doc/html/latest/userspace-api/media/v4l/dev-stateless-decoder.html > [2] https://github.com/chromium/chromium/tree/master/media/gpu/v4l2 > [3] https://gitlab.freedesktop.org/ezequielgarcia/gst-plugins-bad/-/tree/h264_stable_uapi > [4] https://github.com/Kwiboo/FFmpeg/tree/v4l2-request-hwaccel-4.3. Alright, thank you. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.0 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 006B9C2D0E4 for ; Mon, 23 Nov 2020 11:09:47 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8497C20729 for ; Mon, 23 Nov 2020 11:09:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WHelm+4Q" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8497C20729 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id EA9AA86772; Mon, 23 Nov 2020 11:09:45 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Gy9tdJS9No1Z; Mon, 23 Nov 2020 11:09:43 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by whitealder.osuosl.org (Postfix) with ESMTP id DF18286765; Mon, 23 Nov 2020 11:09:43 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 30F5E1BF47A for ; Mon, 23 Nov 2020 11:09:42 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 18DA02002D for ; Mon, 23 Nov 2020 11:09:42 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1NcxyDAEdeLL for ; Mon, 23 Nov 2020 11:09:40 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-lj1-f194.google.com (mail-lj1-f194.google.com [209.85.208.194]) by silver.osuosl.org (Postfix) with ESMTPS id 7C7E020009 for ; Mon, 23 Nov 2020 11:09:39 +0000 (UTC) Received: by mail-lj1-f194.google.com with SMTP id s9so17476931ljo.11 for ; Mon, 23 Nov 2020 03:09:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=HjhWcAaLBjKIfTeObnhdOKRy227KwdAp+UqnwppLEWI=; b=WHelm+4QW3NjS5hvpThLZGiJxH5KsGlwbrRwZby2wckI/my8pTg1phIaEVYb5x3nnf HEkYvOiUAJmXgZnqtSXVyRbMM4ZJ55iBpMuPvtwJSeS8GvMiFcja1PeVAHJ/btpbpSte 38U4fZ83Jqww1DP6RKVdhfR4hA3xYVOqDDax7sdr59HG59roaCv5Mui48v/LMDWKNYin W/E8Zp9fi/qP1wlba8m2I3h7wVWQDhbCRdlE97WIRVZ4vU/kHOc9zsZTTAcdl7XrlxFp W8NKttWDUTzB6sFWOa674LGXhTBnf6RhvDfm4t4PGp6FYefLP9q26r7HW4mMtDgv5B5J KYCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=HjhWcAaLBjKIfTeObnhdOKRy227KwdAp+UqnwppLEWI=; b=XjHGlGNNwxkx/CvTQIWQ0fRmw8nv8n/28mYfwOzdQqF6idEk2k83SVqU0zvILa+Jz3 UYPUtD1R2THINs9warjKR1XPNX3DFLQafOiRIFsFNx7owVEZ1ne9KRQ0bxV6VGK/04d2 UGSsCtj5qA7/OvFY0bSjkHssd8A9+CJax4s39XDzLg4VykGDq+FFLKFomDX0R3z1j4Xf TrvZuxC6vzKK3RfZu2VDAj8cKUY7tYW5lhMy8RT4efGXzgveNEoGt+WByKgy6/Jal3TU GMN66LkMyroJYDq5+cgeU04RXDfGHek291WucpvAP65oo1hZVGiWFXKC4mTJX+hubdXo +oiw== X-Gm-Message-State: AOAM533urto9kLMcHAIxIfbR2krWLSId+YAiYAegPgqQZpIljz4bUIBw P609yPbDuWG0XkarPLtilmk= X-Google-Smtp-Source: ABdhPJyOFvVIdsi0jiEe2T330ZoRH2zbRtblSjL0rkMfbu56kP8aihxZt4/W61FVuc6ZGdm5iYBUgQ== X-Received: by 2002:a2e:924e:: with SMTP id v14mr13723829ljg.264.1606129777498; Mon, 23 Nov 2020 03:09:37 -0800 (PST) Received: from [192.168.2.145] (109-252-193-159.dynamic.spd-mgts.ru. [109.252.193.159]) by smtp.googlemail.com with ESMTPSA id h4sm1339738lfk.224.2020.11.23.03.09.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Nov 2020 03:09:36 -0800 (PST) Subject: Re: [PATCH v5 2/4] staging: media: Introduce NVIDIA Tegra video decoder driver To: Ezequiel Garcia References: <3d565db80f8dccafd14224924305243b37b75a07.1513038011.git.digetx@gmail.com> <5665b221-04d7-6be9-2377-8006b9563d4b@gmail.com> From: Dmitry Osipenko Message-ID: <8372dd41-64b9-64e1-960d-7b20717d5c1e@gmail.com> Date: Mon, 23 Nov 2020 14:09:20 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.2 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, devicetree , Nicolas Dufresne , Stephen Warren , Greg Kroah-Hartman , Linux Kernel Mailing List , Rob Herring , Jonathan Hunter , Hans Verkuil , Vladimir Zapolskiy , Thierry Reding , linux-tegra@vger.kernel.org, Mauro Carvalho Chehab , Dan Carpenter , linux-media Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" MjMuMTEuMjAyMCAwNjowNywgRXplcXVpZWwgR2FyY2lhINC/0LjRiNC10YI6Cj4gT24gU2F0LCAy MSBOb3YgMjAyMCBhdCAyMzowMSwgRG1pdHJ5IE9zaXBlbmtvIDxkaWdldHhAZ21haWwuY29tPiB3 cm90ZToKPj4KPj4gMjIuMTEuMjAyMCAwNDowMiwgRXplcXVpZWwgR2FyY2lhINC/0LjRiNC10YI6 Cj4+PiBIaSBEbWl0cnksCj4+Pgo+PiAuLi4KPj4+PiArKysgYi9kcml2ZXJzL3N0YWdpbmcvbWVk aWEvdGVncmEtdmRlL1RPRE8KPj4+PiBAQCAtMCwwICsxLDQgQEAKPj4+PiArVE9ETzoKPj4+PiAr ICAgICAgIC0gSW1wbGVtZW50IFY0TDIgQVBJIG9uY2UgaXQgZ2FpbnMgc3VwcG9ydCBmb3Igc3Rh dGVsZXNzIGRlY29kZXJzLgo+Pj4+ICsKPj4+PiArQ29udGFjdDogRG1pdHJ5IE9zaXBlbmtvIDxk aWdldHhAZ21haWwuY29tPgo+Pj4KPj4+IFRoZSBBUEkgZm9yIEgyNjQgc3RhdGVsZXNzIGRlY29k aW5nIGlzIHJlYWR5Lgo+Pj4gU2VlIGh0dHBzOi8vbGttbC5vcmcvbGttbC8yMDIwLzExLzE4Lzc5 NS4KPj4KPj4gSGVsbG8gRXplcXVpZWwsCj4+Cj4+IFRoYW5rIHlvdSBmb3IgdGhlIG5vdGlmaWNh dGlvbiEgTXkgbGFzdCBhdHRlbXB0IGF0IGltcGxlbWVudGluZyBWNEwgQVBJCj4+IHN1cHBvcnQg d2FzIGFib3V0IGEgeWVhciBhZ28gYW5kIGl0IHN0b3BwZWQgb25jZSBJIHJlYWxpemVkIHRoYXQg dGhlcmUKPj4gaXMgbm8gdXNlcnNwYWNlIHdoaWNoIHVzZXMgdGhhdCBBUEkuIEZGTVBFRyBhbmQg Y2hyb21pdW0gYnJvd3NlciBoYWQKPj4gc29tZSBraW5kIG9mIFY0TCBzdXBwb3J0LCBidXQgaXQg YWxsIHdhcyBvcmllbnRlZCBhdCBkb3duc3RyZWFtIGRyaXZlcgo+PiBzdGFja3MsIGFuZCB0aHVz LCBub3QgdXNhYmxlLiBEbyB5b3Uga25vdyB3aGF0IGlzIHRoZSBjdXJyZW50IHN0YXR1cz8KPj4K PiAKPiBUaGUgYnVsayBvZiB0aGUgQVBJLCB3aGljaCByZWxpZXMgb24gdGhlIHN0YXRlbGVzcyBk ZWNvZGVyIGludGVyZmFjZSBbMV0sCj4gYW5kIEgyNjQgc3RhdGVsZXNzIFY0TDIgY29udHJvbHMg aGFzIGJlZW4gcmVhZHkgZm9yIHNvbWUgdGltZSBub3csCj4gYW5kIHRoZXJlIGFyZSB2YXJpb3Vz IGltcGxlbWVudGF0aW9ucyBzdXBwb3J0aW5nIGl0Lgo+IAo+IENocm9taXVtIHN1cHBvcnRzIGl0 IFsyXSwgYW5kIEkndmUgdGVzdGVkIGl0IG9uIGNocm9tZWJvb2tzLAo+IHRocm91Z2ggY2hyb21l b3MgYnVpbGRzLiBXZSBoYXZlbid0IHRyaWVkIGEgbm9uLWNocm9tZW9zIGJ1aWxkLAo+IGFuZCBJ IHdvdWxkIHNheSBpdCdzIHF1aXRlIHNvbWUgd29yay4KPiAKPiBHU3RyZWFtZXIgc3VwcG9ydCBp cyBhdmFpbGFibGUgYXMgd2VsbC4gU2VlIFszXSB3aGljaCBzaG91bGQKPiB3b3JrIGZvciB0aGUg bGF0ZXN0IEgyNjQgY29udHJvbHMgKHRoZSBvbmVzIGJlaW5nIG1vdmVkIG91dCBvZiBzdGFnaW5n KS4KPiAKPiBMaWJyZUVMRUMgZGV2ZWxvcGVycyBtYWludGFpbiBhbiBGZm1wZWcgYnJhbmNoIFs0 XSwgSSBleHBlY3QgaXQgd2lsbAo+IGJlIHVwZGF0ZWQgZm9yIHRoZSBsYXRlc3QgSDI2NCBjb250 cm9scyBzb29uLCBhbmQgaG9wZWZ1bGx5IG1lcmdlZAo+IGluIG1haW5saW5lIEZmbXBlZy4KPiAK PiBHU3RyZWFtZXIgYW5kIEZmbXBlZyBhcmUgcmVsYXRpdmVseSBzdHJhaWdodGZvcndhcmQgdG8g YnVpbGQgYW5kIHRlc3QuCj4gCj4gVGhhbmtzLAo+IEV6ZXF1aWVsCj4gCj4gWzFdIGh0dHBzOi8v d3d3Lmtlcm5lbC5vcmcvZG9jL2h0bWwvbGF0ZXN0L3VzZXJzcGFjZS1hcGkvbWVkaWEvdjRsL2Rl di1zdGF0ZWxlc3MtZGVjb2Rlci5odG1sCj4gWzJdIGh0dHBzOi8vZ2l0aHViLmNvbS9jaHJvbWl1 bS9jaHJvbWl1bS90cmVlL21hc3Rlci9tZWRpYS9ncHUvdjRsMgo+IFszXSBodHRwczovL2dpdGxh Yi5mcmVlZGVza3RvcC5vcmcvZXplcXVpZWxnYXJjaWEvZ3N0LXBsdWdpbnMtYmFkLy0vdHJlZS9o MjY0X3N0YWJsZV91YXBpCj4gWzRdIGh0dHBzOi8vZ2l0aHViLmNvbS9Ld2lib28vRkZtcGVnL3Ry ZWUvdjRsMi1yZXF1ZXN0LWh3YWNjZWwtNC4zLgoKQWxyaWdodCwgdGhhbmsgeW91LgoKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZGV2ZWwgbWFpbGluZyBs aXN0CmRldmVsQGxpbnV4ZHJpdmVycHJvamVjdC5vcmcKaHR0cDovL2RyaXZlcmRldi5saW51eGRy aXZlcnByb2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8vZHJpdmVyZGV2LWRldmVsCg==