All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@gmail.com>
Cc: QEMU <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v2 03/13] build-sys: add a rule to print a variable
Date: Tue, 19 Dec 2017 10:31:18 -0600	[thread overview]
Message-ID: <8374b80f-76c8-66c9-9fb4-6be3032231e2@redhat.com> (raw)
In-Reply-To: <CAJ+F1C+kddTNemSB7yzf7uVpyrM3by2n3bscp56BTBRXuxoFZw@mail.gmail.com>

On 12/19/2017 09:45 AM, Marc-André Lureau wrote:

>>> +Useful make targets
>>> +===================
>>> +
>>> +- help
>>> +
>>> +  Print a help message for the most common build targets.
>>
>> Except that this patch forgot to tweak 'make help' to mention 'make
>> print-VAR' ;)
> 
> Well, I don't think print-VAR is a common build target, it's a
> build-sys hack/debug imho, so having it described in build-system.txt
> only make sense.
> 
> Do you agree?

With the bash-completion library installed, performing tab-completion on 
'make ' produces a large list of targets, which includes 'help', but 
even with your patch does NOT include 'print-CFLAGS' or any variant of 
print-.  If I use just tab-completion and 'make help', then having 
'print-FOO' listed under the "Generic targets:" section of the help 
output would let me discover it without me having to read build-system.txt.

Does anyone else have a strong opinion for or against the additional 
output in 'make help'?

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

  reply	other threads:[~2017-12-19 16:31 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-15 15:06 [Qemu-devel] [PATCH v2 00/13] Various build-sys and ASAN related fixes Marc-André Lureau
2017-12-15 15:06 ` [Qemu-devel] [PATCH v2 01/13] build-sys: fix qemu-ga -pthread linking Marc-André Lureau
2017-12-15 18:21   ` Philippe Mathieu-Daudé
2017-12-15 18:31     ` Peter Maydell
2017-12-19 15:43     ` Marc-André Lureau
2017-12-15 15:06 ` [Qemu-devel] [PATCH v2 02/13] build-sys: silence make by default or V=0 Marc-André Lureau
2017-12-19 16:35   ` Eric Blake
2018-01-02 15:49     ` Marc-André Lureau
2018-01-02 17:33       ` Paolo Bonzini
2018-01-02 17:58         ` Marc-André Lureau
2018-01-02 18:02           ` Paolo Bonzini
2017-12-15 15:06 ` [Qemu-devel] [PATCH v2 03/13] build-sys: add a rule to print a variable Marc-André Lureau
2017-12-15 18:28   ` Eric Blake
2017-12-19 15:45     ` Marc-André Lureau
2017-12-19 16:31       ` Eric Blake [this message]
2017-12-15 15:06 ` [Qemu-devel] [PATCH v2 04/13] build-sys: add AddressSanitizer when --enable-debug if possible Marc-André Lureau
2017-12-19 15:48   ` Marc-André Lureau
2018-01-02 15:49     ` Marc-André Lureau
2018-01-02 17:31       ` Paolo Bonzini
2018-01-03 17:52         ` Peter Maydell
2018-01-03 18:02           ` Marc-André Lureau
2018-01-03 18:10             ` Paolo Bonzini
2017-12-15 15:06 ` [Qemu-devel] [PATCH v2 05/13] tests: fix check-qobject leak: Marc-André Lureau
2017-12-15 18:17   ` Philippe Mathieu-Daudé
2017-12-15 15:06 ` [Qemu-devel] [PATCH v2 06/13] vl: fix direct firmware directories leak Marc-André Lureau
2017-12-15 18:30   ` Eric Blake
2017-12-15 15:06 ` [Qemu-devel] [PATCH v2 07/13] readline: add a free function Marc-André Lureau
2017-12-15 18:16   ` Philippe Mathieu-Daudé
2017-12-15 15:06 ` [Qemu-devel] [PATCH v2 08/13] tests: fix migration-test leak Marc-André Lureau
2017-12-15 18:08   ` Philippe Mathieu-Daudé
2017-12-15 15:06 ` [Qemu-devel] [PATCH v2 09/13] crypto: fix stack-buffer-overflow error Marc-André Lureau
2017-12-15 15:06 ` [Qemu-devel] [PATCH v2 10/13] qemu-config: fix leak in query-command-line-options Marc-André Lureau
2017-12-15 18:35   ` Eric Blake
2017-12-15 15:06 ` [Qemu-devel] [PATCH v2 11/13] tests: fix qmp-test leak Marc-André Lureau
2017-12-15 18:11   ` Philippe Mathieu-Daudé
2017-12-15 15:06 ` [Qemu-devel] [PATCH v2 12/13] ucontext: annotate coroutine stack for ASAN Marc-André Lureau
2017-12-15 18:10   ` Philippe Mathieu-Daudé
2017-12-15 18:39   ` Eric Blake
2017-12-18 13:30   ` Stefan Hajnoczi
2017-12-15 15:06 ` [Qemu-devel] [PATCH v2 13/13] tests: fix coroutine leak in /basic/entered Marc-André Lureau
2017-12-18 13:25   ` Stefan Hajnoczi
2017-12-15 15:22 ` [Qemu-devel] [PATCH v2 00/13] Various build-sys and ASAN related fixes Marc-André Lureau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8374b80f-76c8-66c9-9fb4-6be3032231e2@redhat.com \
    --to=eblake@redhat.com \
    --cc=marcandre.lureau@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.