From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by smtp.lore.kernel.org (Postfix) with ESMTP id DDCC9C61DA4
	for <dpdk-dev@archiver.kernel.org>; Thu,  2 Feb 2023 17:16:40 +0000 (UTC)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 15F0C410D7;
	Thu,  2 Feb 2023 18:16:40 +0100 (CET)
Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com
 [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id AD2AE40693
 for <dev@dpdk.org>; Thu,  2 Feb 2023 18:16:37 +0100 (CET)
Received: from compute6.internal (compute6.nyi.internal [10.202.2.47])
 by mailout.nyi.internal (Postfix) with ESMTP id 3C4E85C0190;
 Thu,  2 Feb 2023 12:16:36 -0500 (EST)
Received: from mailfrontend2 ([10.202.2.163])
 by compute6.internal (MEProxy); Thu, 02 Feb 2023 12:16:36 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:cc:content-transfer-encoding:content-type:date:date:from:from
 :in-reply-to:in-reply-to:message-id:mime-version:references
 :reply-to:sender:subject:subject:to:to; s=fm3; t=1675358196; x=
 1675444596; bh=APGeSJ553J4Mk4hmHxNNWEDhwCDxS4NaJCiDE4Zh4gk=; b=A
 hrwy4kdWjtY+qvfYK5Jg0d06AjA/KFrlLF9rXAc/j5LTEqOvf1HemQ8tqCaLH0Ma
 vqzf4RIsy9vmLsRuIqyP/2U9hu4gzLyoQVlVOpEnVC6W2Gj+ToMij2Yn7vXgEyVy
 cA7wX0YaRf21U3UTFhHwC4Kz7bEQkLPLvn9PAGZiHHdQ24cN/zLinLija4dRxXWB
 pnZfALScuuUznxnJkuGsccfr5q7IQgGkIfahdWJDHd9Cma3mQBtyjEDV3yK6LA70
 QgURx2orHaKW8YqPVf6lRb6lFGlzoMDuAVzZFgPB0Ol1o3szBW+Go7zloQfZmkIV
 Ig3L2ZwuGIOeT1P2f/udw==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:cc:content-transfer-encoding
 :content-type:date:date:feedback-id:feedback-id:from:from
 :in-reply-to:in-reply-to:message-id:mime-version:references
 :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy
 :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1675358196; x=
 1675444596; bh=APGeSJ553J4Mk4hmHxNNWEDhwCDxS4NaJCiDE4Zh4gk=; b=b
 LRX0qMcDwLB2vrqmrJ9z+LEVse9ESZUgTUZQRdkhQ04QjA53PguD2KvXITHcDnvD
 bp8iqBAPqv3j5VYJ8QZ7pWu16NGzJmOP6wQPgiU8s5ldfEFHZc/UGiBkPaubmQC0
 srMauMuqi5KLCInahsK+LV3+FiYKZO7GgoK6J0n6wTOQ792R8OpgKVSiLHdzrVBW
 6jNICDEugbwDq0fswNe+bB3yaZYWYrC6XW8Q0GY8S9HWB0tjcbQX2JSnl9yrBH4O
 ZFaN+F56i0Nkcwt7KCfIgHee+UdjHEYVorxcaMAbRzshLL+nQkTP/DeaeHZTqewM
 4ZeS4PHXSpoFuxU9N5rXQ==
X-ME-Sender: <xms:8-_bYwfpcUq98uvQpZoZPnPpNq-4yXFi8LsWaPUrW4ojbJKnGN4qVw>
 <xme:8-_bYyOeRjZnw9kFo-IwHgR0eoicywc8dssQxFMIcFGjwyReM8WXmXhaE50OebsbY
 S1tzXhjP7gdiHL2Yw>
X-ME-Received: <xmr:8-_bYxgfyaeXu8H6U0r6WblA5PyzWsRaNKefAiS2zJlbmnkU5a7nmghMvHLuzQ6QFxQ_gBYXCQrGv90cC-bTZbXBVg>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudefkedgleegucetufdoteggodetrfdotf
 fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
 uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
 cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm
 rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc
 ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei
 kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh
 hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght
X-ME-Proxy: <xmx:8-_bY185leFHSa_X0KgK855UPGCqy1hQHSsUfZzagxSXXmy4KmtK4Q>
 <xmx:8-_bY8uL7J8RlPkz6-g9v-LwgqdaviKZwWxLdtN5DFSzALujoDrhnA>
 <xmx:8-_bY8GDWgco9jsUsZMTLIiaXSn33gynuIGap0RKwrVutumEKF_Hpw>
 <xmx:9O_bYwMoRIjKLeETjBGHa7rSnisoQD80SqQhKDFIRk89Fzii7c02gQ>
Feedback-ID: i47234305:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu,
 2 Feb 2023 12:16:33 -0500 (EST)
From: Thomas Monjalon <thomas@monjalon.net>
To: Ferruh Yigit <ferruh.yigit@amd.com>
Cc: Wisam Jaddo <wisamm@nvidia.com>, Ori Kam <orika@nvidia.com>,
 Aman Singh <aman.deep.singh@intel.com>,
 Yuying Zhang <yuying.zhang@intel.com>,
 Ajit Khaparde <ajit.khaparde@broadcom.com>,
 Somnath Kotur <somnath.kotur@broadcom.com>,
 Hemant Agrawal <hemant.agrawal@nxp.com>,
 Sachin Saxena <sachin.saxena@nxp.com>, Matan Azrad <matan@nvidia.com>,
 Viacheslav Ovsiienko <viacheslavo@nvidia.com>,
 Chaoyong He <chaoyong.he@corigine.com>,
 Niklas =?ISO-8859-1?Q?S=F6derlund?= <niklas.soderlund@corigine.com>,
 Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
 Olivier Matz <olivier.matz@6wind.com>,
 David Marchand <david.marchand@redhat.com>, dev@dpdk.org
Subject: Re: [PATCH v6 4/8] ethdev: use GRE protocol struct for flow matching
Date: Thu, 02 Feb 2023 18:16:32 +0100
Message-ID: <837964623.0ifERbkFSE@thomas>
In-Reply-To: <20230202124500.2578857-5-ferruh.yigit@amd.com>
References: <20221025214410.715864-1-thomas@monjalon.net>
 <20230202124500.2578857-1-ferruh.yigit@amd.com>
 <20230202124500.2578857-5-ferruh.yigit@amd.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

02/02/2023 13:44, Ferruh Yigit:
> --- a/lib/net/rte_gre.h
> +++ b/lib/net/rte_gre.h
> @@ -28,6 +28,8 @@ extern "C" {
>   */
>  __extension__
>  struct rte_gre_hdr {
> +       union {
> +               struct {
>  #if RTE_BYTE_ORDER == RTE_LITTLE_ENDIAN
>         uint16_t res2:4; /**< Reserved */
>         uint16_t s:1;    /**< Sequence Number Present bit */
> @@ -45,6 +47,9 @@ struct rte_gre_hdr {
>         uint16_t res3:5; /**< Reserved */
>         uint16_t ver:3;  /**< Version Number */
>  #endif
> +               };
> +               rte_be16_t c_rsvd0_ver;
> +       };
>         uint16_t proto;  /**< Protocol Type */

Why adding an unioned field c_rsvd0_ver?