All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Verma, Vishal L" <vishal.l.verma@intel.com>
To: "Williams, Dan J" <dan.j.williams@intel.com>,
	"decui@microsoft.com" <decui@microsoft.com>
Cc: "mikelley@microsoft.com" <mikelley@microsoft.com>,
	"qi.fuli@fujitsu.com" <qi.fuli@fujitsu.com>,
	"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>
Subject: Re: [ndctl PATCH v2 4/4] ndctl, monitor: support NVDIMM_FAMILY_HYPERV
Date: Fri, 22 Mar 2019 18:28:39 +0000	[thread overview]
Message-ID: <837eed30b0da59f91e5114aad97e919068a077e8.camel@intel.com> (raw)
In-Reply-To: <PU1P153MB01696BBE1F8859624E5452B0BF430@PU1P153MB0169.APCP153.PROD.OUTLOOK.COM>


On Fri, 2019-03-22 at 17:55 +0000, Dexuan Cui wrote:
> > From: Dan Williams <dan.j.williams@intel.com>
> > Sent: Thursday, March 21, 2019 11:12 PM
> > To: Dexuan Cui <decui@microsoft.com>
> > 
> > On Thu, Mar 21, 2019 at 11:03 PM Dexuan Cui <decui@microsoft.com> wrote:
> > > > From: Dan Williams <dan.j.williams@intel.com>
> > > > Sent: Thursday, March 21, 2019 10:37 PM
> > > > 
> > > > No, I think you misunderstand. Hyper-V implements "function-1",
> > > > "command-1" support can be emulated. The request is to translate the
> > > > Hyper-V function-1 payload into the command-1 payload format.
> > > 
> > > Then, yes, I think so. The first 2 patches of this patchset do the translation:
> > > 
> > > [ndctl,v2,1/4] libndctl: add support for NVDIMM_FAMILY_HYPERV's _DSM
> > Function 1
> > > [ndctl,v2,2/4] libndctl: NVDIMM_FAMILY_HYPERV:
> > add .smart_get_shutdown_count (Function 2)
> > > The problem is how to skip the checkings in ndctl/monitor.c: filter_dimm() on
> > Hyper-V.
> > > If we return early in filter_dimm(), mfa->num_dimm will be zero, then
> > monitor_event()
> > > can't be called, and we have no chance to monitor the events and do the
> > translation.
> > 
> > I'd rather change ndctl_dimm_cmd_is_supported() to call back into a
> > dimm-op so that the Hyper-V implementation can say "yes, I support
> > (emulate) the necessary monitor commands".
> 
> Hi Dan,
> Then we need to add a new dimm-op monitor_supported(), and change 
> ndctl/lib/intel.c and ndctl/lib/hyper.c to implement the new dimm-op, and we
> need to change the common code, i.e. ndctl_dimm_cmd_is_supported(), to use
> this new dimm-op.
> 
> If this sounds reasonable to you and Verma, I'll try to make a patchset for you
> to review.

Yep this approach sounds good to me!

> 
> Thanks,
> -- Dexuan

_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

  parent reply	other threads:[~2019-03-22 18:28 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-20  5:11 [ndctl PATCH v2 4/4] ndctl, monitor: support NVDIMM_FAMILY_HYPERV Dexuan Cui
2019-02-21  8:40 ` qi.fuli
     [not found]   ` <OSBPR01MB50009900A5FE2E8588AA6367F77E0-zhdMvvdcU0ZckHoPmfvix3colHNk5qUtvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2019-02-21 18:30     ` Dexuan Cui
2019-02-25  4:48       ` qi.fuli
     [not found]         ` <OSAPR01MB4993163079F35EEF06DFBB44F77A0-OxqQCv4d1nTzcNm8D4NKs3colHNk5qUtvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2019-02-25  5:16           ` Dexuan Cui
2019-03-21  1:54 ` Verma, Vishal L
     [not found]   ` <9876fd8a491e339f2f41a47e2195d354bf0d5fb2.camel-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2019-03-22  2:08     ` Dexuan Cui
2019-03-22  3:31       ` Dan Williams
     [not found]       ` <PU1P153MB0169CA436F52268DD2BEF745BF430-7hHSCQUTt08p9lVGRpUb+2HfQuWdHs3hiGd9ebBGJoev3QGu/rdwKA@public.gmane.org>
2019-03-22  4:05         ` Dexuan Cui
2019-03-22  4:13           ` Dan Williams
     [not found]             ` <CAPcyv4hVZLW2OSMZ9NqqsQWMg7vxyS9J1ekDZW8G44cmD9_YCw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2019-03-22  5:09               ` Dexuan Cui
2019-03-22  5:36                 ` Dan Williams
     [not found]                   ` <CAPcyv4hM_DTcMJdWhWbtPFfVH_V-kYxXSSCg=MQZLoxVka=Mng-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2019-03-22  6:03                     ` Dexuan Cui
2019-03-22  6:11                       ` Dan Williams
     [not found]                         ` <CAPcyv4h4tAydacTbmZRKy7hmTqWTM22r6hD+Ucm_f3H2tQUm3g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2019-03-22 17:55                           ` Dexuan Cui
2019-03-22 18:03                             ` Dan Williams
     [not found]                               ` <CAPcyv4gMexBmWduqR8G=1H3gKkxbqfBADOLG595nVRipAxVukA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2019-03-22 18:09                                 ` Dexuan Cui
2019-03-22 18:28                             ` Verma, Vishal L [this message]
     [not found]                               ` <837eed30b0da59f91e5114aad97e919068a077e8.camel-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2019-03-23  4:24                                 ` Dexuan Cui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=837eed30b0da59f91e5114aad97e919068a077e8.camel@intel.com \
    --to=vishal.l.verma@intel.com \
    --cc=dan.j.williams@intel.com \
    --cc=decui@microsoft.com \
    --cc=linux-nvdimm@lists.01.org \
    --cc=mikelley@microsoft.com \
    --cc=qi.fuli@fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.