From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7C73AC25B0E for ; Mon, 15 Aug 2022 18:33:00 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id EA31840632; Mon, 15 Aug 2022 18:32:59 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org EA31840632 Authentication-Results: smtp4.osuosl.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=jdED2coZ X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MN3C5l511Oqs; Mon, 15 Aug 2022 18:32:59 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp4.osuosl.org (Postfix) with ESMTPS id D41A5405AA; Mon, 15 Aug 2022 18:32:58 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org D41A5405AA Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 95896C0032; Mon, 15 Aug 2022 18:32:58 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists.linuxfoundation.org (Postfix) with ESMTP id 610ABC002D for ; Mon, 15 Aug 2022 18:32:57 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 22A6F8142C for ; Mon, 15 Aug 2022 18:32:57 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 22A6F8142C Authentication-Results: smtp1.osuosl.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=jdED2coZ X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DzsNbA8dgyJQ for ; Mon, 15 Aug 2022 18:32:55 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 03BDF81332 Received: from mail-pj1-x102c.google.com (mail-pj1-x102c.google.com [IPv6:2607:f8b0:4864:20::102c]) by smtp1.osuosl.org (Postfix) with ESMTPS id 03BDF81332 for ; Mon, 15 Aug 2022 18:32:54 +0000 (UTC) Received: by mail-pj1-x102c.google.com with SMTP id q7-20020a17090a7a8700b001f300db8677so7477802pjf.5 for ; Mon, 15 Aug 2022 11:32:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=8bJQmDi/lCA9PqirReS3MPMutajyKB5RDjNh4fqCzaA=; b=jdED2coZKjWQwnNfe6vINVdrNYG/s4Ap5/xy5Gcip3nOeogSVmoaiJccuFjEMCn604 aiAZAQA12xrgovQ0EK7RmswbJp8NFIGlbMK7CJIoj829dlR/YYKVOetZHn6kiWBGYqVw iKFOwG4d+6zBCeFAM+4iDS7+9tD9UBi/j3bzxO26XKdYiOx4BB2DNlOWrPLyESziZRHe LEaQNj92ErOuotlQ1magSPuxiMp4HGWT4qlqOjqs26rIJlOdgx2ohKm85mKBuL0W3Xiz UuCSlnwEL0+m8YK540p/n30zlzjGqOSmL/ZEk6NbS6E6meNvlkJSA2GfQZf+c2O2OWU8 uGRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=8bJQmDi/lCA9PqirReS3MPMutajyKB5RDjNh4fqCzaA=; b=hIOkRld6bltfwG4+VF9KEVkFrDrus3+I6TcjmiRF/QX13jD3e3R0nhA9q572bKC/k5 D3hS8TMLJxc2mHZGKdokLlDivQ+HnTFfgv1XAL60f5jOhZtMCvJefmGQfK7dEh2NOks8 PY2fraE5Ls6zFUD0Yha4+yYeXUvikgquzCmfZOWylH8H0ohq5ifJ+Qt2UQobyAwerWzS EIxPAUbxxaVgBSltEM90b1HSDI53RySM2Xl+PdJS1gkPYR7j+j/xzrhepH7FYRO16g0B mBj3eCsBgNWb0yEH1dJbTifzq39y86+i8G/RriA8aYL5SxvYzagZDkNEziUm3H0hnSpk JxFw== X-Gm-Message-State: ACgBeo3MJqCEi1/qAAYoMEHluHUNwWnqV9cvSY3BVme1Bnff/ct+bp+u d5s3ZMqxkxMX27RIlSC59SI= X-Google-Smtp-Source: AA6agR6Clbh4D6hp8u1BwYfWLa6d/Cwe/QwEr2ontSg2+IYjxn4HZJNCGeWwoDVqjl6HR/cTznhCPA== X-Received: by 2002:a17:902:c201:b0:172:6c9d:14b9 with SMTP id 1-20020a170902c20100b001726c9d14b9mr7195297pll.161.1660588374426; Mon, 15 Aug 2022 11:32:54 -0700 (PDT) Received: from [192.168.0.110] ([103.159.189.148]) by smtp.gmail.com with ESMTPSA id 200-20020a6216d1000000b005289fad1bbesm7034667pfw.94.2022.08.15.11.32.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Aug 2022 11:32:53 -0700 (PDT) Message-ID: <83820e90-04ac-16cd-b5be-87e1a0bbfca8@gmail.com> Date: Tue, 16 Aug 2022 00:32:46 +0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH linux-next] drm/amdgpu/vcn: Remove unused assignment in vcn_v4_0_stop Content-Language: en-US To: "Dong, Ruijing" , "amd-gfx@lists.freedesktop.org" , "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , "linux-kernel-mentees@lists.linuxfoundation.org" References: <20220815070056.10816-1-khalid.masum.92@gmail.com> <86088c17-585c-4a53-312d-ef339b824538@gmail.com> From: Khalid Masum In-Reply-To: Cc: Wan Jiabing , David Airlie , "Pan, Xinhui" , "Jiang, Sonny" , Daniel Vetter , "Deucher, Alexander" , "Zhu, James" , "Liu, Leo" , "Koenig, Christian" X-BeenThere: linux-kernel-mentees@lists.linuxfoundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: linux-kernel-mentees-bounces@lists.linuxfoundation.org Sender: "Linux-kernel-mentees" On 8/15/22 22:00, Dong, Ruijing wrote: > [AMD Official Use Only - General] > > Then please update commit message, this change is due to "value r is never used, and remove unnecessary assignment", that makes sense to me. > > Thanks > Ruijing > Greg also pointed out that the function vcn_v4_0_stop_dpg_mode should return void. I shall send a patch shortly with these two changes. Thanks for your suggestion. Thanks, -- Khalid Masum _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EF6A6C25B0E for ; Mon, 15 Aug 2022 18:33:17 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7D42AC1048; Mon, 15 Aug 2022 18:33:09 +0000 (UTC) Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [IPv6:2607:f8b0:4864:20::1032]) by gabe.freedesktop.org (Postfix) with ESMTPS id EE875D0D18; Mon, 15 Aug 2022 18:32:54 +0000 (UTC) Received: by mail-pj1-x1032.google.com with SMTP id t2-20020a17090a4e4200b001f21572f3a4so7520325pjl.0; Mon, 15 Aug 2022 11:32:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=8bJQmDi/lCA9PqirReS3MPMutajyKB5RDjNh4fqCzaA=; b=jdED2coZKjWQwnNfe6vINVdrNYG/s4Ap5/xy5Gcip3nOeogSVmoaiJccuFjEMCn604 aiAZAQA12xrgovQ0EK7RmswbJp8NFIGlbMK7CJIoj829dlR/YYKVOetZHn6kiWBGYqVw iKFOwG4d+6zBCeFAM+4iDS7+9tD9UBi/j3bzxO26XKdYiOx4BB2DNlOWrPLyESziZRHe LEaQNj92ErOuotlQ1magSPuxiMp4HGWT4qlqOjqs26rIJlOdgx2ohKm85mKBuL0W3Xiz UuCSlnwEL0+m8YK540p/n30zlzjGqOSmL/ZEk6NbS6E6meNvlkJSA2GfQZf+c2O2OWU8 uGRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=8bJQmDi/lCA9PqirReS3MPMutajyKB5RDjNh4fqCzaA=; b=qDu02swJzIY4khoq6Ai+ihBPvayTfYFoFL2AFeJOkfoinxTqAd7PeHqIbhW1lMfwy5 ZOz8g5RgrW0VWbTtOoXju0Ex9Wm56HmtHoB4AC56HMfl+88UoIfwO0cpNr5hzmvVEGHX Fd8RCvUZ+yK83S8QyYeg9k0awtQEC06RlIQWoyDfrZsovNu6vMZwEkT64VR3TOuJ6vii hPNkiLV2+VQrbXdbZiFSXTeKX/LkQECuHPvbs4rZEyEtyim/vzSNAXa++PJTlf2j+jxM UlA5TGnHWFA2mv+iWHYQr/xIsxHfvUgJ2YKsVBMVj5EaZm9qznNwTBSjCZzFw6CcMIFG mH/g== X-Gm-Message-State: ACgBeo1gUXJCLNpL1FoH3piwKolwJFelskXG5Am4bkdKcFPYa1cGI61L 2vnFZzbuV0pLhdBuS7XcUXPc2ywWRmF7WZDG X-Google-Smtp-Source: AA6agR6Clbh4D6hp8u1BwYfWLa6d/Cwe/QwEr2ontSg2+IYjxn4HZJNCGeWwoDVqjl6HR/cTznhCPA== X-Received: by 2002:a17:902:c201:b0:172:6c9d:14b9 with SMTP id 1-20020a170902c20100b001726c9d14b9mr7195297pll.161.1660588374426; Mon, 15 Aug 2022 11:32:54 -0700 (PDT) Received: from [192.168.0.110] ([103.159.189.148]) by smtp.gmail.com with ESMTPSA id 200-20020a6216d1000000b005289fad1bbesm7034667pfw.94.2022.08.15.11.32.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Aug 2022 11:32:53 -0700 (PDT) Message-ID: <83820e90-04ac-16cd-b5be-87e1a0bbfca8@gmail.com> Date: Tue, 16 Aug 2022 00:32:46 +0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH linux-next] drm/amdgpu/vcn: Remove unused assignment in vcn_v4_0_stop Content-Language: en-US To: "Dong, Ruijing" , "amd-gfx@lists.freedesktop.org" , "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , "linux-kernel-mentees@lists.linuxfoundation.org" References: <20220815070056.10816-1-khalid.masum.92@gmail.com> <86088c17-585c-4a53-312d-ef339b824538@gmail.com> From: Khalid Masum In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Wan Jiabing , David Airlie , "Pan, Xinhui" , "Jiang, Sonny" , "Deucher, Alexander" , "Zhu, James" , "Liu, Leo" , "Koenig, Christian" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 8/15/22 22:00, Dong, Ruijing wrote: > [AMD Official Use Only - General] > > Then please update commit message, this change is due to "value r is never used, and remove unnecessary assignment", that makes sense to me. > > Thanks > Ruijing > Greg also pointed out that the function vcn_v4_0_stop_dpg_mode should return void. I shall send a patch shortly with these two changes. Thanks for your suggestion. Thanks, -- Khalid Masum From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A2DCBC282E7 for ; Mon, 15 Aug 2022 19:03:02 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EA88ED2679; Mon, 15 Aug 2022 19:02:57 +0000 (UTC) Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [IPv6:2607:f8b0:4864:20::1032]) by gabe.freedesktop.org (Postfix) with ESMTPS id EE875D0D18; Mon, 15 Aug 2022 18:32:54 +0000 (UTC) Received: by mail-pj1-x1032.google.com with SMTP id t2-20020a17090a4e4200b001f21572f3a4so7520325pjl.0; Mon, 15 Aug 2022 11:32:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=8bJQmDi/lCA9PqirReS3MPMutajyKB5RDjNh4fqCzaA=; b=jdED2coZKjWQwnNfe6vINVdrNYG/s4Ap5/xy5Gcip3nOeogSVmoaiJccuFjEMCn604 aiAZAQA12xrgovQ0EK7RmswbJp8NFIGlbMK7CJIoj829dlR/YYKVOetZHn6kiWBGYqVw iKFOwG4d+6zBCeFAM+4iDS7+9tD9UBi/j3bzxO26XKdYiOx4BB2DNlOWrPLyESziZRHe LEaQNj92ErOuotlQ1magSPuxiMp4HGWT4qlqOjqs26rIJlOdgx2ohKm85mKBuL0W3Xiz UuCSlnwEL0+m8YK540p/n30zlzjGqOSmL/ZEk6NbS6E6meNvlkJSA2GfQZf+c2O2OWU8 uGRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=8bJQmDi/lCA9PqirReS3MPMutajyKB5RDjNh4fqCzaA=; b=qDu02swJzIY4khoq6Ai+ihBPvayTfYFoFL2AFeJOkfoinxTqAd7PeHqIbhW1lMfwy5 ZOz8g5RgrW0VWbTtOoXju0Ex9Wm56HmtHoB4AC56HMfl+88UoIfwO0cpNr5hzmvVEGHX Fd8RCvUZ+yK83S8QyYeg9k0awtQEC06RlIQWoyDfrZsovNu6vMZwEkT64VR3TOuJ6vii hPNkiLV2+VQrbXdbZiFSXTeKX/LkQECuHPvbs4rZEyEtyim/vzSNAXa++PJTlf2j+jxM UlA5TGnHWFA2mv+iWHYQr/xIsxHfvUgJ2YKsVBMVj5EaZm9qznNwTBSjCZzFw6CcMIFG mH/g== X-Gm-Message-State: ACgBeo1gUXJCLNpL1FoH3piwKolwJFelskXG5Am4bkdKcFPYa1cGI61L 2vnFZzbuV0pLhdBuS7XcUXPc2ywWRmF7WZDG X-Google-Smtp-Source: AA6agR6Clbh4D6hp8u1BwYfWLa6d/Cwe/QwEr2ontSg2+IYjxn4HZJNCGeWwoDVqjl6HR/cTznhCPA== X-Received: by 2002:a17:902:c201:b0:172:6c9d:14b9 with SMTP id 1-20020a170902c20100b001726c9d14b9mr7195297pll.161.1660588374426; Mon, 15 Aug 2022 11:32:54 -0700 (PDT) Received: from [192.168.0.110] ([103.159.189.148]) by smtp.gmail.com with ESMTPSA id 200-20020a6216d1000000b005289fad1bbesm7034667pfw.94.2022.08.15.11.32.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Aug 2022 11:32:53 -0700 (PDT) Message-ID: <83820e90-04ac-16cd-b5be-87e1a0bbfca8@gmail.com> Date: Tue, 16 Aug 2022 00:32:46 +0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH linux-next] drm/amdgpu/vcn: Remove unused assignment in vcn_v4_0_stop Content-Language: en-US To: "Dong, Ruijing" , "amd-gfx@lists.freedesktop.org" , "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , "linux-kernel-mentees@lists.linuxfoundation.org" References: <20220815070056.10816-1-khalid.masum.92@gmail.com> <86088c17-585c-4a53-312d-ef339b824538@gmail.com> From: Khalid Masum In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Mailman-Approved-At: Mon, 15 Aug 2022 19:02:05 +0000 X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Wan Jiabing , David Airlie , "Pan, Xinhui" , "Jiang, Sonny" , Daniel Vetter , "Deucher, Alexander" , "Zhu, James" , "Liu, Leo" , "Koenig, Christian" Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" On 8/15/22 22:00, Dong, Ruijing wrote: > [AMD Official Use Only - General] > > Then please update commit message, this change is due to "value r is never used, and remove unnecessary assignment", that makes sense to me. > > Thanks > Ruijing > Greg also pointed out that the function vcn_v4_0_stop_dpg_mode should return void. I shall send a patch shortly with these two changes. Thanks for your suggestion. Thanks, -- Khalid Masum From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41DF3C00140 for ; Mon, 15 Aug 2022 19:04:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245373AbiHOTEr (ORCPT ); Mon, 15 Aug 2022 15:04:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60434 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245196AbiHOTBb (ORCPT ); Mon, 15 Aug 2022 15:01:31 -0400 Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 04A464B0E0 for ; Mon, 15 Aug 2022 11:32:59 -0700 (PDT) Received: by mail-pj1-x1036.google.com with SMTP id q9-20020a17090a2dc900b001f58bcaca95so15197595pjm.3 for ; Mon, 15 Aug 2022 11:32:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=8bJQmDi/lCA9PqirReS3MPMutajyKB5RDjNh4fqCzaA=; b=jdED2coZKjWQwnNfe6vINVdrNYG/s4Ap5/xy5Gcip3nOeogSVmoaiJccuFjEMCn604 aiAZAQA12xrgovQ0EK7RmswbJp8NFIGlbMK7CJIoj829dlR/YYKVOetZHn6kiWBGYqVw iKFOwG4d+6zBCeFAM+4iDS7+9tD9UBi/j3bzxO26XKdYiOx4BB2DNlOWrPLyESziZRHe LEaQNj92ErOuotlQ1magSPuxiMp4HGWT4qlqOjqs26rIJlOdgx2ohKm85mKBuL0W3Xiz UuCSlnwEL0+m8YK540p/n30zlzjGqOSmL/ZEk6NbS6E6meNvlkJSA2GfQZf+c2O2OWU8 uGRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=8bJQmDi/lCA9PqirReS3MPMutajyKB5RDjNh4fqCzaA=; b=X1z9HjMoXjJumWqSQUpfPPbZll+rvhGnJ/wEoQ3mDnTsZpwPuBfOdJdxGUqUfS7DWP dLTAUXAV+1gG1lnWMYjibb5hJRZNEvDV9HkqOHvQy+K06ryCmkpEOHDMIjrRTu4Xxsng fsIUdhB/Z0biPh40wF6GiXXp6dpbKOy8qcLgJO0n0OrihHfw+wGGEHyg5uYZBGL5uo0/ Nd47CXQgnRuAPhCi9VE6p5kDx3EA69lfJ1aQRZcOzCl8rJisAagnA257sWN7QJuqLhH7 6z/Sl+oAuhSuJWtthe204wtdNyzyjaXQ7jJ/Witmn1l1m5GN8pZuxbl8M2eoYDfUcrAG 8oRQ== X-Gm-Message-State: ACgBeo1F5milE6JG/nOwQVGNL96dceEdZwzVnM/mfiOj6x5XNU/TNO0/ hhF7b9YcWB1eH7OPvVgBVUg= X-Google-Smtp-Source: AA6agR6Clbh4D6hp8u1BwYfWLa6d/Cwe/QwEr2ontSg2+IYjxn4HZJNCGeWwoDVqjl6HR/cTznhCPA== X-Received: by 2002:a17:902:c201:b0:172:6c9d:14b9 with SMTP id 1-20020a170902c20100b001726c9d14b9mr7195297pll.161.1660588374426; Mon, 15 Aug 2022 11:32:54 -0700 (PDT) Received: from [192.168.0.110] ([103.159.189.148]) by smtp.gmail.com with ESMTPSA id 200-20020a6216d1000000b005289fad1bbesm7034667pfw.94.2022.08.15.11.32.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Aug 2022 11:32:53 -0700 (PDT) Message-ID: <83820e90-04ac-16cd-b5be-87e1a0bbfca8@gmail.com> Date: Tue, 16 Aug 2022 00:32:46 +0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH linux-next] drm/amdgpu/vcn: Remove unused assignment in vcn_v4_0_stop Content-Language: en-US To: "Dong, Ruijing" , "amd-gfx@lists.freedesktop.org" , "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , "linux-kernel-mentees@lists.linuxfoundation.org" Cc: "Deucher, Alexander" , "Koenig, Christian" , "Pan, Xinhui" , David Airlie , Daniel Vetter , "Zhu, James" , "Jiang, Sonny" , Wan Jiabing , "Liu, Leo" References: <20220815070056.10816-1-khalid.masum.92@gmail.com> <86088c17-585c-4a53-312d-ef339b824538@gmail.com> From: Khalid Masum In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/15/22 22:00, Dong, Ruijing wrote: > [AMD Official Use Only - General] > > Then please update commit message, this change is due to "value r is never used, and remove unnecessary assignment", that makes sense to me. > > Thanks > Ruijing > Greg also pointed out that the function vcn_v4_0_stop_dpg_mode should return void. I shall send a patch shortly with these two changes. Thanks for your suggestion. Thanks, -- Khalid Masum