From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jingoo Han Subject: Re: [PATCH v3 0/14] Add Analogix Core Display Port Driver Date: Fri, 21 Aug 2015 20:24:16 +0900 Message-ID: <8384E112-E1F4-4CD3-85BF-A2A25989783F@gmail.com> References: <1439995728-18046-1-git-send-email-ykk@rock-chips.com> <105A0032-83A0-4B75-AE94-258F12451670@gmail.com> <55D6F6F8.70504@rock-chips.com> Mime-Version: 1.0 (1.0) Content-Type: multipart/mixed; boundary="===============1696209144==" Return-path: In-Reply-To: <55D6F6F8.70504@rock-chips.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Yakir Yang Cc: "seanpaul@google.com" , "dri-devel@lists.freedesktop.org" , Andrzej Hajda , Gustavo Padovan , "linux-samsung-soc@vger.kernel.org" , Vincent Palatin , "linux-rockchip@lists.infradead.org" , Kishon Vijay Abraham I , Russell King , Thierry Reding , "devicetree@vger.kernel.org" , Pawel Moll , Ian Campbell , "dianders@google.com" , "joe@perches.com" , Rob Herring , "linux-arm-kernel@lists.infradead.org" , Fabio Estevam List-Id: devicetree@vger.kernel.org --===============1696209144== Content-Type: multipart/alternative; boundary=Apple-Mail-CDD072AD-28EC-4D9E-82CF-6B542E7D0D9F Content-Transfer-Encoding: 7bit --Apple-Mail-CDD072AD-28EC-4D9E-82CF-6B542E7D0D9F Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2015. 8. 21., at PM 7:01, Yakir Yang wrote: >=20 > Hi Jingoo, >=20 >> =E5=9C=A8 2015/8/21 16:20, Jingoo Han =E5=86=99=E9=81=93: >>> On 2015. 8. 19., at PM 11:48, Yakir Yang wrote: >>=20 >> ..... >>=20 >>> .../bindings/video/analogix_dp-rockchip.txt | 83 ++ >>> .../devicetree/bindings/video/exynos_dp.txt | 51 +- >>> arch/arm/boot/dts/exynos5250-arndale.dts | 10 +- >>> arch/arm/boot/dts/exynos5250-smdk5250.dts | 10 +- >>> arch/arm/boot/dts/exynos5250-snow.dts | 12 +- >>> arch/arm/boot/dts/exynos5250-spring.dts | 12 +- >>> arch/arm/boot/dts/exynos5420-peach-pit.dts | 12 +- >>> arch/arm/boot/dts/exynos5420-smdk5420.dts | 10 +- >>> arch/arm/boot/dts/exynos5800-peach-pi.dts | 12 +- >>> drivers/gpu/drm/bridge/Kconfig | 5 + >>> drivers/gpu/drm/bridge/Makefile | 1 + >>> drivers/gpu/drm/bridge/analogix_dp_core.c | 1382 ++++++++++++++= +++++ >>> drivers/gpu/drm/bridge/analogix_dp_core.h | 286 ++++ >>> drivers/gpu/drm/bridge/analogix_dp_reg.c | 1294 ++++++++++++++= ++++ >>> .../exynos_dp_reg.h =3D> bridge/analogix_dp_reg.h} | 270 ++-- >>> drivers/gpu/drm/exynos/Kconfig | 5 +- >>> drivers/gpu/drm/exynos/Makefile | 2 +- >>> drivers/gpu/drm/exynos/analogix_dp-exynos.c | 347 +++++ >> Would you change this file name to "exynos_dp.c"? >=20 > Sorry, I don't think so ;( >=20 > I think IP_name+Soc_name would be better in this re-use case. So? Is there the naming rule such as "IP_name+SoC_name"? > Beside I see > there are lots of driver named with this format in kernel, such as dw_hdmi= & dw_mmc Please look at other dw cases. For example, look at dw_pcie. drivers/pci/host/ pcie-designware.c pci-spear13xx.c pci-exynos.c In this case, pci-spear13xx.c and pci-exynos.c do not use "IP_name+SoC_name"= , even though these are dw IPs. Also, naming consistency is more important. Now, Exynos DRM files are using "exynos_drm_" prefix. drivers/gpu/drm/exynos/ exynos_drm_buf.c exynos_drm_core.c .... However, "analogix_dp-exynos.c" looks very inconsistent. If there is no strict naming rule, please use "exynos_dp.c" or "exynos_drm_dp.c".=20 Best regards, Jingoo Han >=20 > (cr) (chromeos-3.14) yakir@server ~/trunk/src/third_party/kernel/v3.14 $ l= s drivers/gpu/drm/imx/ > dw_hdmi-imx.c imx-drm.h imx-tve.c ipuv3-plane.c Kconfig parallel= -display.c >=20 > (cr) (chromeos-3.14) yakir@server ~/trunk/src/third_party/kernel/v3.14 $ l= s drivers/mmc/host/dw_mmc* > drivers/mmc/host/dw_mmc.c drivers/mmc/host/dw_mmc.h drivers/mm= c/host/dw_mmc-pci.c drivers/mmc/host/dw_mmc-pltfm.h > drivers/mmc/host/dw_mmc-exynos.c drivers/mmc/host/dw_mmc-k3.c drivers/mm= c/host/dw_mmc-pltfm.c drivers/mmc/host/dw_mmc-rockchip.c >=20 > Thanks, > - Yakir >=20 >> Best regards, >> Jingoo Han >>=20 >>> drivers/gpu/drm/exynos/exynos_dp_core.c | 1416 --------------= ------ >>> drivers/gpu/drm/exynos/exynos_dp_core.h | 282 ---- >>> drivers/gpu/drm/exynos/exynos_dp_reg.c | 1263 --------------= --- >>> drivers/gpu/drm/rockchip/Kconfig | 9 + >>> drivers/gpu/drm/rockchip/Makefile | 1 + >>> drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 390 ++++++ >>> drivers/phy/Kconfig | 7 + >>> drivers/phy/Makefile | 1 + >>> drivers/phy/phy-rockchip-dp.c | 185 +++ >>> include/drm/bridge/analogix_dp.h | 40 + >>> 30 files changed, 4325 insertions(+), 3172 deletions(-) >>> create mode 100644 Documentation/devicetree/bindings/drm/bridge/analogix= _dp.txt >>> create mode 100644 Documentation/devicetree/bindings/phy/rockchip-dp-phy= .txt >>> create mode 100644 Documentation/devicetree/bindings/video/analogix_dp-r= ockchip.txt >>> create mode 100644 drivers/gpu/drm/bridge/analogix_dp_core.c >>> create mode 100644 drivers/gpu/drm/bridge/analogix_dp_core.h >>> create mode 100644 drivers/gpu/drm/bridge/analogix_dp_reg.c >>> rename drivers/gpu/drm/{exynos/exynos_dp_reg.h =3D> bridge/analogix_dp_r= eg.h} (62%) >>> create mode 100644 drivers/gpu/drm/exynos/analogix_dp-exynos.c >>> delete mode 100644 drivers/gpu/drm/exynos/exynos_dp_core.c >>> delete mode 100644 drivers/gpu/drm/exynos/exynos_dp_core.h >>> delete mode 100644 drivers/gpu/drm/exynos/exynos_dp_reg.c >>> create mode 100644 drivers/gpu/drm/rockchip/analogix_dp-rockchip.c >>> create mode 100644 drivers/phy/phy-rockchip-dp.c >>> create mode 100644 include/drm/bridge/analogix_dp.h >>>=20 >>> --=20 >>> 1.9.1 >>>=20 >>>=20 >=20 --Apple-Mail-CDD072AD-28EC-4D9E-82CF-6B542E7D0D9F Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable
On 2015. 8. 21., at PM 7:01, Yakir Yan= g <ykk@rock-chips.com> wrote= :

=20 =20 =20 Hi Jingoo,

=E5=9C=A8 2015/8/21 16:20, Jingoo Han =E5= =86=99=E9=81=93:
On 2015. 8. 19., at PM 11:48, Yakir Yang <ykk@rock-chips.c=
om> wrote:


      

      
.....



      

        
.../bindings/video/analogix_dp-rockchip.txt        | =
  83 ++
.../devicetree/bindings/video/exynos_dp.txt        |   51 +-
arch/arm/boot/dts/exynos5250-arndale.dts           |   10 +-
arch/arm/boot/dts/exynos5250-smdk5250.dts          |   10 +-
arch/arm/boot/dts/exynos5250-snow.dts              |   12 +-
arch/arm/boot/dts/exynos5250-spring.dts            |   12 +-
arch/arm/boot/dts/exynos5420-peach-pit.dts         |   12 +-
arch/arm/boot/dts/exynos5420-smdk5420.dts          |   10 +-
arch/arm/boot/dts/exynos5800-peach-pi.dts          |   12 +-
drivers/gpu/drm/bridge/Kconfig                     |    5 +
drivers/gpu/drm/bridge/Makefile                    |    1 +
drivers/gpu/drm/bridge/analogix_dp_core.c          | 1382 ++++++++++++++++++=
+
drivers/gpu/drm/bridge/analogix_dp_core.h          |  286 ++++
drivers/gpu/drm/bridge/analogix_dp_reg.c           | 1294 ++++++++++++++++++=

.../exynos_dp_reg.h =3D> bridge/analogix_dp_reg.h}   |  270 ++--
drivers/gpu/drm/exynos/Kconfig                     |    5 +-
drivers/gpu/drm/exynos/Makefile                    |    2 +-
drivers/gpu/drm/exynos/analogix_dp-exynos.c        |  347 +++++


      

      
Would you change this file name to "exynos_dp.c"?


    

    

    Sorry, I don't think so  ;(

    

    I think IP_name+Soc_name would be better in this re-use case.

So? Is there the naming rule such as "IP_name+So=
C_name"?

 Beside
    I see

    there are lots of driver named with this format in kernel, such as
    dw_hdmi & dw_mmc

Please lo=
ok at other dw cases.
For example, look at dw_pcie.

=

drivers/pci/host/
pcie-designware.c
pci-spear=
13xx.c
pci-exynos.c

In this case, pci-spe=
ar13xx.c and pci-exynos.c do not use "IP_name+SoC_name", even though these a=
re dw IPs.

Also, naming consistency is more importa=
nt.
Now, Exynos DRM files are using "exynos_drm_" prefix.

drivers/gpu/drm/exynos/
exynos_drm_buf.c
exynos_drm_core.c
....

However, "analog=
ix_dp-exynos.c" looks very inconsistent.

If there i=
s no strict naming rule, please use "exynos_dp.c"
or "exynos_drm_d=
p.c". 

Best regards,
Jingoo Han


    

     (cr) (chromeos-3.14) yakir@server
    ~/trunk/src/third_party/kernel/v3.14 $ ls
      drivers/gpu/drm/imx/

    dw_hdmi-imx.c   imx-drm.h =

    imx-tve.c     ipuv3-plane.c  Kconfig  =
; parallel-display.c

    

    (cr) (chromeos-3.14) yakir@server
    ~/trunk/src/third_party/kernel/v3.14 $ ls
      drivers/mmc/host/dw_mmc*

    drivers/mmc/host/dw_mmc.c        =
; drivers/mmc/host/dw_mmc.h    
    drivers/mmc/host/dw_mmc-pci.c    drivers/mmc/host/dw_mmc-=
pltfm.h

    drivers/mmc/host/dw_mmc-exynos.c  drivers/mmc/host/dw_mmc-k3.c 
    drivers/mmc/host/dw_mmc-pltfm.c  drivers/mm=
c/host/dw_mmc-rockchip.c

    

    Thanks,

    - Yakir

    

    

      
Best regards,
Jingoo Han



      

        
drivers/gpu/drm/exynos/exynos_dp_core.c            | 1=
416 --------------------
drivers/gpu/drm/exynos/exynos_dp_core.h            |  282 ----
drivers/gpu/drm/exynos/exynos_dp_reg.c             | 1263 -----------------
drivers/gpu/drm/rockchip/Kconfig                   |    9 +
drivers/gpu/drm/rockchip/Makefile                  |    1 +
drivers/gpu/drm/rockchip/analogix_dp-rockchip.c    |  390 ++++++
drivers/phy/Kconfig                                |    7 +
drivers/phy/Makefile                               |    1 +
drivers/phy/phy-rockchip-dp.c                      |  185 +++
include/drm/bridge/analogix_dp.h                   |   40 +
30 files changed, 4325 insertions(+), 3172 deletions(-)
create mode 100644 Documentation/devicetree/bindings/drm/bridge/analogix_dp.=
txt
create mode 100644 Documentation/devicetree/bindings/phy/rockchip-dp-phy.txt=

create mode 100644 Documentation/devicetree/bindings/video/analogix_dp-rockc=
hip.txt
create mode 100644 drivers/gpu/drm/bridge/analogix_dp_core.c
create mode 100644 drivers/gpu/drm/bridge/analogix_dp_core.h
create mode 100644 drivers/gpu/drm/bridge/analogix_dp_reg.c
rename drivers/gpu/drm/{exynos/exynos_dp_reg.h =3D> bridge/analogix_dp_re=
g.h} (62%)
create mode 100644 drivers/gpu/drm/exynos/analogix_dp-exynos.c
delete mode 100644 drivers/gpu/drm/exynos/exynos_dp_core.c
delete mode 100644 drivers/gpu/drm/exynos/exynos_dp_core.h
delete mode 100644 drivers/gpu/drm/exynos/exynos_dp_reg.c
create mode 100644 drivers/gpu/drm/rockchip/analogix_dp-rockchip.c
create mode 100644 drivers/phy/phy-rockchip-dp.c
create mode 100644 include/drm/bridge/analogix_dp.h

--=20
1.9.1




      

      



    

    

 =20


=

--Apple-Mail-CDD072AD-28EC-4D9E-82CF-6B542E7D0D9F--

--===============1696209144==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs
IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0
cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK

--===============1696209144==--