From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B594C48BDF for ; Fri, 18 Jun 2021 13:14:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4D297613D1 for ; Fri, 18 Jun 2021 13:14:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232858AbhFRNQ1 (ORCPT ); Fri, 18 Jun 2021 09:16:27 -0400 Received: from szxga01-in.huawei.com ([45.249.212.187]:11070 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230217AbhFRNQZ (ORCPT ); Fri, 18 Jun 2021 09:16:25 -0400 Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.57]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4G5zns4TKSzZgHJ; Fri, 18 Jun 2021 21:11:13 +0800 (CST) Received: from dggpemm500023.china.huawei.com (7.185.36.83) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Fri, 18 Jun 2021 21:14:10 +0800 Received: from [10.174.187.128] (10.174.187.128) by dggpemm500023.china.huawei.com (7.185.36.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2176.2; Fri, 18 Jun 2021 21:14:09 +0800 Subject: Re: [PATCH v7 3/4] KVM: arm64: Tweak parameters of guest cache maintenance functions To: Marc Zyngier , Fuad Tabba CC: Will Deacon , Quentin Perret , Alexandru Elisei , , , , , Catalin Marinas , James Morse , Julien Thierry , Suzuki K Poulose , Gavin Shan , , , References: <20210617105824.31752-1-wangyanan55@huawei.com> <20210617105824.31752-4-wangyanan55@huawei.com> <87czsjcsv8.wl-maz@kernel.org> From: "wangyanan (Y)" Message-ID: <83887c42-4dbe-b25b-6f5f-cf1766198bdf@huawei.com> Date: Fri, 18 Jun 2021 21:14:07 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <87czsjcsv8.wl-maz@kernel.org> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [10.174.187.128] X-ClientProxiedBy: dggeme705-chm.china.huawei.com (10.1.199.101) To dggpemm500023.china.huawei.com (7.185.36.83) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/6/18 19:30, Marc Zyngier wrote: > On Thu, 17 Jun 2021 11:58:23 +0100, > Yanan Wang wrote: >> Adjust the parameter "kvm_pfn_t pfn" of __clean_dcache_guest_page >> and __invalidate_icache_guest_page to "void *va", which paves the >> way for converting these two guest CMO functions into callbacks in >> structure kvm_pgtable_mm_ops. No functional change. >> >> Signed-off-by: Yanan Wang >> --- >> arch/arm64/include/asm/kvm_mmu.h | 9 ++------- >> arch/arm64/kvm/mmu.c | 28 +++++++++++++++------------- >> 2 files changed, 17 insertions(+), 20 deletions(-) >> > [...] > >> @@ -1219,7 +1221,7 @@ bool kvm_set_spte_gfn(struct kvm *kvm, struct kvm_gfn_range *range) >> * We've moved a page around, probably through CoW, so let's treat it >> * just like a translation fault and clean the cache to the PoC. >> */ >> - clean_dcache_guest_page(pfn, PAGE_SIZE); >> + clean_dcache_guest_page(page_address(pfn_to_page(pfn), PAGE_SIZE); > This obviously doesn't compile. I have fixed it locally, but in the > future please make sure that patch series can be bisected correctly. Ah, yes, I figure out what I have missed by mistake now, and this should have never happened... Much thanks for the local fixes for this series. Also thank Fuad for the naming reference and review. Regards, Yanan . > Thanks, > > M. > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B819C48BDF for ; Fri, 18 Jun 2021 13:14:24 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 89B9E613B4 for ; Fri, 18 Jun 2021 13:14:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 89B9E613B4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 084904B081; Fri, 18 Jun 2021 09:14:23 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id se8ezNLAj5J8; Fri, 18 Jun 2021 09:14:21 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 3D6924A418; Fri, 18 Jun 2021 09:14:21 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 2A7A04A2E5 for ; Fri, 18 Jun 2021 09:14:20 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id c0sHDmDj6Opc for ; Fri, 18 Jun 2021 09:14:16 -0400 (EDT) Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id EA4834A1B0 for ; Fri, 18 Jun 2021 09:14:15 -0400 (EDT) Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.57]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4G5zns4TKSzZgHJ; Fri, 18 Jun 2021 21:11:13 +0800 (CST) Received: from dggpemm500023.china.huawei.com (7.185.36.83) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Fri, 18 Jun 2021 21:14:10 +0800 Received: from [10.174.187.128] (10.174.187.128) by dggpemm500023.china.huawei.com (7.185.36.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2176.2; Fri, 18 Jun 2021 21:14:09 +0800 Subject: Re: [PATCH v7 3/4] KVM: arm64: Tweak parameters of guest cache maintenance functions To: Marc Zyngier , Fuad Tabba References: <20210617105824.31752-1-wangyanan55@huawei.com> <20210617105824.31752-4-wangyanan55@huawei.com> <87czsjcsv8.wl-maz@kernel.org> From: "wangyanan (Y)" Message-ID: <83887c42-4dbe-b25b-6f5f-cf1766198bdf@huawei.com> Date: Fri, 18 Jun 2021 21:14:07 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <87czsjcsv8.wl-maz@kernel.org> Content-Language: en-US X-Originating-IP: [10.174.187.128] X-ClientProxiedBy: dggeme705-chm.china.huawei.com (10.1.199.101) To dggpemm500023.china.huawei.com (7.185.36.83) X-CFilter-Loop: Reflected Cc: kvm@vger.kernel.org, Will Deacon , linux-kernel@vger.kernel.org, Catalin Marinas , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On 2021/6/18 19:30, Marc Zyngier wrote: > On Thu, 17 Jun 2021 11:58:23 +0100, > Yanan Wang wrote: >> Adjust the parameter "kvm_pfn_t pfn" of __clean_dcache_guest_page >> and __invalidate_icache_guest_page to "void *va", which paves the >> way for converting these two guest CMO functions into callbacks in >> structure kvm_pgtable_mm_ops. No functional change. >> >> Signed-off-by: Yanan Wang >> --- >> arch/arm64/include/asm/kvm_mmu.h | 9 ++------- >> arch/arm64/kvm/mmu.c | 28 +++++++++++++++------------- >> 2 files changed, 17 insertions(+), 20 deletions(-) >> > [...] > >> @@ -1219,7 +1221,7 @@ bool kvm_set_spte_gfn(struct kvm *kvm, struct kvm_gfn_range *range) >> * We've moved a page around, probably through CoW, so let's treat it >> * just like a translation fault and clean the cache to the PoC. >> */ >> - clean_dcache_guest_page(pfn, PAGE_SIZE); >> + clean_dcache_guest_page(page_address(pfn_to_page(pfn), PAGE_SIZE); > This obviously doesn't compile. I have fixed it locally, but in the > future please make sure that patch series can be bisected correctly. Ah, yes, I figure out what I have missed by mistake now, and this should have never happened... Much thanks for the local fixes for this series. Also thank Fuad for the naming reference and review. Regards, Yanan . > Thanks, > > M. > _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16078C48BDF for ; Fri, 18 Jun 2021 13:16:20 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DA329613EC for ; Fri, 18 Jun 2021 13:16:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DA329613EC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:CC:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=0T4ee6p6CRRr3N/pshqNAotP27UbOE0Y1mP5yQezMxk=; b=0Gfq9u46Al/cad11DRiGBCYQcI 9bON+R9OL5CS0fjliwxx2tqr1keY0KNOGRLaBmkEZWkYHXHF7hkHFznObsYcqb4U+LiAL1AGfguik Kn2Hp7yN78JpGzu/SF0LT8iVVTBugmz3p1THWxA4z3s9J/4BKM+ONTSdYQO2NMwxPsbSYjnlT23fx e/051txQYOrcWRMYeYTuG2oO1Zrel26uBWddBmwbahUe7JATkc6F2Xyjy9lw8albnHUOYFEggE/KA e3ZfIYutoo9rB2tkD68Wfw+M4lEcdW1iDXtm1DpkOPm6BgfZFwYWOO3bxig3nQN7aAmYdHNfGE5er uhY2KtQQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1luEKM-00E8Rj-W8; Fri, 18 Jun 2021 13:14:31 +0000 Received: from szxga01-in.huawei.com ([45.249.212.187]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1luEKF-00E8Q0-P6 for linux-arm-kernel@lists.infradead.org; Fri, 18 Jun 2021 13:14:28 +0000 Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.57]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4G5zns4TKSzZgHJ; Fri, 18 Jun 2021 21:11:13 +0800 (CST) Received: from dggpemm500023.china.huawei.com (7.185.36.83) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Fri, 18 Jun 2021 21:14:10 +0800 Received: from [10.174.187.128] (10.174.187.128) by dggpemm500023.china.huawei.com (7.185.36.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2176.2; Fri, 18 Jun 2021 21:14:09 +0800 Subject: Re: [PATCH v7 3/4] KVM: arm64: Tweak parameters of guest cache maintenance functions To: Marc Zyngier , Fuad Tabba CC: Will Deacon , Quentin Perret , Alexandru Elisei , , , , , Catalin Marinas , James Morse , Julien Thierry , Suzuki K Poulose , Gavin Shan , , , References: <20210617105824.31752-1-wangyanan55@huawei.com> <20210617105824.31752-4-wangyanan55@huawei.com> <87czsjcsv8.wl-maz@kernel.org> From: "wangyanan (Y)" Message-ID: <83887c42-4dbe-b25b-6f5f-cf1766198bdf@huawei.com> Date: Fri, 18 Jun 2021 21:14:07 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <87czsjcsv8.wl-maz@kernel.org> Content-Language: en-US X-Originating-IP: [10.174.187.128] X-ClientProxiedBy: dggeme705-chm.china.huawei.com (10.1.199.101) To dggpemm500023.china.huawei.com (7.185.36.83) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210618_061424_085365_ECDE6729 X-CRM114-Status: GOOD ( 13.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2021/6/18 19:30, Marc Zyngier wrote: > On Thu, 17 Jun 2021 11:58:23 +0100, > Yanan Wang wrote: >> Adjust the parameter "kvm_pfn_t pfn" of __clean_dcache_guest_page >> and __invalidate_icache_guest_page to "void *va", which paves the >> way for converting these two guest CMO functions into callbacks in >> structure kvm_pgtable_mm_ops. No functional change. >> >> Signed-off-by: Yanan Wang >> --- >> arch/arm64/include/asm/kvm_mmu.h | 9 ++------- >> arch/arm64/kvm/mmu.c | 28 +++++++++++++++------------- >> 2 files changed, 17 insertions(+), 20 deletions(-) >> > [...] > >> @@ -1219,7 +1221,7 @@ bool kvm_set_spte_gfn(struct kvm *kvm, struct kvm_gfn_range *range) >> * We've moved a page around, probably through CoW, so let's treat it >> * just like a translation fault and clean the cache to the PoC. >> */ >> - clean_dcache_guest_page(pfn, PAGE_SIZE); >> + clean_dcache_guest_page(page_address(pfn_to_page(pfn), PAGE_SIZE); > This obviously doesn't compile. I have fixed it locally, but in the > future please make sure that patch series can be bisected correctly. Ah, yes, I figure out what I have missed by mistake now, and this should have never happened... Much thanks for the local fixes for this series. Also thank Fuad for the naming reference and review. Regards, Yanan . > Thanks, > > M. > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel