From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3546C2D0DB for ; Fri, 24 Jan 2020 13:41:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 90F182072C for ; Fri, 24 Jan 2020 13:41:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=castello.eng.br header.i=@castello.eng.br header.b="F+G7QTcq" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389916AbgAXNl3 (ORCPT ); Fri, 24 Jan 2020 08:41:29 -0500 Received: from gateway33.websitewelcome.com ([192.185.146.21]:43199 "EHLO gateway33.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387743AbgAXNl2 (ORCPT ); Fri, 24 Jan 2020 08:41:28 -0500 X-Greylist: delayed 1278 seconds by postgrey-1.27 at vger.kernel.org; Fri, 24 Jan 2020 08:41:27 EST Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway33.websitewelcome.com (Postfix) with ESMTP id 712503890A for ; Fri, 24 Jan 2020 07:20:08 -0600 (CST) Received: from br164.hostgator.com.br ([192.185.176.180]) by cmsmtp with SMTP id uysaiv1pyuRkOuysaiFL11; Fri, 24 Jan 2020 07:20:08 -0600 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=castello.eng.br; s=default; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=V/GeHGqGQjtPkjEYv4FO0ChcoNxVcLXjcaqmJN4l0DA=; b=F+G7QTcqgNmFpk9VOZGAKBivtN saCW7dy/99BySJL2LVJYp5Lda5jwAuZubU158L97EDLYj0SH4Qfr4lIO9vl5opvjApUpcQNglmNGx P1msvHpwXKTaCYcVtsWrdWNEpxWdbY8s6amBjjUMMdNNw/YuO9cpWXigp/rA9Cxsygny1MXnC2Kf1 HdbEd1EGEgMbsl+5X6m8HzOIZLH2aE20kbNMicOoA+mgydQHyKqN4Rzl50VZcJNNaurOI2ecWDyci igahipxKn7W2GVVgF4w8QzvKTXLqAslFQpbhNgeAjOZrw7LLo7UR4ltLVuizHnqvmCyKZE851uLTZ TIF0N81Q==; Received: from [191.31.193.140] (port=38676 helo=[192.168.0.107]) by br164.hostgator.com.br with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.92) (envelope-from ) id 1iuysZ-003I10-NA; Fri, 24 Jan 2020 10:20:08 -0300 Subject: Re: [PATCH] pinctrl actions: Fix functions groups names To: Manivannan Sadhasivam , afaerber@suse.de, linus.walleij@linaro.org Cc: linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, pn@denx.de References: <20200124031819.608217-1-matheus@castello.eng.br> <900334CE-3A85-443D-99EC-4DD169BBCB65@linaro.org> From: Matheus Castello Message-ID: <838d8378-1a6a-11c4-fad8-aeb4b861478b@castello.eng.br> Date: Fri, 24 Jan 2020 10:20:04 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: <900334CE-3A85-443D-99EC-4DD169BBCB65@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: pt-BR Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - br164.hostgator.com.br X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - castello.eng.br X-BWhitelist: no X-Source-IP: 191.31.193.140 X-Source-L: No X-Exim-ID: 1iuysZ-003I10-NA X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: ([192.168.0.107]) [191.31.193.140]:38676 X-Source-Auth: matheus@castello.eng.br X-Email-Count: 5 X-Source-Cap: Y2FzdGUyNDg7Y2FzdGUyNDg7YnIxNjQuaG9zdGdhdG9yLmNvbS5icg== X-Local-Domain: yes Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Em 1/24/20 9:46 AM, Manivannan Sadhasivam escreveu: > Hey, > > +Parthi, who is the author of s700 driver. > > On 24 January 2020 8:48:19 AM IST, Matheus Castello wrote: >> Group names by function do not match their respective structures and >> documentation defined names. >> >> This fixes following errors observed on s500-based Labrador board when >> groups names defined on documentation are used: >> [ 4.262778] pinctrl-s700 b01b0040.pinctrl: invalid group >> "sd0_d1_mfp" for function "sd0" >> [ 4.271394] pinctrl-s700 b01b0040.pinctrl: invalid group >> "sd0_d2_d3_mfp" for function "sd0" >> [ 4.280248] pinctrl-s700 b01b0040.pinctrl: invalid group >> "sd1_d0_d3_mfp" for function "sd0" >> [ 4.289122] pinctrl-s700 b01b0040.pinctrl: invalid group >> "sd0_cmd_mfp" for function "sd0" >> > > Doh, I'm not sure how I missed this obvious mistake during review. Sorry for that. > > The change looks good but the commit message needs to be reworked a bit. It doesn't make sense to use s700 driver on s500 based board. Even though you could've modified it for s500, it should not be mentioned. So just mention the issue. Also you're missing colon after pinctrl in subject. > Ok, I will send a v2. > Btw, are you planning to contribute s500 driver? > Yes I intend to, my research, from a macro view, the pin blocks, groups, registers and functions are quite similar from the s700 to the s500. If so, maybe put a compatible to s500, but still not sure, I have to check it out calmly. > Thanks, > Mani > >> Fixes: 81c9d563cc74 (pinctrl: actions: Add Actions Semi S700 pinctrl >> driver) >> Signed-off-by: Matheus Castello >> --- >> drivers/pinctrl/actions/pinctrl-s700.c | 510 ++++++++++++------------- >> 1 file changed, 255 insertions(+), 255 deletions(-) >> >> diff --git a/drivers/pinctrl/actions/pinctrl-s700.c >> b/drivers/pinctrl/actions/pinctrl-s700.c >> index 8b8121e35edb..1182b38ff4dc 100644 >> --- a/drivers/pinctrl/actions/pinctrl-s700.c >> +++ b/drivers/pinctrl/actions/pinctrl-s700.c >> @@ -1125,317 +1125,317 @@ static const struct owl_pingroup >> s700_groups[] = { >> }; >> >> static const char * const nor_groups[] = { >> - "lcd0_d18", >> - "i2s_d0", >> - "i2s0_pcm0", >> - "i2s1_pcm0", >> - "i2s_d1", >> - "ks_in2", >> - "ks_in1", >> - "ks_in0", >> - "ks_in3", >> - "ks_out0", >> - "ks_out1", >> - "ks_out2", >> - "lcd0_d2", >> - "lvds_ee_pn", >> - "uart2_rx_tx", >> - "spi0_i2c_pcm", >> - "lvds_e_pn", >> - "sd0_d0", >> - "sd0_d1", >> - "sd0_d2_d3", >> - "sd1_d0_d3", >> - "sd0_cmd", >> - "sd1_cmd", >> - "sens0_ckout", >> - "sen0_pclk", >> + "lcd0_d18_mfp", >> + "i2s_d0_mfp", >> + "i2s0_pcm0_mfp", >> + "i2s1_pcm0_mfp", >> + "i2s_d1_mfp", >> + "ks_in2_mfp", >> + "ks_in1_mfp", >> + "ks_in0_mfp", >> + "ks_in3_mfp", >> + "ks_out0_mfp", >> + "ks_out1_mfp", >> + "ks_out2_mfp", >> + "lcd0_d2_mfp", >> + "lvds_ee_pn_mfp", >> + "uart2_rx_tx_mfp", >> + "spi0_i2c_pcm_mfp", >> + "lvds_e_pn_mfp", >> + "sd0_d0_mfp", >> + "sd0_d1_mfp", >> + "sd0_d2_d3_mfp", >> + "sd1_d0_d3_mfp", >> + "sd0_cmd_mfp", >> + "sd1_cmd_mfp", >> + "sens0_ckout_mfp", >> + "sen0_pclk_mfp", >> }; >> >> static const char * const eth_rmii_groups[] = { >> - "rgmii_txd23", >> - "rgmii_rxd2", >> - "rgmii_rxd3", >> - "rgmii_txd01", >> - "rgmii_txd0", >> - "rgmii_txd1", >> - "rgmii_txen", >> - "rgmii_rxen", >> - "rgmii_rxd1", >> - "rgmii_rxd0", >> - "rgmii_ref_clk", >> + "rgmii_txd23_mfp", >> + "rgmii_rxd2_mfp", >> + "rgmii_rxd3_mfp", >> + "rgmii_txd01_mfp", >> + "rgmii_txd0_mfp", >> + "rgmii_txd1_mfp", >> + "rgmii_txen_mfp", >> + "rgmii_rxen_mfp", >> + "rgmii_rxd1_mfp", >> + "rgmii_rxd0_mfp", >> + "rgmii_ref_clk_mfp", >> "eth_smi_dummy", >> }; >> >> static const char * const eth_smii_groups[] = { >> - "rgmii_txd0", >> - "rgmii_txd1", >> - "rgmii_rxd0", >> - "rgmii_rxd1", >> - "rgmii_ref_clk", >> + "rgmii_txd0_mfp", >> + "rgmii_txd1_mfp", >> + "rgmii_rxd0_mfp", >> + "rgmii_rxd1_mfp", >> + "rgmii_ref_clk_mfp", >> "eth_smi_dummy", >> }; >> >> static const char * const spi0_groups[] = { >> - "dsi_dn0", >> - "dsi_dp2", >> - "dsi_dp0", >> - "uart2_rx_tx", >> - "spi0_i2c_pcm", >> - "dsi_dn2", >> + "dsi_dn0_mfp", >> + "dsi_dp2_mfp", >> + "dsi_dp0_mfp", >> + "uart2_rx_tx_mfp", >> + "spi0_i2c_pcm_mfp", >> + "dsi_dn2_mfp", >> }; >> >> static const char * const spi1_groups[] = { >> - "uart0_rx", >> - "uart0_tx", >> + "uart0_rx_mfp", >> + "uart0_tx_mfp", >> "i2c0_mfp", >> }; >> >> static const char * const spi2_groups[] = { >> - "rgmii_txd01", >> - "rgmii_txd0", >> - "rgmii_txd1", >> - "rgmii_ref_clk", >> - "dnand_acle_ce0", >> + "rgmii_txd01_mfp", >> + "rgmii_txd0_mfp", >> + "rgmii_txd1_mfp", >> + "rgmii_ref_clk_mfp", >> + "dnand_acle_ce0_mfp", >> }; >> >> static const char * const spi3_groups[] = { >> - "rgmii_txen", >> - "rgmii_rxen", >> - "rgmii_rxd1", >> - "rgmii_rxd0", >> + "rgmii_txen_mfp", >> + "rgmii_rxen_mfp", >> + "rgmii_rxd1_mfp", >> + "rgmii_rxd0_mfp", >> }; >> >> static const char * const sens0_groups[] = { >> - "csi_cn_cp", >> - "sens0_ckout", >> - "csi_dn_dp", >> - "sen0_pclk", >> + "csi_cn_cp_mfp", >> + "sens0_ckout_mfp", >> + "csi_dn_dp_mfp", >> + "sen0_pclk_mfp", >> }; >> >> static const char * const sens1_groups[] = { >> - "lcd0_d18", >> - "ks_in2", >> - "ks_in1", >> - "ks_in0", >> - "ks_in3", >> - "ks_out0", >> - "ks_out1", >> - "ks_out2", >> - "sens0_ckout", >> - "pcm1_in", >> - "pcm1_clk", >> - "pcm1_sync", >> - "pcm1_out", >> + "lcd0_d18_mfp", >> + "ks_in2_mfp", >> + "ks_in1_mfp", >> + "ks_in0_mfp", >> + "ks_in3_mfp", >> + "ks_out0_mfp", >> + "ks_out1_mfp", >> + "ks_out2_mfp", >> + "sens0_ckout_mfp", >> + "pcm1_in_mfp", >> + "pcm1_clk_mfp", >> + "pcm1_sync_mfp", >> + "pcm1_out_mfp", >> }; >> >> static const char * const uart0_groups[] = { >> - "uart2_rtsb", >> - "uart2_ctsb", >> - "uart0_rx", >> - "uart0_tx", >> + "uart2_rtsb_mfp", >> + "uart2_ctsb_mfp", >> + "uart0_rx_mfp", >> + "uart0_tx_mfp", >> }; >> >> static const char * const uart1_groups[] = { >> - "sd0_d2_d3", >> + "sd0_d2_d3_mfp", >> "i2c0_mfp", >> }; >> >> static const char * const uart2_groups[] = { >> - "rgmii_txen", >> - "rgmii_rxen", >> - "rgmii_rxd1", >> - "rgmii_rxd0", >> - "dsi_dn0", >> - "dsi_dp2", >> - "dsi_dp0", >> - "uart2_rx_tx", >> - "dsi_dn2", >> - "uart2_rtsb", >> - "uart2_ctsb", >> - "sd0_d0", >> - "sd0_d1", >> - "sd0_d2_d3", >> - "uart0_rx", >> - "uart0_tx", >> + "rgmii_txen_mfp", >> + "rgmii_rxen_mfp", >> + "rgmii_rxd1_mfp", >> + "rgmii_rxd0_mfp", >> + "dsi_dn0_mfp", >> + "dsi_dp2_mfp", >> + "dsi_dp0_mfp", >> + "uart2_rx_tx_mfp", >> + "dsi_dn2_mfp", >> + "uart2_rtsb_mfp", >> + "uart2_ctsb_mfp", >> + "sd0_d0_mfp", >> + "sd0_d1_mfp", >> + "sd0_d2_d3_mfp", >> + "uart0_rx_mfp", >> + "uart0_tx_mfp", >> "i2c0_mfp", >> "uart2_dummy" >> }; >> >> static const char * const uart3_groups[] = { >> - "rgmii_txd23", >> - "rgmii_rxd2", >> - "rgmii_rxd3", >> - "uart3_rtsb", >> - "uart3_ctsb", >> + "rgmii_txd23_mfp", >> + "rgmii_rxd2_mfp", >> + "rgmii_rxd3_mfp", >> + "uart3_rtsb_mfp", >> + "uart3_ctsb_mfp", >> "uart3_dummy" >> }; >> >> static const char * const uart4_groups[] = { >> - "rgmii_txd01", >> - "rgmii_ref_clk", >> - "ks_out0", >> - "ks_out1", >> + "rgmii_txd01_mfp", >> + "rgmii_ref_clk_mfp", >> + "ks_out0_mfp", >> + "ks_out1_mfp", >> }; >> >> static const char * const uart5_groups[] = { >> - "rgmii_rxd1", >> - "rgmii_rxd0", >> - "ks_out0", >> - "ks_out2", >> - "uart3_rtsb", >> - "uart3_ctsb", >> - "sd0_d0", >> - "sd0_d1", >> + "rgmii_rxd1_mfp", >> + "rgmii_rxd0_mfp", >> + "ks_out0_mfp", >> + "ks_out2_mfp", >> + "uart3_rtsb_mfp", >> + "uart3_ctsb_mfp", >> + "sd0_d0_mfp", >> + "sd0_d1_mfp", >> }; >> >> static const char * const uart6_groups[] = { >> - "rgmii_txd0", >> - "rgmii_txd1", >> + "rgmii_txd0_mfp", >> + "rgmii_txd1_mfp", >> }; >> >> static const char * const i2s0_groups[] = { >> - "i2s_d0", >> - "i2s_pcm1", >> - "i2s0_pcm0", >> + "i2s_d0_mfp", >> + "i2s_pcm1_mfp", >> + "i2s0_pcm0_mfp", >> }; >> >> static const char * const i2s1_groups[] = { >> - "i2s1_pcm0", >> - "i2s_d1", >> + "i2s1_pcm0_mfp", >> + "i2s_d1_mfp", >> "i2s1_dummy", >> - "spi0_i2c_pcm", >> - "uart0_rx", >> - "uart0_tx", >> + "spi0_i2c_pcm_mfp", >> + "uart0_rx_mfp", >> + "uart0_tx_mfp", >> }; >> >> static const char * const pcm1_groups[] = { >> - "i2s_pcm1", >> - "spi0_i2c_pcm", >> - "uart0_rx", >> - "uart0_tx", >> - "pcm1_in", >> - "pcm1_clk", >> - "pcm1_sync", >> - "pcm1_out", >> + "i2s_pcm1_mfp", >> + "spi0_i2c_pcm_mfp", >> + "uart0_rx_mfp", >> + "uart0_tx_mfp", >> + "pcm1_in_mfp", >> + "pcm1_clk_mfp", >> + "pcm1_sync_mfp", >> + "pcm1_out_mfp", >> }; >> >> static const char * const pcm0_groups[] = { >> - "i2s0_pcm0", >> - "i2s1_pcm0", >> - "uart2_rx_tx", >> - "spi0_i2c_pcm", >> + "i2s0_pcm0_mfp", >> + "i2s1_pcm0_mfp", >> + "uart2_rx_tx_mfp", >> + "spi0_i2c_pcm_mfp", >> }; >> >> static const char * const ks_groups[] = { >> - "ks_in2", >> - "ks_in1", >> - "ks_in0", >> - "ks_in3", >> - "ks_out0", >> - "ks_out1", >> - "ks_out2", >> + "ks_in2_mfp", >> + "ks_in1_mfp", >> + "ks_in0_mfp", >> + "ks_in3_mfp", >> + "ks_out0_mfp", >> + "ks_out1_mfp", >> + "ks_out2_mfp", >> }; >> >> static const char * const jtag_groups[] = { >> - "ks_in2", >> - "ks_in1", >> - "ks_in0", >> - "ks_in3", >> - "ks_out1", >> - "sd0_d0", >> - "sd0_d2_d3", >> - "sd0_cmd", >> - "sd0_clk", >> + "ks_in2_mfp", >> + "ks_in1_mfp", >> + "ks_in0_mfp", >> + "ks_in3_mfp", >> + "ks_out1_mfp", >> + "sd0_d0_mfp", >> + "sd0_d2_d3_mfp", >> + "sd0_cmd_mfp", >> + "sd0_clk_mfp", >> }; >> >> static const char * const pwm0_groups[] = { >> - "rgmii_rxd2", >> - "rgmii_txen", >> - "ks_in2", >> - "sen0_pclk", >> + "rgmii_rxd2_mfp", >> + "rgmii_txen_mfp", >> + "ks_in2_mfp", >> + "sen0_pclk_mfp", >> }; >> >> static const char * const pwm1_groups[] = { >> - "rgmii_rxen", >> - "ks_in1", >> - "ks_in3", >> - "sens0_ckout", >> + "rgmii_rxen_mfp", >> + "ks_in1_mfp", >> + "ks_in3_mfp", >> + "sens0_ckout_mfp", >> }; >> >> static const char * const pwm2_groups[] = { >> - "lcd0_d18", >> - "rgmii_rxd3", >> - "rgmii_rxd1", >> - "ks_out0", >> - "ks_out2", >> + "lcd0_d18_mfp", >> + "rgmii_rxd3_mfp", >> + "rgmii_rxd1_mfp", >> + "ks_out0_mfp", >> + "ks_out2_mfp", >> }; >> >> static const char * const pwm3_groups[] = { >> - "rgmii_rxd0", >> - "ks_out1", >> - "lcd0_d2", >> + "rgmii_rxd0_mfp", >> + "ks_out1_mfp", >> + "lcd0_d2_mfp", >> }; >> >> static const char * const pwm4_groups[] = { >> - "lcd0_d18", >> - "rgmii_txd01", >> - "rgmii_txd0", >> - "ks_in0", >> - "pcm1_in", >> - "nand_ceb3", >> + "lcd0_d18_mfp", >> + "rgmii_txd01_mfp", >> + "rgmii_txd0_mfp", >> + "ks_in0_mfp", >> + "pcm1_in_mfp", >> + "nand_ceb3_mfp", >> }; >> >> static const char * const pwm5_groups[] = { >> - "rgmii_txd1", >> - "ks_in1", >> - "pcm1_clk", >> - "nand_ceb2", >> + "rgmii_txd1_mfp", >> + "ks_in1_mfp", >> + "pcm1_clk_mfp", >> + "nand_ceb2_mfp", >> }; >> >> static const char * const p0_groups[] = { >> - "ks_in2", >> - "ks_in0", >> + "ks_in2_mfp", >> + "ks_in0_mfp", >> }; >> >> static const char * const sd0_groups[] = { >> - "ks_out0", >> - "ks_out1", >> - "ks_out2", >> - "lcd0_d2", >> - "dsi_dp3", >> - "dsi_dp0", >> - "sd0_d0", >> - "sd0_d1", >> - "sd0_d2_d3", >> - "sd1_d0_d3", >> - "sd0_cmd", >> - "sd0_clk", >> + "ks_out0_mfp", >> + "ks_out1_mfp", >> + "ks_out2_mfp", >> + "lcd0_d2_mfp", >> + "dsi_dp3_mfp", >> + "dsi_dp0_mfp", >> + "sd0_d0_mfp", >> + "sd0_d1_mfp", >> + "sd0_d2_d3_mfp", >> + "sd1_d0_d3_mfp", >> + "sd0_cmd_mfp", >> + "sd0_clk_mfp", >> }; >> >> static const char * const sd1_groups[] = { >> - "dsi_dp2", >> - "mfp1_16_14", >> - "lcd0_d2", >> - "mfp1_16_14_d17", >> - "dsi_dp3", >> - "dsi_dn3", >> - "dsi_dnp1_cp_d2", >> - "dsi_dnp1_cp_d17", >> - "dsi_dn2", >> - "sd1_d0_d3", >> - "sd1_cmd", >> + "dsi_dp2_mfp", >> + "mfp1_16_14_mfp", >> + "lcd0_d2_mfp", >> + "mfp1_16_14_d17_mfp", >> + "dsi_dp3_mfp", >> + "dsi_dn3_mfp", >> + "dsi_dnp1_cp_d2_mfp", >> + "dsi_dnp1_cp_d17_mfp", >> + "dsi_dn2_mfp", >> + "sd1_d0_d3_mfp", >> + "sd1_cmd_mfp", >> "sd1_dummy", >> }; >> >> static const char * const sd2_groups[] = { >> - "dnand_data_wr", >> + "dnand_data_wr_mfp", >> }; >> >> static const char * const i2c0_groups[] = { >> - "uart0_rx", >> - "uart0_tx", >> - "i2c0_mfp", >> + "uart0_rx_mfp", >> + "uart0_tx_mfp", >> + "i2c0_mfp_mfp", >> }; >> >> static const char * const i2c1_groups[] = { >> @@ -1448,85 +1448,85 @@ static const char * const i2c2_groups[] = { >> }; >> >> static const char * const i2c3_groups[] = { >> - "uart2_rx_tx", >> - "pcm1_sync", >> - "pcm1_out", >> + "uart2_rx_tx_mfp", >> + "pcm1_sync_mfp", >> + "pcm1_out_mfp", >> }; >> >> static const char * const lvds_groups[] = { >> - "lvds_o_pn", >> - "lvds_ee_pn", >> - "lvds_e_pn", >> + "lvds_o_pn_mfp", >> + "lvds_ee_pn_mfp", >> + "lvds_e_pn_mfp", >> }; >> >> static const char * const bt_groups[] = { >> - "i2s_pcm1", >> - "i2s0_pcm0", >> - "i2s1_pcm0", >> - "ks_in2", >> - "ks_in1", >> - "ks_in0", >> - "ks_in3", >> - "ks_out0", >> - "ks_out1", >> - "ks_out2", >> - "lvds_o_pn", >> - "lvds_ee_pn", >> - "pcm1_in", >> - "pcm1_clk", >> - "pcm1_sync", >> - "pcm1_out", >> + "i2s_pcm1_mfp", >> + "i2s0_pcm0_mfp", >> + "i2s1_pcm0_mfp", >> + "ks_in2_mfp", >> + "ks_in1_mfp", >> + "ks_in0_mfp", >> + "ks_in3_mfp", >> + "ks_out0_mfp", >> + "ks_out1_mfp", >> + "ks_out2_mfp", >> + "lvds_o_pn_mfp", >> + "lvds_ee_pn_mfp", >> + "pcm1_in_mfp", >> + "pcm1_clk_mfp", >> + "pcm1_sync_mfp", >> + "pcm1_out_mfp", >> }; >> >> static const char * const lcd0_groups[] = { >> - "lcd0_d18", >> - "lcd0_d2", >> - "mfp1_16_14_d17", >> - "lvds_o_pn", >> - "dsi_dp3", >> - "dsi_dn3", >> - "lvds_ee_pn", >> - "dsi_dnp1_cp_d2", >> - "dsi_dnp1_cp_d17", >> - "lvds_e_pn", >> + "lcd0_d18_mfp", >> + "lcd0_d2_mfp", >> + "mfp1_16_14_d17_mfp", >> + "lvds_o_pn_mfp", >> + "dsi_dp3_mfp", >> + "dsi_dn3_mfp", >> + "lvds_ee_pn_mfp", >> + "dsi_dnp1_cp_d2_mfp", >> + "dsi_dnp1_cp_d17_mfp", >> + "lvds_e_pn_mfp", >> }; >> >> >> static const char * const usb30_groups[] = { >> - "ks_in1", >> + "ks_in1_mfp", >> }; >> >> static const char * const clko_25m_groups[] = { >> - "clko_25m", >> + "clko_25m_mfp", >> }; >> >> static const char * const mipi_csi_groups[] = { >> - "csi_cn_cp", >> - "csi_dn_dp", >> + "csi_cn_cp_mfp", >> + "csi_dn_dp_mfp", >> }; >> >> static const char * const dsi_groups[] = { >> - "dsi_dn0", >> - "dsi_dp2", >> - "dsi_dp3", >> - "dsi_dn3", >> - "dsi_dp0", >> - "dsi_dnp1_cp_d2", >> - "dsi_dnp1_cp_d17", >> - "dsi_dn2", >> + "dsi_dn0_mfp", >> + "dsi_dp2_mfp", >> + "dsi_dp3_mfp", >> + "dsi_dn3_mfp", >> + "dsi_dp0_mfp", >> + "dsi_dnp1_cp_d2_mfp", >> + "dsi_dnp1_cp_d17_mfp", >> + "dsi_dn2_mfp", >> "dsi_dummy", >> }; >> >> static const char * const nand_groups[] = { >> - "dnand_data_wr", >> - "dnand_acle_ce0", >> - "nand_ceb2", >> - "nand_ceb3", >> + "dnand_data_wr_mfp", >> + "dnand_acle_ce0_mfp", >> + "nand_ceb2_mfp", >> + "nand_ceb3_mfp", >> "nand_dummy", >> }; >> >> static const char * const spdif_groups[] = { >> - "uart0_tx", >> + "uart0_tx_mfp", >> }; >> >> static const char * const sirq0_groups[] = { > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9781C2D0DB for ; Fri, 24 Jan 2020 13:20:16 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B419020838 for ; Fri, 24 Jan 2020 13:20:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="i4gT1ghW"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=castello.eng.br header.i=@castello.eng.br header.b="F+G7QTcq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B419020838 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=castello.eng.br Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=AoJfQb56Q0ZFN2OBjl4kRdKLgHEnDQhgD+RB8qy5mXM=; b=i4gT1ghWlm43Iz6JkwdKTLUdS 0wW5A0Vl8L6y+MMzXSz71BKmNeFFeABcsK5nqbyYxatCNUSPD8Cj5TT1iobIlIyqCOLA73viip/uW 3Ua1K9LOkzdEGdvXygB1Sv+8kDZVd2AXaGwhF2wly+J1XgUJeU1U3JMnEAoaK8ORqBB4JlyqStZp+ QSdyU/0Z4GPt87UvkMzSlZxafWsnDUfQt2RcXy0xq0cNUblJIAUh97tYL2lCSAbwGDbcdq6Jljjbl n0sfZWytnx2AOKpsOMSmer4/w8HeyNNesQ/976fZT7xJEToNwTYAsGItE361MLfu/Lqn9/syyYRLO kXCIqyamw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iuysh-000305-Lf; Fri, 24 Jan 2020 13:20:15 +0000 Received: from gateway22.websitewelcome.com ([192.185.46.225]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iuysd-0002zP-N3 for linux-arm-kernel@lists.infradead.org; Fri, 24 Jan 2020 13:20:14 +0000 Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway22.websitewelcome.com (Postfix) with ESMTP id 894C2135BC for ; Fri, 24 Jan 2020 07:20:08 -0600 (CST) Received: from br164.hostgator.com.br ([192.185.176.180]) by cmsmtp with SMTP id uysai69ojvYkQuysaixRmP; Fri, 24 Jan 2020 07:20:08 -0600 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=castello.eng.br; s=default; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=V/GeHGqGQjtPkjEYv4FO0ChcoNxVcLXjcaqmJN4l0DA=; b=F+G7QTcqgNmFpk9VOZGAKBivtN saCW7dy/99BySJL2LVJYp5Lda5jwAuZubU158L97EDLYj0SH4Qfr4lIO9vl5opvjApUpcQNglmNGx P1msvHpwXKTaCYcVtsWrdWNEpxWdbY8s6amBjjUMMdNNw/YuO9cpWXigp/rA9Cxsygny1MXnC2Kf1 HdbEd1EGEgMbsl+5X6m8HzOIZLH2aE20kbNMicOoA+mgydQHyKqN4Rzl50VZcJNNaurOI2ecWDyci igahipxKn7W2GVVgF4w8QzvKTXLqAslFQpbhNgeAjOZrw7LLo7UR4ltLVuizHnqvmCyKZE851uLTZ TIF0N81Q==; Received: from [191.31.193.140] (port=38676 helo=[192.168.0.107]) by br164.hostgator.com.br with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.92) (envelope-from ) id 1iuysZ-003I10-NA; Fri, 24 Jan 2020 10:20:08 -0300 Subject: Re: [PATCH] pinctrl actions: Fix functions groups names To: Manivannan Sadhasivam , afaerber@suse.de, linus.walleij@linaro.org References: <20200124031819.608217-1-matheus@castello.eng.br> <900334CE-3A85-443D-99EC-4DD169BBCB65@linaro.org> From: Matheus Castello Message-ID: <838d8378-1a6a-11c4-fad8-aeb4b861478b@castello.eng.br> Date: Fri, 24 Jan 2020 10:20:04 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: <900334CE-3A85-443D-99EC-4DD169BBCB65@linaro.org> Content-Language: pt-BR X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - br164.hostgator.com.br X-AntiAbuse: Original Domain - lists.infradead.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - castello.eng.br X-BWhitelist: no X-Source-IP: 191.31.193.140 X-Source-L: No X-Exim-ID: 1iuysZ-003I10-NA X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: ([192.168.0.107]) [191.31.193.140]:38676 X-Source-Auth: matheus@castello.eng.br X-Email-Count: 4 X-Source-Cap: Y2FzdGUyNDg7Y2FzdGUyNDg7YnIxNjQuaG9zdGdhdG9yLmNvbS5icg== X-Local-Domain: yes X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200124_052011_897230_5D23A127 X-CRM114-Status: GOOD ( 15.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-gpio@vger.kernel.org, pn@denx.de, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Em 1/24/20 9:46 AM, Manivannan Sadhasivam escreveu: > Hey, > > +Parthi, who is the author of s700 driver. > > On 24 January 2020 8:48:19 AM IST, Matheus Castello wrote: >> Group names by function do not match their respective structures and >> documentation defined names. >> >> This fixes following errors observed on s500-based Labrador board when >> groups names defined on documentation are used: >> [ 4.262778] pinctrl-s700 b01b0040.pinctrl: invalid group >> "sd0_d1_mfp" for function "sd0" >> [ 4.271394] pinctrl-s700 b01b0040.pinctrl: invalid group >> "sd0_d2_d3_mfp" for function "sd0" >> [ 4.280248] pinctrl-s700 b01b0040.pinctrl: invalid group >> "sd1_d0_d3_mfp" for function "sd0" >> [ 4.289122] pinctrl-s700 b01b0040.pinctrl: invalid group >> "sd0_cmd_mfp" for function "sd0" >> > > Doh, I'm not sure how I missed this obvious mistake during review. Sorry for that. > > The change looks good but the commit message needs to be reworked a bit. It doesn't make sense to use s700 driver on s500 based board. Even though you could've modified it for s500, it should not be mentioned. So just mention the issue. Also you're missing colon after pinctrl in subject. > Ok, I will send a v2. > Btw, are you planning to contribute s500 driver? > Yes I intend to, my research, from a macro view, the pin blocks, groups, registers and functions are quite similar from the s700 to the s500. If so, maybe put a compatible to s500, but still not sure, I have to check it out calmly. > Thanks, > Mani > >> Fixes: 81c9d563cc74 (pinctrl: actions: Add Actions Semi S700 pinctrl >> driver) >> Signed-off-by: Matheus Castello >> --- >> drivers/pinctrl/actions/pinctrl-s700.c | 510 ++++++++++++------------- >> 1 file changed, 255 insertions(+), 255 deletions(-) >> >> diff --git a/drivers/pinctrl/actions/pinctrl-s700.c >> b/drivers/pinctrl/actions/pinctrl-s700.c >> index 8b8121e35edb..1182b38ff4dc 100644 >> --- a/drivers/pinctrl/actions/pinctrl-s700.c >> +++ b/drivers/pinctrl/actions/pinctrl-s700.c >> @@ -1125,317 +1125,317 @@ static const struct owl_pingroup >> s700_groups[] = { >> }; >> >> static const char * const nor_groups[] = { >> - "lcd0_d18", >> - "i2s_d0", >> - "i2s0_pcm0", >> - "i2s1_pcm0", >> - "i2s_d1", >> - "ks_in2", >> - "ks_in1", >> - "ks_in0", >> - "ks_in3", >> - "ks_out0", >> - "ks_out1", >> - "ks_out2", >> - "lcd0_d2", >> - "lvds_ee_pn", >> - "uart2_rx_tx", >> - "spi0_i2c_pcm", >> - "lvds_e_pn", >> - "sd0_d0", >> - "sd0_d1", >> - "sd0_d2_d3", >> - "sd1_d0_d3", >> - "sd0_cmd", >> - "sd1_cmd", >> - "sens0_ckout", >> - "sen0_pclk", >> + "lcd0_d18_mfp", >> + "i2s_d0_mfp", >> + "i2s0_pcm0_mfp", >> + "i2s1_pcm0_mfp", >> + "i2s_d1_mfp", >> + "ks_in2_mfp", >> + "ks_in1_mfp", >> + "ks_in0_mfp", >> + "ks_in3_mfp", >> + "ks_out0_mfp", >> + "ks_out1_mfp", >> + "ks_out2_mfp", >> + "lcd0_d2_mfp", >> + "lvds_ee_pn_mfp", >> + "uart2_rx_tx_mfp", >> + "spi0_i2c_pcm_mfp", >> + "lvds_e_pn_mfp", >> + "sd0_d0_mfp", >> + "sd0_d1_mfp", >> + "sd0_d2_d3_mfp", >> + "sd1_d0_d3_mfp", >> + "sd0_cmd_mfp", >> + "sd1_cmd_mfp", >> + "sens0_ckout_mfp", >> + "sen0_pclk_mfp", >> }; >> >> static const char * const eth_rmii_groups[] = { >> - "rgmii_txd23", >> - "rgmii_rxd2", >> - "rgmii_rxd3", >> - "rgmii_txd01", >> - "rgmii_txd0", >> - "rgmii_txd1", >> - "rgmii_txen", >> - "rgmii_rxen", >> - "rgmii_rxd1", >> - "rgmii_rxd0", >> - "rgmii_ref_clk", >> + "rgmii_txd23_mfp", >> + "rgmii_rxd2_mfp", >> + "rgmii_rxd3_mfp", >> + "rgmii_txd01_mfp", >> + "rgmii_txd0_mfp", >> + "rgmii_txd1_mfp", >> + "rgmii_txen_mfp", >> + "rgmii_rxen_mfp", >> + "rgmii_rxd1_mfp", >> + "rgmii_rxd0_mfp", >> + "rgmii_ref_clk_mfp", >> "eth_smi_dummy", >> }; >> >> static const char * const eth_smii_groups[] = { >> - "rgmii_txd0", >> - "rgmii_txd1", >> - "rgmii_rxd0", >> - "rgmii_rxd1", >> - "rgmii_ref_clk", >> + "rgmii_txd0_mfp", >> + "rgmii_txd1_mfp", >> + "rgmii_rxd0_mfp", >> + "rgmii_rxd1_mfp", >> + "rgmii_ref_clk_mfp", >> "eth_smi_dummy", >> }; >> >> static const char * const spi0_groups[] = { >> - "dsi_dn0", >> - "dsi_dp2", >> - "dsi_dp0", >> - "uart2_rx_tx", >> - "spi0_i2c_pcm", >> - "dsi_dn2", >> + "dsi_dn0_mfp", >> + "dsi_dp2_mfp", >> + "dsi_dp0_mfp", >> + "uart2_rx_tx_mfp", >> + "spi0_i2c_pcm_mfp", >> + "dsi_dn2_mfp", >> }; >> >> static const char * const spi1_groups[] = { >> - "uart0_rx", >> - "uart0_tx", >> + "uart0_rx_mfp", >> + "uart0_tx_mfp", >> "i2c0_mfp", >> }; >> >> static const char * const spi2_groups[] = { >> - "rgmii_txd01", >> - "rgmii_txd0", >> - "rgmii_txd1", >> - "rgmii_ref_clk", >> - "dnand_acle_ce0", >> + "rgmii_txd01_mfp", >> + "rgmii_txd0_mfp", >> + "rgmii_txd1_mfp", >> + "rgmii_ref_clk_mfp", >> + "dnand_acle_ce0_mfp", >> }; >> >> static const char * const spi3_groups[] = { >> - "rgmii_txen", >> - "rgmii_rxen", >> - "rgmii_rxd1", >> - "rgmii_rxd0", >> + "rgmii_txen_mfp", >> + "rgmii_rxen_mfp", >> + "rgmii_rxd1_mfp", >> + "rgmii_rxd0_mfp", >> }; >> >> static const char * const sens0_groups[] = { >> - "csi_cn_cp", >> - "sens0_ckout", >> - "csi_dn_dp", >> - "sen0_pclk", >> + "csi_cn_cp_mfp", >> + "sens0_ckout_mfp", >> + "csi_dn_dp_mfp", >> + "sen0_pclk_mfp", >> }; >> >> static const char * const sens1_groups[] = { >> - "lcd0_d18", >> - "ks_in2", >> - "ks_in1", >> - "ks_in0", >> - "ks_in3", >> - "ks_out0", >> - "ks_out1", >> - "ks_out2", >> - "sens0_ckout", >> - "pcm1_in", >> - "pcm1_clk", >> - "pcm1_sync", >> - "pcm1_out", >> + "lcd0_d18_mfp", >> + "ks_in2_mfp", >> + "ks_in1_mfp", >> + "ks_in0_mfp", >> + "ks_in3_mfp", >> + "ks_out0_mfp", >> + "ks_out1_mfp", >> + "ks_out2_mfp", >> + "sens0_ckout_mfp", >> + "pcm1_in_mfp", >> + "pcm1_clk_mfp", >> + "pcm1_sync_mfp", >> + "pcm1_out_mfp", >> }; >> >> static const char * const uart0_groups[] = { >> - "uart2_rtsb", >> - "uart2_ctsb", >> - "uart0_rx", >> - "uart0_tx", >> + "uart2_rtsb_mfp", >> + "uart2_ctsb_mfp", >> + "uart0_rx_mfp", >> + "uart0_tx_mfp", >> }; >> >> static const char * const uart1_groups[] = { >> - "sd0_d2_d3", >> + "sd0_d2_d3_mfp", >> "i2c0_mfp", >> }; >> >> static const char * const uart2_groups[] = { >> - "rgmii_txen", >> - "rgmii_rxen", >> - "rgmii_rxd1", >> - "rgmii_rxd0", >> - "dsi_dn0", >> - "dsi_dp2", >> - "dsi_dp0", >> - "uart2_rx_tx", >> - "dsi_dn2", >> - "uart2_rtsb", >> - "uart2_ctsb", >> - "sd0_d0", >> - "sd0_d1", >> - "sd0_d2_d3", >> - "uart0_rx", >> - "uart0_tx", >> + "rgmii_txen_mfp", >> + "rgmii_rxen_mfp", >> + "rgmii_rxd1_mfp", >> + "rgmii_rxd0_mfp", >> + "dsi_dn0_mfp", >> + "dsi_dp2_mfp", >> + "dsi_dp0_mfp", >> + "uart2_rx_tx_mfp", >> + "dsi_dn2_mfp", >> + "uart2_rtsb_mfp", >> + "uart2_ctsb_mfp", >> + "sd0_d0_mfp", >> + "sd0_d1_mfp", >> + "sd0_d2_d3_mfp", >> + "uart0_rx_mfp", >> + "uart0_tx_mfp", >> "i2c0_mfp", >> "uart2_dummy" >> }; >> >> static const char * const uart3_groups[] = { >> - "rgmii_txd23", >> - "rgmii_rxd2", >> - "rgmii_rxd3", >> - "uart3_rtsb", >> - "uart3_ctsb", >> + "rgmii_txd23_mfp", >> + "rgmii_rxd2_mfp", >> + "rgmii_rxd3_mfp", >> + "uart3_rtsb_mfp", >> + "uart3_ctsb_mfp", >> "uart3_dummy" >> }; >> >> static const char * const uart4_groups[] = { >> - "rgmii_txd01", >> - "rgmii_ref_clk", >> - "ks_out0", >> - "ks_out1", >> + "rgmii_txd01_mfp", >> + "rgmii_ref_clk_mfp", >> + "ks_out0_mfp", >> + "ks_out1_mfp", >> }; >> >> static const char * const uart5_groups[] = { >> - "rgmii_rxd1", >> - "rgmii_rxd0", >> - "ks_out0", >> - "ks_out2", >> - "uart3_rtsb", >> - "uart3_ctsb", >> - "sd0_d0", >> - "sd0_d1", >> + "rgmii_rxd1_mfp", >> + "rgmii_rxd0_mfp", >> + "ks_out0_mfp", >> + "ks_out2_mfp", >> + "uart3_rtsb_mfp", >> + "uart3_ctsb_mfp", >> + "sd0_d0_mfp", >> + "sd0_d1_mfp", >> }; >> >> static const char * const uart6_groups[] = { >> - "rgmii_txd0", >> - "rgmii_txd1", >> + "rgmii_txd0_mfp", >> + "rgmii_txd1_mfp", >> }; >> >> static const char * const i2s0_groups[] = { >> - "i2s_d0", >> - "i2s_pcm1", >> - "i2s0_pcm0", >> + "i2s_d0_mfp", >> + "i2s_pcm1_mfp", >> + "i2s0_pcm0_mfp", >> }; >> >> static const char * const i2s1_groups[] = { >> - "i2s1_pcm0", >> - "i2s_d1", >> + "i2s1_pcm0_mfp", >> + "i2s_d1_mfp", >> "i2s1_dummy", >> - "spi0_i2c_pcm", >> - "uart0_rx", >> - "uart0_tx", >> + "spi0_i2c_pcm_mfp", >> + "uart0_rx_mfp", >> + "uart0_tx_mfp", >> }; >> >> static const char * const pcm1_groups[] = { >> - "i2s_pcm1", >> - "spi0_i2c_pcm", >> - "uart0_rx", >> - "uart0_tx", >> - "pcm1_in", >> - "pcm1_clk", >> - "pcm1_sync", >> - "pcm1_out", >> + "i2s_pcm1_mfp", >> + "spi0_i2c_pcm_mfp", >> + "uart0_rx_mfp", >> + "uart0_tx_mfp", >> + "pcm1_in_mfp", >> + "pcm1_clk_mfp", >> + "pcm1_sync_mfp", >> + "pcm1_out_mfp", >> }; >> >> static const char * const pcm0_groups[] = { >> - "i2s0_pcm0", >> - "i2s1_pcm0", >> - "uart2_rx_tx", >> - "spi0_i2c_pcm", >> + "i2s0_pcm0_mfp", >> + "i2s1_pcm0_mfp", >> + "uart2_rx_tx_mfp", >> + "spi0_i2c_pcm_mfp", >> }; >> >> static const char * const ks_groups[] = { >> - "ks_in2", >> - "ks_in1", >> - "ks_in0", >> - "ks_in3", >> - "ks_out0", >> - "ks_out1", >> - "ks_out2", >> + "ks_in2_mfp", >> + "ks_in1_mfp", >> + "ks_in0_mfp", >> + "ks_in3_mfp", >> + "ks_out0_mfp", >> + "ks_out1_mfp", >> + "ks_out2_mfp", >> }; >> >> static const char * const jtag_groups[] = { >> - "ks_in2", >> - "ks_in1", >> - "ks_in0", >> - "ks_in3", >> - "ks_out1", >> - "sd0_d0", >> - "sd0_d2_d3", >> - "sd0_cmd", >> - "sd0_clk", >> + "ks_in2_mfp", >> + "ks_in1_mfp", >> + "ks_in0_mfp", >> + "ks_in3_mfp", >> + "ks_out1_mfp", >> + "sd0_d0_mfp", >> + "sd0_d2_d3_mfp", >> + "sd0_cmd_mfp", >> + "sd0_clk_mfp", >> }; >> >> static const char * const pwm0_groups[] = { >> - "rgmii_rxd2", >> - "rgmii_txen", >> - "ks_in2", >> - "sen0_pclk", >> + "rgmii_rxd2_mfp", >> + "rgmii_txen_mfp", >> + "ks_in2_mfp", >> + "sen0_pclk_mfp", >> }; >> >> static const char * const pwm1_groups[] = { >> - "rgmii_rxen", >> - "ks_in1", >> - "ks_in3", >> - "sens0_ckout", >> + "rgmii_rxen_mfp", >> + "ks_in1_mfp", >> + "ks_in3_mfp", >> + "sens0_ckout_mfp", >> }; >> >> static const char * const pwm2_groups[] = { >> - "lcd0_d18", >> - "rgmii_rxd3", >> - "rgmii_rxd1", >> - "ks_out0", >> - "ks_out2", >> + "lcd0_d18_mfp", >> + "rgmii_rxd3_mfp", >> + "rgmii_rxd1_mfp", >> + "ks_out0_mfp", >> + "ks_out2_mfp", >> }; >> >> static const char * const pwm3_groups[] = { >> - "rgmii_rxd0", >> - "ks_out1", >> - "lcd0_d2", >> + "rgmii_rxd0_mfp", >> + "ks_out1_mfp", >> + "lcd0_d2_mfp", >> }; >> >> static const char * const pwm4_groups[] = { >> - "lcd0_d18", >> - "rgmii_txd01", >> - "rgmii_txd0", >> - "ks_in0", >> - "pcm1_in", >> - "nand_ceb3", >> + "lcd0_d18_mfp", >> + "rgmii_txd01_mfp", >> + "rgmii_txd0_mfp", >> + "ks_in0_mfp", >> + "pcm1_in_mfp", >> + "nand_ceb3_mfp", >> }; >> >> static const char * const pwm5_groups[] = { >> - "rgmii_txd1", >> - "ks_in1", >> - "pcm1_clk", >> - "nand_ceb2", >> + "rgmii_txd1_mfp", >> + "ks_in1_mfp", >> + "pcm1_clk_mfp", >> + "nand_ceb2_mfp", >> }; >> >> static const char * const p0_groups[] = { >> - "ks_in2", >> - "ks_in0", >> + "ks_in2_mfp", >> + "ks_in0_mfp", >> }; >> >> static const char * const sd0_groups[] = { >> - "ks_out0", >> - "ks_out1", >> - "ks_out2", >> - "lcd0_d2", >> - "dsi_dp3", >> - "dsi_dp0", >> - "sd0_d0", >> - "sd0_d1", >> - "sd0_d2_d3", >> - "sd1_d0_d3", >> - "sd0_cmd", >> - "sd0_clk", >> + "ks_out0_mfp", >> + "ks_out1_mfp", >> + "ks_out2_mfp", >> + "lcd0_d2_mfp", >> + "dsi_dp3_mfp", >> + "dsi_dp0_mfp", >> + "sd0_d0_mfp", >> + "sd0_d1_mfp", >> + "sd0_d2_d3_mfp", >> + "sd1_d0_d3_mfp", >> + "sd0_cmd_mfp", >> + "sd0_clk_mfp", >> }; >> >> static const char * const sd1_groups[] = { >> - "dsi_dp2", >> - "mfp1_16_14", >> - "lcd0_d2", >> - "mfp1_16_14_d17", >> - "dsi_dp3", >> - "dsi_dn3", >> - "dsi_dnp1_cp_d2", >> - "dsi_dnp1_cp_d17", >> - "dsi_dn2", >> - "sd1_d0_d3", >> - "sd1_cmd", >> + "dsi_dp2_mfp", >> + "mfp1_16_14_mfp", >> + "lcd0_d2_mfp", >> + "mfp1_16_14_d17_mfp", >> + "dsi_dp3_mfp", >> + "dsi_dn3_mfp", >> + "dsi_dnp1_cp_d2_mfp", >> + "dsi_dnp1_cp_d17_mfp", >> + "dsi_dn2_mfp", >> + "sd1_d0_d3_mfp", >> + "sd1_cmd_mfp", >> "sd1_dummy", >> }; >> >> static const char * const sd2_groups[] = { >> - "dnand_data_wr", >> + "dnand_data_wr_mfp", >> }; >> >> static const char * const i2c0_groups[] = { >> - "uart0_rx", >> - "uart0_tx", >> - "i2c0_mfp", >> + "uart0_rx_mfp", >> + "uart0_tx_mfp", >> + "i2c0_mfp_mfp", >> }; >> >> static const char * const i2c1_groups[] = { >> @@ -1448,85 +1448,85 @@ static const char * const i2c2_groups[] = { >> }; >> >> static const char * const i2c3_groups[] = { >> - "uart2_rx_tx", >> - "pcm1_sync", >> - "pcm1_out", >> + "uart2_rx_tx_mfp", >> + "pcm1_sync_mfp", >> + "pcm1_out_mfp", >> }; >> >> static const char * const lvds_groups[] = { >> - "lvds_o_pn", >> - "lvds_ee_pn", >> - "lvds_e_pn", >> + "lvds_o_pn_mfp", >> + "lvds_ee_pn_mfp", >> + "lvds_e_pn_mfp", >> }; >> >> static const char * const bt_groups[] = { >> - "i2s_pcm1", >> - "i2s0_pcm0", >> - "i2s1_pcm0", >> - "ks_in2", >> - "ks_in1", >> - "ks_in0", >> - "ks_in3", >> - "ks_out0", >> - "ks_out1", >> - "ks_out2", >> - "lvds_o_pn", >> - "lvds_ee_pn", >> - "pcm1_in", >> - "pcm1_clk", >> - "pcm1_sync", >> - "pcm1_out", >> + "i2s_pcm1_mfp", >> + "i2s0_pcm0_mfp", >> + "i2s1_pcm0_mfp", >> + "ks_in2_mfp", >> + "ks_in1_mfp", >> + "ks_in0_mfp", >> + "ks_in3_mfp", >> + "ks_out0_mfp", >> + "ks_out1_mfp", >> + "ks_out2_mfp", >> + "lvds_o_pn_mfp", >> + "lvds_ee_pn_mfp", >> + "pcm1_in_mfp", >> + "pcm1_clk_mfp", >> + "pcm1_sync_mfp", >> + "pcm1_out_mfp", >> }; >> >> static const char * const lcd0_groups[] = { >> - "lcd0_d18", >> - "lcd0_d2", >> - "mfp1_16_14_d17", >> - "lvds_o_pn", >> - "dsi_dp3", >> - "dsi_dn3", >> - "lvds_ee_pn", >> - "dsi_dnp1_cp_d2", >> - "dsi_dnp1_cp_d17", >> - "lvds_e_pn", >> + "lcd0_d18_mfp", >> + "lcd0_d2_mfp", >> + "mfp1_16_14_d17_mfp", >> + "lvds_o_pn_mfp", >> + "dsi_dp3_mfp", >> + "dsi_dn3_mfp", >> + "lvds_ee_pn_mfp", >> + "dsi_dnp1_cp_d2_mfp", >> + "dsi_dnp1_cp_d17_mfp", >> + "lvds_e_pn_mfp", >> }; >> >> >> static const char * const usb30_groups[] = { >> - "ks_in1", >> + "ks_in1_mfp", >> }; >> >> static const char * const clko_25m_groups[] = { >> - "clko_25m", >> + "clko_25m_mfp", >> }; >> >> static const char * const mipi_csi_groups[] = { >> - "csi_cn_cp", >> - "csi_dn_dp", >> + "csi_cn_cp_mfp", >> + "csi_dn_dp_mfp", >> }; >> >> static const char * const dsi_groups[] = { >> - "dsi_dn0", >> - "dsi_dp2", >> - "dsi_dp3", >> - "dsi_dn3", >> - "dsi_dp0", >> - "dsi_dnp1_cp_d2", >> - "dsi_dnp1_cp_d17", >> - "dsi_dn2", >> + "dsi_dn0_mfp", >> + "dsi_dp2_mfp", >> + "dsi_dp3_mfp", >> + "dsi_dn3_mfp", >> + "dsi_dp0_mfp", >> + "dsi_dnp1_cp_d2_mfp", >> + "dsi_dnp1_cp_d17_mfp", >> + "dsi_dn2_mfp", >> "dsi_dummy", >> }; >> >> static const char * const nand_groups[] = { >> - "dnand_data_wr", >> - "dnand_acle_ce0", >> - "nand_ceb2", >> - "nand_ceb3", >> + "dnand_data_wr_mfp", >> + "dnand_acle_ce0_mfp", >> + "nand_ceb2_mfp", >> + "nand_ceb3_mfp", >> "nand_dummy", >> }; >> >> static const char * const spdif_groups[] = { >> - "uart0_tx", >> + "uart0_tx_mfp", >> }; >> >> static const char * const sirq0_groups[] = { > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel